Re: [OMPI devel] [EXTERNAL] Re: oshmem and CFLAGS removal

2013-10-31 Thread Joshua Ladd 
Yes, understood. We will resolve the warnings. 

Josh

-Original Message-
From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Barrett, Brian W
Sent: Thursday, October 31, 2013 4:45 PM
To: Open MPI Developers
Subject: Re: [OMPI devel] [EXTERNAL] Re: oshmem and CFLAGS removal

On 10/31/13 2:42 PM, "Rolf vandeVaart"  wrote:

>>-Original Message-
>>From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Jeff 
>>Squyres
>>(jsquyres)
>>Sent: Thursday, October 31, 2013 4:12 PM
>>To: Open MPI Developers
>>Subject: Re: [OMPI devel] oshmem and CFLAGS removal
>>
>>On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart 
>>wrote:
>>
>>> # Strip off problematic arguments
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-
>>double//g'`"
>>
>>I think the solution is simple -- delete this line:
>>
>>> CFLAGS="$oshmem_CFLAGS"
>>
>
>Nope, it was not that simple.   With that change, the -pedantic and
>-Wundef end up in the CFLAGS for oshmem and I see all the warnings.
>I will submit a ticket and give it to Joshua Ladd.

Yeah, that's not going to work.  But a bigger question: why aren't -pedantic 
and -Wundef set for SHMEM?  If it's an OMPI project, it has to follow all the 
rules the other OMPI projects follow.

Brian

--
  Brian W. Barrett
  Scalable System Software Group
  Sandia National Laboratories




___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [EXTERNAL] Re: oshmem and CFLAGS removal

2013-10-31 Thread Barrett, Brian W 
On 10/31/13 2:42 PM, "Rolf vandeVaart"  wrote:

>>-Original Message-
>>From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Jeff Squyres
>>(jsquyres)
>>Sent: Thursday, October 31, 2013 4:12 PM
>>To: Open MPI Developers
>>Subject: Re: [OMPI devel] oshmem and CFLAGS removal
>>
>>On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart 
>>wrote:
>>
>>> # Strip off problematic arguments
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-
>>double//g'`"
>>
>>I think the solution is simple -- delete this line:
>>
>>> CFLAGS="$oshmem_CFLAGS"
>>
>
>Nope, it was not that simple.   With that change, the -pedantic and
>-Wundef end up in the CFLAGS for oshmem and I see all the warnings.
>I will submit a ticket and give it to Joshua Ladd.

Yeah, that's not going to work.  But a bigger question: why aren't
-pedantic and -Wundef set for SHMEM?  If it's an OMPI project, it has to
follow all the rules the other OMPI projects follow.

Brian

--
  Brian W. Barrett
  Scalable System Software Group
  Sandia National Laboratories

Re: [OMPI devel] oshmem and CFLAGS removal

2013-10-31 Thread Joshua Ladd 
Submit the ticket, please. I am looking at it now

Josh

-Original Message-
From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Rolf vandeVaart
Sent: Thursday, October 31, 2013 4:43 PM
To: Open MPI Developers
Subject: Re: [OMPI devel] oshmem and CFLAGS removal



>-Original Message-
>From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Jeff 
>Squyres
>(jsquyres)
>Sent: Thursday, October 31, 2013 4:12 PM
>To: Open MPI Developers
>Subject: Re: [OMPI devel] oshmem and CFLAGS removal
>
>On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart 
>wrote:
>
>> # Strip off problematic arguments
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-
>double//g'`"
>
>I think the solution is simple -- delete this line:
>
>> CFLAGS="$oshmem_CFLAGS"
>

Nope, it was not that simple.   With that change, the -pedantic and -Wundef end 
up in the CFLAGS for oshmem and I see all the warnings.
I will submit a ticket and give it to Joshua Ladd.  
---
This email message is for the sole use of the intended recipient(s) and may 
contain confidential information.  Any unauthorized review, use, disclosure or 
distribution is prohibited.  If you are not the intended recipient, please 
contact the sender by reply email and destroy all copies of the original 
message.
---
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] oshmem and CFLAGS removal

2013-10-31 Thread Rolf vandeVaart 


>-Original Message-
>From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Jeff Squyres
>(jsquyres)
>Sent: Thursday, October 31, 2013 4:12 PM
>To: Open MPI Developers
>Subject: Re: [OMPI devel] oshmem and CFLAGS removal
>
>On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart 
>wrote:
>
>> # Strip off problematic arguments
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-
>double//g'`"
>
>I think the solution is simple -- delete this line:
>
>> CFLAGS="$oshmem_CFLAGS"
>

Nope, it was not that simple.   With that change, the -pedantic and -Wundef end 
up in the CFLAGS for oshmem and I see all the warnings.
I will submit a ticket and give it to Joshua Ladd.  
---
This email message is for the sole use of the intended recipient(s) and may 
contain
confidential information.  Any unauthorized review, use, disclosure or 
distribution
is prohibited.  If you are not the intended recipient, please contact the 
sender by
reply email and destroy all copies of the original message.
---

Re: [OMPI devel] oshmem and CFLAGS removal

2013-10-31 Thread Jeff Squyres (jsquyres) 
On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart  wrote:

> # Strip off problematic arguments
> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-double//g'`"

I think the solution is simple -- delete this line:

> CFLAGS="$oshmem_CFLAGS"


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

[OMPI devel] oshmem and CFLAGS removal

2013-10-31 Thread Rolf vandeVaart 
I noticed that there were some CFLAGS that were no longer set when enabling 
with --enable-picky for gcc.  Specifically, -Wundef and -pedantic  were no 
longer set.
This is not a problem for Open MPI 1.7.

I believe this is happening because of some code in the 
config/oshmem_configure_options.m4 file that is supposed to be oshmem specific, 
but seems to be bleeding into everything that gets compiled.

oshmem_CFLAGS="$CFLAGS"

# Strip off problematic arguments
oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-double//g'`"
CFLAGS="$oshmem_CFLAGS"

Does anyone know an easy fix for this?  This is why I think some warnings 
appeared in Open MPI 1.7 that we did not see for the same change in the trunk.

Thanks,
Rolf
---
This email message is for the sole use of the intended recipient(s) and may 
contain
confidential information.  Any unauthorized review, use, disclosure or 
distribution
is prohibited.  If you are not the intended recipient, please contact the 
sender by
reply email and destroy all copies of the original message.
---