[OMPI devel] 1.7.4rc4 is out
A few last minute fixes made it in: http://www.open-mpi.org/software/ompi/v1.7/ Changes since rc3: - Fix wrapper compiler flags with rpath and --disable-dlopen - Fix various compiler warnings (from Paul H) - External libevent fix (Orion) - basemuma bug fixes - MPI_SUBARRAYS_SUPPORTED and MPI_ASYNC_PROTECTS_NONBLOCKING fixes (from Rolf R) - Ensure Fortran configure compiler test turds are removed - Restore version number output to ompi_info --all - Fix lost OOB TCP message and thread termination issues - Clarify SPARC-related text in README and error messages -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [OMPI devel] [OMPI svn] svn:open-mpi r30555 - in trunk: . config contrib/platform/lanl/cray_xe6
Fixed in r30559 -Nathan On Tue, Feb 04, 2014 at 01:09:50PM -0700, Nathan Hjelm wrote: > On Tue, Feb 04, 2014 at 07:55:51PM +, Dave Goodell (dgoodell) wrote: > > On Feb 4, 2014, at 1:44 PM, svn-commit-mai...@open-mpi.org wrote: > > > > > Author: hjelmn (Nathan Hjelm) > > > Date: 2014-02-04 14:44:08 EST (Tue, 04 Feb 2014) > > > New Revision: 30555 > > > URL: https://svn.open-mpi.org/trac/ompi/changeset/30555 > > > > > > Log: > > > Fix wrapper ldflags. > > > > > > cmr=v1.7.4:reviewer=jsquyres > > > > > > Text files modified: > > > trunk/config/opal_setup_wrappers.m4 | 9 - > > > > > > trunk/configure.ac | 2 ++ > > > > > > trunk/contrib/platform/lanl/cray_xe6/cray-common | 4 > > > > > > 3 files changed, 6 insertions(+), 9 deletions(-) > > > > > > Modified: trunk/config/opal_setup_wrappers.m4 > > > == > > > --- trunk/config/opal_setup_wrappers.m4 Tue Feb 4 09:47:04 2014 > > > (r30554) > > > +++ trunk/config/opal_setup_wrappers.m4 2014-02-04 14:44:08 EST (Tue, > > > 04 Feb 2014) (r30555) > > > @@ -150,7 +150,7 @@ > > > # (because if script A sources script B, and B calls "exit", then both > > > # B and A will exit). Instead, we have to send the output to a file > > > # and then source that. > > > -$OMPI_TOP_BUILDDIR/opal/libltdl/libtool --config > $rpath_outfile > > > +$OMPI_TOP_BUILDDIR/libtool --config > $rpath_outfile > > > > > > chmod +x $rpath_outfile > > > . ./$rpath_outfile > > > @@ -214,9 +214,8 @@ > > > # runtime), and the RUNPATH args, if we have them. > > > AC_DEFUN([RPATHIFY_LDFLAGS],[ > > > OPAL_VAR_SCOPE_PUSH([rpath_out rpath_dir rpath_tmp]) > > > -AS_IF([test "$enable_wrapper_rpath" = "no" -o > > > "$WRAPPER_RPATH_SUPPORT" = "disabled"], > > > - [:], > > > - [rpath_out= > > > +AS_IF([test "$enable_wrapper_rpath" = "yes" -a ! > > > "$WRAPPER_RPATH_SUPPORT" = "disabled" -a ! "WRAPPER_RPATH_SUPPORT" = > > > "unnecessary"], [ > > > > This "test" looks dangerous to me. Both non-portable [1] and slightly > > challenging to read at first glance. It would be better as: > > > > 8< > > test "$enable_wrapper_rpath" = "yes" && > > test "$WRAPPER_RPATH_SUPPORT" != "disabled" && > > test "$WRAPPER_RPATH_SUPPORT" != "unnecessary" > > 8< > > > > In fact, if you look carefully at the third test, there is a missing "$" > > before "WRAPPER_RPATH_SUPPORT" in the SVN version... > > Good catch on the typo. Neither I nor the reviewers noticed that. As for > the test semantics, I wasn't aware that -a, -o, and () were > deprecated. I will update the test. > > -Nathan > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel pgpIL2lUcqGcM.pgp Description: PGP signature
Re: [OMPI devel] [OMPI svn] svn:open-mpi r30555 - in trunk: . config contrib/platform/lanl/cray_xe6
On Tue, Feb 04, 2014 at 07:55:51PM +, Dave Goodell (dgoodell) wrote: > On Feb 4, 2014, at 1:44 PM, svn-commit-mai...@open-mpi.org wrote: > > > Author: hjelmn (Nathan Hjelm) > > Date: 2014-02-04 14:44:08 EST (Tue, 04 Feb 2014) > > New Revision: 30555 > > URL: https://svn.open-mpi.org/trac/ompi/changeset/30555 > > > > Log: > > Fix wrapper ldflags. > > > > cmr=v1.7.4:reviewer=jsquyres > > > > Text files modified: > > trunk/config/opal_setup_wrappers.m4 | 9 - > > > > trunk/configure.ac | 2 ++ > > > > trunk/contrib/platform/lanl/cray_xe6/cray-common | 4 > > > > 3 files changed, 6 insertions(+), 9 deletions(-) > > > > Modified: trunk/config/opal_setup_wrappers.m4 > > == > > --- trunk/config/opal_setup_wrappers.m4 Tue Feb 4 09:47:04 2014 > > (r30554) > > +++ trunk/config/opal_setup_wrappers.m4 2014-02-04 14:44:08 EST (Tue, > > 04 Feb 2014) (r30555) > > @@ -150,7 +150,7 @@ > > # (because if script A sources script B, and B calls "exit", then both > > # B and A will exit). Instead, we have to send the output to a file > > # and then source that. > > -$OMPI_TOP_BUILDDIR/opal/libltdl/libtool --config > $rpath_outfile > > +$OMPI_TOP_BUILDDIR/libtool --config > $rpath_outfile > > > > chmod +x $rpath_outfile > > . ./$rpath_outfile > > @@ -214,9 +214,8 @@ > > # runtime), and the RUNPATH args, if we have them. > > AC_DEFUN([RPATHIFY_LDFLAGS],[ > > OPAL_VAR_SCOPE_PUSH([rpath_out rpath_dir rpath_tmp]) > > -AS_IF([test "$enable_wrapper_rpath" = "no" -o "$WRAPPER_RPATH_SUPPORT" > > = "disabled"], > > - [:], > > - [rpath_out= > > +AS_IF([test "$enable_wrapper_rpath" = "yes" -a ! > > "$WRAPPER_RPATH_SUPPORT" = "disabled" -a ! "WRAPPER_RPATH_SUPPORT" = > > "unnecessary"], [ > > This "test" looks dangerous to me. Both non-portable [1] and slightly > challenging to read at first glance. It would be better as: > > 8< > test "$enable_wrapper_rpath" = "yes" && > test "$WRAPPER_RPATH_SUPPORT" != "disabled" && > test "$WRAPPER_RPATH_SUPPORT" != "unnecessary" > 8< > > In fact, if you look carefully at the third test, there is a missing "$" > before "WRAPPER_RPATH_SUPPORT" in the SVN version... Good catch on the typo. Neither I nor the reviewers noticed that. As for the test semantics, I wasn't aware that -a, -o, and () were deprecated. I will update the test. -Nathan pgpxbcaO6bXML.pgp Description: PGP signature
Re: [OMPI devel] [OMPI svn] svn:open-mpi r30555 - in trunk: . config contrib/platform/lanl/cray_xe6
On Feb 4, 2014, at 1:44 PM, svn-commit-mai...@open-mpi.org wrote: > Author: hjelmn (Nathan Hjelm) > Date: 2014-02-04 14:44:08 EST (Tue, 04 Feb 2014) > New Revision: 30555 > URL: https://svn.open-mpi.org/trac/ompi/changeset/30555 > > Log: > Fix wrapper ldflags. > > cmr=v1.7.4:reviewer=jsquyres > > Text files modified: > trunk/config/opal_setup_wrappers.m4 | 9 - > > trunk/configure.ac | 2 ++ > > trunk/contrib/platform/lanl/cray_xe6/cray-common | 4 > > 3 files changed, 6 insertions(+), 9 deletions(-) > > Modified: trunk/config/opal_setup_wrappers.m4 > == > --- trunk/config/opal_setup_wrappers.m4 Tue Feb 4 09:47:04 2014 > (r30554) > +++ trunk/config/opal_setup_wrappers.m4 2014-02-04 14:44:08 EST (Tue, > 04 Feb 2014) (r30555) > @@ -150,7 +150,7 @@ > # (because if script A sources script B, and B calls "exit", then both > # B and A will exit). Instead, we have to send the output to a file > # and then source that. > -$OMPI_TOP_BUILDDIR/opal/libltdl/libtool --config > $rpath_outfile > +$OMPI_TOP_BUILDDIR/libtool --config > $rpath_outfile > > chmod +x $rpath_outfile > . ./$rpath_outfile > @@ -214,9 +214,8 @@ > # runtime), and the RUNPATH args, if we have them. > AC_DEFUN([RPATHIFY_LDFLAGS],[ > OPAL_VAR_SCOPE_PUSH([rpath_out rpath_dir rpath_tmp]) > -AS_IF([test "$enable_wrapper_rpath" = "no" -o "$WRAPPER_RPATH_SUPPORT" = > "disabled"], > - [:], > - [rpath_out= > +AS_IF([test "$enable_wrapper_rpath" = "yes" -a ! > "$WRAPPER_RPATH_SUPPORT" = "disabled" -a ! "WRAPPER_RPATH_SUPPORT" = > "unnecessary"], [ This "test" looks dangerous to me. Both non-portable [1] and slightly challenging to read at first glance. It would be better as: 8< test "$enable_wrapper_rpath" = "yes" && test "$WRAPPER_RPATH_SUPPORT" != "disabled" && test "$WRAPPER_RPATH_SUPPORT" != "unnecessary" 8< In fact, if you look carefully at the third test, there is a missing "$" before "WRAPPER_RPATH_SUPPORT" in the SVN version... [1] http://www.gnu.org/software/autoconf/manual/autoconf.html#index-g_t_0040command_007btest_007d-1793 -Dave
Re: [OMPI devel] Use unique collective ids for the checkpoint/restart code
Thanks for spotting the 'printf'. I removed it as it was for debugging in a very early stage. I committed the patch without the 'printf' to svn. Adrian On Mon, Feb 03, 2014 at 12:42:39PM -0800, Ralph Castain wrote: > Looks okay to me - I see you left a "printf" statement in > plm_base_launch_support.c, so you might want to make that an > opal_output_verbose or something. > > On Feb 3, 2014, at 12:19 PM, Adrian Reber wrote: > > > This patch > > > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=14ec7f42baab882e345948ff79c4f75f5084bbbf > > > > introduces unique collective ids for the checkpoint/restart code and > > with this applied it seems to work pretty good. As this patch also > > touches non-CR code it would be good if someone could have a look at it. > > > > With this patch applied the code seems to work up to the point where > > orterun actually pauses all processes and tries to create the > > checkpoints. The checkpoint creation does not work for me as CRS does > > not yet include support for checkpoint/restart using CRIU which would be > > my next step. > > > > Adrian > > ___ > > devel mailing list > > de...@open-mpi.org > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
