Re: [OMPI devel] Bad parameter in file oob_tcp.c
Yes - but Marco said he was going to look into it. I meant that I would fix
the problem George identified, although it doesn't fix the problem Marco
hit.
Sorry for the confusion
On Wed, Mar 5, 2014 at 2:48 PM, Paul Hargrove wrote:
> Wait a second...
>
> Unless I am missing something Marco's error means that Cygwin *did* return
> INADDR_ANY.
> According to George's research that shouldn't happen (unless on XP or
> older and host is an empty string).
>
> So, changing the code to check for INADDR_NONE just ignores what should be
> an impossible return, right?
> I agree that the change makes the code check for what it was meant to
> check for, but doesn't Marco's result *still* point at a problem with host
> resolution under Cygwin?
>
> -Paul
>
>
> On Wed, Mar 5, 2014 at 2:35 PM, Ralph Castain wrote:
>
>> Cool - I'll make the correction. Thx!
>>
>>
>>
>> On Wed, Mar 5, 2014 at 2:08 PM, George Bosilca wrote:
>>
>>> I'm afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY
>>> should not be a valid return for inet_addr. Here is a quick check on
>>> different OSes.
>>>
>>> On Linux, the man Page states:
>>>
>>> If the input is invalid, INADDR_NONE (usually -1) is returned.
>>>
>>>
>>> On Mac OS X:
>>>
>>> The constant INADDR_NONE is returned by inet_addr() and inet_network()
>>> for malformed requests.
>>>
>>>
>>> On Windows things are slightly more complicated:
>>>
>>> On Windows Server 2003 and later if the string in the cp parameter is an
>>> empty string, then inet_addr returns the value INADDR_NONE. If NULL is
>>> passed in the cp parameter, then inet_addrreturns the value INADDR_NONE.
>>> On Windows XP and earlier if the string in the cp parameter is an empty
>>> string, then inet_addr returns the value INADDR_ANY. If NULL is passed in
>>> the cp parameter, then inet_addr returns the value INADDR_NONE.
>>>
>>>
>>> Thus, we should compare with INADDR_NONE and not with INADDR_ANY.
>>>
>>> George.
>>>
>>> On Mar 4, 2014, at 22:06 , Ralph Castain wrote:
>>>
>>> The code generating the error is here:
>>>
>>> in->sin_addr.s_addr = inet_addr(host);
>>> if (in->sin_addr.s_addr == INADDR_ANY) {
>>> return ORTE_ERR_BAD_PARAM;
>>> }
>>>
>>>
>>> The address is resolving to INADDR_ANY instead of a regular address.
>>> Does cygwin require some other method for resolving a hostname to an IP
>>> address?
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Tue, Mar 4, 2014 at 3:19 PM, Marco Atzeri wrote:
>>>
noted on cygwin with 1.7.4 and on 1.7.5rc1
$ mpirun -n 4 ./hello_c.exe
[MATZERI:06212] [[62628,1],0] ORTE_ERROR_LOG: Bad parameter in file
/pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
at line 292
[MATZERI:05620] [[62628,1],1] ORTE_ERROR_LOG: Bad parameter in file
/pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
at line 292
[MATZERI:06892] [[62628,1],2] ORTE_ERROR_LOG: Bad parameter in file
/pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
at line 292
[MATZERI:03908] [[62628,1],3] ORTE_ERROR_LOG: Bad parameter in file
/pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
at line 292
Hello, world, I am 1 of 4, (Open MPI v1.7.5rc1, package: Open MPI
marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
Hello, world, I am 2 of 4, (Open MPI v1.7.5rc1, package: Open MPI
marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
Hello, world, I am 3 of 4, (Open MPI v1.7.5rc1, package: Open MPI
marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
Hello, world, I am 0 of 4, (Open MPI v1.7.5rc1, package: Open MPI
marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
any idea what could be the cause ?
I don't remember it in previous 1.7.x releases
the relevant code is:
if ((rc = parse_uri(pop->af_family, pop->net, pop->port, (struct
sockaddr*) &inaddr)) != ORTE_SUCCESS) {
ORTE_ERROR_LOG(rc);
Regards
Marco
___
devel mailing list
de...@open-mpi.org
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Searchable archives: http://www.open-mpi.org/
community/lists/devel/2014/03/index.php
>>>
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> Searchable archives:
>>> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
>>>
>>>
>>>
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> Link to this post:
>>> http://www.open-mpi.org/community/lists/devel/2014/03/14301.php
>>>
>>
>>
>> ___
Re: [OMPI devel] Bad parameter in file oob_tcp.c
Wait a second...
Unless I am missing something Marco's error means that Cygwin *did* return
INADDR_ANY.
According to George's research that shouldn't happen (unless on XP or older
and host is an empty string).
So, changing the code to check for INADDR_NONE just ignores what should be
an impossible return, right?
I agree that the change makes the code check for what it was meant to check
for, but doesn't Marco's result *still* point at a problem with host
resolution under Cygwin?
-Paul
On Wed, Mar 5, 2014 at 2:35 PM, Ralph Castain wrote:
> Cool - I'll make the correction. Thx!
>
>
>
> On Wed, Mar 5, 2014 at 2:08 PM, George Bosilca wrote:
>
>> I'm afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY
>> should not be a valid return for inet_addr. Here is a quick check on
>> different OSes.
>>
>> On Linux, the man Page states:
>>
>> If the input is invalid, INADDR_NONE (usually -1) is returned.
>>
>>
>> On Mac OS X:
>>
>> The constant INADDR_NONE is returned by inet_addr() and inet_network()
>> for malformed requests.
>>
>>
>> On Windows things are slightly more complicated:
>>
>> On Windows Server 2003 and later if the string in the cp parameter is an
>> empty string, then inet_addr returns the value INADDR_NONE. If NULL is
>> passed in the cp parameter, then inet_addrreturns the value INADDR_NONE.
>> On Windows XP and earlier if the string in the cp parameter is an empty
>> string, then inet_addr returns the value INADDR_ANY. If NULL is passed in
>> the cp parameter, then inet_addr returns the value INADDR_NONE.
>>
>>
>> Thus, we should compare with INADDR_NONE and not with INADDR_ANY.
>>
>> George.
>>
>> On Mar 4, 2014, at 22:06 , Ralph Castain wrote:
>>
>> The code generating the error is here:
>>
>> in->sin_addr.s_addr = inet_addr(host);
>> if (in->sin_addr.s_addr == INADDR_ANY) {
>> return ORTE_ERR_BAD_PARAM;
>> }
>>
>>
>> The address is resolving to INADDR_ANY instead of a regular address. Does
>> cygwin require some other method for resolving a hostname to an IP address?
>>
>> Ralph
>>
>>
>>
>> On Tue, Mar 4, 2014 at 3:19 PM, Marco Atzeri wrote:
>>
>>> noted on cygwin with 1.7.4 and on 1.7.5rc1
>>>
>>> $ mpirun -n 4 ./hello_c.exe
>>> [MATZERI:06212] [[62628,1],0] ORTE_ERROR_LOG: Bad parameter in file
>>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>>> at line 292
>>> [MATZERI:05620] [[62628,1],1] ORTE_ERROR_LOG: Bad parameter in file
>>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>>> at line 292
>>> [MATZERI:06892] [[62628,1],2] ORTE_ERROR_LOG: Bad parameter in file
>>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>>> at line 292
>>> [MATZERI:03908] [[62628,1],3] ORTE_ERROR_LOG: Bad parameter in file
>>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>>> at line 292
>>> Hello, world, I am 1 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>> Hello, world, I am 2 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>> Hello, world, I am 3 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>> Hello, world, I am 0 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>>
>>> any idea what could be the cause ?
>>>
>>> I don't remember it in previous 1.7.x releases
>>>
>>> the relevant code is:
>>>
>>> if ((rc = parse_uri(pop->af_family, pop->net, pop->port, (struct
>>> sockaddr*) &inaddr)) != ORTE_SUCCESS) {
>>> ORTE_ERROR_LOG(rc);
>>>
>>> Regards
>>> Marco
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> Searchable archives: http://www.open-mpi.org/
>>> community/lists/devel/2014/03/index.php
>>>
>>
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Searchable archives:
>> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
>>
>>
>>
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Link to this post:
>> http://www.open-mpi.org/community/lists/devel/2014/03/14301.php
>>
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/03/14302.php
>
--
Paul H. Hargrove phhargr...@lbl.gov
Future Technologies Group
Computer and Data Sciences Department Tel: +1-510-495-2352
Lawr
Re: [OMPI devel] Bad parameter in file oob_tcp.c
Cool - I'll make the correction. Thx!
On Wed, Mar 5, 2014 at 2:08 PM, George Bosilca wrote:
> I'm afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY should
> not be a valid return for inet_addr. Here is a quick check on different
> OSes.
>
> On Linux, the man Page states:
>
> If the input is invalid, INADDR_NONE (usually -1) is returned.
>
>
> On Mac OS X:
>
> The constant INADDR_NONE is returned by inet_addr() and inet_network() for
> malformed requests.
>
>
> On Windows things are slightly more complicated:
>
> On Windows Server 2003 and later if the string in the cp parameter is an
> empty string, then inet_addr returns the value INADDR_NONE. If NULL is
> passed in the cp parameter, then inet_addrreturns the value INADDR_NONE.
> On Windows XP and earlier if the string in the cp parameter is an empty
> string, then inet_addr returns the value INADDR_ANY. If NULL is passed in
> the cp parameter, then inet_addr returns the value INADDR_NONE.
>
>
> Thus, we should compare with INADDR_NONE and not with INADDR_ANY.
>
> George.
>
> On Mar 4, 2014, at 22:06 , Ralph Castain wrote:
>
> The code generating the error is here:
>
> in->sin_addr.s_addr = inet_addr(host);
> if (in->sin_addr.s_addr == INADDR_ANY) {
> return ORTE_ERR_BAD_PARAM;
> }
>
>
> The address is resolving to INADDR_ANY instead of a regular address. Does
> cygwin require some other method for resolving a hostname to an IP address?
>
> Ralph
>
>
>
> On Tue, Mar 4, 2014 at 3:19 PM, Marco Atzeri wrote:
>
>> noted on cygwin with 1.7.4 and on 1.7.5rc1
>>
>> $ mpirun -n 4 ./hello_c.exe
>> [MATZERI:06212] [[62628,1],0] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:05620] [[62628,1],1] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:06892] [[62628,1],2] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:03908] [[62628,1],3] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> Hello, world, I am 1 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 2 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 3 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 0 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>
>> any idea what could be the cause ?
>>
>> I don't remember it in previous 1.7.x releases
>>
>> the relevant code is:
>>
>> if ((rc = parse_uri(pop->af_family, pop->net, pop->port, (struct
>> sockaddr*) &inaddr)) != ORTE_SUCCESS) {
>> ORTE_ERROR_LOG(rc);
>>
>> Regards
>> Marco
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Searchable archives: http://www.open-mpi.org/
>> community/lists/devel/2014/03/index.php
>>
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Searchable archives:
> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
>
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/03/14301.php
>
Re: [OMPI devel] Bad parameter in file oob_tcp.c
I’m afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY should not
be a valid return for inet_addr. Here is a quick check on different OSes.
On Linux, the man Page states:
> If the input is invalid, INADDR_NONE (usually -1) is returned.
On Mac OS X:
> The constant INADDR_NONE is returned by inet_addr() and inet_network() for
> malformed requests.
On Windows things are slightly more complicated:
> On Windows Server 2003 and later if the string in the cp parameter is an
> empty string, then inet_addr returns the value INADDR_NONE. If NULL is passed
> in the cp parameter, then inet_addrreturns the value INADDR_NONE.
> On Windows XP and earlier if the string in the cp parameter is an empty
> string, then inet_addr returns the value INADDR_ANY. If NULL is passed in the
> cp parameter, then inet_addr returns the value INADDR_NONE.
Thus, we should compare with INADDR_NONE and not with INADDR_ANY.
George.
On Mar 4, 2014, at 22:06 , Ralph Castain wrote:
> The code generating the error is here:
>
> in->sin_addr.s_addr = inet_addr(host);
> if (in->sin_addr.s_addr == INADDR_ANY) {
> return ORTE_ERR_BAD_PARAM;
> }
>
>
> The address is resolving to INADDR_ANY instead of a regular address. Does
> cygwin require some other method for resolving a hostname to an IP address?
>
> Ralph
>
>
>
> On Tue, Mar 4, 2014 at 3:19 PM, Marco Atzeri wrote:
> noted on cygwin with 1.7.4 and on 1.7.5rc1
>
> $ mpirun -n 4 ./hello_c.exe
> [MATZERI:06212] [[62628,1],0] ORTE_ERROR_LOG: Bad parameter in file
> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
> at line 292
> [MATZERI:05620] [[62628,1],1] ORTE_ERROR_LOG: Bad parameter in file
> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
> at line 292
> [MATZERI:06892] [[62628,1],2] ORTE_ERROR_LOG: Bad parameter in file
> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
> at line 292
> [MATZERI:03908] [[62628,1],3] ORTE_ERROR_LOG: Bad parameter in file
> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
> at line 292
> Hello, world, I am 1 of 4, (Open MPI v1.7.5rc1, package: Open MPI
> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
> Hello, world, I am 2 of 4, (Open MPI v1.7.5rc1, package: Open MPI
> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
> Hello, world, I am 3 of 4, (Open MPI v1.7.5rc1, package: Open MPI
> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
> Hello, world, I am 0 of 4, (Open MPI v1.7.5rc1, package: Open MPI
> marco@MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>
> any idea what could be the cause ?
>
> I don't remember it in previous 1.7.x releases
>
> the relevant code is:
>
> if ((rc = parse_uri(pop->af_family, pop->net, pop->port, (struct
> sockaddr*) &inaddr)) != ORTE_SUCCESS) {
> ORTE_ERROR_LOG(rc);
>
> Regards
> Marco
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Searchable archives:
> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Searchable archives:
> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
Re: [OMPI devel] Fix compiler warnings in FT code
That looks great. Thanks! On Wed, Mar 5, 2014 at 12:24 PM, Ralph Castain wrote: > Nicely done - thanks! > > > > On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote: > >> Josh, please have a look at: >> >> >> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488 >> >> I moved the parameter initialization to sstore_stage_register() and can >> now see that the variables are correctly used: >> >> $ orterun --mca sstore_stage_verbose 30 >> [...] >> [dcbz:02880] sstore:stage: open() >> [dcbz:02880] sstore:stage: open: priority = 10 >> [dcbz:02880] sstore:stage: open: verbosity = 30 >> [dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp >> [dcbz:02880] sstore:stage: open: Is Global dir. shared= False >> [dcbz:02880] sstore:stage: open: Node Local Caching = Disabled >> [dcbz:02880] sstore:stage: open: Compression = Disabled >> [dcbz:02880] sstore:stage: open: Compression Delay= 0 >> [dcbz:02880] sstore:stage: open: Skip FileM (Debug Only) = False >> >> >> >> On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote: >> > I will prepare a patch that moves the parameter initialization >> somewhere else >> > and will not remove it. Do you think the other parts of the patch can be >> > applied (without sstore_stage_select() removal)? >> > >> > >> > On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote: >> > > It should probably be moved to the component initialization of the >> sstore >> > > stage component since those parameters are how the user controls >> where to >> > > store those files. I think there is an MCA registration function that >> is >> > > called after component initialization - that would be the best spot, >> but I >> > > do not remember how to set it up at the moment. >> > > >> > > >> > > >> > > >> > > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber wrote: >> > > >> > > > I removed a complete function because it was not used: >> > > > >> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At >> top >> > > > level: >> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12: >> > > > warning: 'sstore_stage_select' defined but not used >> [-Wunused-function] >> > > > static int sstore_stage_select (void) >> > > > >> > > > And grepping through the code it seems the compiler is right. >> > > > >> > > > Should we keep the code and maybe just #ifdef it out. >> > > > >> > > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote: >> > > > > It looks like you removed a number of sstore stage MCA >> parameters. Did >> > > > they >> > > > > move somewhere else? or do you have a different way to set those >> > > > parameters? >> > > > > >> > > > > Other than that it looks good to me. >> > > > > >> > > > > >> > > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber >> wrote: >> > > > > >> > > > > > I have a simple patch which fixes the remaining compiler >> warnings when >> > > > > > running with '--with-ft': >> > > > > > >> > > > > > >> > > > > > >> > > > >> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f >> > > > > > >> > > > > > Does anybody see any problems with this patch? >> > > > > > >> > > > > > Adrian >> > > > > > ___ >> > > > > > devel mailing list >> > > > > > de...@open-mpi.org >> > > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel >> > > > ___ >> > > > devel mailing list >> > > > de...@open-mpi.org >> > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel >> > ___ >> > devel mailing list >> > de...@open-mpi.org >> > http://www.open-mpi.org/mailman/listinfo.cgi/devel >> >> Adrian >> >> -- >> Adrian Reber http://lisas.de/~adrian/ >> guru, n.: >> A person in T-shirt and sandals who took an elevator ride with >> a senior vice-president and is ultimately responsible for the >> phone call you are about to receive from your boss. >> ___ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2014/03/14298.php >> > > > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/03/14299.php > -- Joshua Hursey Assistant Professor of Computer Science University of Wisconsin-La Crosse http://cs.uwlax.edu/~jjhursey
Re: [OMPI devel] Fix compiler warnings in FT code
Nicely done - thanks! On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote: > Josh, please have a look at: > > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488 > > I moved the parameter initialization to sstore_stage_register() and can > now see that the variables are correctly used: > > $ orterun --mca sstore_stage_verbose 30 > [...] > [dcbz:02880] sstore:stage: open() > [dcbz:02880] sstore:stage: open: priority = 10 > [dcbz:02880] sstore:stage: open: verbosity = 30 > [dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp > [dcbz:02880] sstore:stage: open: Is Global dir. shared= False > [dcbz:02880] sstore:stage: open: Node Local Caching = Disabled > [dcbz:02880] sstore:stage: open: Compression = Disabled > [dcbz:02880] sstore:stage: open: Compression Delay= 0 > [dcbz:02880] sstore:stage: open: Skip FileM (Debug Only) = False > > > > On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote: > > I will prepare a patch that moves the parameter initialization somewhere > else > > and will not remove it. Do you think the other parts of the patch can be > > applied (without sstore_stage_select() removal)? > > > > > > On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote: > > > It should probably be moved to the component initialization of the > sstore > > > stage component since those parameters are how the user controls where > to > > > store those files. I think there is an MCA registration function that > is > > > called after component initialization - that would be the best spot, > but I > > > do not remember how to set it up at the moment. > > > > > > > > > > > > > > > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber wrote: > > > > > > > I removed a complete function because it was not used: > > > > > > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top > > > > level: > > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12: > > > > warning: 'sstore_stage_select' defined but not used > [-Wunused-function] > > > > static int sstore_stage_select (void) > > > > > > > > And grepping through the code it seems the compiler is right. > > > > > > > > Should we keep the code and maybe just #ifdef it out. > > > > > > > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote: > > > > > It looks like you removed a number of sstore stage MCA parameters. > Did > > > > they > > > > > move somewhere else? or do you have a different way to set those > > > > parameters? > > > > > > > > > > Other than that it looks good to me. > > > > > > > > > > > > > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber > wrote: > > > > > > > > > > > I have a simple patch which fixes the remaining compiler > warnings when > > > > > > running with '--with-ft': > > > > > > > > > > > > > > > > > > > > > > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f > > > > > > > > > > > > Does anybody see any problems with this patch? > > > > > > > > > > > > Adrian > > > > > > ___ > > > > > > devel mailing list > > > > > > de...@open-mpi.org > > > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > > > ___ > > > > devel mailing list > > > > de...@open-mpi.org > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > ___ > > devel mailing list > > de...@open-mpi.org > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > Adrian > > -- > Adrian Reber http://lisas.de/~adrian/ > guru, n.: > A person in T-shirt and sandals who took an elevator ride with > a senior vice-president and is ultimately responsible for the > phone call you are about to receive from your boss. > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/03/14298.php >
Re: [OMPI devel] Fix compiler warnings in FT code
Josh, please have a look at: https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488 I moved the parameter initialization to sstore_stage_register() and can now see that the variables are correctly used: $ orterun --mca sstore_stage_verbose 30 [...] [dcbz:02880] sstore:stage: open() [dcbz:02880] sstore:stage: open: priority = 10 [dcbz:02880] sstore:stage: open: verbosity = 30 [dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp [dcbz:02880] sstore:stage: open: Is Global dir. shared= False [dcbz:02880] sstore:stage: open: Node Local Caching = Disabled [dcbz:02880] sstore:stage: open: Compression = Disabled [dcbz:02880] sstore:stage: open: Compression Delay= 0 [dcbz:02880] sstore:stage: open: Skip FileM (Debug Only) = False On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote: > I will prepare a patch that moves the parameter initialization somewhere else > and will not remove it. Do you think the other parts of the patch can be > applied (without sstore_stage_select() removal)? > > > On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote: > > It should probably be moved to the component initialization of the sstore > > stage component since those parameters are how the user controls where to > > store those files. I think there is an MCA registration function that is > > called after component initialization - that would be the best spot, but I > > do not remember how to set it up at the moment. > > > > > > > > > > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber wrote: > > > > > I removed a complete function because it was not used: > > > > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top > > > level: > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12: > > > warning: 'sstore_stage_select' defined but not used [-Wunused-function] > > > static int sstore_stage_select (void) > > > > > > And grepping through the code it seems the compiler is right. > > > > > > Should we keep the code and maybe just #ifdef it out. > > > > > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote: > > > > It looks like you removed a number of sstore stage MCA parameters. Did > > > they > > > > move somewhere else? or do you have a different way to set those > > > parameters? > > > > > > > > Other than that it looks good to me. > > > > > > > > > > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber wrote: > > > > > > > > > I have a simple patch which fixes the remaining compiler warnings when > > > > > running with '--with-ft': > > > > > > > > > > > > > > > > > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f > > > > > > > > > > Does anybody see any problems with this patch? > > > > > > > > > > Adrian > > > > > ___ > > > > > devel mailing list > > > > > de...@open-mpi.org > > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > > ___ > > > devel mailing list > > > de...@open-mpi.org > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel Adrian -- Adrian Reber http://lisas.de/~adrian/ guru, n.: A person in T-shirt and sandals who took an elevator ride with a senior vice-president and is ultimately responsible for the phone call you are about to receive from your boss.
Re: [OMPI devel] autoconf warnings: openib BTL
On Mar 3, 2014, at 10:59 PM, Vasily Filipov wrote:
> Yes, it is possible, but there is some different if I will do it this way -
> With the current implementation (today into a trunk) if AC_RUN_IFELSE fails
> => old code of RDMACM will rise,
> And by way you suggest, if we postpone the decision to a run time and the
> check fails =>
> we have to abort RDMACM at all, because it was compiled for working with
> AF_IB.
> So my question to you, if we take into account all this stuff above -
> What's the right way to implement it ? What do you think ?
I'm not sure I understand. Can't you write something like:
#if HAVE_DECL_AF_IB
rc = try_using_af_ib();
if (OMPI_ERR_NOT_AVAILABLE == rc) {
rc = try_the_other_way();
}
#else
rc = try_the_other_way();
#endif
--
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [OMPI devel] mercurial mirror stuck to 02-19-2014
Fixed -- thanks for the heads up. On Mar 5, 2014, at 2:11 AM, Guillaume Papauré wrote: > Hi, > according to https://bitbucket.org/ompiteam/ompi-svn-mirror/commits/all the > bitbucket update process seems dead. > Maybe it just has to be restarted ? > > Regards, > Guillaume > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Searchable archives: > http://www.open-mpi.org/community/lists/devel/2014/03/14294.php -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [OMPI devel] Bad parameter in file oob_tcp.c
On 05/03/2014 04:06, Ralph Castain wrote:
The code generating the error is here:
in->sin_addr.s_addr = inet_addr(host);
if (in->sin_addr.s_addr == INADDR_ANY) {
return ORTE_ERR_BAD_PARAM;
}
The address is resolving to INADDR_ANY instead of a regular address.
Does cygwin require some other method for resolving a hostname to an IP
address?
Ralph
in theory should be transparent using the same as windows.
But I need to understand if there is any difference in formal behavior
Regards
Marco
[OMPI devel] mercurial mirror stuck to 02-19-2014
Hi, according to https://bitbucket.org/ompiteam/ompi-svn-mirror/commits/all the bitbucket update process seems dead. Maybe it just has to be restarted ? Regards, Guillaume
