[OMPI devel] Open MPI BTL TCP interface mapping

[Zhang, William via devel]

Hello devel,

Can someone (not Brian – he’s already reviewed it and this is a big enough 
change that I’d like others in the community to provide feedback), review the 
two patches https://github.com/open-mpi/ompi/pull/7167   
https://github.com/open-mpi/ompi/pull/7167

These PR’s fix common matching bugs that users utilizing the tcp btl encounter. 
It has been proven to fix issue https://github.com/open-mpi/ompi/issues/7115 – 
it’s also the first utilization of the Reachability framework, which can 
provide valuable reference material.

Thanks,
William Zhang

P.S.
I will start increasing the frequency of these reminders, since these PR’s are 
2+ months old.

Re: [OMPI devel] [EXTERNAL] Git submodules are coming

[Jeff Squyres (jsquyres) via devel]

Good idea -- see https://github.com/open-mpi/ompi/pull/7286.


On Jan 8, 2020, at 10:10 AM, Thomas Naughton 
mailto:naught...@ornl.gov>> wrote:

Hi Jeff,

I'm not sure where the issue templates reside, but it might be useful to
add `git submodule status` to the list of commands when reporting issues. (Once 
the first submodule PR is merged)


beaker:$ git submodule status
b94e2617df3fd9a3e83c388fa1c691c0057a77e9 opal/mca/pmix/pmix4x/openpmix 
(v1.1.3-2128-gb94e261)
52d498811f19be5306bd55b8433024733d3b589a prrte (dev-30165-g52d4988)
beaker:$


--tjn


_
 Thomas Naughton  
naught...@ornl.gov
 Research Associate   (865) 576-4184


On Tue, 7 Jan 2020, Jeff Squyres (jsquyres) via devel wrote:

We now have two PRs pending that will introduce the use of Git submodules (and 
there are probably more such PRs on the way).  At last one of these first two 
PRs will likely be merged "Real Soon Now".

We've been talking about using Git submodules forever.  Now we're just about 
ready.

**
*** DEVELOPERS: THIS AFFECTS YOU!! ***
**

You cannot just "clone and build" any more:

-
git clone g...@github.com:open-mpi/ompi.git
cd ompi && ./autogen.pl && ./configure ...
-

You will *have* to initialize the Git submodule(s) -- either during or after 
the clone.  *THEN* you can build Open MPI.

Go read this wiki: https://github.com/open-mpi/ompi/wiki/GitSubmodules

May the force be with us!

--
Jeff Squyres
jsquy...@cisco.com




--
Jeff Squyres
jsquy...@cisco.com

Re: [OMPI devel] Git submodules are coming

[Jeff Squyres (jsquyres) via devel]

The hwloc git submodule just got merged 
(https://github.com/open-mpi/ompi/pull/6821).

A new age is upon us!

Be sure you read the wiki before you complain here about your builds being 
broken.  :-)

https://github.com/open-mpi/ompi/wiki/GitSubmodules




On Jan 8, 2020, at 9:04 AM, Ralph Castain via devel 
mailto:devel@lists.open-mpi.org>> wrote:

Actually, I take that back - making a separate PR to change the opal/pmix 
embedded component to a submodule was way too painful. I simply added it to the 
existing #7202.


On Jan 7, 2020, at 1:33 PM, Ralph Castain via devel 
mailto:devel@lists.open-mpi.org>> wrote:

Just an FYI: there will soon be THREE PRs introducing submodules - I am 
breaking #7202 into two pieces. The first will replace opal/pmix with direct 
use of PMIx everywhere and replace the embedded pmix component with a submodule 
pointing to PMIx master, and the second will replace ORTE with PRRTE.


On Jan 7, 2020, at 9:02 AM, Jeff Squyres (jsquyres) via devel 
mailto:devel@lists.open-mpi.org>> wrote:

We now have two PRs pending that will introduce the use of Git submodules (and 
there are probably more such PRs on the way).  At last one of these first two 
PRs will likely be merged "Real Soon Now".

We've been talking about using Git submodules forever.  Now we're just about 
ready.

**
*** DEVELOPERS: THIS AFFECTS YOU!! ***
**

You cannot just "clone and build" any more:

-
git clone g...@github.com:open-mpi/ompi.git
cd ompi && ./autogen.pl && ./configure ...
-

You will *have* to initialize the Git submodule(s) -- either during or after 
the clone.  *THEN* you can build Open MPI.

Go read this wiki: https://github.com/open-mpi/ompi/wiki/GitSubmodules

May the force be with us!

--
Jeff Squyres
jsquy...@cisco.com







--
Jeff Squyres
jsquy...@cisco.com

Re: [OMPI devel] [EXTERNAL] Git submodules are coming

[Thomas Naughton via devel]

Hi Jeff,

I'm not sure where the issue templates reside, but it might be useful to
add `git submodule status` to the list of commands when reporting issues. 
(Once the first submodule PR is merged)



beaker:$ git submodule status
 b94e2617df3fd9a3e83c388fa1c691c0057a77e9 opal/mca/pmix/pmix4x/openpmix 
(v1.1.3-2128-gb94e261)
 52d498811f19be5306bd55b8433024733d3b589a prrte (dev-30165-g52d4988)
beaker:$


--tjn


 _
  Thomas Naughton  naught...@ornl.gov
  Research Associate   (865) 576-4184


On Tue, 7 Jan 2020, Jeff Squyres (jsquyres) via devel wrote:


We now have two PRs pending that will introduce the use of Git submodules (and there are 
probably more such PRs on the way).  At last one of these first two PRs will likely be 
merged "Real Soon Now".

We've been talking about using Git submodules forever.  Now we're just about 
ready.

**
*** DEVELOPERS: THIS AFFECTS YOU!! ***
**

You cannot just "clone and build" any more:

-
git clone g...@github.com:open-mpi/ompi.git
cd ompi && ./autogen.pl && ./configure ...
-

You will *have* to initialize the Git submodule(s) -- either during or after 
the clone.  *THEN* you can build Open MPI.

Go read this wiki: https://github.com/open-mpi/ompi/wiki/GitSubmodules

May the force be with us!

--
Jeff Squyres
jsquy...@cisco.com

Re: [OMPI devel] Git submodules are coming

[Ralph Castain via devel]

Actually, I take that back - making a separate PR to change the opal/pmix 
embedded component to a submodule was way too painful. I simply added it to the 
existing #7202.


> On Jan 7, 2020, at 1:33 PM, Ralph Castain via devel 
>  wrote:
> 
> Just an FYI: there will soon be THREE PRs introducing submodules - I am 
> breaking #7202 into two pieces. The first will replace opal/pmix with direct 
> use of PMIx everywhere and replace the embedded pmix component with a 
> submodule pointing to PMIx master, and the second will replace ORTE with 
> PRRTE.
> 
> 
>> On Jan 7, 2020, at 9:02 AM, Jeff Squyres (jsquyres) via devel 
>>  wrote:
>> 
>> We now have two PRs pending that will introduce the use of Git submodules 
>> (and there are probably more such PRs on the way).  At last one of these 
>> first two PRs will likely be merged "Real Soon Now".
>> 
>> We've been talking about using Git submodules forever.  Now we're just about 
>> ready.
>> 
>> **
>> *** DEVELOPERS: THIS AFFECTS YOU!! ***
>> **
>> 
>> You cannot just "clone and build" any more:
>> 
>> -
>> git clone g...@github.com:open-mpi/ompi.git
>> cd ompi && ./autogen.pl && ./configure ...
>> -
>> 
>> You will *have* to initialize the Git submodule(s) -- either during or after 
>> the clone.  *THEN* you can build Open MPI.
>> 
>> Go read this wiki: https://github.com/open-mpi/ompi/wiki/GitSubmodules
>> 
>> May the force be with us!
>> 
>> -- 
>> Jeff Squyres
>> jsquy...@cisco.com
>> 
> 
>