Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r32711 - trunk/opal/mca/pmix/cray

[Pritchard Jr., Howard]

thanks, it was bad cut/paste

From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Tim Mattox
Sent: Thursday, September 11, 2014 2:54 PM
To: Open MPI Developers
Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r32711 - 
trunk/opal/mca/pmix/cray

I'm sure that is not what you meant to do...
the assignment to NULL should occur AFTER the free()...

On Thu, Sep 11, 2014 at 4:30 PM, 
<svn-commit-mai...@open-mpi.org<mailto:svn-commit-mai...@open-mpi.org>> wrote:
Author: hppritcha (Howard Pritchard)
Date: 2014-09-11 16:30:40 EDT (Thu, 11 Sep 2014)
New Revision: 32711
URL: https://svn.open-mpi.org/trac/ompi/changeset/32711

Log:
Fix potential double free in cray pmi cray_fini

Text files modified:
   trunk/opal/mca/pmix/cray/pmix_cray.c | 1 +
   1 files changed, 1 insertions(+), 0 deletions(-)

Modified: trunk/opal/mca/pmix/cray/pmix_cray.c
==
--- trunk/opal/mca/pmix/cray/pmix_cray.cThu Sep 11 10:51:30 2014
(r32710)
+++ trunk/opal/mca/pmix/cray/pmix_cray.c2014-09-11 16:30:40 EDT (Thu, 
11 Sep 2014)  (r32711)
@@ -257,6 +257,7 @@
 }

 if (NULL != pmix_lranks) {
+pmix_lranks = NULL;
 free(pmix_lranks);
 }

___
svn-full mailing list
svn-f...@open-mpi.org<mailto:svn-f...@open-mpi.org>
http://www.open-mpi.org/mailman/listinfo.cgi/svn-full



--
Tim Mattox, Ph.D. - tmat...@gmail.com<mailto:tmat...@gmail.com>

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r32711 - trunk/opal/mca/pmix/cray

[Tim Mattox]

I'm sure that is not what you meant to do...
the assignment to NULL should occur AFTER the free()...

On Thu, Sep 11, 2014 at 4:30 PM,  wrote:

> Author: hppritcha (Howard Pritchard)
> Date: 2014-09-11 16:30:40 EDT (Thu, 11 Sep 2014)
> New Revision: 32711
> URL: https://svn.open-mpi.org/trac/ompi/changeset/32711
>
> Log:
> Fix potential double free in cray pmi cray_fini
>
> Text files modified:
>trunk/opal/mca/pmix/cray/pmix_cray.c | 1 +
>1 files changed, 1 insertions(+), 0 deletions(-)
>
> Modified: trunk/opal/mca/pmix/cray/pmix_cray.c
>
> ==
> --- trunk/opal/mca/pmix/cray/pmix_cray.cThu Sep 11 10:51:30 2014
>   (r32710)
> +++ trunk/opal/mca/pmix/cray/pmix_cray.c2014-09-11 16:30:40 EDT
> (Thu, 11 Sep 2014)  (r32711)
> @@ -257,6 +257,7 @@
>  }
>
>  if (NULL != pmix_lranks) {
> +pmix_lranks = NULL;
>  free(pmix_lranks);
>  }
>
> ___
> svn-full mailing list
> svn-f...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>



-- 
Tim Mattox, Ph.D. - tmat...@gmail.com