Re: [OMPI devel] [v1.8] illegal commas after last item in enum

[Jeff Squyres (jsquyres)]

Fixed in trunk in r32482; CMR'ed to v1.8.

Thanks.


On Aug 9, 2014, at 12:36 AM, Paul Hargrove  wrote:

> The Solaris Studio 12.3 C++ compiler warns about commas after the last item 
> in an enum.
> While these commas are legal in C99, they are ILLEGAL in C++ prior to C++11
> 
> The warnings below list the four instances I encountered while building the 
> C++ bindings, but there might be others.
> 
> -Paul
> 
> "openmpi-1.8.2rc4r32480/ompi/include/ompi/constants.h", line 70: Warning: 
> Identifier expected instead of "}".
> "openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_framework.h", line 37: 
> Warning: Identifier expected instead of "}".
> "openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_framework.h", line 119: 
> Warning: Identifier expected instead of "}".
> "openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_var.h", line 694: Warning: 
> Identifier expected instead of "}".
> 
> 
> -- 
> Paul H. Hargrove  phhargr...@lbl.gov
> Future Technologies Group
> Computer and Data Sciences Department Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: 
> http://www.open-mpi.org/community/lists/devel/2014/08/15576.php


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

[OMPI devel] [v1.8] illegal commas after last item in enum

[Paul Hargrove]

The Solaris Studio 12.3 C++ compiler warns about commas after the last item
in an enum.
While these commas are legal in C99, they are ILLEGAL in C++ prior to C++11

The warnings below list the four instances I encountered while building the
C++ bindings, but there might be others.

-Paul

"openmpi-1.8.2rc4r32480/ompi/include/ompi/constants.h", line 70: Warning:
Identifier expected instead of "}".
"openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_framework.h", line 37:
Warning: Identifier expected instead of "}".
"openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_framework.h", line 119:
Warning: Identifier expected instead of "}".
"openmpi-1.8.2rc4r32480/opal/mca/base/mca_base_var.h", line 694: Warning:
Identifier expected instead of "}".


-- 
Paul H. Hargrove  phhargr...@lbl.gov
Future Technologies Group
Computer and Data Sciences Department Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory Fax: +1-510-486-6900