Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Josh Hursey 
That looks great. Thanks!


On Wed, Mar 5, 2014 at 12:24 PM, Ralph Castain  wrote:

> Nicely done - thanks!
>
>
>
> On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber  wrote:
>
>> Josh, please have a look at:
>>
>>
>> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488
>>
>> I moved the parameter initialization to sstore_stage_register() and can
>> now see that the variables are correctly used:
>>
>> $ orterun --mca sstore_stage_verbose 30
>> [...]
>> [dcbz:02880] sstore:stage: open()
>> [dcbz:02880] sstore:stage: open: priority   = 10
>> [dcbz:02880] sstore:stage: open: verbosity  = 30
>> [dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp
>> [dcbz:02880] sstore:stage: open: Is Global dir. shared= False
>> [dcbz:02880] sstore:stage: open: Node Local Caching   = Disabled
>> [dcbz:02880] sstore:stage: open: Compression  = Disabled
>> [dcbz:02880] sstore:stage: open: Compression Delay= 0
>> [dcbz:02880] sstore:stage: open: Skip FileM (Debug Only)  = False
>>
>>
>>
>> On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote:
>> > I will prepare a patch that moves the parameter initialization
>> somewhere else
>> > and will not remove it. Do you think the other parts of the patch can be
>> > applied (without sstore_stage_select() removal)?
>> >
>> >
>> > On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
>> > > It should probably be moved to the component initialization of the
>> sstore
>> > > stage component since those parameters are how the user controls
>> where to
>> > > store those files. I think there is an MCA registration function that
>> is
>> > > called after component initialization - that would be the best spot,
>> but I
>> > > do not remember how to set it up at the moment.
>> > >
>> > >
>> > >
>> > >
>> > > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:
>> > >
>> > > > I removed a complete function because it was not used:
>> > > >
>> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At
>> top
>> > > > level:
>> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
>> > > > warning: 'sstore_stage_select' defined but not used
>> [-Wunused-function]
>> > > >  static int sstore_stage_select (void)
>> > > >
>> > > > And grepping through the code it seems the compiler is right.
>> > > >
>> > > > Should we keep the code and maybe just #ifdef it out.
>> > > >
>> > > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
>> > > > > It looks like you removed a number of sstore stage MCA
>> parameters. Did
>> > > > they
>> > > > > move somewhere else? or do you have a different way to set those
>> > > > parameters?
>> > > > >
>> > > > > Other than that it looks good to me.
>> > > > >
>> > > > >
>> > > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber 
>> wrote:
>> > > > >
>> > > > > > I have a simple patch which fixes the remaining compiler
>> warnings when
>> > > > > > running with '--with-ft':
>> > > > > >
>> > > > > >
>> > > > > >
>> > > >
>> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
>> > > > > >
>> > > > > > Does anybody see any problems with this patch?
>> > > > > >
>> > > > > > Adrian
>> > > > > > ___
>> > > > > > devel mailing list
>> > > > > > de...@open-mpi.org
>> > > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> > > > ___
>> > > > devel mailing list
>> > > > de...@open-mpi.org
>> > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> > ___
>> > devel mailing list
>> > de...@open-mpi.org
>> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>> Adrian
>>
>> --
>> Adrian Reber http://lisas.de/~adrian/
>> guru, n.:
>> A person in T-shirt and sandals who took an elevator ride with
>> a senior vice-president and is ultimately responsible for the
>> phone call you are about to receive from your boss.
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Link to this post:
>> http://www.open-mpi.org/community/lists/devel/2014/03/14298.php
>>
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/03/14299.php
>



-- 
Joshua Hursey
Assistant Professor of Computer Science
University of Wisconsin-La Crosse
http://cs.uwlax.edu/~jjhursey

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Ralph Castain 
Nicely done - thanks!



On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber  wrote:

> Josh, please have a look at:
>
>
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488
>
> I moved the parameter initialization to sstore_stage_register() and can
> now see that the variables are correctly used:
>
> $ orterun --mca sstore_stage_verbose 30
> [...]
> [dcbz:02880] sstore:stage: open()
> [dcbz:02880] sstore:stage: open: priority   = 10
> [dcbz:02880] sstore:stage: open: verbosity  = 30
> [dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp
> [dcbz:02880] sstore:stage: open: Is Global dir. shared= False
> [dcbz:02880] sstore:stage: open: Node Local Caching   = Disabled
> [dcbz:02880] sstore:stage: open: Compression  = Disabled
> [dcbz:02880] sstore:stage: open: Compression Delay= 0
> [dcbz:02880] sstore:stage: open: Skip FileM (Debug Only)  = False
>
>
>
> On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote:
> > I will prepare a patch that moves the parameter initialization somewhere
> else
> > and will not remove it. Do you think the other parts of the patch can be
> > applied (without sstore_stage_select() removal)?
> >
> >
> > On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
> > > It should probably be moved to the component initialization of the
> sstore
> > > stage component since those parameters are how the user controls where
> to
> > > store those files. I think there is an MCA registration function that
> is
> > > called after component initialization - that would be the best spot,
> but I
> > > do not remember how to set it up at the moment.
> > >
> > >
> > >
> > >
> > > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:
> > >
> > > > I removed a complete function because it was not used:
> > > >
> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top
> > > > level:
> > > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
> > > > warning: 'sstore_stage_select' defined but not used
> [-Wunused-function]
> > > >  static int sstore_stage_select (void)
> > > >
> > > > And grepping through the code it seems the compiler is right.
> > > >
> > > > Should we keep the code and maybe just #ifdef it out.
> > > >
> > > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> > > > > It looks like you removed a number of sstore stage MCA parameters.
> Did
> > > > they
> > > > > move somewhere else? or do you have a different way to set those
> > > > parameters?
> > > > >
> > > > > Other than that it looks good to me.
> > > > >
> > > > >
> > > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber 
> wrote:
> > > > >
> > > > > > I have a simple patch which fixes the remaining compiler
> warnings when
> > > > > > running with '--with-ft':
> > > > > >
> > > > > >
> > > > > >
> > > >
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> > > > > >
> > > > > > Does anybody see any problems with this patch?
> > > > > >
> > > > > > Adrian
> > > > > > ___
> > > > > > devel mailing list
> > > > > > de...@open-mpi.org
> > > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > > > ___
> > > > devel mailing list
> > > > de...@open-mpi.org
> > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > ___
> > devel mailing list
> > de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> Adrian
>
> --
> Adrian Reber http://lisas.de/~adrian/
> guru, n.:
> A person in T-shirt and sandals who took an elevator ride with
> a senior vice-president and is ultimately responsible for the
> phone call you are about to receive from your boss.
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/03/14298.php
>

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-05 Thread Adrian Reber 
Josh, please have a look at:

https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488

I moved the parameter initialization to sstore_stage_register() and can
now see that the variables are correctly used:

$ orterun --mca sstore_stage_verbose 30
[...]
[dcbz:02880] sstore:stage: open()
[dcbz:02880] sstore:stage: open: priority   = 10
[dcbz:02880] sstore:stage: open: verbosity  = 30
[dcbz:02880] sstore:stage: open: Local snapshot directory = /tmp
[dcbz:02880] sstore:stage: open: Is Global dir. shared= False
[dcbz:02880] sstore:stage: open: Node Local Caching   = Disabled
[dcbz:02880] sstore:stage: open: Compression  = Disabled
[dcbz:02880] sstore:stage: open: Compression Delay= 0
[dcbz:02880] sstore:stage: open: Skip FileM (Debug Only)  = False



On Mon, Mar 03, 2014 at 05:42:13PM +0100, Adrian Reber wrote:
> I will prepare a patch that moves the parameter initialization somewhere else
> and will not remove it. Do you think the other parts of the patch can be
> applied (without sstore_stage_select() removal)?
> 
> 
> On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
> > It should probably be moved to the component initialization of the sstore
> > stage component since those parameters are how the user controls where to
> > store those files. I think there is an MCA registration function that is
> > called after component initialization - that would be the best spot, but I
> > do not remember how to set it up at the moment.
> > 
> > 
> > 
> > 
> > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:
> > 
> > > I removed a complete function because it was not used:
> > >
> > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top
> > > level:
> > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
> > > warning: 'sstore_stage_select' defined but not used [-Wunused-function]
> > >  static int sstore_stage_select (void)
> > >
> > > And grepping through the code it seems the compiler is right.
> > >
> > > Should we keep the code and maybe just #ifdef it out.
> > >
> > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> > > > It looks like you removed a number of sstore stage MCA parameters. Did
> > > they
> > > > move somewhere else? or do you have a different way to set those
> > > parameters?
> > > >
> > > > Other than that it looks good to me.
> > > >
> > > >
> > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber  wrote:
> > > >
> > > > > I have a simple patch which fixes the remaining compiler warnings when
> > > > > running with '--with-ft':
> > > > >
> > > > >
> > > > >
> > > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> > > > >
> > > > > Does anybody see any problems with this patch?
> > > > >
> > > > > Adrian
> > > > > ___
> > > > > devel mailing list
> > > > > de...@open-mpi.org
> > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > > ___
> > > devel mailing list
> > > de...@open-mpi.org
> > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Adrian

-- 
Adrian Reber http://lisas.de/~adrian/
guru, n.:
A person in T-shirt and sandals who took an elevator ride with
a senior vice-president and is ultimately responsible for the
phone call you are about to receive from your boss.

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Josh Hursey 
Yea. Those look fine. Thanks!


On Mon, Mar 3, 2014 at 10:42 AM, Adrian Reber  wrote:

> I will prepare a patch that moves the parameter initialization somewhere
> else
> and will not remove it. Do you think the other parts of the patch can be
> applied (without sstore_stage_select() removal)?
>
>
> On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
> > It should probably be moved to the component initialization of the sstore
> > stage component since those parameters are how the user controls where to
> > store those files. I think there is an MCA registration function that is
> > called after component initialization - that would be the best spot, but
> I
> > do not remember how to set it up at the moment.
> >
> >
> >
> >
> > On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:
> >
> > > I removed a complete function because it was not used:
> > >
> > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top
> > > level:
> > > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
> > > warning: 'sstore_stage_select' defined but not used [-Wunused-function]
> > >  static int sstore_stage_select (void)
> > >
> > > And grepping through the code it seems the compiler is right.
> > >
> > > Should we keep the code and maybe just #ifdef it out.
> > >
> > > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> > > > It looks like you removed a number of sstore stage MCA parameters.
> Did
> > > they
> > > > move somewhere else? or do you have a different way to set those
> > > parameters?
> > > >
> > > > Other than that it looks good to me.
> > > >
> > > >
> > > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber 
> wrote:
> > > >
> > > > > I have a simple patch which fixes the remaining compiler warnings
> when
> > > > > running with '--with-ft':
> > > > >
> > > > >
> > > > >
> > >
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> > > > >
> > > > > Does anybody see any problems with this patch?
> > > > >
> > > > > Adrian
> > > > > ___
> > > > > devel mailing list
> > > > > de...@open-mpi.org
> > > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > > ___
> > > devel mailing list
> > > de...@open-mpi.org
> > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>



-- 
Joshua Hursey
Assistant Professor of Computer Science
University of Wisconsin-La Crosse
http://cs.uwlax.edu/~jjhursey

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Adrian Reber 
I will prepare a patch that moves the parameter initialization somewhere else
and will not remove it. Do you think the other parts of the patch can be
applied (without sstore_stage_select() removal)?


On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
> It should probably be moved to the component initialization of the sstore
> stage component since those parameters are how the user controls where to
> store those files. I think there is an MCA registration function that is
> called after component initialization - that would be the best spot, but I
> do not remember how to set it up at the moment.
> 
> 
> 
> 
> On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:
> 
> > I removed a complete function because it was not used:
> >
> > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top
> > level:
> > ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
> > warning: 'sstore_stage_select' defined but not used [-Wunused-function]
> >  static int sstore_stage_select (void)
> >
> > And grepping through the code it seems the compiler is right.
> >
> > Should we keep the code and maybe just #ifdef it out.
> >
> > On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> > > It looks like you removed a number of sstore stage MCA parameters. Did
> > they
> > > move somewhere else? or do you have a different way to set those
> > parameters?
> > >
> > > Other than that it looks good to me.
> > >
> > >
> > > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber  wrote:
> > >
> > > > I have a simple patch which fixes the remaining compiler warnings when
> > > > running with '--with-ft':
> > > >
> > > >
> > > >
> > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> > > >
> > > > Does anybody see any problems with this patch?
> > > >
> > > > Adrian
> > > > ___
> > > > devel mailing list
> > > > de...@open-mpi.org
> > > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > ___
> > devel mailing list
> > de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Josh Hursey 
It should probably be moved to the component initialization of the sstore
stage component since those parameters are how the user controls where to
store those files. I think there is an MCA registration function that is
called after component initialization - that would be the best spot, but I
do not remember how to set it up at the moment.




On Mon, Mar 3, 2014 at 7:25 AM, Adrian Reber  wrote:

> I removed a complete function because it was not used:
>
> ../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top
> level:
> ../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12:
> warning: 'sstore_stage_select' defined but not used [-Wunused-function]
>  static int sstore_stage_select (void)
>
> And grepping through the code it seems the compiler is right.
>
> Should we keep the code and maybe just #ifdef it out.
>
> On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> > It looks like you removed a number of sstore stage MCA parameters. Did
> they
> > move somewhere else? or do you have a different way to set those
> parameters?
> >
> > Other than that it looks good to me.
> >
> >
> > On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber  wrote:
> >
> > > I have a simple patch which fixes the remaining compiler warnings when
> > > running with '--with-ft':
> > >
> > >
> > >
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> > >
> > > Does anybody see any problems with this patch?
> > >
> > > Adrian
> > > ___
> > > devel mailing list
> > > de...@open-mpi.org
> > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>



-- 
Joshua Hursey
Assistant Professor of Computer Science
University of Wisconsin-La Crosse
http://cs.uwlax.edu/~jjhursey

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Adrian Reber 
I removed a complete function because it was not used:

../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top level:
../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12: warning: 
'sstore_stage_select' defined but not used [-Wunused-function]
 static int sstore_stage_select (void)

And grepping through the code it seems the compiler is right.

Should we keep the code and maybe just #ifdef it out.

On Mon, Mar 03, 2014 at 07:17:19AM -0600, Josh Hursey wrote:
> It looks like you removed a number of sstore stage MCA parameters. Did they
> move somewhere else? or do you have a different way to set those parameters?
> 
> Other than that it looks good to me.
> 
> 
> On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber  wrote:
> 
> > I have a simple patch which fixes the remaining compiler warnings when
> > running with '--with-ft':
> >
> >
> > https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
> >
> > Does anybody see any problems with this patch?
> >
> > Adrian
> > ___
> > devel mailing list
> > de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Josh Hursey 
It looks like you removed a number of sstore stage MCA parameters. Did they
move somewhere else? or do you have a different way to set those parameters?

Other than that it looks good to me.


On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber  wrote:

> I have a simple patch which fixes the remaining compiler warnings when
> running with '--with-ft':
>
>
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
>
> Does anybody see any problems with this patch?
>
> Adrian
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>



-- 
Joshua Hursey
Assistant Professor of Computer Science
University of Wisconsin-La Crosse
http://cs.uwlax.edu/~jjhursey

[OMPI devel] Fix compiler warnings in FT code

2014-03-03 Thread Adrian Reber 
I have a simple patch which fixes the remaining compiler warnings when
running with '--with-ft':

https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f

Does anybody see any problems with this patch?

Adrian