Re: [OMPI devel] Master warnings?

2018-06-03 Thread Gilles Gouaillardet
Nathan,

there could be another issue :

with gcc 8.1.0, I get some warnings (see logs at the end)

From 
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-error-function-attribute

error ("message")warning ("message")

If the error or warning attribute is used on a function declaration
and a call to such a function is not eliminated through dead code
elimination or other optimizations, an error or warning (respectively)
that includes message is diagnosed. This is useful for compile-time
checking, especially together with __builtin_constant_p and inline
functions where checking the inline function arguments is not possible
through extern char [(condition) ? 1 : -1]; tricks.

While it is possible to leave the function undefined and thus invoke a
link failure (to define the function with a message in .gnu.warning*
section), when using these attributes the problem is diagnosed earlier
and with exact location of the call even in presence of inline
functions or when not emitting debugging information.


Unlike the deprecated attribute, nothing is said about variables, so
based on the warning message, I guess the error attribute is only
allowed for functions (e.g. *not* on variables or typedef)

Cheers,

Gilles


mpicc ../../../src/ompi-master/examples/hello_c.c

In file included from ../../../src/ompi-master/examples/hello_c.c:11:

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:423:9: warning:
'error' attribute ignored [-Wattributes]

 __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed
in MPI-3.0; use MPI_Comm_errhandler_function instead");

 ^

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:425:9: warning:
'error' attribute ignored [-Wattributes]

 __mpi_interface_removed__("MPI_File_errhandler_fn was removed
in MPI-3.0; use MPI_File_errhandler_function instead");

 ^

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:427:9: warning:
'error' attribute ignored [-Wattributes]

 __mpi_interface_removed__("MPI_Win_errhandler_fn was removed
in MPI-3.0; use MPI_Win_errhandler_function instead");

 ^

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:429:9: warning:
'error' attribute ignored [-Wattributes]

 __mpi_interface_removed__("MPI_Handler_function was removed
in MPI-3.0; use MPI_Win_errhandler_function instead");

 ^

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:1042:29: warning:
'error' attribute ignored [-Wattributes]

 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb
__mpi_interface_removed__("MPI_LB was removed in MPI-3.0");

 ^~

/Users/gilles/local/ompi-master-gcc8/include/mpi.h:1043:29: warning:
'error' attribute ignored [-Wattributes]

 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub
__mpi_interface_removed__("MPI_UB was removed in MPI-3.0");

 ^~

On Sat, Jun 2, 2018 at 11:56 PM, r...@open-mpi.org  wrote:
> No problem - I just commented because earlier in the week it had built
> clean, so I was surprised to get the flood.
>
> This was with gcc 6.3.0, so not that old
>
>
> On Jun 2, 2018, at 7:19 AM, Nathan Hjelm  wrote:
>
> Should have it fixed today or tomorrow. Guess I didn't have a sufficiently
> old gcc to catch this during testing.
>
> -Nathan
>
> On Jun 2, 2018, at 1:09 AM, gil...@rist.or.jp wrote:
>
> Hi Ralph,
>
>
>
> see my last comment in https://github.com/open-mpi/ompi/pull/5210
>
>
>
> long story short, this is just a warning you can ignore.
>
> If you are running on a CentOS 7 box
>
> with the default GNU compiler, you can
>
> opal_cv___attribute__error=0 configure ...
>
> in order to get rid of these.
>
>
>
> Cheers,
>
>
>
> Gilles
>
> - Original Message -
>
> Geez guys - what happened?
>
> In file included from monitoring_prof.c:47:0:
> ../../../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in
> MPI-3.0; use MPI_Comm_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored
> [-Wattributes]
>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in
> MPI-3.0; use MPI_File_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in
> MPI-3.0; use MPI_Win_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Handler_function was removed in
> MPI-3.0; use MPI_Win_errhandler_function instead");
>   ^~~~

Re: [OMPI devel] Master warnings?

2018-06-02 Thread r...@open-mpi.org
No problem - I just commented because earlier in the week it had built clean, 
so I was surprised to get the flood.

This was with gcc 6.3.0, so not that old


> On Jun 2, 2018, at 7:19 AM, Nathan Hjelm  wrote:
> 
> Should have it fixed today or tomorrow. Guess I didn't have a sufficiently 
> old gcc to catch this during testing.
> 
> -Nathan
> 
> On Jun 2, 2018, at 1:09 AM, gil...@rist.or.jp  
> wrote:
> 
>> Hi Ralph,
>> 
>>  
>> see my last comment in https://github.com/open-mpi/ompi/pull/5210 
>> 
>>  
>> long story short, this is just a warning you can ignore.
>> 
>> If you are running on a CentOS 7 box
>> 
>> with the default GNU compiler, you can
>> 
>> opal_cv___attribute__error=0 configure ...
>> 
>> in order to get rid of these.
>> 
>>  
>> Cheers,
>> 
>>  
>> Gilles
>> 
>> - Original Message -
>> 
>> Geez guys - what happened?
>>  
>> In file included from monitoring_prof.c:47:0:
>> ../../../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Comm_errhandler_function instead");
>>   ^
>> ../../../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
>> MPI-3.0; use MPI_File_errhandler_function instead");
>>   ^
>> ../../../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Win_errhandler_function instead");
>>   ^
>> ../../../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Handler_function was removed in 
>> MPI-3.0; use MPI_Win_errhandler_function instead");
>>   ^
>> ../../../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute 
>> ignored [-Wattributes]
>>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
>> __mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
>> ^~
>> ../../../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ attribute 
>> ignored [-Wattributes]
>>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
>> __mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
>> ^~
>> In file included from monitoring_test.c:65:0:
>> ../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Comm_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
>> MPI-3.0; use MPI_File_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Win_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Handler_function was removed in 
>> MPI-3.0; use MPI_Win_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
>> __mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
>> ^~
>> ../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
>> __mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
>> ^~
>> In file included from check_monitoring.c:21:0:
>> ../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Comm_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
>> MPI-3.0; use MPI_File_errhandler_function instead");
>>   ^
>> ../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
>> [-Wattributes]
>>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
>> MPI-3.0; use MPI_Win_errhandler_function ins

Re: [OMPI devel] Master warnings?

2018-06-02 Thread Nathan Hjelm
Should have it fixed today or tomorrow. Guess I didn't have a sufficiently old 
gcc to catch this during testing.

-Nathan

> On Jun 2, 2018, at 1:09 AM, gil...@rist.or.jp wrote:
> 
> Hi Ralph,
> 
>  
> 
> see my last comment in https://github.com/open-mpi/ompi/pull/5210
> 
>  
> 
> long story short, this is just a warning you can ignore.
> 
> If you are running on a CentOS 7 box
> 
> with the default GNU compiler, you can
> 
> opal_cv___attribute__error=0 configure ...
> 
> in order to get rid of these.
> 
>  
> 
> Cheers,
> 
>  
> 
> Gilles
> 
> - Original Message -
> 
> Geez guys - what happened?
>  
> In file included from monitoring_prof.c:47:0:
> ../../../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
> MPI-3.0; use MPI_Comm_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
> MPI-3.0; use MPI_File_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
> MPI-3.0; use MPI_Win_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Handler_function was removed in MPI-3.0; 
> use MPI_Win_errhandler_function instead");
>   ^
> ../../../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
> __mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
> ^~
> ../../../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
> __mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
> ^~
> In file included from monitoring_test.c:65:0:
> ../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
> MPI-3.0; use MPI_Comm_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
> MPI-3.0; use MPI_File_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
> MPI-3.0; use MPI_Win_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Handler_function was removed in MPI-3.0; 
> use MPI_Win_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
> __mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
> ^~
> ../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>  OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
> __mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
> ^~
> In file included from check_monitoring.c:21:0:
> ../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed in 
> MPI-3.0; use MPI_Comm_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_File_errhandler_fn was removed in 
> MPI-3.0; use MPI_File_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Win_errhandler_fn was removed in 
> MPI-3.0; use MPI_Win_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>   __mpi_interface_removed__("MPI_Handler_function was removed in MPI-3.0; 
> use MPI_Win_errhandler_function instead");
>   ^
> ../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute ignored 
> [-Wattributes]
>  OMP

Re: [OMPI devel] Master warnings?

2018-06-02 Thread gilles
Hi Ralph,

see my last comment in https://github.com/open-mpi/ompi/pull/5210

long story short, this is just a warning you can ignore.

If you are running on a CentOS 7 box

with the default GNU compiler, you can

opal_cv___attribute__error=0 configure ...

in order to get rid of these.

Cheers,

Gilles

- Original Message -

Geez guys - what happened?

In file included from monitoring_prof.c:47:0:
../../../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed 
in MPI-3.0; use MPI_Comm_errhandler_function instead");
  ^
../../../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_File_errhandler_fn was removed 
in MPI-3.0; use MPI_File_errhandler_function instead");
  ^
../../../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Win_errhandler_fn was removed 
in MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Handler_function was removed in 
MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ 
attribute ignored [-Wattributes]
 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
__mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
^~
../../../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ 
attribute ignored [-Wattributes]
 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
__mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
^~
In file included from monitoring_test.c:65:0:
../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed 
in MPI-3.0; use MPI_Comm_errhandler_function instead");
  ^
../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_File_errhandler_fn was removed 
in MPI-3.0; use MPI_File_errhandler_function instead");
  ^
../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Win_errhandler_fn was removed 
in MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Handler_function was removed in 
MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute 
ignored [-Wattributes]
 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
__mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
^~
../../ompi/include/mpi.h:1043:29:warning: ‘__error__’ attribute 
ignored [-Wattributes]
 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_ub 
__mpi_interface_removed__("MPI_UB was removed in MPI-3.0");
^~
In file included from check_monitoring.c:21:0:
../../ompi/include/mpi.h:423:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Comm_errhandler_fn was removed 
in MPI-3.0; use MPI_Comm_errhandler_function instead");
  ^
../../ompi/include/mpi.h:425:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_File_errhandler_fn was removed 
in MPI-3.0; use MPI_File_errhandler_function instead");
  ^
../../ompi/include/mpi.h:427:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Win_errhandler_fn was removed 
in MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../ompi/include/mpi.h:429:9:warning: ‘__error__’ attribute 
ignored [-Wattributes]
  __mpi_interface_removed__("MPI_Handler_function was removed in 
MPI-3.0; use MPI_Win_errhandler_function instead");
  ^
../../ompi/include/mpi.h:1042:29:warning: ‘__error__’ attribute 
ignored [-Wattributes]
 OMPI_DECLSPEC extern struct ompi_predefined_datatype_t ompi_mpi_lb 
__mpi_interface_removed__("MPI_LB was removed in MPI-3.0");
^~
../../ompi/include/mpi.h:1043:29:wa

Re: [OMPI devel] Master warnings

2017-06-13 Thread George Bosilca
e9d533e62ecb should fix these warnings. They are harmless, as we cannot be
reaching the context needed for them to have an impact because collectives
communications with 0 bytes are trimmed out in the MPI layer.

Thanks for reporting.
  George.


On Tue, Jun 13, 2017 at 12:43 PM, r...@open-mpi.org  wrote:

> Configured master with no options given to it (i.e., out-of-the-box) - the
> key being that it defaults to --disable-debug - and drowned in warnings:
>
> *base/coll_base_scatter.c:* In function ‘
> *ompi_coll_base_scatter_intra_binomial*’:
> *base/coll_base_scatter.c:90:28:* *warning: *‘*sgap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  ptmp = tempbuf *-* sgap;
> *^*
> *base/coll_base_scatter.c:117:24:* *warning: *‘*rgap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  ptmp = tempbuf *-* rgap;
> *^*
> *base/coll_base_alltoall.c:* In function ‘
> *mca_coll_base_alltoall_intra_basic_inplace*’:
> *base/coll_base_alltoall.c:69:35:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  tmp_buffer = allocated_buffer *-* gap;
>*^*
> *base/coll_base_alltoall.c:* In function ‘
> *ompi_coll_base_alltoall_intra_bruck*’:
> *base/coll_base_alltoall.c:230:26:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  tmpbuf = tmpbuf_free *-* gap;
>   *^*
> *base/coll_base_allgather.c:* In function ‘
> *ompi_coll_base_allgather_intra_bruck*’:
> *base/coll_base_allgather.c:179:30:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  shift_buf = free_buf *-* gap;
>   *^*
> *base/coll_base_gather.c:* In function ‘
> *ompi_coll_base_gather_intra_binomial*’:
> *base/coll_base_gather.c:91:28:* *warning: *‘*rgap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  ptmp = tempbuf *-* rgap;
> *^*
> *base/coll_base_gather.c:114:24:* *warning: *‘*sgap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  ptmp = tempbuf *-* sgap;
> *^*
> *base/coll_base_reduce_scatter.c:* In function ‘
> *ompi_coll_base_reduce_scatter_intra_nonoverlapping*’:
> *base/coll_base_reduce_scatter.c:83:36:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  tmprbuf = tmprbuf_free *-* gap;
> *^*
> *base/coll_base_reduce.c:* In function ‘*ompi_coll_base_reduce_generic*’:
> *base/coll_base_reduce.c:124:34:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  inbuf[0] = inbuf_free[0] *-* gap;
>   *^*
> *base/coll_base_allreduce.c:* In function ‘
> *ompi_coll_base_allreduce_intra_recursivedoubling*’:
> *base/coll_base_allreduce.c:159:34:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  inplacebuf = inplacebuf_free *-* gap;
>   *^*
> *base/coll_base_reduce_scatter.c:* In function ‘
> *ompi_coll_base_reduce_scatter_intra_basic_recursivehalving*’:
> *base/coll_base_reduce_scatter.c:178:30:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  recv_buf = recv_buf_free *-* gap;
>   *^*
> *base/coll_base_reduce.c:* In function ‘
> *ompi_coll_base_reduce_intra_in_order_binary*’:
> *base/coll_base_reduce.c:549:34:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  tmpbuf = tmpbuf_free *-* gap;
>   *^*
> *base/coll_base_reduce.c:* In function ‘
> *ompi_coll_base_reduce_intra_basic_linear*’:
> *base/coll_base_reduce.c:653:34:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  pml_buffer = free_buffer *-* gap;
>   *^*
> *base/coll_base_reduce_scatter.c:* In function ‘
> *ompi_coll_base_reduce_scatter_intra_ring*’:
> *base/coll_base_reduce_scatter.c:513:30:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  accumbuf = accumbuf_free *-* gap;
>
> *coll_basic_allgather.c:* In function ‘*mca_coll_basic_allgather_inter*’:
> *coll_basic_allgather.c:112:30:* *warning: *‘*gap*’ may be used
> uninitialized in this function [*-Wmaybe-uninitialized*]
>  tmpbuf = tmpbuf_free *-* gap;
>   *^*
> *coll_basic_exscan.c:* In function ‘*mca_coll_basic_exscan_intra*’:
> *coll_basic_exscan.c:92:33:* *warning: *‘*gap*’ may be used uninitialized
> in this function [*-Wmaybe-uninitialized*]
>  reduce_buffer = free_buffer *-* gap;
>  *

Re: [OMPI devel] Master warnings

2015-01-27 Thread Burette, Yohann
I fixed the compiler warnings for the OFI MTL.

Yohann

From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of George Bosilca
Sent: Tuesday, January 27, 2015 10:26 AM
To: Open MPI Developers
Subject: Re: [OMPI devel] Master warnings

I took care of the TCP warnings.

  George.



On Tue, Jan 27, 2015 at 7:20 AM, Ralph Castain 
mailto:r...@open-mpi.org>> wrote:

btl_tcp_frag.c: In function 'mca_btl_tcp_frag_dump':

btl_tcp_frag.c:99: warning: comparison between signed and unsigned

btl_tcp_frag.c:104: warning: comparison between signed and unsigned



mtl_ofi.c: In function 'ompi_mtl_ofi_add_procs':

mtl_ofi.c:108: warning: comparison between signed and unsigned

mtl_ofi.c:111: warning: format '%s' expects type 'char *', but argument 6 has 
type 'int'



base/memheap_base_mkey.c: In function 'oshmem_mkey_recv_cb':

base/memheap_base_mkey.c:375: warning: comparison of distinct pointer types 
lacks a cast


___
devel mailing list
de...@open-mpi.org<mailto:de...@open-mpi.org>
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Link to this post: 
http://www.open-mpi.org/community/lists/devel/2015/01/16825.php



Re: [OMPI devel] Master warnings

2015-01-27 Thread George Bosilca
I took care of the TCP warnings.

  George.



On Tue, Jan 27, 2015 at 7:20 AM, Ralph Castain  wrote:

> btl_tcp_frag.c: In function 'mca_btl_tcp_frag_dump':
>
> btl_tcp_frag.c:99: warning: comparison between signed and unsigned
>
> btl_tcp_frag.c:104: warning: comparison between signed and unsigned
>
>
> mtl_ofi.c: In function 'ompi_mtl_ofi_add_procs':
>
> mtl_ofi.c:108: warning: comparison between signed and unsigned
>
> mtl_ofi.c:111: warning: format '%s' expects type 'char *', but argument 6
> has type 'int'
>
>
> base/memheap_base_mkey.c: In function 'oshmem_mkey_recv_cb':
>
> base/memheap_base_mkey.c:375: warning: comparison of distinct pointer
> types lacks a cast
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2015/01/16825.php
>