[O-MPI devel] f77_check.m4 changes

2006-01-13 Thread Ralf Wildenhues
Hi Brian,

Did you mean this in your recent changes to the trunk?
I'm not quite sure, I don't really understand the code
at a glance.

Without it, configure barfs over here because it contains
  if ...; then
  fi
somewhere, which is a shell syntax error.

Cheers,
Ralf

Index: config/f77_check.m4
===
--- config/f77_check.m4 (revision 8684)
+++ config/f77_check.m4 (working copy)
@@ -70,12 +70,10 @@
 else
 # Look for a corresponding C type (will abort by itself if the
 # type isn't found and we need it)
-if test "$3" != ""; then
-OMPI_FIND_TYPE([$1], [$3], [$2], [$ofc_type_size], 
[ofc_c_type])
-if test -z "$ofc_c_type"; then
-ofc_have_type=
-fi
-fi
+   m4_ifval([$3], [OMPI_FIND_TYPE([$1], [$3], [$2], [$ofc_type_size], 
[ofc_c_type])
+   if test -z "$ofc_c_type"; then
+   ofc_have_type=
+   fi])

 # Get the alignment of the type
 if test "$ofc_have_type" = "1"; then


Re: [O-MPI devel] f77_check.m4 changes

2006-01-13 Thread Brian Barrett
Yeah, I should have used the m4_ifval :/.  What platform were you  
seeing badness on?  I know there's something with gfortran on 64bit  
linux and it seems to work on 32bit linux with gfortran.


Brian

On Jan 13, 2006, at 9:28 AM, Ralf Wildenhues wrote:


Hi Brian,

Did you mean this in your recent changes to the trunk?
I'm not quite sure, I don't really understand the code
at a glance.

Without it, configure barfs over here because it contains
  if ...; then
  fi
somewhere, which is a shell syntax error.

Cheers,
Ralf

Index: config/f77_check.m4
===
--- config/f77_check.m4 (revision 8684)
+++ config/f77_check.m4 (working copy)
@@ -70,12 +70,10 @@
 else
 # Look for a corresponding C type (will abort by  
itself if the

 # type isn't found and we need it)
-if test "$3" != ""; then
-OMPI_FIND_TYPE([$1], [$3], [$2], [$ofc_type_size],  
[ofc_c_type])

-if test -z "$ofc_c_type"; then
-ofc_have_type=
-fi
-fi
+	m4_ifval([$3], [OMPI_FIND_TYPE([$1], [$3], [$2],  
[$ofc_type_size], [ofc_c_type])

+   if test -z "$ofc_c_type"; then
+   ofc_have_type=
+   fi])

 # Get the alignment of the type
 if test "$ofc_have_type" = "1"; then
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel




Re: [O-MPI devel] f77_check.m4 changes

2006-01-13 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Fri, Jan 13, 2006 at 03:28:09PM CET:
> 
> Did you mean this in your recent changes to the trunk?
> I'm not quite sure, I don't really understand the code
> at a glance.

Hmm, another thing that fails here is that ompi_fortran_integer16_t gets
set to "not found" on GNU/Linux/x86_64, which causes a compile failure.

It goes away with the patch below, but that patch is not right,
it just moves the error further to when the preprocessor gets
to mpi.h:
| #if OMPI_HAVE_FORTRAN_INTEGER16

and barfs (while compiling pabort.c):
| ../../../../include/mpi.h:574:32: #if with no expression
| ../../../../include/mpi.h:676:32: #if with no expression

Hope that helps a bit,
Ralf

Index: config/ompi_find_type.m4
===
--- config/ompi_find_type.m4(revision 8684)
+++ config/ompi_find_type.m4(working copy)
@@ -38,7 +38,7 @@
fi
 ])])
  AS_IF([test -z "$oft_real_type"],
-   [AS_VAR_SET(type_var, "not found")],
+   [AS_VAR_SET(type_var, "")],
[AS_VAR_SET(type_var, "$oft_real_type")])])

 AS_IF([test "AS_VAR_GET(type_var)" == "not found"],


Re: [O-MPI devel] f77_check.m4 changes

2006-01-13 Thread Brian Barrett
Yup - Jeff found this one this morning.  Stupid me testing on x86  
only :(.  Anyway, this and your other one were just fixed in SVN.


Brian

On Jan 13, 2006, at 9:48 AM, Ralf Wildenhues wrote:


* Ralf Wildenhues wrote on Fri, Jan 13, 2006 at 03:28:09PM CET:


Did you mean this in your recent changes to the trunk?
I'm not quite sure, I don't really understand the code
at a glance.


Hmm, another thing that fails here is that ompi_fortran_integer16_t  
gets
set to "not found" on GNU/Linux/x86_64, which causes a compile  
failure.


It goes away with the patch below, but that patch is not right,
it just moves the error further to when the preprocessor gets
to mpi.h:
| #if OMPI_HAVE_FORTRAN_INTEGER16

and barfs (while compiling pabort.c):
| ../../../../include/mpi.h:574:32: #if with no expression
| ../../../../include/mpi.h:676:32: #if with no expression

Hope that helps a bit,
Ralf

Index: config/ompi_find_type.m4
===
--- config/ompi_find_type.m4(revision 8684)
+++ config/ompi_find_type.m4(working copy)
@@ -38,7 +38,7 @@
fi
 ])])
  AS_IF([test -z "$oft_real_type"],
-   [AS_VAR_SET(type_var, "not found")],
+   [AS_VAR_SET(type_var, "")],
[AS_VAR_SET(type_var, "$oft_real_type")])])

 AS_IF([test "AS_VAR_GET(type_var)" == "not found"],
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel




Re: [O-MPI devel] f77_check.m4 changes

2006-01-13 Thread Ralf Wildenhues
* Brian Barrett wrote on Fri, Jan 13, 2006 at 03:53:33PM CET:
> Yup - Jeff found this one this morning.  Stupid me testing on x86  
> only :(.  Anyway, this and your other one were just fixed in SVN.

Thank you very much, seems to work fine!

Cheers,
Ralf


Re: [O-MPI devel] Intel tests

2006-01-13 Thread Graham E Fagg

Hi Tim
 I can get an error but not quite the same as yours. In my case I get a 
segfault as someone corrupts the memory attached to a communicator (data 
segment). Looks like a possible inplace error. Expect a fix shortly.


G.

On Tue, 10 Jan 2006, Tim Prins wrote:


Graham,

It works properly if I select the basic coll component. Anyways, here is
the output you requested. The full output is about 140MB, so I killed it
before it  finished...

Tim

Quoting Graham E Fagg :


Hi Tim
  nope, can you rerun with  mpirun -np 4 -mca coll_base_verbose 1

and email me the output?
Thanks
G
On Tue, 10 Jan 2006, Tim Prins wrote:


Hi everyone,

I have been playing around with Open-MPI, using it as a test bed

for

another project I am working on, and have found that on the intel

test

suite, ompi is failing the MPI_Allreduce_user_c,
MPI_Reduce_scatter_user_c, and MPI_Reduce_user_c tests (it prints
something like  MPITEST error (2): i=0, int value=4, expected 1,

etc).

Are these known error?

BTW, this is on a x86_64 linux box running 4 processes locally,

running

the trunk svn version 8667, with no additional mca parameters set.

Thanks,

TIm
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel




Thanks,
Graham.
--
Dr Graham E. Fagg   | Distributed, Parallel and Meta-Computing
Innovative Computing Lab. PVM3.4, HARNESS, FT-MPI, SNIPE & Open MPI
Computer Science Dept   | Suite 203, 1122 Volunteer Blvd,
University of Tennessee | Knoxville, Tennessee, USA. TN 37996-3450
Email: f...@cs.utk.edu  | Phone:+1(865)974-5790 |
Fax:+1(865)974-8296
Broken complex systems are always derived from working simple
systems
--
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel








Thanks,
Graham.
--
Dr Graham E. Fagg   | Distributed, Parallel and Meta-Computing
Innovative Computing Lab. PVM3.4, HARNESS, FT-MPI, SNIPE & Open MPI
Computer Science Dept   | Suite 203, 1122 Volunteer Blvd,
University of Tennessee | Knoxville, Tennessee, USA. TN 37996-3450
Email: f...@cs.utk.edu  | Phone:+1(865)974-5790 | Fax:+1(865)974-8296
Broken complex systems are always derived from working simple systems
--