Re: [OMPI devel] bug in Makefile.in

2006-05-09 Thread Brian Barrett
I think I have this fixed (using the $file_system_[foo] variables).   
Thanks for all the bug reports.  I've committed to the trunk and am  
building a new nightly tarball right now.  Can you try it to make  
sure I have all your issues fixed?


Thanks for all the bug reports!

Brian

On May 8, 2006, at 8:46 PM, Dries Kimpe wrote:


There are a number of errors in my mail below (probably caused by the
fact that I was in a hurry to leave for dinner ;-)

1) The file is configure.in, in mca/io/romio/romio/configure.in, not
   Makefile.in

2) The $ in grep 'pvfs$' was added by me as a temporary hack to
prevent it from building pvfs along with pvfs2.
  It's not a good solution anyway, because $FILE_SYSTEM contains  
things

  as "nfs ufs pvfs pvfs2"

Really, the correct fix is just to use $file_system_pvfs,
$file_system_pvfs2, ...

  Greetings,
  Dries


Dries Kimpe wrote:


  Sorry to keep you busy,

but I found another problem with the Open MPI <-> ROMIO integration:

mca/io/romio/romio/Makefile.in:

# Open MPI: setup the AM_CONDITIONALs to build the different adio  
devices
AM_CONDITIONAL(BUILD_GRIDFTP, [test -n "`echo $FILE_SYSTEM | grep  
gridftp`"])

AM_CONDITIONAL(BUILD_HFS, [test -n "`echo $FILE_SYSTEM | grep hfs`"])
AM_CONDITIONAL(BUILD_NFS, [test -n "`echo $FILE_SYSTEM | grep nfs`"])
AM_CONDITIONAL(BUILD_PANFS, [test -n "`echo $FILE_SYSTEM | grep  
panfs`"])

AM_CONDITIONAL(BUILD_PFS, [test -n "`echo $FILE_SYSTEM | grep pfs`"])
AM_CONDITIONAL(BUILD_PIOFS, [test -n "`echo $FILE_SYSTEM | grep  
piofs`"])
AM_CONDITIONAL(BUILD_PVFS, [test -n "`echo $FILE_SYSTEM | grep pvfs 
$`"])
AM_CONDITIONAL(BUILD_PVFS2, [test -n "`echo $FILE_SYSTEM | grep  
pvfs2`"])

AM_CONDITIONAL(BUILD_SFS, [test -n "`echo $FILE_SYSTEM | grep sfs`"])
AM_CONDITIONAL(BUILD_TESTFS, [test -n "`echo $FILE_SYSTEM | grep  
testfs`"])

AM_CONDITIONAL(BUILD_UFS, [test -n "`echo $FILE_SYSTEM | grep ufs`"])
AM_CONDITIONAL(BUILD_XFS, [test -n "`echo $FILE_SYSTEM | grep xfs`"])

When the ROMIO's configure finds support for a filesystem, it sets
file_system_ to 1. (This is done by checking support for  
each of the

filesystems listed in $FILE_SYSTEM (passed from --with-filesystems))

In my case, I want PVFS2 so file_system_pvfs2=1 (because configure  
found

all the needed headers)

However, two things are wrong with the AM_CONDITIONAL code:

1) FILE_SYSTEM is tested, meaning that if the user demanded pvfs2  
but didn't have
the headers/tools to build it, ROMIO's configure would have set  
file_system_pvfs2 to 0,
and the code above would still try to build the PVFS2 AD because  
it only tests if the name was

specified.

2) If grep pvfs2 matches, grep pvfs also matches... ;-)


   Greetings,
   Dries




Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel




Re: [OMPI devel] another small ROMIO fix...

2006-05-09 Thread Brian Barrett

On May 8, 2006, at 11:17 PM, Dries Kimpe wrote:


In ompi/mca/io/romio/romio/adio/Makefile.am there is an entry missing
for PVFS2.

Index: Makefile.am
===
--- Makefile.am (revision 9851)
+++ Makefile.am (working copy)
@@ -139,7 +139,7 @@
 libadio_la_LIBADD = \
 common/libadio_common.la \
 $(HFS_LIB) $(NFS_LIB) $(NTFS_LIB) $(PFS_LIB) $(PIOFS_LIB) \
-$(PVFS_LIB) $(SFS_LIB) $(TESTFS_LIB) $(UFS_LIB) $(XFS_LIB)
+$(PVFS_LIB) $(PVFS2_LIB) $(SFS_LIB) $(TESTFS_LIB) $(UFS_LIB)
$(XFS_LIB)
 libadio_la_DEPENDENCIES = \
 $(libadio_la_LIBADD)


  Greetings,
  Dries


PS. This should be the last one, I finally have the combo Open MPI,
ROMIO & PVFS2 over native IB up and running :-)


Thanks.  Fixed on the trunk, and hopefully moving into the release  
branches soon.


Brian

--
  Brian Barrett
  Open MPI developer
  http://www.open-mpi.org/




Re: [OMPI devel] another small ROMIO fix...

2006-05-09 Thread Jeff Squyres (jsquyres)
All the ROMIO fixes have been committed to the v1.0 and v1.1 branches.


> -Original Message-
> From: devel-boun...@open-mpi.org 
> [mailto:devel-boun...@open-mpi.org] On Behalf Of Brian Barrett
> Sent: Tuesday, May 09, 2006 5:37 AM
> To: Open MPI Developers
> Subject: Re: [OMPI devel] another small ROMIO fix...
> 
> On May 8, 2006, at 11:17 PM, Dries Kimpe wrote:
> 
> > In ompi/mca/io/romio/romio/adio/Makefile.am there is an 
> entry missing
> > for PVFS2.
> >
> > Index: Makefile.am
> > ===
> > --- Makefile.am (revision 9851)
> > +++ Makefile.am (working copy)
> > @@ -139,7 +139,7 @@
> >  libadio_la_LIBADD = \
> >  common/libadio_common.la \
> >  $(HFS_LIB) $(NFS_LIB) $(NTFS_LIB) $(PFS_LIB) $(PIOFS_LIB) \
> > -$(PVFS_LIB) $(SFS_LIB) $(TESTFS_LIB) $(UFS_LIB) $(XFS_LIB)
> > +$(PVFS_LIB) $(PVFS2_LIB) $(SFS_LIB) $(TESTFS_LIB) 
> $(UFS_LIB)
> > $(XFS_LIB)
> >  libadio_la_DEPENDENCIES = \
> >  $(libadio_la_LIBADD)
> >
> >
> >   Greetings,
> >   Dries
> >
> >
> > PS. This should be the last one, I finally have the combo Open MPI,
> > ROMIO & PVFS2 over native IB up and running :-)
> 
> Thanks.  Fixed on the trunk, and hopefully moving into the release  
> branches soon.
> 
> Brian
> 
> -- 
>Brian Barrett
>Open MPI developer
>http://www.open-mpi.org/
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 



Re: [OMPI devel] bug in Makefile.in

2006-05-09 Thread Dries Kimpe
Brian Barrett wrote:
> I think I have this fixed (using the $file_system_[foo] variables).   
> Thanks for all the bug reports.  I've committed to the trunk and am  
> building a new nightly tarball right now.  Can you try it to make  
> sure I have all your issues fixed?
> 
I reverted all my modifications, updated & rebuilt everything.
Seems to work :-)

Thanks.

  Greetings,
  Dries

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm