[OMPI devel] MPI_MAX_INFO_KEY used when MPI_MAX_INFO_VAL should be

[Chris Hennes]

In the file ompi/mpi/c/info_set.c, lines 87-92, from the current
release version of the code (v1.1),

   value_length = (value) ? strlen (value) : 0;
   if ((NULL == value) || (0 == value_length) ||
   (MPI_MAX_INFO_KEY <= value_length)) {
   return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_INFO_VALUE,
  FUNC_NAME);
   }

I believe that in this case the third line down (line 89) should instead be

   (MPI_MAX_INFO_VAL <= value_length)) {

i.e. comparing the value argument to the max value length, rather than
the max key length.

Thanks,

Chris Hennes
Penn State

Re: [OMPI devel] MPI_MAX_INFO_KEY used when MPI_MAX_INFO_VAL should be

[Jeff Squyres]

You're exactly right -- thanks for the report!


On 8/1/06 8:49 AM, "Chris Hennes"  wrote:

> In the file ompi/mpi/c/info_set.c, lines 87-92, from the current
> release version of the code (v1.1),
> 
> value_length = (value) ? strlen (value) : 0;
> if ((NULL == value) || (0 == value_length) ||
> (MPI_MAX_INFO_KEY <= value_length)) {
> return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_INFO_VALUE,
>FUNC_NAME);
> }
> 
> I believe that in this case the third line down (line 89) should instead be
> 
> (MPI_MAX_INFO_VAL <= value_length)) {
> 
> i.e. comparing the value argument to the max value length, rather than
> the max key length.
> 
> Thanks,
> 
> Chris Hennes
> Penn State
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel


-- 
Jeff Squyres
Server Virtualization Business Unit
Cisco Systems