Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723
The change is in: https://svn.open-mpi.org/trac/ompi/changeset/16764 Thanks for the heads-up, brad On Nov 20, 2007 9:48 AM, Brad Penoff wrote: > Sorry, saw this thread late. We'll try to make the change later today > after a few meetings! > > brad > > > > On Nov 14, 2007 8:16 AM, Jeff Squyres (jsquyres) wrote: > > > > > > > > Tim - excellent catch! > > > > I totally agree. We must be very mindful of IP-related issues. > > > > -jms > > Sent from my PDA > > > > > > -Original Message- > > From: Tim Prins [mailto:tpr...@cs.indiana.edu] > > Sent: Wednesday, November 14, 2007 09:44 AM Eastern Standard Time > > To: de...@open-mpi.org > > Subject:Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723 > > > > Hi, > > > > The following files bother me about this commit: > > trunk/ompi/mca/btl/sctp/sctp_writev.c > > trunk/ompi/mca/btl/sctp/sctp_writev.h > > > > They bother me for 2 reasons: > > 1. Their naming does not follow the prefix rule > > 2. They are LGPL licensed. While I personally like the LGPL, I do not > > believe it is compatible with the BSD license that OMPI is distributed > > under. I think (though I could be wrong) that these files need to be > > removed from the repository and the functionality implemented in some > > other way. > > > > > > Tim > > > > > > pen...@osl.iu.edu wrote: > > > Author: penoff > > > Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007) > > > New Revision: 16723 > > > URL: https://svn.open-mpi.org/trac/ompi/changeset/16723 > > > > > > Log: > > > initial SCTP BTL commit > > > Added: > > >trunk/ompi/mca/btl/sctp/ > > >trunk/ompi/mca/btl/sctp/.ompi_ignore > > >trunk/ompi/mca/btl/sctp/.ompi_unignore > > >trunk/ompi/mca/btl/sctp/Makefile.am > > >trunk/ompi/mca/btl/sctp/btl_sctp.c > > >trunk/ompi/mca/btl/sctp/btl_sctp.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_addr.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_component.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_component.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_frag.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_frag.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_proc.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_proc.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h > > >trunk/ompi/mca/btl/sctp/btl_sctp_utils.c > > >trunk/ompi/mca/btl/sctp/btl_sctp_utils.h > > >trunk/ompi/mca/btl/sctp/configure.m4 > > >trunk/ompi/mca/btl/sctp/configure.params > > >trunk/ompi/mca/btl/sctp/sctp_writev.c > > >trunk/ompi/mca/btl/sctp/sctp_writev.h > > > > > > > > > Diff not shown due to size (201438 bytes). > > > To see the diff, run the following command: > > > > > > svn diff -r 16722:16723 --no-diff-deleted > > > > > > ___ > > > svn mailing list > > > s...@open-mpi.org > > > http://www.open-mpi.org/mailman/listinfo.cgi/svn > > ___ > > devel mailing list > > de...@open-mpi.org > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > > > ___ > > devel mailing list > > de...@open-mpi.org > > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > >
Re: [OMPI devel] initial SCTP BTL commit comments?
On Nov 20, 2007, at 1:46 PM, Brad Penoff wrote: More specifically: can you have your configure.m4 script check to see if the current system a) supports SCTP, Yes, the current configure.m4 does this by making use of OMPI_CHECK_PACKAGE. Good. and b) if yes, if it supports 1-to-many? This kind of checking would theoretically allow running on Solaris This is a little more tricky. [snip] Hmm, I suppose you're right. We could just make Solaris set the MCA variable btl_sctp_if_11 to 1 in order to use the 1-to-1 mode to avoid this mess. How would one change the default of an MCA variable in an autoconf rule? I really hope there's a way to keep one-to-many the default as often as possible (if not always). Basically, if you can make a short C program that tests the behavior, then AC can do it. Specifically, AC can compile/link/run a program and you can look at the result. The only hitch in this scheme is for cross-compiling environments (because you can compile/link, but you can't run) -- but in those situations, AC "knows" that it's cross- compiling and therefore you can set some default value. As for setting an MCA param based on the result of an AC test, we typically use AC_DEFINE to #define some value based on the result of the test. Then in the C code, set the default value of that MCA param to be the #define macro. Note one philosophy in the OMPI code base: we *always* AC_DEFINE macros, even for logical values. See the last point on (I just added it): https://svn.open-mpi.org/trac/ompi/wiki/CodingStyle The SCTP API is typically within it's own library called libsctp. However, in FreeBSD 7, the API is within libc. So say we're looking for something like sctp_recvmsg (as we do now)... what is the best way to structure an autoconf rule to look for this in either libsctp or libc, and to not complain if libsctp doesn't exist? Should I just call OMPI_CHECK_PACKAGE once with libsctp and if that fails then call OMPI_CHECK_PACKAGE again with libc? Ick. OMPI_CHECK_PACKAGE is currently not well setup a) to check multiple libraries or b) be called more than once for the same component. This will take some thought, but I cannot do it until after the US holiday. :-\ -- Jeff Squyres Cisco Systems
