Re: [OMPI devel] v1.3: libnbc and sm2 coll components
Thanks! I removed it from v1.3 in r18974. On Jul 21, 2008, at 10:52 PM, Richard Graham wrote: No need for SM2 right now. We need a change to the communicator, before we can bring this over, and have just gotten around to addressing this yet. Rich On 7/21/08 3:40 PM, "Jeff Squyres" wrote: Should these 2 components be in v1.3? -- Jeff Squyres Cisco Systems ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel -- Jeff Squyres Cisco Systems
[OMPI devel] ibcm private header file
Pasha --
I notice that all of IU's builds failed last night with errors like
this:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../opal/include -
I../../../../orte/include -I../../../../ompi/include -I../../../../
opal/mca/paffinity/linux/plpa/src/libplpa -I/usr/local/ofed/include -
I../../../.. -O3 -DNDEBUG -m32 -pipe -finline-functions -fno-strict-
aliasing -pthread -fvisibility=hidden -MT connect/
btl_openib_connect_ibcm.lo -MD -MP -MF connect/.deps/
btl_openib_connect_ibcm.Tpo -c connect/btl_openib_connect_ibcm.c -
fPIC -DPIC -o connect/.libs/btl_openib_connect_ibcm.o
In file included from /usr/include/asm/byteorder.h:7,
from connect/btl_openib_connect_ibcm.c:260:
/usr/include/asm-i386/byteorder.h:6:2: warning: #warning using private
kernel header; include instead!
In file included from ../../../../opal/util/if.h:33,
from connect/btl_openib_connect_ibcm.c:262:
/usr/include/netinet/in.h:354: error: syntax error before '(' token
/usr/include/netinet/in.h:354: error: syntax error before "__u32"
/usr/include/netinet/in.h:355: error: syntax error before '(' token
/usr/include/netinet/in.h:355: error: syntax error before "__u16"
/usr/include/netinet/in.h:357: error: syntax error before '(' token
/usr/include/netinet/in.h:357: error: syntax error before "__u32"
/usr/include/netinet/in.h:359: error: syntax error before '(' token
/usr/include/netinet/in.h:359: error: syntax error before "__u16"
make[2]: *** [connect/btl_openib_connect_ibcm.lo] Error 1
So I think using byteorder.h is not a good idea (note the warning).
How about just having two #defines, picking the Right one based on
WORDS_BIGENDIAN?
--
Jeff Squyres
Cisco Systems
Re: [OMPI devel] ibcm private header file
> So I think using byteorder.h is not a good idea (note the warning). > How about just having two #defines, picking the Right one based on > WORDS_BIGENDIAN? On Linux, the public header might have what you need. For that matter has htonll() defined. - R.
[OMPI devel] LSF & ompi r18978
Hi, I just tested compiling ompi on a LSF cluster (LSF 7.0.2) (see ticket 1356). I could solve a few trivial bugs myself (see svn diff below), however I hit compile errors beyond my knowledge of ORTE internal structures in orte/mca/ras/lsf/ras_lsf_module.c and orte/mca/ras/lsf/ ras_lsf_component.c : orte/mca/ras/lsf/ras_lsf_module.c:49: warning: initialization from incompatible pointer type orte/mca/ras/lsf/ras_lsf_module.c: In function ‘allocate’: orte/mca/ras/lsf/ras_lsf_module.c:73: error: ‘orte_node_t’ has no member named ‘node_slots’ orte/mca/ras/lsf/ras_lsf_component.c: In function ‘orte_ras_lsf_component_query’: orte/mca/ras/lsf/ras_lsf_component.c:94: error: ‘orte_proc_info_t’ has no member named ‘seed’ This needs fixing before I can try a run. Bests, Thomas INRIA - Grand-Large Project/Team === --- orte/mca/ras/lsf/ras_lsf_module.c (revision 18978) +++ orte/mca/ras/lsf/ras_lsf_module.c (working copy) @@ -17,7 +17,7 @@ * $HEADER$ */ #include "orte_config.h" -#include "orte/orte_constants.h" +#include "orte/constants.h" #include #include Index: orte/mca/ras/lsf/ras_lsf_component.c === --- orte/mca/ras/lsf/ras_lsf_component.c(revision 18978) +++ orte/mca/ras/lsf/ras_lsf_component.c(working copy) @@ -21,7 +21,7 @@ #include -#include "orte/orte_constants.h" +#include "orte/constants.h" #include "opal/mca/base/base.h" #include "opal/mca/base/mca_base_param.h" #include "orte/util/proc_info.h" Index: orte/mca/plm/lsf/plm_lsf_component.c === --- orte/mca/plm/lsf/plm_lsf_component.c(revision 18978) +++ orte/mca/plm/lsf/plm_lsf_component.c(working copy) @@ -124,7 +124,7 @@ opal_output_verbose(10, orte_plm_globals.output, "plm:lsf: NOT available for selection"); *module = NULL; -return ORTE_ERROR: +return ORTE_ERROR; } *priority = mca_plm_lsf_component.priority; Index: orte/mca/ess/lsf/Makefile.am === --- orte/mca/ess/lsf/Makefile.am(revision 18978) +++ orte/mca/ess/lsf/Makefile.am(working copy) @@ -17,7 +17,7 @@ # $HEADER$ # -AM_CPPFLAGS = $(pls_lsf_CPPFLAGS) +AM_CPPFLAGS = $(ess_lsf_CPPFLAGS) sources = \ ess_lsf.h \
Re: [OMPI devel] ibcm private header file
On Jul 22, 2008, at 12:32 PM, Roland Dreier wrote: So I think using byteorder.h is not a good idea (note the warning). How about just having two #defines, picking the Right one based on WORDS_BIGENDIAN? On Linux, the public header might have what you need. For that matter has htonll() defined. The problematic line is: #define IB_CM_ASSIGN_SERVICE_ID __cpu_to_be64(0x0200ULL) There's no reason this has to be byte-swapped at compile time, right? Using htonll or OMPI's hton64() should be sufficient, right? -- Jeff Squyres Cisco Systems
Re: [OMPI devel] LSF & ompi r18978
Thanks! I'm really happy to see that someone is taking a look at this since I don't have a way to test it. I'll make these fixes and let you know what revision to check again. Probably later this evening. Ralph On Jul 22, 2008, at 10:38 AM, Thomas Herault wrote: Hi, I just tested compiling ompi on a LSF cluster (LSF 7.0.2) (see ticket 1356). I could solve a few trivial bugs myself (see svn diff below), however I hit compile errors beyond my knowledge of ORTE internal structures in orte/mca/ras/lsf/ras_lsf_module.c and orte/mca/ras/lsf/ ras_lsf_component.c : orte/mca/ras/lsf/ras_lsf_module.c:49: warning: initialization from incompatible pointer type orte/mca/ras/lsf/ras_lsf_module.c: In function ‘allocate’: orte/mca/ras/lsf/ras_lsf_module.c:73: error: ‘orte_node_t’ has no member named ‘node_slots’ orte/mca/ras/lsf/ras_lsf_component.c: In function ‘orte_ras_lsf_component_query’: orte/mca/ras/lsf/ras_lsf_component.c:94: error: ‘orte_proc_info_t’ has no member named ‘seed’ This needs fixing before I can try a run. Bests, Thomas INRIA - Grand-Large Project/Team === --- orte/mca/ras/lsf/ras_lsf_module.c (revision 18978) +++ orte/mca/ras/lsf/ras_lsf_module.c (working copy) @@ -17,7 +17,7 @@ * $HEADER$ */ #include "orte_config.h" -#include "orte/orte_constants.h" +#include "orte/constants.h" #include #include Index: orte/mca/ras/lsf/ras_lsf_component.c === --- orte/mca/ras/lsf/ras_lsf_component.c(revision 18978) +++ orte/mca/ras/lsf/ras_lsf_component.c(working copy) @@ -21,7 +21,7 @@ #include -#include "orte/orte_constants.h" +#include "orte/constants.h" #include "opal/mca/base/base.h" #include "opal/mca/base/mca_base_param.h" #include "orte/util/proc_info.h" Index: orte/mca/plm/lsf/plm_lsf_component.c === --- orte/mca/plm/lsf/plm_lsf_component.c(revision 18978) +++ orte/mca/plm/lsf/plm_lsf_component.c(working copy) @@ -124,7 +124,7 @@ opal_output_verbose(10, orte_plm_globals.output, "plm:lsf: NOT available for selection"); *module = NULL; -return ORTE_ERROR: +return ORTE_ERROR; } *priority = mca_plm_lsf_component.priority; Index: orte/mca/ess/lsf/Makefile.am === --- orte/mca/ess/lsf/Makefile.am(revision 18978) +++ orte/mca/ess/lsf/Makefile.am(working copy) @@ -17,7 +17,7 @@ # $HEADER$ # -AM_CPPFLAGS = $(pls_lsf_CPPFLAGS) +AM_CPPFLAGS = $(ess_lsf_CPPFLAGS) sources = \ ess_lsf.h \ ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel
