[OMPI devel] application hangs with multiple dup

2009-09-08 Thread Thomas Ropars 

Hi,

I'm working on r21949 of the trunk.

When I run on a single node with 4 processes this simple program calling 
2 times MPI_Comm_dup , the processes hang from time to time in the 2nd dup.


int main(int argc, char *argv[])
{
 MPI_Comm comm,comm2;

 MPI_Init(&argc, &argv);

 MPI_Comm_dup(MPI_COMM_WORLD,&comm);
 MPI_Comm_dup(comm,&comm2);


}

Thomas

[OMPI devel] Error message improvement

2009-09-08 Thread Arthur Huillet 

Hi,

please find attached a patch to ompi/communicator/communicator.h that 
fixes the error message displayed by ompi_comm_peer_lookup() so the 
function name that appears is correct.


--
Greetings, 
A. Huillet


diff -r 686ec286164a ompi/communicator/communicator.h
--- a/ompi/communicator/communicator.h	Tue Sep 08 14:39:03 2009 +0200
+++ b/ompi/communicator/communicator.h	Tue Sep 08 15:48:06 2009 +0200
@@ -313,7 +313,7 @@
 {
 #if OPAL_ENABLE_DEBUG
 if(peer_id >= comm->c_remote_group->grp_proc_count) {
-opal_output(0, "ompi_comm_lookup_peer: invalid peer index (%d)", peer_id);
+opal_output(0, "ompi_comm_peer_lookup: invalid peer index (%d)", peer_id);
 return (struct ompi_proc_t *) NULL;
 }
 #endif

Re: [OMPI devel] Error message improvement

2009-09-08 Thread Lenny Verkhovsky 
Why not using __FUNCTION__  in all our error messages ???
diff -r 686ec286164a ompi/communicator/communicator.h
--- a/ompi/communicator/communicator.h Tue Sep 08 14:39:03 2009 +0200
+++ b/ompi/communicator/communicator.h Tue Sep 08 15:48:06 2009 +0200
@@ -313,7 +313,7 @@
 {
 #if OPAL_ENABLE_DEBUG
  if(peer_id >= comm->c_remote_group->grp_proc_count) {
- opal_output(0, "ompi_comm_lookup_peer: invalid peer index (%d)", peer_id);
+ opal_output(0, "%s: invalid peer index (%d)", __FUNCTION__,peer_id);
  return (struct ompi_proc_t *) NULL;
  }
 #endif


On Tue, Sep 8, 2009 at 4:49 PM, Arthur Huillet wrote:

> Hi,
>
> please find attached a patch to ompi/communicator/communicator.h that fixes
> the error message displayed by ompi_comm_peer_lookup() so the function name
> that appears is correct.
>
> --
> Greetings, A. Huillet
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

Re: [OMPI devel] Error message improvement

2009-09-08 Thread Arthur Huillet 

Lenny Verkhovsky wrote:

Why not using __FUNCTION__  in all our error messages ???


Sounds good, this way the function names are always correct.

--
Greetings, 
A. Huillet

Re: [OMPI devel] Error message improvement

2009-09-08 Thread Lenny Verkhovsky 
fixed in r21952
thanks.

On Tue, Sep 8, 2009 at 5:08 PM, Arthur Huillet wrote:

> Lenny Verkhovsky wrote:
>
>> Why not using __FUNCTION__  in all our error messages ???
>>
>
> Sounds good, this way the function names are always correct.
>
> --
> Greetings, A. Huillet
>
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>