Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r26243

[ADACHI Tomoya]

Hi George,

This fix seems insufficient for multibyte datatypes...
The correct increment of the pointers is length * extent, isn't it?

(2012/04/06 23:50), bosi...@osl.iu.edu wrote:
> Author: bosilca
> Date: 2012-04-06 10:50:04 EDT (Fri, 06 Apr 2012)
> New Revision: 26243
> URL: https://svn.open-mpi.org/trac/ompi/changeset/26243
> 
> Log:
> Don't forget to move the pointers after the copy (only affects large data
> transfers).
> 
> Text files modified:
> trunk/ompi/datatype/ompi_datatype.h | 5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
> 
> Modified: trunk/ompi/datatype/ompi_datatype.h
> ==
> --- trunk/ompi/datatype/ompi_datatype.h   (original)
> +++ trunk/ompi/datatype/ompi_datatype.h   2012-04-06 10:50:04 EDT (Fri, 
> 06 Apr 2012)
> @@ -289,8 +289,11 @@
>   while( 0 != count ) {
>   length = INT_MAX;
>   if( ((size_t)length)>  count ) length = (int32_t)count;
> -rc = opal_datatype_copy_content_same_ddt(&type->super, count, 
> pDestBuf, pSrcBuf );
> +rc = opal_datatype_copy_content_same_ddt(&type->super, length,
> +  pDestBuf, pSrcBuf );
>   if( 0 != rc ) return rc;
> +pDestBuf += (ptrdiff_t)length;
> +pSrcBuf  += (ptrdiff_t)length;
>   count -= (size_t)length;
>   }
>   return 0;
> ___
> svn-full mailing list
> svn-f...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
> 
> 

-- 
富士通株式会社 次世代TC開発本部
ソフトウェア開発統括部 第四開発部
安達 知也 (ADACHI Tomoya) (adachi.tom...@jp.fujitsu.com)
tel: 7103-8632(内線) 044-754-8769(外線)

Re: [OMPI devel] [EXTERNAL] Re: Developers Meeting

[TERRY DONTJE]

+1 here too.

--td

On 4/6/2012 11:19 PM, Barrett, Brian W wrote:

Agreed.

Brian

On Apr 6, 2012, at 7:31 PM, Ralph Castain wrote:


+1 for SJ - much easier to be someplace with a major airport.


On Apr 5, 2012, at 7:54 AM, Gutierrez, Samuel K wrote:


My vote is for San Jose.

Sam


From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Josh 
Hursey [jjhur...@open-mpi.org]
Sent: Wednesday, April 04, 2012 5:14 AM
To: Open MPI Developers
Subject: Re: [OMPI devel] [EXTERNAL] Re: Developers Meeting

I second Oak Ridge (or even UTK) sometime in June.

-- Josh

On Tue, Apr 3, 2012 at 3:07 PM, Barrett, Brian W  wrote:

On 4/3/12 11:08 AM, "Jeffrey Squyres"  wrote:


On Apr 3, 2012, at 11:44 AM, Barrett, Brian W wrote:


There is discussion of attempting to have a developers meeting this
summer.  We haven't had one in a while and people thought it would be
good
to work through some of the ideas on how to implement features for 1.7.
We don't have a location yet, but possibilities include Los Alamos and
San
Jose.  To help us get an idea of who can attend, please add your
information to the doodle poll below.

http://www.doodle.com/cei3ve3qyeer9bv9


Since the meeting is likely to take a whole week, might I suggest making
each Doodle entry represent an entire week?  E.g., June 4-11, June 11-15,
etc.

We talked about 3 days, so I was thinking that perhaps there were half
weeks that worked well for people.

Brian

--
Brian W. Barrett
Dept. 1423: Scalable System Software
Sandia National Laboratories






___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Joshua Hursey
Postdoctoral Research Associate
Oak Ridge National Laboratory
http://users.nccs.gov/~jjhursey

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel




___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


--
Terry D. Dontje | Principal Software Engineer
Developer Tools Engineering | +1.781.442.2631
Oracle *- Performance Technologies*
95 Network Drive, Burlington, MA 01803
Email terry.don...@oracle.com 

[OMPI devel] trunk regressions

[TERRY DONTJE]

After looking at Oracles MTT results there seem to be a (some??) 
regressions between r26240 and 26249 detected by the ibm and intel tests 
suites.  An example of this is the failures in the comm_join, final and 
loop_spawn tests of the ibm test suite as seen in 
http://www.open-mpi.org/mtt/index.php?do_redir=2055.


Note, I've seen similar errors detected by IU runs too.

I'll look further into this but I thought I would post this just in case 
someone else has seen this.

--
Terry D. Dontje | Principal Software Engineer
Developer Tools Engineering | +1.781.442.2631
Oracle *- Performance Technologies*
95 Network Drive, Burlington, MA 01803
Email terry.don...@oracle.com 

Re: [OMPI devel] trunk regressions

[Josh Hursey]

This is totally not related to the bug report, but a neat trick in Trac.

My question was "what were the commits between r26240 and 26249"?
In the search box type:
  log:@26240:26249
Or use the direct url:
  https://svn.open-mpi.org/trac/ompi/log/?revs=26240-26249

nifty...

-- Josh

On Mon, Apr 9, 2012 at 9:17 AM, TERRY DONTJE  wrote:
> After looking at Oracles MTT results there seem to be a (some??) regressions
> between r26240 and 26249 detected by the ibm and intel tests suites.  An
> example of this is the failures in the comm_join, final and loop_spawn tests
> of the ibm test suite as seen in
> http://www.open-mpi.org/mtt/index.php?do_redir=2055.
>
> Note, I've seen similar errors detected by IU runs too.
>
> I'll look further into this but I thought I would post this just in case
> someone else has seen this.
> --
> Terry D. Dontje | Principal Software Engineer
> Developer Tools Engineering | +1.781.442.2631
> Oracle - Performance Technologies
> 95 Network Drive, Burlington, MA 01803
> Email terry.don...@oracle.com
>
>
>
>
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel


-- 
Joshua Hursey
Postdoctoral Research Associate
Oak Ridge National Laboratory
http://users.nccs.gov/~jjhursey

Re: [OMPI devel] trunk regressions

[Ralph Castain]

FWIW: this isn't a bug in orte_dpm, but in the MPI binding for comm_join. The 
problem is that both sides in the comm_join are setting "send_first" to true - 
i.e., both sides are trying to be the first to send on the handshake. We got 
away with this before because of a bug in orte_dpm that made the value of 
send_first irrelevant, but that has now been fixed.

So someone needs to figure out how to properly set "send_first" in comm_join so 
that the two sides agree on who does what first. Looking at the code, it isn't 
obvious to me how one would do so as I don't see any rank info passed into the 
function.


On Apr 9, 2012, at 8:31 AM, Josh Hursey wrote:

> This is totally not related to the bug report, but a neat trick in Trac.
> 
> My question was "what were the commits between r26240 and 26249"?
> In the search box type:
>  log:@26240:26249
> Or use the direct url:
>  https://svn.open-mpi.org/trac/ompi/log/?revs=26240-26249
> 
> nifty...
> 
> -- Josh
> 
> On Mon, Apr 9, 2012 at 9:17 AM, TERRY DONTJE  wrote:
>> After looking at Oracles MTT results there seem to be a (some??) regressions
>> between r26240 and 26249 detected by the ibm and intel tests suites.  An
>> example of this is the failures in the comm_join, final and loop_spawn tests
>> of the ibm test suite as seen in
>> http://www.open-mpi.org/mtt/index.php?do_redir=2055.
>> 
>> Note, I've seen similar errors detected by IU runs too.
>> 
>> I'll look further into this but I thought I would post this just in case
>> someone else has seen this.
>> --
>> Terry D. Dontje | Principal Software Engineer
>> Developer Tools Engineering | +1.781.442.2631
>> Oracle - Performance Technologies
>> 95 Network Drive, Burlington, MA 01803
>> Email terry.don...@oracle.com
>> 
>> 
>> 
>> 
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> 
> -- 
> Joshua Hursey
> Postdoctoral Research Associate
> Oak Ridge National Laboratory
> http://users.nccs.gov/~jjhursey
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] trunk regressions

[Ralph Castain]

Nobody stepped up, so I fixed this in r26257

On Apr 9, 2012, at 9:21 AM, Ralph Castain wrote:

> FWIW: this isn't a bug in orte_dpm, but in the MPI binding for comm_join. The 
> problem is that both sides in the comm_join are setting "send_first" to true 
> - i.e., both sides are trying to be the first to send on the handshake. We 
> got away with this before because of a bug in orte_dpm that made the value of 
> send_first irrelevant, but that has now been fixed.
> 
> So someone needs to figure out how to properly set "send_first" in comm_join 
> so that the two sides agree on who does what first. Looking at the code, it 
> isn't obvious to me how one would do so as I don't see any rank info passed 
> into the function.
> 
> 
> On Apr 9, 2012, at 8:31 AM, Josh Hursey wrote:
> 
>> This is totally not related to the bug report, but a neat trick in Trac.
>> 
>> My question was "what were the commits between r26240 and 26249"?
>> In the search box type:
>> log:@26240:26249
>> Or use the direct url:
>> https://svn.open-mpi.org/trac/ompi/log/?revs=26240-26249
>> 
>> nifty...
>> 
>> -- Josh
>> 
>> On Mon, Apr 9, 2012 at 9:17 AM, TERRY DONTJE  wrote:
>>> After looking at Oracles MTT results there seem to be a (some??) regressions
>>> between r26240 and 26249 detected by the ibm and intel tests suites.  An
>>> example of this is the failures in the comm_join, final and loop_spawn tests
>>> of the ibm test suite as seen in
>>> http://www.open-mpi.org/mtt/index.php?do_redir=2055.
>>> 
>>> Note, I've seen similar errors detected by IU runs too.
>>> 
>>> I'll look further into this but I thought I would post this just in case
>>> someone else has seen this.
>>> --
>>> Terry D. Dontje | Principal Software Engineer
>>> Developer Tools Engineering | +1.781.442.2631
>>> Oracle - Performance Technologies
>>> 95 Network Drive, Burlington, MA 01803
>>> Email terry.don...@oracle.com
>>> 
>>> 
>>> 
>>> 
>>> ___
>>> devel mailing list
>>> de...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> 
>> 
>> -- 
>> Joshua Hursey
>> Postdoctoral Research Associate
>> Oak Ridge National Laboratory
>> http://users.nccs.gov/~jjhursey
>> 
>> ___
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 

Re: [OMPI devel] trunk regressions

[Ralph Castain]

Should all be fixed now.

On Apr 9, 2012, at 7:17 AM, TERRY DONTJE wrote:

> After looking at Oracles MTT results there seem to be a (some??) regressions 
> between r26240 and 26249 detected by the ibm and intel tests suites.  An 
> example of this is the failures in the comm_join, final and loop_spawn tests 
> of the ibm test suite as seen in 
> http://www.open-mpi.org/mtt/index.php?do_redir=2055.
> 
> Note, I've seen similar errors detected by IU runs too.
> 
> I'll look further into this but I thought I would post this just in case 
> someone else has seen this.
> -- 
> Terry D. Dontje | Principal Software Engineer
> Developer Tools Engineering | +1.781.442.2631
> Oracle - Performance Technologies
> 95 Network Drive, Burlington, MA 01803
> Email terry.don...@oracle.com
> 
> 
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel