[OMPI devel] oshmem Fortran

2013-10-17 Thread Jeff Squyres (jsquyres)
Mellanox --

In r29448, you deleted the comment without doing what it explicitly said to do. 
 For example, you can --disable-mpi-fortran --enable-oshmem-fortran and get a 
broken build.

Additionally, the shmem example in examples/ has several problems:

1. Why all the #defines?  This is supposed to be a trivial "hello world in 
shmem" program, not a test case.  Please make it the equivalent of "hello 
world".

2. The hello world shmem program does not follow the same naming conventions as 
the rest of the code in the examples/ directory.

3. There's no Fortran shmem example.

Adding C/Fortran shmem test cases to a test suite for MTT runs would be a very 
good thing.  Can they be added so that others can run shmem tests in an 
automated fashion?  Indeed, we have no proof of any shmem correctness right 
now; that makes me quite nervous...


On Oct 17, 2013, at 1:42 AM,  wrote:

> Author: miked (Mike Dubman)
> Date: 2013-10-17 01:42:43 EDT (Thu, 17 Oct 2013)
> New Revision: 29448
> URL: https://svn.open-mpi.org/trac/ompi/changeset/29448
> 
> Log:
> add --enable-oshmem-fortran opt to configure
> 
> Text files modified: 
>   trunk/config/ompi_configure_options.m4   | 1 -  
>  
>   trunk/config/oshmem_configure_options.m4 |29 
> -   
>   2 files changed, 12 insertions(+), 18 deletions(-)
> 
> Modified: trunk/config/ompi_configure_options.m4
> ==
> --- trunk/config/ompi_configure_options.m4Thu Oct 17 01:39:20 2013
> (r29447)
> +++ trunk/config/ompi_configure_options.m42013-10-17 01:42:43 EDT (Thu, 
> 17 Oct 2013)  (r29448)
> @@ -114,7 +114,6 @@
>   [OMPI_WANT_FORTRAN_BINDINGS=1],
>   [OMPI_WANT_FORTRAN_BINDINGS=0])
> 
> -
> #
> # MPI profiling
> #
> 
> Modified: trunk/config/oshmem_configure_options.m4
> ==
> --- trunk/config/oshmem_configure_options.m4  Thu Oct 17 01:39:20 2013
> (r29447)
> +++ trunk/config/oshmem_configure_options.m4  2013-10-17 01:42:43 EDT (Thu, 
> 17 Oct 2013)  (r29448)
> @@ -79,26 +79,21 @@
> fi
> AM_CONDITIONAL(OSHMEM_PROFILING, test "$oshmem_profiling_support" = 1)
> 
> -# Whether to build the OpenShmem fortran support or not For the
> -# moment, use the same value as was derived from --enable-mpi-fortra.
> -# *This seems wrong*; someone should somehow unify these two
> -# options... but the implications are complicated.
> #
> -# Option 1: make --enable-fortran that governs both MPI and shmem.
> -# This has 2 implications:
> -# - --enable-mpi-fortran needs to be maintained for at least the
> -#   1.7/1.8 series
> -# - what to do with --enable-mpi-cxx?  It should be made consistent --
> -#   so make it --enable-cxx?
> -# 
> -# Option 2: make separate --enable-oshmem-fortran.  This seems sucky,
> -# though, because oshmem Fortran depends on a lot of MPI Fortran
> -# infrastructure.  If it isin't there, then oshmem Fortran can't
> -# built.
> +# Fortran bindings
> #
> -# Option 3: ...? (something better than option 1/2?)
> +AC_ARG_ENABLE(oshmem-fortran,
> +AC_HELP_STRING([--enable-oshmem-fortran],
> +   [enable OSHMEM Fortran bindings (default: enabled if Fortran 
> compiler found)]))
> +if test "$enable_oshmem_fortran" != "no"; then
> +AC_MSG_RESULT([yes])
> +OSHMEM_WANT_FORTRAN_BINDINGS=1
> +else
> +AC_MSG_RESULT([no])
> +OSHMEM_WANT_FORTRAN_BINDINGS=0
> +fi
> +
> AC_MSG_CHECKING([if want to build SHMEM fortran bindings])
> -OSHMEM_WANT_FORTRAN_BINDINGS=$OMPI_WANT_FORTRAN_BINDINGS
> AM_CONDITIONAL(OSHMEM_WANT_FORTRAN_BINDINGS,
> [test $OSHMEM_WANT_FORTRAN_BINDINGS -eq 1])
> AS_IF([test $OSHMEM_WANT_FORTRAN_BINDINGS -eq 1],
> ___
> svn-full mailing list
> svn-f...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/



Re: [OMPI devel] OMPI Git mirror history: incorrect history & rewinding

2013-10-17 Thread David Goodell (dgoodell)
FYI, all subsequent expected rewinds have occurred.  The mirroring process has 
been modified to reduce the risk of an accidental rewind in the future.  
Several (correct) tags have been added and several (incorrect) tags have been 
deleted.

Going forward, we will also add a .mailmap file to the repository to perform a 
few minor name corrections and add proper emails to the commit history.  This 
should allow us to avoid name-related rewinds.  I'll send a separate email/RFC 
about the email addresses.

-Dave

On Sep 23, 2013, at 8:31 AM, David Goodell (dgoodell)  
wrote:

> A clarification for those on the devel@ list who were not on our private 
> email thread about these issues: "issue (F)" is the "v1.X-series" tag issue.  
> That is, the second rewind has not yet happened.
> 
> -Dave
> 
> On Sep 22, 2013, at 3:33 AM, Eugene Voronov  wrote:
> 
>> Hi All,
>> I've finished with dynamic generation of authors list direct from SVN, thus 
>> feature provide solution resolve issues of mirroring from svn2git.
>> 
>> Last issue (F) I'll try solve in next few days.
>> 
>> 
>> 
>> 
>> -Original Message-
>> From: David Goodell (dgoodell) [mailto:dgood...@cisco.com] 
>> Sent: Friday, September 20, 2013 7:27 PM
>> To: Open MPI Developers
>> Cc: Eugene Voronov; Mike Dubman
>> Subject: OMPI Git mirror history: incorrect history & rewinding
>> 
>> Short Version:
>> 
>> The OMPI GitHub mirror of the OMPI SVN history currently contains some bad 
>> history, specifically related to the version tags.  Prior to roughly 
>> September 16th, this repository also contained several other bits of bad 
>> information/history.  The git history was *rewound* some time around the 
>> 16th, which could cause problems for developers who are using it to 
>> construct patches for our SVN repository.  We expect the history to be 
>> rewound again once at some point in the (hopefully) near future, which will 
>> have a similar effect.
>> 
>> Users of the git mirror may need to perform some unconventional steps to 
>> recover from the upstream rewind in some cases.  If you are not currently 
>> experiencing any trouble with the mirror you may wish to wait until the 
>> second rewind occurs in the near future.
>> 
>> 
>> More Detail:
>> 
>> Though OMPI uses SVN as the canonical version control system (VCS), many 
>> developers use Mercurial (hg) or Git repositories for feature development 
>> and collaboration before bringing those changes back to SVN.  To this end, 
>> there are two helpful mirrors hosted on bitbucket and GitHub respectively:
>> 
>> https://bitbucket.org/ompiteam/ompi-svn-mirror
>> https://github.com/open-mpi/ompi-svn-mirror
>> 
>> The Git mirror is maintained by Mellanox and has been extremely helpful so 
>> far.  However, in July it became clear that some of the history in the 
>> mirror was incorrect.  Specifically:
>> 
>> 1) Several commits had been squashed into a single commit, losing some 
>> history (eb0b490+7fc1da3+36d7b2c+482041f --> 616629d).  However, the tree 
>> (Git-speak for file contents) at each commit always matched the 
>> corresponding commit message.
>> 
>> 2) Some author names and user IDs were incorrect in the history.  The 
>> severity of this is low, since they were all typo-level inaccuracies, not 
>> arbitrarily swapped names.
>> 
>> 3) Most of the release tags are incorrect.  The mirror has tags of the form 
>> "v1.X-series" (where "X" is a valid number) instead of "v1.6.2".  These 
>> "-series" tags then contain directories for each release within that series 
>> instead of the expected source tree.
>> 
>> Eugene V. at Mellanox recently (~2013-09-16) updated the mirror to address 
>> issues (1) and (2).   Issue (3) remains outstanding, necessitating a future 
>> update at some as-yet unspecified time.  Unfortunately, the act of updating 
>> the repository to resolve these issues causes entirely new commit ID hashes 
>> to be created, resulting in a "rewind" of all of the Git branches and tags 
>> in the mirror.  Most git users have not encountered this case and may 
>> experience difficulty coping with it.
>> 
>> If you encounter trouble with these recent repository updates, you might be 
>> able to fix your situation by following some of the advice from the 
>> "RECOVERING FROM UPSTREAM REBASE" section of the "git rebase" manual 
>> (https://www.kernel.org/pub/software/scm/git/docs/git-rebase.html).  If that 
>> doesn't make any sense to you or you encounter too much trouble with it then 
>> you have a couple of options:
>> 
>> A) Assuming you only use your cloned version of the repository to generate 
>> small patch sets, you can always clone another copy of the repository and 
>> move your patches over by hand.
>> 
>> B) You may contact me with a clear explanation of your situation and I will 
>> attempt to point you in the right direction and clear up any confusion about 
>> the recent repository changes.  I won't do any work for you, but I'm happy 
>> to help with explanation in an