Re: [OMPI devel] Lots and lots of warnings on master
Once you squash all these warnings, you could set up a little bit of Jenkins or Travis CI logic to check for PRs that add new warnings and marks them appropriately. Of course, with people making commits directly to master, warnings introduced by those direct commits will be ascribed to those who make PRs against master. But at least you'd catch them quickly. The MPICH project has a script that could easily be adapted to extract only the warnings: http://git.mpich.org/mpich.git/blob/HEAD:/maint/clmake.in Alternatively/additionally you could have a build bot that watches for new commits to master, runs a quick build on each new commit, and sends mail to de...@open-mpi.org and the offender with the new warnings that have been introduced. -Dave > On Nov 10, 2015, at 10:51 PM, Ralph Castain wrote: > > This is from an older compiler, so take it for what it’s worth - I’ll take > care of the orte ones, but the bcol, nbc, and osc ones will need addressing: > > pmix1_server_south.c: In function 'myerr': > pmix1_server_south.c:58: warning: 'nm' may be used uninitialized in this > function > > pmix1_client.c: In function 'myerr': > pmix1_client.c:44: warning: 'nm' may be used uninitialized in this function > > base/rml_base_channel_handlers.c: In function > 'orte_rml_base_close_channel_send_callback': > base/rml_base_channel_handlers.c:95: warning: unused variable ‘peer' > > runtime/orte_data_server.c: In function 'orte_data_server': > runtime/orte_data_server.c:174: warning: 'uid' may be used uninitialized in > this function > > util/dash_host/dash_host.c: In function 'orte_util_add_dash_host_nodes': > util/dash_host/dash_host.c:57: warning: 'slots' may be used uninitialized in > this function > util/dash_host/dash_host.c:58: warning: 'slots_given' may be used > uninitialized in this function > > qos_ack_component.c: In function 'orte_qos_ack_recv_msg_timeout_callback': > qos_ack_component.c:534: warning: unused variable 'msg' > qos_ack_component.c: In function 'orte_qos_ack_msg_send_callback': > qos_ack_component.c:667: warning: unused variable 'channel' > qos_ack_component.c: In function 'ack_recv': > qos_ack_component.c:316: warning: 'room_num' may be used uninitialized in > this function > > ras_slurm_module.c: In function 'recv_data': > ras_slurm_module.c:778: warning: 'app' may be used uninitialized in this > function > > bcol_ptpcoll_allreduce.c: In function 'bcol_ptpcoll_allreduce_narraying_init': > bcol_ptpcoll_allreduce.c:236: warning: unused variable 'dtype' > bcol_ptpcoll_allreduce.c:235: warning: unused variable ‘count' > > nbc.c: In function 'NBC_Progress': > nbc.c:297: warning: 'size' may be used uninitialized in this function > > osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_accumulate_w_req': > osc_pt2pt_comm.c:424: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_comm.c:420: warning: 'frag' may be used uninitialized in this > function > osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_put_w_req': > osc_pt2pt_comm.c:250: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_comm.c:242: warning: 'frag' may be used uninitialized in this > function > osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_callback': > osc_pt2pt_data_move.c:1615: warning: unused variable 'incoming_length' > osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_accumulate_internal': > osc_pt2pt_comm.c:951: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_comm.c:947: warning: 'frag' may be used uninitialized in this > function > osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_control_send': > osc_pt2pt_data_move.c:213: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_data_move.c:212: warning: 'frag' may be used uninitialized in this > function > osc_pt2pt_data_move.c: In function 'ompi_osc_gacc_long_start': > osc_pt2pt_data_move.c:961: warning: 'acc_data' may be used uninitialized in > this function > osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_gacc_start': > osc_pt2pt_data_move.c:914: warning: 'acc_data' may be used uninitialized in > this function > osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_internal': > osc_pt2pt_comm.c:744: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_comm.c:740: warning: 'frag' may be used uninitialized in this > function > osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_acc_long_start': > osc_pt2pt_data_move.c:831: warning: 'acc_data' may be used uninitialized in > this function > osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_compare_and_swap': > osc_pt2pt_comm.c:601: warning: 'ptr' may be used uninitialized in this > function > osc_pt2pt_comm.c:594: warning: 'frag' may be used uninitialized in this > function > > osc_rdma_active_target.c: In function 'ompi_osc_rdma_post_atomic': > osc_rdma_active_target.c:183: warning: 'frag' may be used uninitialized in > this function > osc_rdma_accumulate.c: In function 'ompi_osc_rdma_compar
Re: [OMPI devel] Lots and lots of warnings on master
FWIW: I don’t think that’s the issue here. I don’t see these warnings on my CentOS7 box, for example. I think this is driven by the fact that odin has some very old compilers and a very different environment, and so it has historically generated more warnings. The warnings often are valid - they just don’t get issued by other compilers, or configure activates other code paths. > On Nov 11, 2015, at 6:17 AM, Dave Goodell (dgoodell) > wrote: > > Once you squash all these warnings, you could set up a little bit of Jenkins > or Travis CI logic to check for PRs that add new warnings and marks them > appropriately. Of course, with people making commits directly to master, > warnings introduced by those direct commits will be ascribed to those who > make PRs against master. But at least you'd catch them quickly. > > The MPICH project has a script that could easily be adapted to extract only > the warnings: http://git.mpich.org/mpich.git/blob/HEAD:/maint/clmake.in > > Alternatively/additionally you could have a build bot that watches for new > commits to master, runs a quick build on each new commit, and sends mail to > de...@open-mpi.org and the offender with the new warnings that have been > introduced. > > -Dave > >> On Nov 10, 2015, at 10:51 PM, Ralph Castain wrote: >> >> This is from an older compiler, so take it for what it’s worth - I’ll take >> care of the orte ones, but the bcol, nbc, and osc ones will need addressing: >> >> pmix1_server_south.c: In function 'myerr': >> pmix1_server_south.c:58: warning: 'nm' may be used uninitialized in this >> function >> >> pmix1_client.c: In function 'myerr': >> pmix1_client.c:44: warning: 'nm' may be used uninitialized in this function >> >> base/rml_base_channel_handlers.c: In function >> 'orte_rml_base_close_channel_send_callback': >> base/rml_base_channel_handlers.c:95: warning: unused variable ‘peer' >> >> runtime/orte_data_server.c: In function 'orte_data_server': >> runtime/orte_data_server.c:174: warning: 'uid' may be used uninitialized in >> this function >> >> util/dash_host/dash_host.c: In function 'orte_util_add_dash_host_nodes': >> util/dash_host/dash_host.c:57: warning: 'slots' may be used uninitialized in >> this function >> util/dash_host/dash_host.c:58: warning: 'slots_given' may be used >> uninitialized in this function >> >> qos_ack_component.c: In function 'orte_qos_ack_recv_msg_timeout_callback': >> qos_ack_component.c:534: warning: unused variable 'msg' >> qos_ack_component.c: In function 'orte_qos_ack_msg_send_callback': >> qos_ack_component.c:667: warning: unused variable 'channel' >> qos_ack_component.c: In function 'ack_recv': >> qos_ack_component.c:316: warning: 'room_num' may be used uninitialized in >> this function >> >> ras_slurm_module.c: In function 'recv_data': >> ras_slurm_module.c:778: warning: 'app' may be used uninitialized in this >> function >> >> bcol_ptpcoll_allreduce.c: In function >> 'bcol_ptpcoll_allreduce_narraying_init': >> bcol_ptpcoll_allreduce.c:236: warning: unused variable 'dtype' >> bcol_ptpcoll_allreduce.c:235: warning: unused variable ‘count' >> >> nbc.c: In function 'NBC_Progress': >> nbc.c:297: warning: 'size' may be used uninitialized in this function >> >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_accumulate_w_req': >> osc_pt2pt_comm.c:424: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:420: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_put_w_req': >> osc_pt2pt_comm.c:250: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:242: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_callback': >> osc_pt2pt_data_move.c:1615: warning: unused variable 'incoming_length' >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_accumulate_internal': >> osc_pt2pt_comm.c:951: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:947: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_control_send': >> osc_pt2pt_data_move.c:213: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c:212: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_gacc_long_start': >> osc_pt2pt_data_move.c:961: warning: 'acc_data' may be used uninitialized in >> this function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_gacc_start': >> osc_pt2pt_data_move.c:914: warning: 'acc_data' may be used uninitialized in >> this function >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_internal': >> osc_pt2pt_comm.c:744: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:740: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_acc
Re: [OMPI devel] Lots and lots of warnings on master
On Nov 11, 2015, at 10:09 AM, Ralph Castain wrote: > > FWIW: I don’t think that’s the issue here. I don’t see these warnings on my > CentOS7 box, for example. I think this is driven by the fact that odin has > some very old compilers and a very different environment, and so it has > historically generated more warnings. > > The warnings often are valid - they just don’t get issued by other compilers, > or configure activates other code paths. Sure, but the automation could be set up to do builds on both Odin and newer systems. I think it's easier to tend to this sort of warning cruft as it happens, rather than big stomps later on, but that's just personal preference. It would also hopefully reduce the amount of cherry picking that needs to happen to release branches. *shrug* just a suggestion -Dave
Re: [OMPI devel] Lots and lots of warnings on master
I’m not saying it’s a bad suggestion - just pointing out that it likely wasn’t caused by carelessness. Setting something up on odin would be tricky, but someone could look at that environment to see why it’s generating all these when we don’t see them elsewhere - maybe it would be simple to setup something elsewhere that gets the same result. > On Nov 11, 2015, at 7:15 AM, Dave Goodell (dgoodell) > wrote: > > On Nov 11, 2015, at 10:09 AM, Ralph Castain wrote: >> >> FWIW: I don’t think that’s the issue here. I don’t see these warnings on my >> CentOS7 box, for example. I think this is driven by the fact that odin has >> some very old compilers and a very different environment, and so it has >> historically generated more warnings. >> >> The warnings often are valid - they just don’t get issued by other >> compilers, or configure activates other code paths. > > Sure, but the automation could be set up to do builds on both Odin and newer > systems. I think it's easier to tend to this sort of warning cruft as it > happens, rather than big stomps later on, but that's just personal > preference. It would also hopefully reduce the amount of cherry picking that > needs to happen to release branches. > > *shrug* just a suggestion > > -Dave > > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2015/11/18360.php
[OMPI devel] question on ORTE_DAEMON_ADD_LOCAL_PROCS
Hi, I'm seeing this message an awful amount of times. (I.e. orders of magnitude more than I launch processes) [nid15897:18424] [[2305,0],103] orted:comm:process_commands() Processing Command: ORTE_DAEMON_ADD_LOCAL_PROCS How should I interpret that? Thanks Mark
Re: [OMPI devel] question on ORTE_DAEMON_ADD_LOCAL_PROCS
You must have the “-d” option set on the orte-dvm cmd line? You’ll get one of those from every daemon in the job each time you launch an app. > On Nov 11, 2015, at 1:03 PM, Mark Santcroos > wrote: > > Hi, > > I'm seeing this message an awful amount of times. (I.e. orders of magnitude > more than I launch processes) > > [nid15897:18424] [[2305,0],103] orted:comm:process_commands() Processing > Command: ORTE_DAEMON_ADD_LOCAL_PROCS > > How should I interpret that? > > Thanks > > Mark > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2015/11/18362.php
Re: [OMPI devel] question on ORTE_DAEMON_ADD_LOCAL_PROCS
> On 11 Nov 2015, at 22:43 , Ralph Castain wrote: > You must have the “-d” option set on the orte-dvm cmd line? Yes. > You’ll get one of those from every daemon in the job each time you launch an > app. Ok, that explains the number better :) Why is every orted aware of a job on another orted?
Re: [OMPI devel] question on ORTE_DAEMON_ADD_LOCAL_PROCS
Every orted maintains knowledge of where every process in the DVM is located in case some local client needs information or to otherwise communicate out-of-band with some non-local peer. The RTE has no idea of the possible communication pattern, so we err on the side of more info to avoid sometime having to say “I don’t know how to do that, Dave” > On Nov 11, 2015, at 1:58 PM, Mark Santcroos > wrote: > > >> On 11 Nov 2015, at 22:43 , Ralph Castain wrote: >> You must have the “-d” option set on the orte-dvm cmd line? > > Yes. > >> You’ll get one of those from every daemon in the job each time you launch an >> app. > > Ok, that explains the number better :) > Why is every orted aware of a job on another orted? > > > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2015/11/18364.php
Re: [OMPI devel] question on ORTE_DAEMON_ADD_LOCAL_PROCS
If Dave says it's ok then it must be! :) (Thanks for the explanation) > On 11 Nov 2015, at 23:04 , Ralph Castain wrote: > > Every orted maintains knowledge of where every process in the DVM is located > in case some local client needs information or to otherwise communicate > out-of-band with some non-local peer. The RTE has no idea of the possible > communication pattern, so we err on the side of more info to avoid sometime > having to say “I don’t know how to do that, Dave” > > >> On Nov 11, 2015, at 1:58 PM, Mark Santcroos >> wrote: >> >> >>> On 11 Nov 2015, at 22:43 , Ralph Castain wrote: >>> You must have the “-d” option set on the orte-dvm cmd line? >> >> Yes. >> >>> You’ll get one of those from every daemon in the job each time you launch >>> an app. >> >> Ok, that explains the number better :) >> Why is every orted aware of a job on another orted? >> >> >> ___ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2015/11/18364.php > > ___ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2015/11/18365.php
