Re: [OMPI devel] C89 support
The patches can be seen here (Trivial and hopefully acceptable) https://github.com/pathscale/ompi/commit/42cf248bd026148fc09148626dd3029515498472 https://github.com/pathscale/ompi/commit/c181c0bb080ada407602319ea45548f428e724e0 https://github.com/pathscale/ompi/commit/fb8940303a7e85bb0b462d1f5c268be5ece3176b On Sat, Aug 27, 2016 at 9:51 PM, Nathan Hjelm wrote: > We do not depend on any C99 specific behavior out of libc that I know of. We > depend on the types (stdint.h) and syntax (sub-object naming, variadic > macros, etc). A little surprised there are any linking failures with Open MPI > even with an ancient glibc. > > If the patch is simple please send it to us and we will take a look. If it > doesn’t disrupt anything we will consider it. > > -Nathan > >> On Aug 27, 2016, at 7:41 AM, cbergst...@pathscale.com wrote: >> >> It's well documented that the version of glibc that goes with SLES10 is not >> c99. As well as that gcc's claimed c99 is not in fact conformant. Newer >> glibc fixed this but SLES10 is stuck. I can provide exact documentation >> links if necessary. >> >> Clang and any real c99 compiler fails at link time. >> >> This effects all versions of clang or us up to svn trunk. >> >> The patch is simple and non-performance impacting. >> >> Original Message >> From: Nathan Hjelm >> Sent: Saturday, August 27, 2016 20:23 >> To: Open MPI Developers >> Reply To: Open MPI Developers >> Subject: Re: [OMPI devel] C89 support >> >> Considering gcc more or less had full C99 support in 3.1 (2002) and SLES10 >> dates back to 2004 I find this surprising. Clangs goal from the beginning >> was full C99 support. Checking back it looks like llvm 1.0 (2003) had C99 >> support. What version of clang/llvm are you using? >> >> -Nathan >> >>> On Aug 27, 2016, at 6:38 AM, C Bergström wrote: >>> >>> I realize a number of changes have been made to make the codebase C99. >>> As I'm setting up more testing platforms, I found that this caused >>> Clang (and us) to be broken on SLES10. While I realize that platform >>> is quite *old*, it is still used in production at more than one sight >>> which we support. If there isn't a strong feeling against it, would >>> you guys accept a patch to get this building again.. >>> >>> Thanks >>> ___ >>> devel mailing list >>> devel@lists.open-mpi.org >>> https://rfd.newmexicoconsortium.org/mailman/listinfo/devel >> >> ___ >> devel mailing list >> devel@lists.open-mpi.org >> https://rfd.newmexicoconsortium.org/mailman/listinfo/devel >> ___ >> devel mailing list >> devel@lists.open-mpi.org >> https://rfd.newmexicoconsortium.org/mailman/listinfo/devel > > ___ > devel mailing list > devel@lists.open-mpi.org > https://rfd.newmexicoconsortium.org/mailman/listinfo/devel ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
Re: [OMPI devel] C89 support
Christopher, i made PR #1345 https://github.com/open-mpi/ompi-release/pull/1345 (there is no copyright in these files, let me know how i should credit pathscale (if you want that of course) this is basically your patch plus a few changes : you need to configure with '--disable-c99' if you are using pre C99 compiler. i noted these patches are for the v1.10 series. do you also expect v2.x (and master too ?) can be built with pre C99 compilers too ? Cheers, Gilles On 8/27/2016 10:41 PM, cbergst...@pathscale.com wrote: It's well documented that the version of glibc that goes with SLES10 is not c99. As well as that gcc's claimed c99 is not in fact conformant. Newer glibc fixed this but SLES10 is stuck. I can provide exact documentation links if necessary. Clang and any real c99 compiler fails at link time. This effects all versions of clang or us up to svn trunk. The patch is simple and non-performance impacting. Original Message From: Nathan Hjelm Sent: Saturday, August 27, 2016 20:23 To: Open MPI Developers Reply To: Open MPI Developers Subject: Re: [OMPI devel] C89 support Considering gcc more or less had full C99 support in 3.1 (2002) and SLES10 dates back to 2004 I find this surprising. Clangs goal from the beginning was full C99 support. Checking back it looks like llvm 1.0 (2003) had C99 support. What version of clang/llvm are you using? -Nathan On Aug 27, 2016, at 6:38 AM, C Bergström wrote: I realize a number of changes have been made to make the codebase C99. As I'm setting up more testing platforms, I found that this caused Clang (and us) to be broken on SLES10. While I realize that platform is quite *old*, it is still used in production at more than one sight which we support. If there isn't a strong feeling against it, would you guys accept a patch to get this building again.. Thanks ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
Re: [OMPI devel] C89 support
On Mon, Aug 29, 2016 at 12:59 PM, Gilles Gouaillardet wrote: > Christopher, > > > i made PR #1345 https://github.com/open-mpi/ompi-release/pull/1345 > > (there is no copyright in these files, let me know how i should credit > pathscale (if you want that of course) I'm not sure that there is anything substantial enough to be copyright. If the shoe was on the other foot I'd highly question anyone who pushed for attribution on these patches. > > > this is basically your patch plus a few changes : you need to configure with > '--disable-c99' if you are using pre C99 compiler. > > i noted these patches are for the v1.10 series. do you also expect v2.x (and > master too ?) can be built with pre C99 compilers too ? If these style of changes are acceptable we'll do patches for all. Thanks for your help on this. I have a couple other small things I'm hoping to get upstream after this. ___ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
