Re: [OpenSIPS-Devel] [OpenSIPS-Users] New features in BLF and presence
Iñaki Baz Castillo wrote: > Let me a question: > > In case the INVITE has a SDP just containing a MSRP path (without > "audio"/"video"), would also the pua_dialog generate a "ringing" > dialog-info Publish? > This is, if Alice starts a MSRP messaging session with Bob, would > Carol see both Alice and Bob with activity "On the phone"? :) > > > Hi Inaki, Yes, it will. In fact what happens is that the dialog module will trigger the pua_dialoginfo callback for created dialog and pua_dialoginfo will generate a Publish with state trying. The dialoginfo - presence translation feature in presence module will then generate a presence publish with substatus ringing. The pua_dialoginfo doesn't do any check of the SIP message and assumes that if the dialoginfo_set function has been called from the script, then it should generated dialog publications for that dialog.The problem is that the MSRP offers are also carried in SDP bodies so it is hard to check this from the script and not call dialoginfo_set for those Invites. I think that somewhere in this path a check should be added to prevent generating dialog info and presence publications for MSRP Invites. Probably either by writing a function to be called from script like is_msrp() or doing the check in pua_dialoginfo. Regards, -- Anca Vamanu www.voice-system.ro ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2989001 ] consume_credentials problem
Bugs item #2989001, was opened at 2010-04-18 17:56 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989001&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) >Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: consume_credentials problem Initial Comment: consume_credentials doesn't appear to work correctly for sequential requests. I am just yanking the auth header for now but it seems like something that should be looked into. -- >Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 13:34 Message: the consume_credentials() will not remove any credentials that were not used during an auth. So, if you do not do auth, you cannot remove them... Is this your case? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989001&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [OpenSIPS-Users] New features in BLF and presence
Hi Anca and Inaki,
> Hi Inaki,
>
> Yes, it will.
> In fact what happens is that the dialog module will trigger the
> pua_dialoginfo callback for created dialog and pua_dialoginfo will
> generate a Publish with state trying. The dialoginfo - presence
> translation feature in presence module will then generate a presence
> publish with substatus ringing.
That sounds right to me.
> The pua_dialoginfo doesn't do any check of the SIP message and assumes
> that if the dialoginfo_set function has been called from the script,
> then it should generated dialog publications for that dialog.The problem
> is that the MSRP offers are also carried in SDP bodies so it is hard to
> check this from the script and not call dialoginfo_set for those Invites.
Currently I'm doing something like this:
if (has_body("application/sdp") && search_body("(m=).*?(MSRP)")) {
## SDP contains MSRP
}
You don't want to do call forwarding for a MSRP invite, do you? xDD
The problem I see here is with sessions with multiple types of streams:
if I send an INVITE with audio and MSRP, I don't know if communication
will be audio or MSRP chat or both.
> I think that somewhere in this path a check should be added to prevent
> generating dialog info and presence publications for MSRP Invites.
> Probably either by writing a function to be called from script like
> is_msrp() or doing the check in pua_dialoginfo.
>
May I suggest something: instead of using terms like 'on the phone' that
suggest only telephony we could use a more generic ones, to match the
concept of a 'session'. A user may establish an audio, video, msrp, t140
session with another, so instead of being 'on the phone' he would be 'In
session...', instead of being 'Ringing...' it would be 'Alerting...' or
some more appropriate messages. How does it sound?
Regards,
--
Saúl Ibarra Corretgé
AG Projects
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2987919 ] Opensips Control Panel: Bad link on Monit Tool
Bugs item #2987919, was opened at 2010-04-16 00:05
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2987919&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
Group: 1.6.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Opensips Control Panel: Bad link on Monit Tool
Initial Comment:
Hello
On file opensips-cp/web/tools/system/monit/monit_proxyfy.php, I think the line:
require_once("../../../../config/tools/monit/local.inc.php");
Should be:
require_once("../../../../config/tools/system/monit/local.inc.php");
--
>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-04-20 14:00
Message:
The error is already fixed on SVN. Today the dowload tarballs will be
updated.
Thanks and regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2987919&group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2985429 ] Parameter transformation fails on space (parse_params)
Bugs item #2985429, was opened at 2010-04-11 17:27
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2985429&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: coxx ()
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Parameter transformation fails on space (parse_params)
Initial Comment:
If From or To headers contains display name with a SPACE (for ex. "ABC XYC")
then transformation $(hdr(From){param.value,tag} fails with message:
ERROR:core:parse_params: invalid character, ; expected, found X
--
>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-04-20 14:01
Message:
Please post the entire FROM hdr.
Thanks.
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2985429&group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2988814 ] dialog pvar not functional in local route
Bugs item #2988814, was opened at 2010-04-17 23:32 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) >Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: dialog pvar not functional in local route Initial Comment: In the local route I am able to get stored dialog values using fetch_dlg_value however attempting to read value via $dlg_val I get nothing returned and error in log: Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: no value in right expression Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: error at line: 508 -- >Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 14:34 Message: there is a dialog context (and dialog vars) only for BYEs generated by dialog module (on timeout). Is this your scenario ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6801] trunk/modules/presence
Revision: 6801 http://opensips.svn.sourceforge.net/opensips/?rev=6801&view=rev Author: anca_vamanu Date: 2010-04-20 13:16:19 + (Tue, 20 Apr 2010) Log Message: --- - addition for BLA: the possibility to define a custom presentity URI to use for BLA Subscriptions Modified Paths: -- trunk/modules/presence/README trunk/modules/presence/doc/presence_admin.xml trunk/modules/presence/presence.c trunk/modules/presence/presence.h trunk/modules/presence/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[6802] branches/1.6/modules/presence
Revision: 6802 http://opensips.svn.sourceforge.net/opensips/?rev=6802&view=rev Author: anca_vamanu Date: 2010-04-20 13:18:15 + (Tue, 20 Apr 2010) Log Message: --- - addition in BLA: the possibility to define a custom presentity URI to use when processing BLA Subscribes Modified Paths: -- branches/1.6/modules/presence/README branches/1.6/modules/presence/doc/presence_admin.xml branches/1.6/modules/presence/presence.c branches/1.6/modules/presence/presence.h branches/1.6/modules/presence/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2989001 ] consume_credentials problem
Bugs item #2989001, was opened at 2010-04-18 14:56 Message generated for change (Comment added) made by rrevels You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989001&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: consume_credentials problem Initial Comment: consume_credentials doesn't appear to work correctly for sequential requests. I am just yanking the auth header for now but it seems like something that should be looked into. -- >Comment By: Richard Revels (rrevels) Date: 2010-04-20 14:15 Message: No. I noticed that in the docs and put an if() block in my BYE handler to try auth and consume credentials if it passed. Otherwise, mangle the packet in other ways and send it on its way. : > -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 10:34 Message: the consume_credentials() will not remove any credentials that were not used during an auth. So, if you do not do auth, you cannot remove them... Is this your case? Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989001&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2988814 ] dialog pvar not functional in local route
Bugs item #2988814, was opened at 2010-04-17 20:32 Message generated for change (Comment added) made by rrevels You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: dialog pvar not functional in local route Initial Comment: In the local route I am able to get stored dialog values using fetch_dlg_value however attempting to read value via $dlg_val I get nothing returned and error in log: Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: no value in right expression Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: error at line: 508 -- >Comment By: Richard Revels (rrevels) Date: 2010-04-20 14:26 Message: Umm, I need to think about that for a while. And go read the wiki. I noticed the context had been added for specifying a pvar but didn't pay attention to it since I had set the dialog value in the INVITE and the fetch_dlg_value worked as expected. Let me set it back up and I'll get back to you. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 11:34 Message: there is a dialog context (and dialog vars) only for BYEs generated by dialog module (on timeout). Is this your scenario ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2989974 ] calling t_newtran() before t_replicate => t_replicate fails
Bugs item #2989974, was opened at 2010-04-20 16:11
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989974&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.6.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: calling t_newtran() before t_replicate => t_replicate fails
Initial Comment:
There's a bug in t_replicate which is trying to create the transaction even if
it was already created.
Simple script to reproduce:
route {
t_newtran();
t_replicate("sip:another_proxy");
}
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2989974&group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2988814 ] dialog pvar not functional in local route
Bugs item #2988814, was opened at 2010-04-17 20:32 Message generated for change (Comment added) made by rrevels You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: dialog pvar not functional in local route Initial Comment: In the local route I am able to get stored dialog values using fetch_dlg_value however attempting to read value via $dlg_val I get nothing returned and error in log: Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: no value in right expression Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: error at line: 508 -- >Comment By: Richard Revels (rrevels) Date: 2010-04-20 19:20 Message: Okay, I've looked at the docs and what I was doing again and I still don't understand what you are asking me. First thing though is that I shouldn't have used the word pvar in the summary line. What I'm trying to do is read a dialog value via the pseudo variable $dlg_val(name). I can read the dialog value in the local route (BYE initiated by dialog module timeout on the dialog) by calling the fetch_dlg_value function but get the error when trying to read the value directly using the pseudo variable. -- Comment By: Richard Revels (rrevels) Date: 2010-04-20 14:26 Message: Umm, I need to think about that for a while. And go read the wiki. I noticed the context had been added for specifying a pvar but didn't pay attention to it since I had set the dialog value in the INVITE and the fetch_dlg_value worked as expected. Let me set it back up and I'll get back to you. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 11:34 Message: there is a dialog context (and dialog vars) only for BYEs generated by dialog module (on timeout). Is this your scenario ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-2988814 ] dialog pvar not functional in local route
Bugs item #2988814, was opened at 2010-04-17 20:32 Message generated for change (Comment added) made by rrevels You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.6.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Revels (rrevels) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: dialog pvar not functional in local route Initial Comment: In the local route I am able to get stored dialog values using fetch_dlg_value however attempting to read value via $dlg_val I get nothing returned and error in log: Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: no value in right expression Apr 17 20:08:07 guinea-pig2 osips-log[17277]: ERROR:core:do_assign: error at line: 508 -- >Comment By: Richard Revels (rrevels) Date: 2010-04-20 19:23 Message: Also, this is a pretty minor thing since fetct_dlg_value works and it may have something to do with the statement from the documentation that the pseudo variable is only available on sequential requests arter doing loose route. I couldn't decide if that meant it wasn't available in the local route or not. -- Comment By: Richard Revels (rrevels) Date: 2010-04-20 19:20 Message: Okay, I've looked at the docs and what I was doing again and I still don't understand what you are asking me. First thing though is that I shouldn't have used the word pvar in the summary line. What I'm trying to do is read a dialog value via the pseudo variable $dlg_val(name). I can read the dialog value in the local route (BYE initiated by dialog module timeout on the dialog) by calling the fetch_dlg_value function but get the error when trying to read the value directly using the pseudo variable. -- Comment By: Richard Revels (rrevels) Date: 2010-04-20 14:26 Message: Umm, I need to think about that for a while. And go read the wiki. I noticed the context had been added for specifying a pvar but didn't pay attention to it since I had set the dialog value in the INVITE and the fetch_dlg_value worked as expected. Let me set it back up and I'll get back to you. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-04-20 11:34 Message: there is a dialog context (and dialog vars) only for BYEs generated by dialog module (on timeout). Is this your scenario ? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2988814&group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
