[OpenSIPS-Devel] [ opensips-Bugs-3610662 ] REGISTRAR save with force flag and limited contacts broken
Bugs item #3610662, was opened at 2013-04-12 01:32 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3610662group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: 1.8.x Status: Open Resolution: Fixed Priority: 5 Private: No Submitted By: Kiss Karoly (kisskaroly) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: REGISTRAR save with force flag and limited contacts broken Initial Comment: When using save in registrar module with f and cXX flags set, the number of contacts can exceed the XX value. Consider the following scenario: 3 devices registering with the same SIP account and XX above is set to 2, with f flag set. In this case we should be seeing two contacts saved, and the third should randomly overwrite one of the two contacts because of the force flag. What I see instead is that when the third device registers, one of the contacts is correctly overwritten, however when the device whos contact was overwritten, reregisters, it's contact is incorrectly added to the list of contacts, thus exceeding the limit of maximum allowed contacts. The cXX flag in my case is specified as a parameter to the save command in script. Tested with opensips 1.8.2 svn rev 9438. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-04-18 07:31 Message: Kiss, Following our chat on IRC, see the new patch (Final fix with change in limit) that hopefully solve all the issues. Regards, Bogdan -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-04-17 10:26 Message: Kiss, indeed, the update logic was not fully correct - I tried a simpler approach (which should work) - the version 2 patch is here, against SVN (so remove any prev patch). Please have it tested and let me know what's the result :) Thanks and regards, Bogdan -- Comment By: Kiss Karoly (kisskaroly) Date: 2013-04-16 05:41 Message: With this patch, the original problem is solved, however still not working as expected. The problem is, that when max allowed regs is 2 and there are two contacts registered, at the first refresh by one of the contacts, the other contact is deleted. I would expect it not to delete any contacts, when I allow 2 and have 2. -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-04-15 09:39 Message: Hi Kiss, Attached is a patch that should solve the problem - at least it solved it in my tests :). Please apply it and give it a try - ignore the really verbose debug messages :D. Thanks and regards, Bogdan -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-04-12 10:46 Message: Hi Kiss, I managed to reproduce the scenario - I'm working on a fix. Thanks and regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3610662group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Cachedb_Couchbase questions
Hi Ryan, Wondered about that myself when the module was built, about why they would have two different mechanisms for reporting errors. I included both just for the sake of reporting all errors, but didn't see the lcb_get_last_error() triggering. I guess we need the help of some libcouchbase devs here, or dig into the libcouchbase code to see when lcb_get_last_error() triggers and error. Best Regards, Vlad Paiu OpenSIPS Developer http://www.opensips-solutions.com On 04/18/2013 12:54 AM, Ryan Bullock wrote: Hey all, I am doing some work with opensips + couchbase and have started on a patchset for the opensips couchbase driver to clean up a few things (better error outputs, etc) and make some changes that we require before going production. One thing I am noticing are calls to lcb_get_last_error() after every operation, even though the error on the callback is being stored in last_error. In my quick testing the response from lcb_get_last_error() seems to always be success even if the operation failed (such as due to a connection failure), last_error shows the correct failure. I am wondering if the checks to lcb_get_last_error could be removed? Or are their instances where it would show an error not caught by last_error? I don't see many uses of lcb_get_last_error in the libcouchbase examples and they seem to all go off the error in the callback. The benefit I see is being able to more easily report useful and relevant errors. Input welcome. Regards, Ryan ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9957] trunk/modules/acc/acc_logic.c
Revision: 9957 http://opensips.svn.sourceforge.net/opensips/?rev=9957view=rev Author: razvancrainea Date: 2013-04-18 15:24:44 + (Thu, 18 Apr 2013) Log Message: --- prevent REINVITEs from overwriting acc internal structures Modified Paths: -- trunk/modules/acc/acc_logic.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9958] branches/1.9/modules/acc/acc_logic.c
Revision: 9958 http://opensips.svn.sourceforge.net/opensips/?rev=9958view=rev Author: razvancrainea Date: 2013-04-18 15:28:35 + (Thu, 18 Apr 2013) Log Message: --- Backported from trunk (rev #9957): prevent REINVITEs from overwriting acc internal structures Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9957view=rev Modified Paths: -- branches/1.9/modules/acc/acc_logic.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9959] branches/1.8/modules/acc/acc_logic.c
Revision: 9959 http://opensips.svn.sourceforge.net/opensips/?rev=9959view=rev Author: razvancrainea Date: 2013-04-18 15:28:51 + (Thu, 18 Apr 2013) Log Message: --- Backported from trunk (rev #9957): prevent REINVITEs from overwriting acc internal structures Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9957view=rev Modified Paths: -- branches/1.8/modules/acc/acc_logic.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9960] trunk/action.c
Revision: 9960 http://opensips.svn.sourceforge.net/opensips/?rev=9960view=rev Author: razvancrainea Date: 2013-04-18 16:29:15 + (Thu, 18 Apr 2013) Log Message: --- restore route type after running error route Modified Paths: -- trunk/action.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9961] branches/1.9/action.c
Revision: 9961 http://opensips.svn.sourceforge.net/opensips/?rev=9961view=rev Author: razvancrainea Date: 2013-04-18 16:29:45 + (Thu, 18 Apr 2013) Log Message: --- Backported from trunk (rev #9960): restore route type after running error route Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9960view=rev Modified Paths: -- branches/1.9/action.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9963] trunk/modules/dialog/dlg_tophiding.c
Revision: 9963 http://opensips.svn.sourceforge.net/opensips/?rev=9963view=rev Author: razvancrainea Date: 2013-04-18 16:35:29 + (Thu, 18 Apr 2013) Log Message: --- double check if the dialog can be found after created Modified Paths: -- trunk/modules/dialog/dlg_tophiding.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9964] branches/1.9/modules/dialog/dlg_tophiding.c
Revision: 9964 http://opensips.svn.sourceforge.net/opensips/?rev=9964view=rev Author: razvancrainea Date: 2013-04-18 16:36:14 + (Thu, 18 Apr 2013) Log Message: --- Backported from trunk (rev #9963): double check if the dialog can be found after created Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9963view=rev Modified Paths: -- branches/1.9/modules/dialog/dlg_tophiding.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9965] branches/1.8/modules/dialog/dlg_tophiding.c
Revision: 9965 http://opensips.svn.sourceforge.net/opensips/?rev=9965view=rev Author: razvancrainea Date: 2013-04-18 16:36:24 + (Thu, 18 Apr 2013) Log Message: --- Backported from trunk (rev #9963): double check if the dialog can be found after created Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9963view=rev Modified Paths: -- branches/1.8/modules/dialog/dlg_tophiding.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] Cachedb_Couchbase questions
Ok, I need to dig into this anyways so I will see what I can find and work up a patch based on that. Regards, Ryan On Thu, Apr 18, 2013 at 7:41 AM, Vlad Paiu vladp...@opensips.org wrote: ** Hi Ryan, Wondered about that myself when the module was built, about why they would have two different mechanisms for reporting errors. I included both just for the sake of reporting all errors, but didn't see the lcb_get_last_error() triggering. I guess we need the help of some libcouchbase devs here, or dig into the libcouchbase code to see when lcb_get_last_error() triggers and error. Best Regards, Vlad Paiu OpenSIPS Developerhttp://www.opensips-solutions.com On 04/18/2013 12:54 AM, Ryan Bullock wrote: Hey all, I am doing some work with opensips + couchbase and have started on a patchset for the opensips couchbase driver to clean up a few things (better error outputs, etc) and make some changes that we require before going production. One thing I am noticing are calls to lcb_get_last_error() after every operation, even though the error on the callback is being stored in last_error. In my quick testing the response from lcb_get_last_error() seems to always be success even if the operation failed (such as due to a connection failure), last_error shows the correct failure. I am wondering if the checks to lcb_get_last_error could be removed? Or are their instances where it would show an error not caught by last_error? I don't see many uses of lcb_get_last_error in the libcouchbase examples and they seem to all go off the error in the callback. The benefit I see is being able to more easily report useful and relevant errors. Input welcome. Regards, Ryan ___ Devel mailing listDevel@lists.opensips.orghttp://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3611297 ] B2BUA bridging in prepaid demo doesn't work.
Bugs item #3611297, was opened at 2013-04-18 12:21 Message generated for change (Tracker Item Submitted) made by rumb80 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3611297group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: 1.9.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Renat (rumb80) Assigned to: Nobody/Anonymous (nobody) Summary: B2BUA bridging in prepaid demo doesn't work. Initial Comment: B2BUA bridging in prepaid demo doesn't work in 1.9, but work as expected in 1.8.2 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086410aid=3611297group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Feature Requests-3611300 ] Get b2bl_key_avp working again in b2b_logic
Feature Requests item #3611300, was opened at 2013-04-18 13:09 Message generated for change (Tracker Item Submitted) made by rumb80 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086413aid=3611300group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Renat (rumb80) Assigned to: Nobody/Anonymous (nobody) Summary: Get b2bl_key_avp working again in b2b_logic Initial Comment: Hi guys, i really need b2bl_key_avp working in 1.8.2 or 1.9 to implement some weird scenario with B2BUA. Any suggestions how to get it back? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086413aid=3611300group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
