Re: [OpenSIPS-Devel] [opensips] pua_dialoginfo: failed calls triggers sending PUBLISH errors (#142)
Hi, Damien, two aspects: 1) going back to Ovidiu's question: I understand what the RFC says, but it is wise from user perspective no to publish at all while he is in a call with trying state ? 2) as a fix when publish_on_trying is not used, we can either look at the old state when TERMINATING (to see from which state with switched to terminated) or we can use a dlg val as marker to remember if a prev publish was sent or not - I can look more into this. Regards, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/142#issuecomment-30734198___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] pua_dialoginfo: failed calls triggers sending PUBLISH errors (#142)
Hi Bogdan, 1) I think it is wise. Actually, the early state of the dialog is notified (180 Ringing, or even, I think 100 Trying). The only state that is not notified is the trying state. This trying state does not correspond to a specific SIP Message or dialog state, but to the fact that pua_dialoginfo_set has been called from the routing script. I think it is preferable in most cases to notify only when there is some kind of SIP message transiting over the network. 2) OK --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/142#issuecomment-30745381___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] pua_dialoginfo: failed calls triggers sending PUBLISH errors (#142)
@dsandras The trying state correspond to the INVITE being sent out and therefor there is a message transiting the network. @bogdan-iancu I was looking into a solution for this and we should aim for a generic one. My idea was to use a flag to mark when a PUBLISH was sent and to send a new PUBLISH out with a '0' expiry only if a previous PUBLISH was sent. This doesn't need to keep track of the state and it is more aligned with presence (I would like to avoid specific dialog details in the PUBLISH sending decision logic, for this particular '0' expiry case). Regards, Ovidiu Sas --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/142#issuecomment-30755459___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] pua_dialoginfo: failed calls triggers sending PUBLISH errors (#142)
@ovidiusas : Yes, I meant a response from the remote peer transiting over the network. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/142#issuecomment-30756247___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] pua_dialoginfo: failed calls triggers sending PUBLISH errors (#142)
Just to avoid any confusion, the doc should be updated with a diagram: For a successful call we have: ``` UAC proxy UAS presence server |--INVITE-| || |-100-|--INVITE-|| | |--PUBLISH(trying)-| | |-100-|| | | || | |-18x-|| |-18x-|--PUBLISH(early)--| | | || | |-200-|| |-200-|--PUBLISH(confirmed)--| |--ACK| || | |--ACK|| | | || ``` If we choose to avoid the trying state, then early will be triggered on the first 18x provisional reply. Something like this: ``` UAC proxy UAS presence server |--INVITE-| || |-100-|--INVITE-|| | |-100-|| | | || | |-18x-|| |-18x-|--PUBLISH(early)--| | | || | |-200-|| |-200-|--PUBLISH(confirmed)--| |--ACK| || | |--ACK|| | | || ``` The issue is with rejected calls. If we don't have a 18x provisional reply, then we have this: ``` UAC proxy UAS presence server |--INVITE-| || |-100-|--INVITE-|| | |--PUBLISH(trying)-| | |-100-|| | | || | |-456xx---|| | |--PUBLISH(terminated)-| |-456xx---|--ACK|| |--ACK| || ``` If we don't have a 18x provisional reply and we avoid the trying state, then we don't have any PUBLISH at all: ``` UAC proxy UAS presence server |--INVITE-| || |-100-|--INVITE-|| | |-100-|| | | || | |-456xx---|| |-456xx---|--ACK|| |--ACK| || ``` --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/142#issuecomment-30758792___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 54a22d: scripts/opensipsctl: nicer output for 'trap' if op...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 54a22de28833d674350b919a4791f1a2c2953ba9 https://github.com/OpenSIPS/opensips/commit/54a22de28833d674350b919a4791f1a2c2953ba9 Author: Ovidiu Sas o...@voipembedded.com Date: 2013-12-17 (Tue, 17 Dec 2013) Changed paths: M scripts/opensipsctl Log Message: --- scripts/opensipsctl: nicer output for 'trap' if opensips is not running ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
