[OpenSIPS-Devel] [OpenSIPS/opensips] c94887: digest+m_auth: Allow a domain in the digest userna...

2014-02-18 Thread Walter Doekes
  Branch: refs/heads/1.9
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c94887a5f5e950ee59e699f1bcfb3118d7cc78fb
  
https://github.com/OpenSIPS/opensips/commit/c94887a5f5e950ee59e699f1bcfb3118d7cc78fb
  Author: Walter Doekes walter+git...@wjd.nu
  Date:   2014-02-05 (Wed, 05 Feb 2014)

  Changed paths:
M modules/auth/auth_mod.c
M parser/digest/digest.c

  Log Message:
  ---
  digest+m_auth: Allow a domain in the digest username.

Before this patch, a domain in the digest username was allowed:

Digest username=abc@domain, realm=domain

but only if the domain is equal to the realm. This was introduced in
a92bf789 (Juha Heinanen, Mar. 29 2006).

The SIP spec. doesn't mention any such restriction.

This patch undoes that commit and makes sure the whole username is used
when authenticating through `pv_www_authorize` and `pv_proxy_authorize`.
That makes the following valid:

Digest username=abc@domain, realm=something different


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


[OpenSIPS-Devel] [OpenSIPS/opensips] 26044b: digest+m_auth: Allow a domain in the digest userna...

2014-02-18 Thread Walter Doekes
  Branch: refs/heads/1.10
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 26044bfee42c28d3d53516fbe54080a3a9420a87
  
https://github.com/OpenSIPS/opensips/commit/26044bfee42c28d3d53516fbe54080a3a9420a87
  Author: Walter Doekes walter+git...@wjd.nu
  Date:   2014-02-05 (Wed, 05 Feb 2014)

  Changed paths:
M modules/auth/auth_mod.c
M parser/digest/digest.c

  Log Message:
  ---
  digest+m_auth: Allow a domain in the digest username.

Before this patch, a domain in the digest username was allowed:

Digest username=abc@domain, realm=domain

but only if the domain is equal to the realm. This was introduced in
a92bf789 (Juha Heinanen, Mar. 29 2006).

The SIP spec. doesn't mention any such restriction.

This patch undoes that commit and makes sure the whole username is used
when authenticating through `pv_www_authorize` and `pv_proxy_authorize`.
That makes the following valid:

Digest username=abc@domain, realm=something different


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
 @@ -177,6 +180,7 @@
  {call_token_avp,  STR_PARAM, (call_token_avp.spec.s)},
  {prepaid_account_flag,STR_PARAM, prepaid_account_str},
  {prepaid_account_flag,INT_PARAM, prepaid_account_flag},
 +{sip_application_avp, STR_PARAM, (sip_application_avp.spec.s)},

Please move this before the flags, so that all avps are grouped together.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/170/files#r9851647___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
 @@ -640,6 +662,7 @@ struct module_exports exports = {
 prepaid: %s\r\n
 call_limit: %d\r\n
 call_token: %.*s\r\n
 +   application: %.*s\r\n

sip_application

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/170/files#r9851689___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
 @@ -406,6 +411,22 @@ struct module_exports exports = {
  return value.s;
  }
  
 +// Get SIP application type
 +static str
 +get_sip_application(struct sip_msg* msg)
 +{
 +int_str value;
 +
 +if (!search_first_avp(sip_application_avp.type | AVP_VAL_STR,
 +  sip_application_avp.name, value, NULL) ||
 +!value.s.s || value.s.len==0) {
 +
 +value.s.s = audio;

Lets use  as the default value. It's easy enough for anybody to set it in the 
config script.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/170/files#r9851713___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel