Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hi I have tested the new function added to the topology_hiding I added the following to the dialog settings in the opensips.cfg modparam(dialog, th_passed_contact_params, confid;+com.avistar.confapi.v1;isfocus) As you can see below in the contact the information is present Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. After the topology hiding you see that the confid has now been passed and is fine, but the SIP conferencing UA is still not working at it requires the last two params that have been sent Contact: sip:64.62.166.180;transport=tcp;did=481.0964f035;confid=3FD99511F9EB238C3FE825FF752847D1. According to the RFC4579 the isfocus is a valid param, could modify the fix to allow these other forms of params to be passed if the exist ie ;+com.avistar.confapi.v1;isfocus http://tools.ietf.org/html/rfc4579 Thanks Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-52598820___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 6580c7: dialog: fix possible hash id conflict on restart
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 6580c703ffcd61129603449faaacf3564fb39bcb https://github.com/OpenSIPS/opensips/commit/6580c703ffcd61129603449faaacf3564fb39bcb Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_replication.c Log Message: --- dialog: fix possible hash id conflict on restart When restarting the proxy, the auto-generated next_id of each hash entry is not properly incremented if a loaded dialog happens to have this same next_id as hash id. This will soon lead to duplicate hash ids. Reported by miko95 on GitHub. (cherry picked from commit b7c3686c176e7c15b806e50f9743ab91656a8da3) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 632d28: dialog: fix possible hash id conflict on restart
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: 632d286d6e207c7c2cc44f85138a791b9545bf10 https://github.com/OpenSIPS/opensips/commit/632d286d6e207c7c2cc44f85138a791b9545bf10 Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_replication.c Log Message: --- dialog: fix possible hash id conflict on restart When restarting the proxy, the auto-generated next_id of each hash entry is not properly incremented if a loaded dialog happens to have this same next_id as hash id. This will soon lead to duplicate hash ids. Reported by miko95 on GitHub. (cherry picked from commit b7c3686c176e7c15b806e50f9743ab91656a8da3) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 9d5caa: dialog: fix possible hash id conflict on restart
Branch: refs/heads/1.8 Home: https://github.com/OpenSIPS/opensips Commit: 9d5caa519968261e1a73abbff64103645ae9 https://github.com/OpenSIPS/opensips/commit/9d5caa519968261e1a73abbff64103645ae9 Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialog/dlg_db_handler.c Log Message: --- dialog: fix possible hash id conflict on restart When restarting the proxy, the auto-generated next_id of each hash entry is not properly incremented if a loaded dialog happens to have this same next_id as hash id. This will soon lead to duplicate hash ids. Reported by miko95 on GitHub. (cherry picked from commit b7c3686c176e7c15b806e50f9743ab91656a8da3) Conflicts: modules/dialog/dlg_replication.c ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Possible hash_entry, hash_id duplicate due to bad loading of dialogs at startup (#304)
Closed #304. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/304#event-154367176___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Possible hash_entry, hash_id duplicate due to bad loading of dialogs at startup (#304)
Fixed in b7c3686, backported to 1.11, 1.10 and 1.8! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/304#issuecomment-52608714___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] msg_translator: Passing MSG_TRANS_NOVIA_FLAG means don't touch Via. (#305)
Before this, if you passed the MSG_TRANS_NOVIA_FLAG flag to build_res_buf_from_sip_res, the msg-gt;via1-gt;next would get checked but not used. Now it#39;s not touched at all. You can merge this Pull Request by running: git pull https://github.com/wdoekes/opensips wjd-msg_trans_no_via-no_crash Or you can view, comment on it, or merge it online at: https://github.com/OpenSIPS/opensips/pull/305 -- Commit Summary -- * msg_translator: Passing MSG_TRANS_NOVIA_FLAG means don#39;t touch Via. -- File Changes -- M msg_translator.c (32) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/305.patch https://github.com/OpenSIPS/opensips/pull/305.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/305 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] dlg_id as primary key and single dialog table shared by multiple opensips instances (#306)
Hi, After the dialog table schema has been changed to replace the hash_entry and hash_id columns by the new dlg_id column, the dlg_id column is now the primary key of the table (while only an index - non UNIQUE - was defined before for the (hash_entry,hash_id) columns). With a configuration where multiple opensips instances share the same dialog table, I can imagine a case where multiple instances create dialogs with the same (hash_entry,hash_id) pair. The problem is that if one instance inserts a dialog with the coordinates (6,2) and that some time after another instance inserts a new dialog with the coordinates (6,2), the database will reject the INSERT statement since the dlg_id will be the same for both dialogs. Regards, Mickael --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/306___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] When building dialplan rule, the compiled matching regex is not free in case of error (#307)
--- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/307___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 60cc7e: dialplan: fix shm leak when parsing invalid regex
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 60cc7e1d03e94ad808994524588b635643960382 https://github.com/OpenSIPS/opensips/commit/60cc7e1d03e94ad808994524588b635643960382 Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialplan/dp_db.c Log Message: --- dialplan: fix shm leak when parsing invalid regex Upon (re)load, if the subst or repl columns contain expressions which fail to compile, OpenSIPS will leak shared memory. Reported by miko95 on GitHub Closes issue #307 (cherry picked from commit 72028d26bef361b6c99f6ad3653f0e1dbb07c767) (cherry picked from commit f57025fa90431ae080a91d54ae92564b919da52f) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] f57025: dialplan: fix shm leak when parsing invalid regex
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: f57025fa90431ae080a91d54ae92564b919da52f https://github.com/OpenSIPS/opensips/commit/f57025fa90431ae080a91d54ae92564b919da52f Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialplan/dp_db.c Log Message: --- dialplan: fix shm leak when parsing invalid regex Upon (re)load, if the subst or repl columns contain expressions which fail to compile, OpenSIPS will leak shared memory. Reported by miko95 on GitHub Closes issue #307 (cherry picked from commit 72028d26bef361b6c99f6ad3653f0e1dbb07c767) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] df1bff: dialplan: fix shm leak when parsing invalid regex
Branch: refs/heads/1.8 Home: https://github.com/OpenSIPS/opensips Commit: df1bff843452be132da2f74e3d9eb3a1b1f6f633 https://github.com/OpenSIPS/opensips/commit/df1bff843452be132da2f74e3d9eb3a1b1f6f633 Author: Liviu Chircu li...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialplan/dp_db.c Log Message: --- dialplan: fix shm leak when parsing invalid regex Upon (re)load, if the subst or repl columns contain expressions which fail to compile, OpenSIPS will leak shared memory. Reported by miko95 on GitHub Closes issue #307 (cherry picked from commit 72028d26bef361b6c99f6ad3653f0e1dbb07c767) (cherry picked from commit f57025fa90431ae080a91d54ae92564b919da52f) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] When building dialplan rule, the compiled matching regex is not free in case of error (#307)
Closed #307. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/307#event-154423005___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] When building dialplan rule, the compiled matching regex is not free in case of error (#307)
Fixed in 72028d26, backported to 1.11, 1.10 and 1.8. Many thanks for the report, miko! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/307#issuecomment-52623412___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] a16207: Properly propagate parameters with no value
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: a1620725c9a79904ce595de0fe6f703fada4d736 https://github.com/OpenSIPS/opensips/commit/a1620725c9a79904ce595de0fe6f703fada4d736 Author: Vlad Paiu vladp...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialog/dlg_tophiding.c Log Message: --- Properly propagate parameters with no value ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 526642: Removed INFO debug
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 5266427dd57c07afdcf7d539bbd0891baf3fb8d1 https://github.com/OpenSIPS/opensips/commit/5266427dd57c07afdcf7d539bbd0891baf3fb8d1 Author: Vlad Paiu vladp...@opensips.org Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M modules/dialog/dlg_tophiding.c Log Message: --- Removed INFO debug ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hello, Just tested now, and with a Contact header like Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. , no parameters are passed to the other side, since according to RFC 3261 If no and are present, all parameters after the URI are header parameters, not URI parameters The devel done was for the URI parameters, not the Contact header parameters... Best Regards, Vlad --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-52624244___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] Loading a db_text file with one unterminated line causes crash (#308)
If a database file only contains one line with the column type definitions, it is only parsed correctly (as an empty table) if the file ends with a newline. If not, loading the file crashes opensips. I looked at a gdb backtrace, but not investigated it any further. Program terminated with signal 11, Segmentation fault. #0 dbt_get_refs (_dtp=0x7f45d03655d8, _k=0x7fffbaf8f870, _n=6) at dbt_res.c:169 169 if(_k[i]-len==_dtp-colv[j]-name.len (gdb) bt #0 dbt_get_refs (_dtp=0x7f45d03655d8, _k=0x7fffbaf8f870, _n=6) at dbt_res.c:169 #1 0x7f45d39cd7a8 in dbt_query (_h=0x7f45d3fef940, _k=optimized out, _op=0x0, _v=0x0, _c=0x7fffbaf8f870, _n=0, _nc=6, _o=0x0, _r=0x7fffbaf8f8e0) at dbt_base.c:208 #2 0x7f45d26dd418 in ds_reload_db () from /usr/lib/opensips/modules/dispatcher.so #3 0x7f45d26df341 in ?? () from /usr/lib/opensips/modules/dispatcher.so #4 0x0046e411 in ?? () #5 0x0046e3a9 in ?? () #6 0x0042e702 in main () Using version 1.11. As a related issue: if a table has records, but the last record's line is unterminated, that record is silently ignored. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/308___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
