[OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Contact header parameters (#309)
Hi Guys After posting a responce to issue #301 is it posible to create a function as part of the topology_hiding to preserver the contact header parameters, the new function to pass a list of custom URI paramaters is working fine. But the contact headers are being stripped, and the UAC is unable to detect the fact its a conference room facility. Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. After topology_hiding and the preserving the URI params Contact: sip:64.62.166.180;transport=tcp;did=481.0964f035;confid=3FD99511F9EB238C3FE825FF752847D1. As you see ;+com.avistar.confapi.v1;isfocus. are lost in the hide topology. The param isfocus is used by all dial in video conference room services to control who had focus in the conference room. If we can add this feature it would be greatly appreacated. Thanks Craig (irc dexteruk) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/309___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] dlg_id of dialog to update not set before executing UPDATE (#310)
Hi,
In function update_dialog_dbinfo (see dlg_db_handler.c), the dlg_id is not set
before issuing the UPDATE statement. The type is set to DB_BIGINT using the
VAL_TYPE macro, but the value is not set.
} else if (cell-flags DLG_FLAG_VP_CHANGED) {
VAL_TYPE(values) = DB_BIGINT;
VAL_TYPE(values+20) = DB_INT;
VAL_TYPE(values+21) = DB_INT;
VAL_TYPE(values+18) = VAL_TYPE(values+19) = DB_STR;
/* lock the entry */
entry = (d_table-entries)[cell-h_entry];
dlg_lock( d_table, entry);
/* THIS LINE SHOULD BE ADDED */
SET_BIGINT_VALUE(values, (((long long)cell-h_entry 32) |
cell-h_id));
set_final_update_cols(values+18, cell, 0);
CON_PS_REFERENCE(dialog_db_handle) = my_ps_update_vp;
if((dialog_dbf.update(dialog_db_handle, (insert_keys), 0,
(values), (insert_keys+18),
(values+18), 1, 4)) !=0){
LM_ERR(could not update database info\n);
goto error;
}
run_dlg_callbacks( DLGCB_SAVED, cell, 0, DLG_DIR_NONE, 0);
cell-flags = ~DLG_FLAG_VP_CHANGED;
}
The issue will only affect users that have set db_mode to DB_REALTIME.
Regards,
Mickael
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/310___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] OpenSIPS Public Meetings
Hello, all! I would like to announce you that starting from this month, we are planning to organize a series of public meetings where we will be discussing hot topics related to the OpenSIPS project. The goal of the OpenSIPS Public Meetings[1] program is to speed up the process of identifying issues and tio provide better solutions that satisfy the needs of the entire OpenSIPS community. We are planning to do this by engaging both developers and users in live discussions about existing issues, implementation challenges, features, etc. When? We will organize a meeting on every last Wednesday of the month, at 18:00 UTC+2 Where? The meetings will take place on the #opensips channel[2] Who? Anywone is welcome to attend these discussions and contribute with ideas, solutions and feedback What? The topics of the discussions will change every month. You are encouraged to propose interesting topics to m...@opensips.org We hope this program will help us create a closer link between us, the developers, and the entire OpenSIPS community. And stay tuned! This month's Public Meeting will be announced soon! [1] http://www.opensips.org/Community/PublicMeetings [2] http://www.opensips.org/Support/Contact#toc2 Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
