Re: [OpenSIPS-Devel] [opensips] Allow TCP without transport=tcp header (#420)
@etamme, I was thinking of a function to use in script - set_preferred_proto(list). If you do not want any fallback, simply put one proto in the list :) . And if a function, this can be used in a more flexible way comparing with global params. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/420#issuecomment-77450030___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] core timer delay warnings on master (#421)
Hi @etamme - is there any chance to get access to that server for troubleshooting ? This will be the fastest way to get this solved. Thanks, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/421#issuecomment-77448493___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 8dfe15: json: set $json content to NULL if assignment fail...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 8dfe15e3ced61d959530bf25c3751d6707f1ed70 https://github.com/OpenSIPS/opensips/commit/8dfe15e3ced61d959530bf25c3751d6707f1ed70 Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M modules/json/json.c Log Message: --- json: set $json content to NULL if assignment fails This makes it possible to test for parsing errors if the $json variable was already populated (possibly even from other SIP requests!) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)
Closed #419. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/419#event-246611137___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)
Hi @jamesabravo , thanks for the fix. The NO_ZERO_CHECKS checks were dropped in 2.1 as they does not make too much of a sense anymore. So, I completely removed them from 1.11, 1.10 and 1.8 too. Thanks and regards, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77327291___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 843932: Remove NO_ZERO_CHECKS as it is bogus wuth bin cont...
Branch: refs/heads/1.8 Home: https://github.com/OpenSIPS/opensips Commit: 84393238d76972c34892a67f85fab8315e3cf343 https://github.com/OpenSIPS/opensips/commit/84393238d76972c34892a67f85fab8315e3cf343 Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M sctp_server.c M udp_server.c Log Message: --- Remove NO_ZERO_CHECKS as it is bogus wuth bin content. Reported by @jamesabravo on GH, closing #419 (cherry picked from commit 5daef76d3eb7848330b0b21c15163b58dcb985a5) Conflicts: bin_interface.c (cherry picked from commit b2f3658497946498aa804d07961f5ef69e6db781) Conflicts: bin_interface.c ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] b2f365: Remove NO_ZERO_CHECKS as it is bogus wuth bin cont...
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: b2f3658497946498aa804d07961f5ef69e6db781 https://github.com/OpenSIPS/opensips/commit/b2f3658497946498aa804d07961f5ef69e6db781 Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M bin_interface.c M sctp_server.c M udp_server.c Log Message: --- Remove NO_ZERO_CHECKS as it is bogus wuth bin content. Reported by @jamesabravo on GH, closing #419 (cherry picked from commit 5daef76d3eb7848330b0b21c15163b58dcb985a5) Conflicts: bin_interface.c ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)
Thanks. Are u sure about removing lines 377-383 in udp_server.c ? You probably know the code a lot better then be, I was just concerned that probing packets (usually 4 zero's) will upset things further ok? On Thu, Mar 5, 2015 at 8:49 AM, Bogdan Andrei IANCU notificati...@github.com wrote: Hi @jamesabravo https://github.com/jamesabravo , thanks for the fix. The NO_ZERO_CHECKS checks were dropped in 2.1 as they does not make too much of a sense anymore. So, I completely removed them from 1.11, 1.10 and 1.8 too. Thanks and regards, Bogdan — Reply to this email directly or view it on GitHub https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77327291. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77329105___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 5daef7: Remove NO_ZERO_CHECKS as it is bogus wuth bin cont...
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: 5daef76d3eb7848330b0b21c15163b58dcb985a5 https://github.com/OpenSIPS/opensips/commit/5daef76d3eb7848330b0b21c15163b58dcb985a5 Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M bin_interface.c M sctp_server.c M udp_server.c Log Message: --- Remove NO_ZERO_CHECKS as it is bogus wuth bin content. Reported by @jamesabravo on GH, closing #419 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] aeb351: Put back code accidentaly removed in prev commit.
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: aeb3519a577932e817f4f981c1d6fee0e2a7637e https://github.com/OpenSIPS/opensips/commit/aeb3519a577932e817f4f981c1d6fee0e2a7637e Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M udp_server.c Log Message: --- Put back code accidentaly removed in prev commit. (cherry picked from commit 96aca846c4f8b208088691bd43881c60d8ce1fe9) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 96aca8: Put back code accidentaly removed in prev commit.
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: 96aca846c4f8b208088691bd43881c60d8ce1fe9 https://github.com/OpenSIPS/opensips/commit/96aca846c4f8b208088691bd43881c60d8ce1fe9 Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M udp_server.c Log Message: --- Put back code accidentaly removed in prev commit. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 60d247: rest_post: allow the Content-Type parameter to be ...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 60d2473979d2a6a5e56ee5d87e48db67e6e1b877 https://github.com/OpenSIPS/opensips/commit/60d2473979d2a6a5e56ee5d87e48db67e6e1b877 Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M modules/rest_client/rest_client.c Log Message: --- rest_post: allow the Content-Type parameter to be NULL This makes libcurl use the default Content-Type for POST requests: application/x-www-form-urlencoded Commit: 8ae9f6042dd518aa1eb68417759f53b4eb2aab85 https://github.com/OpenSIPS/opensips/commit/8ae9f6042dd518aa1eb68417759f53b4eb2aab85 Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M modules/rest_client/README M modules/rest_client/doc/rest_client_admin.xml Log Message: --- rest_client: documentation update Compare: https://github.com/OpenSIPS/opensips/compare/08023112b8b3...8ae9f6042dd5___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] bb53e6: bin interface processing: add check for min length
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: bb53e6cb07d5bdc1e6eb2f8446fd54e393728c36 https://github.com/OpenSIPS/opensips/commit/bb53e6cb07d5bdc1e6eb2f8446fd54e393728c36 Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M bin_interface.c M bin_interface.h Log Message: --- bin interface processing: add check for min length (cherry picked from commit 4efeba5bafe482215ac8c42b8af92d4107bb94cc) Conflicts: bin_interface.c ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Allow TCP without transport=tcp header (#420)
Hi, let me explain first how things do work, and then we can see how to change :) - I agree that things may be simpler (for user understanding/usage) and may be improved. So, right now the outgoing protocol is determined based on next hop URI and the set network socket. What @oteren said is correct - the transport=TCP does not have anything to do with the received proto, but it indicates the proto to be used to reach that URI (so it is not about the inbound proto, but about outbound proto). OpenSIPS looks for the transport param in target URI to see if there is any special protocol requested for the next hop URI. This is correlated withe the protocol from the requested net socket (via force_send_socket) - if they conflict, the proto URI has priority; if one in NONE, the other one will win. No proto explicitly requested - UDP will be used. So, the outbound protocol can be right now controlled via the transport URI param (this actually makes that protocol a must and gives no fallback posibility) or via the used netowork interface ( you can do force_send_socket(tcp:.) - if the URI does not forces another proto, the socket proto will be used). I would say this force_send_socket() is closest to what you need (setting a preferred transport proto without messing with the sip message), but has no fallback to another proto. Maybe adding a new function like set_preferred_proto(tcp, tls) - this will set the outbound protocol if none is forced by the target URI (via the transport param). It will allow you to change the default (which now is hardcoded to UDP) and to have a fallback. If TCP is not available, TLS will be used (like in your case when the DNS based proto selection did not return anything usable). Looking forward for input and comments :) Regards, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/420#issuecomment-77351332___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 4efeba: bin interface processing: add check for min length
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 4efeba5bafe482215ac8c42b8af92d4107bb94cc https://github.com/OpenSIPS/opensips/commit/4efeba5bafe482215ac8c42b8af92d4107bb94cc Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M bin_interface.c M bin_interface.h Log Message: --- bin interface processing: add check for min length ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] add event support to presence module. (#423)
The event E_PRESENCE_PUBLISH will be triggered each time the presence module receives a PUBLISH The parameters of the event are: user::AOR domain::domain event::event_type expires::int_time_to_expire etag::etag_string body::string_with_xml_body_of_publish You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/423 -- Commit Summary -- * added event support to presence module. -- File Changes -- M modules/presence/presence.c (11) M modules/presence/publish.c (64) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/423.patch https://github.com/OpenSIPS/opensips/pull/423.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/423 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] xlog_buf_size and xlog_force_color are no longer documented anywhere (#422)
Updated *Global Parameter* and *Escape Sequences* sections all the way down to OpenSIPS 1.8. Thank you for reporting! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/422#issuecomment-77356587___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] xlog_buf_size and xlog_force_color are no longer documented anywhere (#422)
Closed #422. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/422#event-246728267___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 080231: Optimized TCP writing
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 08023112b8b3bbb9643dba27ff8d4f4f6448fc13 https://github.com/OpenSIPS/opensips/commit/08023112b8b3bbb9643dba27ff8d4f4f6448fc13 Author: Vlad Paiu vladp...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M io_wait.h M net/api_proto_net.h M net/net_tcp.c M net/net_tcp_proc.c M net/proto_tcp/proto_tcp.c M net/proto_tcp/tcp_common.h M net/tcp_conn_defs.h Log Message: --- Optimized TCP writing Do not try to aquire FD from main on TCP write in case the TCP connection is already polled on in the context of the current TCP worker ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] core timer delay warnings on master (#421)
@etamme, whatever the script is, you should not get such errors, especially without the traffic. Is that the only kind of warn you get from the timer subsystem ? Do you get that message in a consistent way or from time to time ? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/421#issuecomment-77335637___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)
You and be both. Take care On Thu, Mar 5, 2015 at 9:31 AM, Bogdan Andrei IANCU notificati...@github.com wrote: @jamesabravo https://github.com/jamesabravo you saved me !!! thank you !! my intention was to remove the define only, not the code inside of it.guess I need a coffee ;). Best Regards, Bogdan — Reply to this email directly or view it on GitHub https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77332662. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77334902___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] xlog_buf_size and xlog_force_color are no longer documented anywhere (#422)
Hi @rshpount - it seems they are not documented in the Global Parameter section. Thank you for the heads up, we will fixit asap. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/422#issuecomment-77336031___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] cb4667: Put back code accidentaly removed in prev commit.
Branch: refs/heads/1.8 Home: https://github.com/OpenSIPS/opensips Commit: cb466725126adffbef455e78345b4e6e07539e85 https://github.com/OpenSIPS/opensips/commit/cb466725126adffbef455e78345b4e6e07539e85 Author: Bogdan-Andrei Iancu bog...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M udp_server.c Log Message: --- Put back code accidentaly removed in prev commit. (cherry picked from commit 96aca846c4f8b208088691bd43881c60d8ce1fe9) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] add event support to presence module. (#423)
Can you also write documentation for this new event triggered? After that I will merge it in the master branch. Thanks, Răzvan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/423#issuecomment-77338654___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] core timer delay warnings on master (#421)
@bogdan-iancu the warnings happen all the time, but I can not see any particular interval to them. I did 'grep timer /var/log/opensips' and made a gist of the last 24 hours https://gist.github.com/etamme/a75198a5590c22bfa574 This box is litereally sitting idle - I have one UA that I am registering via TCP, but the warnings were occurring before I even enabled tcp. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/421#issuecomment-77372991___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Allow TCP without transport=tcp header (#420)
If there is a preference for UDP, and an SRV lookup is done with no result, I would still want to fall through and attempt a TCP SRV lookup. It seems like this SHOULD be the way things work. If there is a parameter to place preference on one protocol vs. the other I would still want the fall through behaviour should the preferred protocol not get any SRV result. If this fall through behaviour would be undesirable for speed purposes to some, then perhaps two parameters: proto_preference, [UDP|TCP|TLS] proto_fallthrough, [1|0] In this case all the existing mechanisms to previously determine the protocol would still be in place, and these parameters would only take effect in the case where an SRV lookup with an assumed protocol happens. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/420#issuecomment-77374361___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 960076: bin interface processing: add check for min length
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: 960076cfb3887542b76fa01159558629adfe668f https://github.com/OpenSIPS/opensips/commit/960076cfb3887542b76fa01159558629adfe668f Author: Liviu Chircu li...@opensips.org Date: 2015-03-05 (Thu, 05 Mar 2015) Changed paths: M bin_interface.c M bin_interface.h Log Message: --- bin interface processing: add check for min length (cherry picked from commit 4efeba5bafe482215ac8c42b8af92d4107bb94cc) Conflicts: bin_interface.c ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
