[OpenSIPS-Devel] [OpenSIPS/opensips] 7e1bde: tcp: drop CRLF TCP messages
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 7e1bded0fab67eb5a3174befc19710807d0b4a46 https://github.com/OpenSIPS/opensips/commit/7e1bded0fab67eb5a3174befc19710807d0b4a46 Author: Razvan Crainea raz...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M net/proto_tcp/tcp_common.h Log Message: --- tcp: drop CRLF TCP messages ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 5863cd: tcp: drop CRLF TCP messages
Branch: refs/heads/2.1 Home: https://github.com/OpenSIPS/opensips Commit: 5863cda406dff23134dfb4e45a49a409145851ee https://github.com/OpenSIPS/opensips/commit/5863cda406dff23134dfb4e45a49a409145851ee Author: Razvan Crainea raz...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M net/proto_tcp/tcp_common.h Log Message: --- tcp: drop CRLF TCP messages (cherry picked from commit 111df6804b5a58f26767674c30bed369dd0209ca) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Allow TCP without transport=tcp header (#420)
@olivermt , that is good news - I suggest closing this as bug and opening a feature request with the ability to specify multiple protos (for fallback). Is that ok ? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/420#issuecomment-91283835___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 7beddd: fixed buffer overflow check when query too big; fi...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 7bea2adbe700a1b7d896a0bcbf7cfd754821 https://github.com/OpenSIPS/opensips/commit/7bea2adbe700a1b7d896a0bcbf7cfd754821 Author: ionutrazvanionita ionution...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M modules/db_sqlite/dbase.c M modules/db_sqlite/row.c Log Message: --- fixed buffer overflow check when query too big; fixed null value return; query string/blob value is now copied into opensips pkg memory ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Added pike mi command for unblocking IP addresses (#456)
Merged #456. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/456#event-277306575___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Added pike mi command for unblocking IP addresses (#456)
Thank you !!! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/456#issuecomment-91271029___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Registrar: Add contact-based aliasing when the remote UA supports it. (#446)
Closed #446. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/446#event-277328795___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Registrar: Add contact-based aliasing when the remote UA supports it. (#446)
We had some long discussions about TCP and the aliasing ...here are some conclusions: 1) You have 2 types of entities involved: network level (ip:port) and SIP level (SIP uris). 2) in SIP, the next hop (upstream or downstream) can be different on network and SIP level: even if I received the INVITE from proxyA, because of RR (or missing RR from A), on SIP level, for sequential requests, I may talk to proxyB ; or during a registration via an edge proxy, the contact may still point to the end-point, but the TCP conn may come from the edge proxy. 3) the existing aliasing (for VIA) is done at network level: network info from VIA is aliased on the TCP conn (everything is network here) 4) what you did in USRLOC is a mixing (in terms of aliasing) of SIP (the contact URI) with net info (the TCP conn) - I understand it fixes your problem, but it is not the correct way to do it. Think about if end point registers via edge proxy (using mpath) - you will add to the tcp conn (to edge proxy) and alias with the port of the end-device :P. 5) I'm not sure if what you are trying to do is correct (as forcing the tcp conn re-usage) in your particular case: it is clear that the end point is aware of the 2 ports (the uac ephemeral one 3 and the uas listening one 5060) as it using 3 in VIA and 5060 in Contact. And this (for me) is an indication that the device explicitly wants to be contacted on 5060, otherwise it should use 3 too in the Contact URI. So you may try to fix something that is not broken :) (of course, considering non NAT scenarios) 6) still, there is another problem left, when opensips behaves as a proxy (and not as registrar) : A - proxy - B , where A and B are end points. If A use 3 in VIA (and net level) and contact 5060 (as in your case), proxy will create a new conn when routing a BYE from B to A (as B will use A's contact, with 5060 port). and if there is no registration involved (like doing presence), there will be alias between 3 and 5060.. Until we will come up with a complete and correct solution, we decided not to accept your patch because: - it is mixing the SIP and network levels (works only for particular cases) - it is bogus when there is an edge proxy with mpath between the uac and registrant - it is not complete (does not cover the case when doing routing without registration). We do not what to upload the temporary hack (which may prove into wrong direction) until there is a clear and complete solution. In the mean while, what I recommend you as workaround (that at least is consistent with not mixing the SIP and network level and has no drawback) - before save() use fix_nated_register(), see: http://www.opensips.org/html/docs/modules/1.11.x/nathelper.html#id294034 This will not change your message, but it will create a SIP aliase between the Contact URI and the outbound URI (where the Register came from): sip:ip:5060- sip:ip:3, so it should solve your problem. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/446#issuecomment-91278866___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Incoming TLS request gets outbound proto set to TLS (#452)
This issue is only occuring when there is a route header, an example route header from on of the UA experiencing the issue is: Route: sip:alpha.uphreak.com:5061;lr --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/452#issuecomment-91322883___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Incoming TLS request gets outbound proto set to TLS (#452)
Following some investigation, the difference in behaviour comes from the presence (or lack) of a pre-loaded Route header. This header points to a TLS interface, making opensips (while handling the preload route) to force a TLS send socket . According to #420, if no proto is dictated by RURI, the one from forced socket is used. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/452#issuecomment-91317097___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] baa342: added dbschema scripts and tables
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: baa342d0ce1ed80195058da4262aa370418bc03b https://github.com/OpenSIPS/opensips/commit/baa342d0ce1ed80195058da4262aa370418bc03b Author: ionutrazvanionita ionution...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M db/schema/Makefile A doc/dbschema/xsl/sqlite.xsl A scripts/opensipsctl.sqlite M scripts/opensipsdbctl A scripts/opensipsdbctl.sqlite A scripts/sqlite/acc-create.sql A scripts/sqlite/alias_db-create.sql A scripts/sqlite/auth_db-create.sql A scripts/sqlite/avpops-create.sql A scripts/sqlite/b2b-create.sql A scripts/sqlite/b2b_sca-create.sql A scripts/sqlite/cachedb_sql-create.sql A scripts/sqlite/call_center-create.sql A scripts/sqlite/carrierroute-create.sql A scripts/sqlite/closeddial-create.sql A scripts/sqlite/cpl-create.sql A scripts/sqlite/dialog-create.sql A scripts/sqlite/dialplan-create.sql A scripts/sqlite/dispatcher-create.sql A scripts/sqlite/domain-create.sql A scripts/sqlite/domainpolicy-create.sql A scripts/sqlite/drouting-create.sql A scripts/sqlite/fraud_detection-create.sql A scripts/sqlite/group-create.sql A scripts/sqlite/imc-create.sql A scripts/sqlite/load_balancer-create.sql A scripts/sqlite/msilo-create.sql A scripts/sqlite/permissions-create.sql A scripts/sqlite/presence-create.sql A scripts/sqlite/registrant-create.sql A scripts/sqlite/registrar-create.sql A scripts/sqlite/rls-create.sql A scripts/sqlite/rtpproxy-create.sql A scripts/sqlite/siptrace-create.sql A scripts/sqlite/speeddial-create.sql A scripts/sqlite/standard-create.sql A scripts/sqlite/uri_db-create.sql A scripts/sqlite/userblacklist-create.sql A scripts/sqlite/usrloc-create.sql Log Message: --- added dbschema scripts and tables ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 9dd26b: proto_ws: update doc to reflect WS client implemen...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 9dd26b84622e25ff285b336f974ad92bc51471ed https://github.com/OpenSIPS/opensips/commit/9dd26b84622e25ff285b336f974ad92bc51471ed Author: Răzvan Crainea raz...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M modules/proto_ws/README M modules/proto_ws/doc/proto_ws_admin.xml M modules/proto_ws/doc/proto_ws_faq.xml Log Message: --- proto_ws: update doc to reflect WS client implementation ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] d50630: Added pike mi command for unblocking IP addresses
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: d506309346b8beb402cc5a5bd64b84977a4e336f https://github.com/OpenSIPS/opensips/commit/d506309346b8beb402cc5a5bd64b84977a4e336f Author: Jarrod Baumann j...@rrod.org Date: 2015-04-08 (Wed, 08 Apr 2015) Changed paths: M modules/pike/pike.c M modules/pike/pike_mi.c M modules/pike/pike_mi.h Log Message: --- Added pike mi command for unblocking IP addresses Commit: 996c98967efc20611242884a064e521183cefe3b https://github.com/OpenSIPS/opensips/commit/996c98967efc20611242884a064e521183cefe3b Author: Jarrod Baumann j...@rrod.org Date: 2015-04-08 (Wed, 08 Apr 2015) Changed paths: M modules/pike/doc/pike_admin.xml Log Message: --- Added simple section to the pike_admin.xml docs detailing the command Commit: 3a37fa4b89a04530cf3125a713688603aaf5c81b https://github.com/OpenSIPS/opensips/commit/3a37fa4b89a04530cf3125a713688603aaf5c81b Author: Jarrod Baumann j...@rrod.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M modules/pike/pike_mi.c M modules/pike/pike_mi.h Log Message: --- updated logic to reset the block flags and counters instead of actually removing the node from the tree Commit: 0fed0483a286f1e6e7ca7f1d3028b5f836f133f4 https://github.com/OpenSIPS/opensips/commit/0fed0483a286f1e6e7ca7f1d3028b5f836f133f4 Author: Bogdan Andrei IANCU bog...@opensips.org Date: 2015-04-09 (Thu, 09 Apr 2015) Changed paths: M modules/pike/doc/pike_admin.xml M modules/pike/pike.c M modules/pike/pike_mi.c M modules/pike/pike_mi.h Log Message: --- Merge pull request #456 from jarrodb/pike_rm Added pike mi command for unblocking IP addresses Compare: https://github.com/OpenSIPS/opensips/compare/7e1bded0fab6...0fed0483a286___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Added pike mi command for unblocking IP addresses (#456)
This came up when I was doing some rollout to production with pike module. Some actual customers were getting pike blocked, and I wanted to unblock them. Jarrod decided to code it up after we talked about it. We ended up having to put an iptables rule in to drop the customer entirely, then remove it, then drop them, then remove it until we could get over the pike threshold. I think pike_rm should be that literal - this is not a soft unblock, it is when you want to remove the ip in the pike tree. If there was a soft unblock command, then I agree it would be better to reset counters etc. But for the situation where traffic has been blocked that you do not want blocked - I want to remove the ip from the tree. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/456#issuecomment-91241299___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Registrar: Add contact-based aliasing when the remote UA supports it. (#446)
@dsandras , please open a bug report on this matter, so we have it on the radar for fixing. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/446#issuecomment-91279243___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Added pike mi command for unblocking IP addresses (#456)
Shouldn't be a better approach to reset the red flag and the counters instead of actually removing the tree node? Thanks, bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/456#issuecomment-91239388___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Added pike mi command for unblocking IP addresses (#456)
Awesome! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/456#issuecomment-91231595___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
