[OpenSIPS-Devel] [OpenSIPS/opensips] b37734: stir_shaken: Add the `e164_max_length` parameter (...
Branch: refs/heads/3.2 Home: https://github.com/OpenSIPS/opensips Commit: b37734b1cfe3b2d47bdd20a67cbe3c4b0110e07d https://github.com/OpenSIPS/opensips/commit/b37734b1cfe3b2d47bdd20a67cbe3c4b0110e07d Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/doc/stir_shaken_admin.xml M modules/stir_shaken/stir_shaken.c M test/test_ut.c M ut.h Log Message: --- stir_shaken: Add the `e164_max_length` parameter (interop fix) This parameter allows the 15-digit number length restriction of the E.164 format to be bypassed. Especially useful in scenarios where various telephony number prefixes are in use, causing some numbers to exceed the standard maximum length. Credits to @Integration-IT for watching over the core issue and helping work towards the current solution! Fixes #3202 Fixes #3182 Fixes #3181 (cherry picked from commit 2e662357307a387020b9c16e465a9d093fd29a23) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] fd850c: stir_shaken: Add the `e164_max_length` parameter (...
Branch: refs/heads/3.3 Home: https://github.com/OpenSIPS/opensips Commit: fd850cc804d3e1090dcc8be49bf7c1b1a072f0e9 https://github.com/OpenSIPS/opensips/commit/fd850cc804d3e1090dcc8be49bf7c1b1a072f0e9 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/doc/stir_shaken_admin.xml M modules/stir_shaken/stir_shaken.c M test/test_ut.c M ut.h Log Message: --- stir_shaken: Add the `e164_max_length` parameter (interop fix) This parameter allows the 15-digit number length restriction of the E.164 format to be bypassed. Especially useful in scenarios where various telephony number prefixes are in use, causing some numbers to exceed the standard maximum length. Credits to @Integration-IT for watching over the core issue and helping work towards the current solution! Fixes #3202 Fixes #3182 Fixes #3181 (cherry picked from commit 2e662357307a387020b9c16e465a9d093fd29a23) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 24d817: stir_shaken VS: Improve several return codes
Branch: refs/heads/3.2 Home: https://github.com/OpenSIPS/opensips Commit: 24d8179f3fd75b90e44069399d0ab86c9f0f6b15 https://github.com/OpenSIPS/opensips/commit/24d8179f3fd75b90e44069399d0ab86c9f0f6b15 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken VS: Improve several return codes * on bad client-side signature length, return "438 Invalid Identity Header (bad signature)" vs. "500 Internal Server Error" (??) * on encountering expired certificates advertised by clients, return "438 Invalid Identity Header (cert validity)" vs. "403 Stale Date" (?!) * fix abs() related compiler warnings introduced earlier (cherry picked from commit e2977a4f49f1a164369c515bb7a79b5b436aeb31) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 5bdac5: stir_shaken VS: Improve several return codes
Branch: refs/heads/3.3 Home: https://github.com/OpenSIPS/opensips Commit: 5bdac5e58b54c5fb50edabd0c71aac3e2b9f531f https://github.com/OpenSIPS/opensips/commit/5bdac5e58b54c5fb50edabd0c71aac3e2b9f531f Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken VS: Improve several return codes * on bad client-side signature length, return "438 Invalid Identity Header (bad signature)" vs. "500 Internal Server Error" (??) * on encountering expired certificates advertised by clients, return "438 Invalid Identity Header (cert validity)" vs. "403 Stale Date" (?!) * fix abs() related compiler warnings introduced earlier (cherry picked from commit e2977a4f49f1a164369c515bb7a79b5b436aeb31) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 630ce8: stir_shaken VS: Improve several return codes
Branch: refs/heads/3.4 Home: https://github.com/OpenSIPS/opensips Commit: 630ce8abf9b7d1d31f715de7481f0cfabbccfd3b https://github.com/OpenSIPS/opensips/commit/630ce8abf9b7d1d31f715de7481f0cfabbccfd3b Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken VS: Improve several return codes * on bad client-side signature length, return "438 Invalid Identity Header (bad signature)" vs. "500 Internal Server Error" (??) * on encountering expired certificates advertised by clients, return "438 Invalid Identity Header (cert validity)" vs. "403 Stale Date" (?!) * fix abs() related compiler warnings introduced earlier (cherry picked from commit e2977a4f49f1a164369c515bb7a79b5b436aeb31) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] e2977a: stir_shaken VS: Improve several return codes
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: e2977a4f49f1a164369c515bb7a79b5b436aeb31 https://github.com/OpenSIPS/opensips/commit/e2977a4f49f1a164369c515bb7a79b5b436aeb31 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken VS: Improve several return codes * on bad client-side signature length, return "438 Invalid Identity Header (bad signature)" vs. "500 Internal Server Error" (??) * on encountering expired certificates advertised by clients, return "438 Invalid Identity Header (cert validity)" vs. "403 Stale Date" (?!) * fix abs() related compiler warnings introduced earlier ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 4a1cf8: stir_shaken: Fix detection for invalid "future Dat...
Branch: refs/heads/3.2 Home: https://github.com/OpenSIPS/opensips Commit: 4a1cf80dd5743d69572e1ef8d9b077ac926dd101 https://github.com/OpenSIPS/opensips/commit/4a1cf80dd5743d69572e1ef8d9b077ac926dd101 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken: Fix detection for invalid "future Date/iat" This patch fixes a bug where both the Date hf and the "iat" PASSporT claim could be filled in with a random timestamp value "in the future" and still bypass the OpenSIPS "freshness" integrity checks. Issue discovered during OpenSIPIt'03, thanks to Pavel Bussel & Maksym Sobolyev (Sippy Software) (cherry picked from commit 75a168a9f4315e59ba92bdcc2920639176e7f415) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 28bebc: stir_shaken: Fix detection for invalid "future Dat...
Branch: refs/heads/3.3 Home: https://github.com/OpenSIPS/opensips Commit: 28bebc7f258dba96941fa24869877efd7ff76073 https://github.com/OpenSIPS/opensips/commit/28bebc7f258dba96941fa24869877efd7ff76073 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken: Fix detection for invalid "future Date/iat" This patch fixes a bug where both the Date hf and the "iat" PASSporT claim could be filled in with a random timestamp value "in the future" and still bypass the OpenSIPS "freshness" integrity checks. Issue discovered during OpenSIPIt'03, thanks to Pavel Bussel & Maksym Sobolyev (Sippy Software) (cherry picked from commit 75a168a9f4315e59ba92bdcc2920639176e7f415) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] d3ff32: stir_shaken: Fix detection for invalid "future Dat...
Branch: refs/heads/3.4 Home: https://github.com/OpenSIPS/opensips Commit: d3ff3257033ea9d5305e4b68ef0b508b033bb357 https://github.com/OpenSIPS/opensips/commit/d3ff3257033ea9d5305e4b68ef0b508b033bb357 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken: Fix detection for invalid "future Date/iat" This patch fixes a bug where both the Date hf and the "iat" PASSporT claim could be filled in with a random timestamp value "in the future" and still bypass the OpenSIPS "freshness" integrity checks. Issue discovered during OpenSIPIt'03, thanks to Pavel Bussel & Maksym Sobolyev (Sippy Software) (cherry picked from commit 75a168a9f4315e59ba92bdcc2920639176e7f415) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 75a168: stir_shaken: Fix detection for invalid "future Dat...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 75a168a9f4315e59ba92bdcc2920639176e7f415 https://github.com/OpenSIPS/opensips/commit/75a168a9f4315e59ba92bdcc2920639176e7f415 Author: Liviu Chircu Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/stir_shaken/stir_shaken.c Log Message: --- stir_shaken: Fix detection for invalid "future Date/iat" This patch fixes a bug where both the Date hf and the "iat" PASSporT claim could be filled in with a random timestamp value "in the future" and still bypass the OpenSIPS "freshness" integrity checks. Issue discovered during OpenSIPIt'03, thanks to Pavel Bussel & Maksym Sobolyev (Sippy Software) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 54e7ed: [WIP] statistics: fix crash when creating a series...
Branch: refs/heads/3.2 Home: https://github.com/OpenSIPS/opensips Commit: 54e7edb159b7da664b5dc8b6632c7045ce5162d3 https://github.com/OpenSIPS/opensips/commit/54e7edb159b7da664b5dc8b6632c7045ce5162d3 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M statistics.c Log Message: --- [WIP] statistics: fix crash when creating a series stat Under normal circumstances, when a statistic is updated, we first search whether it exists, and if not, we add it to the statistics hash. However, due to the way it is implemented, searching and adding a statistic is not atomic, hence, with high concurrency, when adding a new statistic, we might already find an existing one there. In this case, the code tries to return that statistic in the `pvar` parameter - however, that parameter might be a (r/o) function, hence a crash happens. This commit fixes the crash. Close #3136 However, it returns 0, as if the statistic was properly added - the problem with this approach is that from the caller's perspective, we do not know whether the statistic was already there or not, to free the existing structure - hence this might result into a leak. We are still working on a solution for this. (cherry picked from commit 4640465215f131592326363bd0748d9f0e79f04d) ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 85b17a: siprec: fix memory leaking while setting the same ...
Branch: refs/heads/3.3 Home: https://github.com/OpenSIPS/opensips Commit: 85b17acad5569a1245d12c79b69cca3d0f2314ba https://github.com/OpenSIPS/opensips/commit/85b17acad5569a1245d12c79b69cca3d0f2314ba Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/siprec/siprec_var.c Log Message: --- siprec: fix memory leaking while setting the same field of siprec var Credits go to Rob Moore, Daniel Bryars and Steven Ayre from Dubber, as well as Liviu Chircu from the OpenSIPS team for working together to spot this leak. (cherry picked from commit 1dde47b524e4bb27e992ede2b15631eb12092537) Commit: 1c67f7b0c6c7e8696b18f9c25fd75b1cbd245ea1 https://github.com/OpenSIPS/opensips/commit/1c67f7b0c6c7e8696b18f9c25fd75b1cbd245ea1 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M statistics.c Log Message: --- [WIP] statistics: fix crash when creating a series stat Under normal circumstances, when a statistic is updated, we first search whether it exists, and if not, we add it to the statistics hash. However, due to the way it is implemented, searching and adding a statistic is not atomic, hence, with high concurrency, when adding a new statistic, we might already find an existing one there. In this case, the code tries to return that statistic in the `pvar` parameter - however, that parameter might be a (r/o) function, hence a crash happens. This commit fixes the crash. Close #3136 However, it returns 0, as if the statistic was properly added - the problem with this approach is that from the caller's perspective, we do not know whether the statistic was already there or not, to free the existing structure - hence this might result into a leak. We are still working on a solution for this. (cherry picked from commit 4640465215f131592326363bd0748d9f0e79f04d) Compare: https://github.com/OpenSIPS/opensips/compare/68216f868d17...1c67f7b0c6c7 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] ca968c: siprec: fix memory leaking while setting the same ...
Branch: refs/heads/3.4 Home: https://github.com/OpenSIPS/opensips Commit: ca968c21af1c9ea9f9f21480a93651ff9225e6d2 https://github.com/OpenSIPS/opensips/commit/ca968c21af1c9ea9f9f21480a93651ff9225e6d2 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/siprec/siprec_var.c Log Message: --- siprec: fix memory leaking while setting the same field of siprec var Credits go to Rob Moore, Daniel Bryars and Steven Ayre from Dubber, as well as Liviu Chircu from the OpenSIPS team for working together to spot this leak. (cherry picked from commit 1dde47b524e4bb27e992ede2b15631eb12092537) Commit: e031651215b35b73a0a0cb7c71a37689d76717d3 https://github.com/OpenSIPS/opensips/commit/e031651215b35b73a0a0cb7c71a37689d76717d3 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M statistics.c Log Message: --- [WIP] statistics: fix crash when creating a series stat Under normal circumstances, when a statistic is updated, we first search whether it exists, and if not, we add it to the statistics hash. However, due to the way it is implemented, searching and adding a statistic is not atomic, hence, with high concurrency, when adding a new statistic, we might already find an existing one there. In this case, the code tries to return that statistic in the `pvar` parameter - however, that parameter might be a (r/o) function, hence a crash happens. This commit fixes the crash. Close #3136 However, it returns 0, as if the statistic was properly added - the problem with this approach is that from the caller's perspective, we do not know whether the statistic was already there or not, to free the existing structure - hence this might result into a leak. We are still working on a solution for this. (cherry picked from commit 4640465215f131592326363bd0748d9f0e79f04d) Compare: https://github.com/OpenSIPS/opensips/compare/4993bf7b1799...e031651215b3 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [OpenSIPS/opensips] 1dde47: siprec: fix memory leaking while setting the same ...
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 1dde47b524e4bb27e992ede2b15631eb12092537 https://github.com/OpenSIPS/opensips/commit/1dde47b524e4bb27e992ede2b15631eb12092537 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M modules/siprec/siprec_var.c Log Message: --- siprec: fix memory leaking while setting the same field of siprec var Credits go to Rob Moore, Daniel Bryars and Steven Ayre from Dubber, as well as Liviu Chircu from the OpenSIPS team for working together to spot this leak. Commit: 41aa549a5f37fb09073fa8cb8e79f8673d40ae76 https://github.com/OpenSIPS/opensips/commit/41aa549a5f37fb09073fa8cb8e79f8673d40ae76 Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M main.c Log Message: --- main: avoid 'for' loop initial declarations in C98 This would break rpm build on CentOS 7 due to old compiler/standard Commit: 4640465215f131592326363bd0748d9f0e79f04d https://github.com/OpenSIPS/opensips/commit/4640465215f131592326363bd0748d9f0e79f04d Author: Razvan Crainea Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M statistics.c Log Message: --- [WIP] statistics: fix crash when creating a series stat Under normal circumstances, when a statistic is updated, we first search whether it exists, and if not, we add it to the statistics hash. However, due to the way it is implemented, searching and adding a statistic is not atomic, hence, with high concurrency, when adding a new statistic, we might already find an existing one there. In this case, the code tries to return that statistic in the `pvar` parameter - however, that parameter might be a (r/o) function, hence a crash happens. This commit fixes the crash. Close #3136 However, it returns 0, as if the statistic was properly added - the problem with this approach is that from the caller's perspective, we do not know whether the statistic was already there or not, to free the existing structure - hence this might result into a leak. We are still working on a solution for this. Compare: https://github.com/OpenSIPS/opensips/compare/75605d539311...4640465215f1 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
