[OpenSIPS-Devel] [ opensips-Patches-3600377 ] Allow avps as a parameters in rtpproxy
Patches item #3600377, was opened at 2013-01-11 03:22 Message generated for change (Settings changed) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Allow avps as a parameters in rtpproxy Initial Comment: This is a copy of an original commit from your nasty twin's Git repository. It allows rtpproxy_offer/rtpproxy_answer to accept variables. I'm using a generic functions - fixup_spve_null, fixup_spve_spve, so please review it. I suppose that no additional fixup_free function is required here, right? -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-17 07:46 Message: Hi Peter, Thanks for the patch - I had to do some changes as there was an error in your patch ; fixup_get_svalue() returns a STR value, while the params for force_rtp_proxy() are CHAR* . Simply doing str-s is not enough as that string is not null terminated. I made a fix on that, so please test my code and let me know if all cases do work as expected. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3600377 ] Allow avps as a parameters in rtpproxy
Patches item #3600377, was opened at 2013-01-11 03:22 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Allow avps as a parameters in rtpproxy Initial Comment: This is a copy of an original commit from your nasty twin's Git repository. It allows rtpproxy_offer/rtpproxy_answer to accept variables. I'm using a generic functions - fixup_spve_null, fixup_spve_spve, so please review it. I suppose that no additional fixup_free function is required here, right? -- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2013-01-17 07:46 Message: Hi Peter, Thanks for the patch - I had to do some changes as there was an error in your patch ; fixup_get_svalue() returns a STR value, while the params for force_rtp_proxy() are CHAR* . Simply doing str-s is not enough as that string is not null terminated. I made a fix on that, so please test my code and let me know if all cases do work as expected. Regards, Bogdan -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3600377 ] Allow avps as a parameters in rtpproxy
Patches item #3600377, was opened at 2013-01-11 03:22 Message generated for change (Tracker Item Submitted) made by peter_lemenkov You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Peter Lemenkov (peter_lemenkov) Assigned to: Nobody/Anonymous (nobody) Summary: Allow avps as a parameters in rtpproxy Initial Comment: This is a copy of an original commit from your nasty twin's Git repository. It allows rtpproxy_offer/rtpproxy_answer to accept variables. I'm using a generic functions - fixup_spve_null, fixup_spve_spve, so please review it. I suppose that no additional fixup_free function is required here, right? -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3600377group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel