Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)

2015-03-05 Thread Bogdan Andrei IANCU
Closed #419.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/419#event-246611137___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)

2015-03-05 Thread Bogdan Andrei IANCU
Hi @jamesabravo , thanks for the fix. The NO_ZERO_CHECKS checks were dropped in 
2.1 as they does not make too much of a sense anymore.
So, I completely removed them from 1.11, 1.10 and 1.8 too.

Thanks and regards,
Bogdan

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77327291___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)

2015-03-05 Thread jamesabravo
Thanks.

Are u sure about removing lines 377-383 in udp_server.c ? You probably know
the code a lot better then be, I was just concerned that probing packets
(usually 4 zero's) will upset things further ok?


On Thu, Mar 5, 2015 at 8:49 AM, Bogdan Andrei IANCU 
notificati...@github.com wrote:

 Hi @jamesabravo https://github.com/jamesabravo , thanks for the fix.
 The NO_ZERO_CHECKS checks were dropped in 2.1 as they does not make too
 much of a sense anymore.
 So, I completely removed them from 1.11, 1.10 and 1.8 too.

 Thanks and regards,
 Bogdan

 —
 Reply to this email directly or view it on GitHub
 https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77327291.



---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77329105___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSIPS-Devel] [opensips] Problems when receiving binary content using SCTP (#419)

2015-03-05 Thread jamesabravo
You and be both. Take care

On Thu, Mar 5, 2015 at 9:31 AM, Bogdan Andrei IANCU 
notificati...@github.com wrote:

 @jamesabravo https://github.com/jamesabravo you saved me !!! thank you
 !! my intention was to remove the define only, not the code inside of
 it.guess I need a coffee ;).

 Best Regards, Bogdan

 —
 Reply to this email directly or view it on GitHub
 https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77332662.



---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/419#issuecomment-77334902___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel