Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)
Closed #238. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/238#event-123410979___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)
Hi @nikbyte , there are couple of issues with this patch: 1) first, you assume the rtpproxy modules binds all the time to the dialog module; but this happens only if engage_rtpproxy() is used; so, the dialog api may not be available to you all the time; This can be fixed by trying to bind (with no error on failure) to dialog if autobridging is used. 2) you disregard the direction of the message relative to the call (as you take the info from the caller leg all the time) - this will fail if you have the reply to a re-INVITE from callee side ; This may be fixed by looking to the right leg (caller or callee) based on the in-dialog direction of the request. 3) the IP information you get from dialog is not what you need. Rtpproxy needs to the IP of the destination (of the reply) - the via2; but you extract from the dialog the IP of the opensips interface used for sending out the reply - unfortunately this cannot be fixed (as dialog module does not contain such information) I will close this patch - as the overall approach is wrong - and work out a similar fix but based on the TM module (instead of dialog) - I will send you a commit link in order to test. Thanks, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/238#issuecomment-43774720___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)
> } else {
> - LM_ERR("can't extract 2nd via
> found reply\n");
> + if (parse_headers(msg,
> HDR_VIA2_F, 0) != -1 &&
I like this syntax. It's easier to read.
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/238/files#r12897675___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)
> } else {
> - LM_ERR("can't extract 2nd via
> found reply\n");
> + if (parse_headers(msg,
> HDR_VIA2_F, 0) != -1 &&
Hi! I believe I did suggest moving this `if` into the `else` above, avoiding
unnecessary extra indentation.
TIA :)
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/238/files#r12897609___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)
RTPPROXY module: workaround to run rtpproxy when we use dialog topology hiding and thus we have not 2nd via in reply It fixes autobridging for rtpproxy when using topology hiding. The problem is reply doesn't have second via. We used this patch on production system about 7 months without any problems. You can merge this Pull Request by running: git pull https://github.com/nikbyte/nikbyte-opensips rtpproxy Or you can view, comment on it, or merge it online at: https://github.com/OpenSIPS/opensips/pull/238 -- Commit Summary -- * RTPPROXY module: workaround to run rtpproxy when we use dialog topology hiding and thus we have not 2nd via in reply -- File Changes -- M modules/rtpproxy/rtpproxy.c (22) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/238.patch https://github.com/OpenSIPS/opensips/pull/238.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/238 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
