Re: [OpenSIPS-Devel] [opensips] dialog: Update dlg lifetime whe re-evaluating the AVP after the callback... (#431)
Starting with 1.11, there is a different approach on updating the lifetime - the modules do access directly the dlg->lifetime to it (the AVP lifetime was dropped): - modules (for internal stuff) use the dlg->lifetime - script uses the dedicated script variable for lifetime. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/431#issuecomment-94406202___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] dialog: Update dlg lifetime whe re-evaluating the AVP after the callback... (#431)
No problem... What about 1.11 and master? (I did not check them) Le lundi 20 avril 2015 à 02:23 -0700, Bogdan Andrei IANCU a écrit : > Thank you @dsandras , I also updated 1.10 - it suffers from the same > problem. > > — > Reply to this email directly or view it on GitHub. > -- Damien Sandras --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/431#issuecomment-94405255___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] dialog: Update dlg lifetime whe re-evaluating the AVP after the callback... (#431)
Thank you @dsandras , I also updated 1.10 - it suffers from the same problem. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/431#issuecomment-94404859___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] dialog: Update dlg lifetime whe re-evaluating the AVP after the callback... (#431)
Merged #431. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/431#event-285043232___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [opensips] dialog: Update dlg lifetime whe re-evaluating the AVP after the callback... (#431)
This completes the previous commit. Without this fix, when the SST module is activated and the routines are activated with the appropriate setflag, the calls will be interrupted after the sst timeout even when there is no sst support at all from both peers. You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/431 -- Commit Summary -- * dialog: Update dlg lifetime whe re-evaluating the AVP after the callbacks. -- File Changes -- M modules/dialog/dlg_handlers.c (1) -- Patch Links -- https://github.com/OpenSIPS/opensips/pull/431.patch https://github.com/OpenSIPS/opensips/pull/431.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/431 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel