Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Closed #301. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#event-171355483___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hello, Great to hear that it's working fine. Since this is a new feature, it won't be backported to the already released 1.11 - it will only be part of the next OpenSIPS release. Best Regards, Vlad --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-57131680___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hi Vlad Ok, no problem any chance on getting a patch for 1.11 so we can apply it to our versions of 1.11 Thanks Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-57132509___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hi Vlad Forget the last message, i managed to create my own patch from the github changes. Once again thanks for your help on this one. Thanks Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-57150428___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hi Vlad I have tested this feature everything is working fine, i see no issues. Can we get this feature pushed to 1.11 LTS Thanks Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-56685696___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hello, See commit 02453d , added th_passed_contact_uri_params to be used for Contact URI params propagation, and th_passed_contact_params to be used for Contact Header params propagation. Please test and let me know how it goes. Best Regards, Vlad --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-55750030___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
OhhhI seethis explains a lot...I guess we need an additional param to do the same but for the header parameters. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-54954451___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Yes sorry about that in the editor on github it shows the but when you save it, it didnt display which caused the confussion. But yes if we can get this it would be fantastic. So we can pass both URI and Header params --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-55013985___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
@dexteruk , so actually you need this functionality for header params, not for URI params (for the Contact hdr), right ? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-54470147___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. Both, there is two sets of the params that are being passed which is the confid= and the params outside the ;+com.avistar.confapi.v1;isfocus. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-54479084___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Closed #301. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#event-160826836___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Is there any update on this? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-54366621___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Reopened #301. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#event-160829528___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Reopened #301. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#event-156473844___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
@dexteruk , as @vladpaiu pointed out, in your case, the Contact hdr as the brackets or not ? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-53181627___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hi I have tested the new function added to the topology_hiding I added the following to the dialog settings in the opensips.cfg modparam(dialog, th_passed_contact_params, confid;+com.avistar.confapi.v1;isfocus) As you can see below in the contact the information is present Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. After the topology hiding you see that the confid has now been passed and is fine, but the SIP conferencing UA is still not working at it requires the last two params that have been sent Contact: sip:64.62.166.180;transport=tcp;did=481.0964f035;confid=3FD99511F9EB238C3FE825FF752847D1. According to the RFC4579 the isfocus is a valid param, could modify the fix to allow these other forms of params to be passed if the exist ie ;+com.avistar.confapi.v1;isfocus http://tools.ietf.org/html/rfc4579 Thanks Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-52598820___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Hello, Just tested now, and with a Contact header like Contact: sip:108.60.100.184:5060;transport=tcp;confid=3FD99511F9EB238C3FE825FF752847D1;+com.avistar.confapi.v1;isfocus. , no parameters are passed to the other side, since according to RFC 3261 If no and are present, all parameters after the URI are header parameters, not URI parameters The devel done was for the URI parameters, not the Contact header parameters... Best Regards, Vlad --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-52624244___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
Closed #301. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#event-152468510___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Re: [OpenSIPS-Devel] [opensips] Topology_Hiding - Preserving Non-Transport Params (#301)
I will run the tests on this tomorrow and let you know how we got on with the MCU conferencing, Thanks for you help on this Vlad. Craig --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/301#issuecomment-52083869___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
