Re: [Devel] [RH7 PATCH 4/6] ploop: io_kaio support PLOOP_REQ_DEL_FLUSH

2016-06-23 Thread Maxim Patlasov 

On 06/23/2016 10:25 AM, Dmitry Monakhov wrote:

Currently noone tag preqs with such bit but let it be here for simmetry


I hate dead code (things that impossible to verify by any test). Can we 
add this "symmetry" check later, along with a patch for kaio setting 
this bit? (i.e.: kaio doesn't set it; ergo it must not check it)




Signed-off-by: Dmitry Monakhov 
---
  drivers/block/ploop/io_kaio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c
index bee2cee..5341fd5 100644
--- a/drivers/block/ploop/io_kaio.c
+++ b/drivers/block/ploop/io_kaio.c
@@ -73,6 +73,7 @@ static void kaio_complete_io_state(struct ploop_request * 
preq)
  
  	/* Convert requested fua to fsync */

if (test_and_clear_bit(PLOOP_REQ_FORCE_FUA, >state) ||
+   test_and_clear_bit(PLOOP_REQ_DEL_FLUSH, >state) ||
test_and_clear_bit(PLOOP_REQ_KAIO_FSYNC, >state))
post_fsync = 1;
  


___
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

[Devel] [RH7 PATCH 4/6] ploop: io_kaio support PLOOP_REQ_DEL_FLUSH

2016-06-23 Thread Dmitry Monakhov 
Currently noone tag preqs with such bit but let it be here for simmetry

Signed-off-by: Dmitry Monakhov 
---
 drivers/block/ploop/io_kaio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c
index bee2cee..5341fd5 100644
--- a/drivers/block/ploop/io_kaio.c
+++ b/drivers/block/ploop/io_kaio.c
@@ -73,6 +73,7 @@ static void kaio_complete_io_state(struct ploop_request * 
preq)
 
/* Convert requested fua to fsync */
if (test_and_clear_bit(PLOOP_REQ_FORCE_FUA, >state) ||
+   test_and_clear_bit(PLOOP_REQ_DEL_FLUSH, >state) ||
test_and_clear_bit(PLOOP_REQ_KAIO_FSYNC, >state))
post_fsync = 1;
 
-- 
1.8.3.1

___
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel