[ovirt-devel] Urgent BUG: renaming of template fails
Hi, this is my test setup: DC1 with local storage, some templates, e.g. template1 DC2 with local storage, some templates, e.g. template2 what I want to do: rename template2 to template1 in DC 2 actual results: [Cannot edit Template. The Template name is already in use, please choose a unique name and try again.] This fails via GUI and via REST api (GUI blocks the form, you can't click ok). expected results: Template Names should at the very least just be unique for one DC, and not for the whole engine. Strictly speaking even this is not needed as engine uses UUIDs to identify templates, but I agree that it might be handier for end users to just allow a template name once per datacenter. This occurs on ovirt-engine 3.3.3-2.el6 but I fear this is still present in current 3.5 RC and even master. So please, can somebody confirm this bug so I can open a BZ for this? Thanks. PS: the storage architecture type should not matter, I just added it for completeness sake. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Urgent BUG: renaming of template fails
BZ created: https://bugzilla.redhat.com/1130090 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Urgent BUG: renaming of template fails
Hi Sven, I tried changing template name on my setup (based on latest master) and it worked. Can you please share the output of the following psql command on your engine DB: SELECT vm_guid, vm_name, entity_type, description from vm_static where vm_name = 'template1' Can u also search this entity in oVirt using the following: Template:name = template* Regards, Maor - Original Message - From: Sven Kieske s.kie...@mittwald.de To: devel@ovirt.org Sent: Thursday, August 14, 2014 1:14:48 PM Subject: Re: [ovirt-devel] Urgent BUG: renaming of template fails BZ created: https://bugzilla.redhat.com/1130090 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Urgent BUG: renaming of template fails
Am 14.08.2014 13:12, schrieb Maor Lipchuk: Hi Sven, I tried changing template name on my setup (based on latest master) and it worked. Can you please share the output of the following psql command on your engine DB: SELECT vm_guid, vm_name, entity_type, description from vm_static where vm_name = 'template1' Hi Maor, it seems you did not test properly. You need 2 DCs with a template in each datacenter. rename one of them to match the other. It will fail, quoting Nir from my Bugzilla entry: This is how the system works. Changing is nice to have feature, as it does not effect much the usage of the system. We have the same issue with cluster names, vm names - most names are unique globally. I also find this annoying, and practically create names with dc-cluser prefixes to avoid this. I really don't understand the logic behind making these names unique on a global level. There are many easily thought use cases where you want the same template name in different DCs, now I will have to juggle with dc-prefixes. I really hope this gets fixed up for 3.6 Thanks for your fast replies anyway. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] popup dialog
- Original Message -
From: Leaboy wlblea...@126.com
To: Vojtech Szocs vsz...@redhat.com
Cc: devel@ovirt.org
Sent: Thursday, August 14, 2014 2:12:37 PM
Subject: Re: [ovirt-devel] popup dialog
Hi:
you said that ,I have done, and the dialog
Can display, and I can pass a parameter from dialog
To the backend executeCommand().
Now the question is, after executeCommand(),
Hou could I get the return value in the frontend.
For example, when I clicked backup button,
A dialog is display, now I type some parameters into
The dialog, click OK button, the backend executeCommand()
Do something, now, I need some value from executeCommand()
to frontend.
Sorry, I missed that your question was about executing backend
command (I thought you referred to Model.executeCommand) ...
Backup dialog's OK button is represented by:
UICommand tempVar = new UICommand(OnBackup, this);
When user clicks OK button, that ^^ UICommand is executed.
Model's executeCommand should route flow to some onBackup()
method, I assume you already did this:
// inside TemplateListModel#executeCommand
...
else if (OnBackup.equals(command.getName())) {
onBackup();
}
...
// inside TemplateListModel
private void onBackup() {
TemplateBackupModel windowModel = (TemplateBackupModel) getWindow();
// do nothing if windowModel is already doing something -or- if
// windowModel validation failed (i.e. bad/missing user input)
if (windowModel.getProgress() != null || !windowModel.validate()) {
return;
}
// this replaces dialog content UI with progress animated image
// to indicate that a call to backend is about to be initiated
windowModel.startProgress(null);
// on backend, assume you have TemplateBackupCommand that works
// with parameter type TemplateBackupParameters
TemplateBackupParameters params = new TemplateBackupParameters();
// update params according to window model
params.setFoo(windowModel.getFoo().getEntity());
// this is the async callback executed when backend command
// (TemplateBackupCommand in our case) has done its job
IFrontendActionAsyncCallback callback = new IFrontendActionAsyncCallback() {
@Override
public void executed(FrontendActionAsyncResult result) {
TemplateListModel listModel = (TemplateListModel) result.getState();
listModel.postOnBackup(result.getReturnValue());
}
};
// call backend
Frontend.getInstance().runAction(
VdcActionType.TemplateBackup, params, callback, this);
}
// still inside TemplateListModel
private void postOnBackup(VdcReturnValueBase returnValue) {
// at this point, backend has replied with returnValue,
// we can remove progress animated image in dialog
getWindow().stopProgress();
// if the backend operation was successful, close the
// dialog (otherwise the dialog will remain open)
if (returnValue != null returnValue.getSucceeded()) {
setWindow(null);
}
}
Regards,
Vojtech
在 8/14/14, 19:48， Vojtech Szocs vsz...@redhat.com 写入:
- Original Message -
From: Leaboy wlblea...@126.com
To: Vojtech Szocs vsz...@redhat.com
Cc: devel@ovirt.org
Sent: Thursday, August 14, 2014 6:19:17 AM
Subject: Re: [ovirt-devel] popup dialog
Hi,Vojtech Szocs:
Thanks for your help, I have let it work,
The Error I got just because I miss the step 3 you noted.
Another question is how could I got the returnValue after
executeCommand , and let the returnValue display on the oher
Popup dialog.
Please add this into MainTabTemplateView:
...
getTable().addActionButton(new
WebAdminButtonDefinitionVmTemplate(constants.templateBackup()) {
@Override
protected UICommand resolveCommand() {
return getMainModel().getTemplateBackupCommand();
}
});
...
This adds a button under Template main tab. When clicked, it executes
given command (getTemplateBackupCommand) on model (TemplateListModel).
Model's executeCommand() ensures that backup() method is called. Inside
backup() method, you call setWindow(model) which triggers an event - UI
infra handles this event and uses getModelPopup (see TemplateModule)
to resolve window model to GWTP PresenterWidget which is then revealed
as popup. This is how dialogs work in UiCommon / UI (GWTP) infra.
how could I got the returnValue after executeCommand
As I wrote above, executeCommand() just calls appropriate method (like
backup) on the list model. That method has no return value (void) since
it uses setWindow(model) to trigger event to notify UI infra to reveal
a dialog.
If you need to pass data to dialog, for example:
...
TemplateBackupModel model = new TemplateBackupModel();
setWindow(model);
... set window model's title, help tag, hash name ...
model.setSomeData(abc);
model.doSomething();
...
In other words, after you call setWindow(model) you
Re: [ovirt-devel] ovirt3.5 - deep dive - OVF on any domain + import existing data domain
Updated link: https://www.youtube.com/watch?v=71EuTct0wfc - Original Message - From: Barak Azulay bazu...@redhat.com To: Liron Aravot lara...@redhat.com, mlipc...@redhat.com, Allon Mureinik amure...@redhat.com, us...@ovirt.org, devel@ovirt.org Sent: Tuesday, August 12, 2014 5:44:53 PM Subject: ovirt3.5 - deep dive - OVF on any domain + import existing data domain The following meeting has been modified: Subject: ovirt3.5 - deep dive - OVF on any domain + import existing data domain Organizer: Barak Azulay bazu...@redhat.com Time: Thursday, August 14, 2014, 5:00:00 PM - 5:45:00 PM GMT +02:00 Jerusalem Invitees: lara...@redhat.com; mlipc...@redhat.com; amure...@redhat.com; us...@ovirt.org; devel@ovirt.org *~*~*~*~*~*~*~*~*~* Hangout link: https://plus.google.com/events/c7rkldonq80g14c9e3ob8as2kq8 Session description: The OVF on any domain feature introduces a change on the way the vm ovfs are being stored/backed up in oVirt. Currently all the ovfs are being stored on the master domain and are being updated asynchronously on a time basis by the OvfAutoUpdater, This feature purpose is to store the OVFs on all wanted domains to provide better recovery abillity, reduce the use of master_fs and the master domain and add capabillities to oVirt that will be used further on. The import data storage domain feature makes use of the OVF on any domain feature to import existing storage domain in order to be able to recover after the loss of the oVirt Engine's database and be able to move storage domain with vms/templates between setups. The talk will cover those two featuers and will provide deep dive into it's use and implementation. Wiki pages: http://www.ovirt.org/Feature/OvfOnAnyDomain http://www.ovirt.org/Features/ImportStorageDomain ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Management network as a role - design proposal
Hi All, The proposed feature will allow defining an arbitrary network in the DC as the management network for the cluster, which in its turn will allow assigning different VLANs for the management networks in the same DC. Feature page can be found here - http://www.ovirt.org/Features/Management_Network_As_A_Role . Please take a look into the page especially into Open issues section. I'd like to have your opinions on that. Best regards, Yevgeny Zaspitsky ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Management network as a role - design proposal
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: devel@ovirt.org Cc: rhevm-network-st...@redhat.com Sent: Thursday, August 14, 2014 6:52:41 PM Subject: [ovirt-devel] Management network as a role - design proposal Hi All, The proposed feature will allow defining an arbitrary network in the DC as the management network for the cluster, which in its turn will allow assigning different VLANs for the management networks in the same DC. Feature page can be found here - http://www.ovirt.org/Features/Management_Network_As_A_Role . Please take a look into the page especially into Open issues section. I'd like to have your opinions on that. Hi, is there no way on getting some default value in case you do not pass the network at RESTFul API? Best regards, Yevgeny Zaspitsky ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
