Re: [ovirt-devel] Master building issue
tsaban already fixed it and merged. On Sun, Dec 13, 2015 at 2:20 PM, Yaniv Bronheim wrote: > pep8 violation that was introduced by commit > 2a053f98a1cf1fb717b90b1900bf4c7b4318d254 > there you go - https://gerrit.ovirt.org/#/c/50383 > > On Sun, Dec 13, 2015 at 12:23 PM, Fred Rolland > wrote: > >> Hi , >> >> I have issues building the engine on master. >> >> The build finishes quick with this error : >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py:188:9: >> E301 expected 1 blank line, found 0 >> Makefile:316: recipe for target 'validations' failed >> >> >> Is there a fix for it ? >> >> Thanks, >> >> Fred >> >> ___ >> Devel mailing list >> Devel@ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > > > > -- > *Yaniv Bronhaim.* > > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Automation CI for vdsm
I like the idea but I have the same feelings as Francesco. I think that we need to make sure that functional tests for each vertical are stable before enabling this process. On Sun, Dec 13, 2015 at 8:34 AM, Eyal Edri wrote: > adding also infra team for visibility on the change in CI. > also inline. > > On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani > wrote: > >> - Original Message - >> > From: "Yaniv Bronheim" >> > To: devel@ovirt.org, "Francesco Romani" , "Nir >> Soffer" , "Piotr Kliczewski" >> > >> > Cc: "danken" , "David Caro" , >> "Eyal Edri" >> > Sent: Thursday, December 10, 2015 6:46:37 PM >> > Subject: Automation CI for vdsm >> >> [...] >> > We want to allow developers to trigger the script once reviews and >> > verification are ready (last step before merge). To do so we agreed to >> add >> > Continues Integration flag for each vdsm patch. > > > This flag will be called 'Workflow' or we can name it otherwise, we just > need to choose what makes sense. > David/Yaniv - Please correct me if I'm wrong. > > >> Once this flag will be >> > signed with +1 it will trigger Jenkins CI to run the check-merged script >> > (adding new button to gerrit is not an option - you can image that flag >> as >> > a trigger button), on success Jenkins CI flag will turn to +2. on fail >> > we'll get -1 and once new patchset is ready the developer will remove >> the >> > +1 and add it back to the Continues Integration flag to re-trigger the >> job. >> > >> > Please ack the process before we move on with that >> >> Sounds good, even though I'm a little scared (just gut feeling, no >> evidence >> whatsoever) that this could add even more complexity and fragility to the >> jenkins >> fleet. >> >> In the long run, when this is reliable, it will help greatly. >> In the short term, I'm scared because this can lead to false positives >> and bogus >> failures. >> >> Let me stress I don't have concrete item to share or specific flaws. >> >> As action item on me, I will find some time next week to check virt >> functional tests, >> to see if they need some fixes, work reliably and so forth >> >> > The patch for those scripts still under review and testing - >> > https://gerrit.ovirt.org/#/c/48268 >> >> Will review asap. >> >> -- >> Francesco Romani >> RedHat Engineering Virtualization R & D >> Phone: 8261328 >> IRC: fromani >> > > > > -- > Eyal Edri > Supervisor, RHEV CI > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Debian support for vdsm and subpackages
We currently manage debian packaging files under https://gerrit.ovirt.org/#/q/project:releng-tools instead of in the project itself. imo it makes it harder, as developer won't update the debian folder while changing spec parts , which makes much more observation work for Simone.. But if we keep to manage debian that way we should remove the debian folder from cpopen, vdsm, pthreading to avoid duplication. Simone can you explain more how you manage to flow code changes and update the debian support currently? should I indeed drop the current debian code that we have in vdsm? -- *Yaniv Bronhaim.* ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] AppErrors cleanup
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum). On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik wrote: > Hi all, > > A recent bug [1] reported as part of the translation effort alerted me to > the fact that we have a lot (and I mean a LOT - over 100 per file) of > deprecated, unused keys in the various AppErrors files that serve no > purpose and just take up space and waste translators time when they examine > them. > > To make a long story short - I've just merged a patch to remove all these > useless messages, and enforce via unit tests that EVERY key there should > have a corresponding constant in the EngineMessage or EngineError enums. > > Many thanks to my reviewers! > I know this was an tedious patch that couldn't have been too fun to review. > > > -Allon > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Master building issue
pep8 violation that was introduced by commit 2a053f98a1cf1fb717b90b1900bf4c7b4318d254 there you go - https://gerrit.ovirt.org/#/c/50383 On Sun, Dec 13, 2015 at 12:23 PM, Fred Rolland wrote: > Hi , > > I have issues building the engine on master. > > The build finishes quick with this error : > packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py:188:9: > E301 expected 1 blank line, found 0 > Makefile:316: recipe for target 'validations' failed > > > Is there a fix for it ? > > Thanks, > > Fred > > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > -- *Yaniv Bronhaim.* ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] suggestion to merge ovirt-engine unit-tests in master to standard ci
FYI, As part of moving all jobs to the standard ci [1], I'd like to propose to move the following into 'check-patch' and 'check-merged' : 1. unit tests 2. find-bugs Currently these run as separate jobs and not even yamelized. My only concern is populating junit & findbugs results into jenkins UI to enable reviewing the errors and continue to enforce logic from the original jobs, like '0' high/med/low bugs on find-bugs. Thoughts/Concerns? -- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ) ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Master building issue
Hi , I have issues building the engine on master. The build finishes quick with this error : packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py:188:9: E301 expected 1 blank line, found 0 Makefile:316: recipe for target 'validations' failed Is there a fix for it ? Thanks, Fred ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
