[ovirt-devel] Re: COPR: How add new project as ovirt-master-snapshots package

[Artur Socha]

Thanks Sandro!,
This PR is excellent.
About admin rights - not sure if I truly need them because there is only
one new project/package I need to configure(perhaps a 'builder' role would
be better for handling jsonrpc, keycloak or kubevirt client).
Of course I am happy to help and do it by myself once admin is granted
(even for just this single job or to stay as a backup in case 'primary'
admins are not available)
Artur

On Mon, Nov 29, 2021 at 3:29 PM Sandro Bonazzola 
wrote:

>
>
> Il giorno lun 29 nov 2021 alle ore 13:51 Artur Socha 
> ha scritto:
>
>> Hi Sandro,
>> (** I have included dev@ovirt in CC because the answer might be useful
>> to others as well **)
>>
>> I have created a new gerrit project / package 'ovirt-engine-keycloak' [1]
>> and I would like to somehow enable the COPR build.  I saw there is
>> 'ovirt-master-snapshot' [2] that has multiple packages configured ie.
>> vdsm-jsonrpc-java that I searched for reference.
>>
>> What is the process to add a new package there (ie. some patch
>> somewhere,  ticket or just pinging relevant people, any special setup in GH
>> repo besides .copr/Makefile)?
>>
>> [1] https://gerrit.ovirt.org/#/q/project:ovirt-engine-keycloak
>> [2]
>> https://copr.fedorainfracloud.org/coprs/ovirt/ovirt-master-snapshot/package/vdsm-jsonrpc-java/
>>
>>
>> thanks!
>>
>
> Hi, I documented the procedure here:
> https://github.com/oVirt/ovirt-site/pull/2644
> Please review. Let me know if you want to do it yourself and take admin
> responsibility on the project or if you prefer to just ask existing admins
> to handle it.
>
> @Lev Veyde  , @Sanja Bonic  can you
> please review as well?
>
> Thanks.
>
>
>
>
>
>> --
>> Artur Socha
>> Senior Software Engineer, RHV
>> Red Hat
>>
>
>
> --
>
> Sandro Bonazzola
>
> MANAGER, SOFTWARE ENGINEERING, EMEA R RHV
>
> Red Hat EMEA 
>
> sbona...@redhat.com
> 
>
> *Red Hat respects your work life balance. Therefore there is no need to
> answer this email out of your office hours.*
>
>
>

-- 
Artur Socha
Senior Software Engineer, RHV
Red Hat
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/2IZZ3OPBYT7LNHSE3Q5SZNLIPUU6VPW2/

[ovirt-devel] Re: COPR: How add new project as ovirt-master-snapshots package

[Sandro Bonazzola]

Il giorno lun 29 nov 2021 alle ore 13:51 Artur Socha  ha
scritto:

> Hi Sandro,
> (** I have included dev@ovirt in CC because the answer might be useful to
> others as well **)
>
> I have created a new gerrit project / package 'ovirt-engine-keycloak' [1]
> and I would like to somehow enable the COPR build.  I saw there is
> 'ovirt-master-snapshot' [2] that has multiple packages configured ie.
> vdsm-jsonrpc-java that I searched for reference.
>
> What is the process to add a new package there (ie. some patch somewhere,
> ticket or just pinging relevant people, any special setup in GH repo
> besides .copr/Makefile)?
>
> [1] https://gerrit.ovirt.org/#/q/project:ovirt-engine-keycloak
> [2]
> https://copr.fedorainfracloud.org/coprs/ovirt/ovirt-master-snapshot/package/vdsm-jsonrpc-java/
>
>
> thanks!
>

Hi, I documented the procedure here:
https://github.com/oVirt/ovirt-site/pull/2644
Please review. Let me know if you want to do it yourself and take admin
responsibility on the project or if you prefer to just ask existing admins
to handle it.

@Lev Veyde  , @Sanja Bonic  can you
please review as well?

Thanks.





> --
> Artur Socha
> Senior Software Engineer, RHV
> Red Hat
>


-- 

Sandro Bonazzola

MANAGER, SOFTWARE ENGINEERING, EMEA R RHV

Red Hat EMEA 

sbona...@redhat.com


*Red Hat respects your work life balance. Therefore there is no need to
answer this email out of your office hours.*
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/TMTWV454KS7PWAYBLJM43KARLTLXG2GF/

[ovirt-devel] Re: oVirt Dashpanel - see all open issues and PRs on GitHub

[Nir Soffer]

On Mon, Nov 29, 2021 at 3:12 PM Sanja Bonic  wrote:
>
> Hi everyone,
>
> In the ovirt-site repository, we now have an overview of all open issues and 
> PRs:
>
> https://github.com/oVirt/ovirt-site/blob/dashpanel/dashpanel-ovirt.md

Nice.

I think these changes are needed:

- Rename the strange "Dashpanel - oVirt" to "oVirt projects"

- Include all the projects in the list

- Link to every project entrypoint for contributing. I hope that all project
  will use github or gitlab soon, but for now most projects should link
  to gerrit.ovirt.org.

- The number of issues is not relevant for most projects since we don't
  use github issues, we really want to see the number of bugs from
  bugzilla.redhat.com.

> Archived and private repositories are excluded from this list. The .md is 
> linked from https://www.ovirt.org/community/ in the "Developers" section and 
> is updated automatically every day using GitHub Actions.

I think a better place for this content is here:
https://www.ovirt.org/develop/

This page has almost no useful content. Seeing the actual projects that
you can contribute to sounds useful.

Or include the top 10 active projects in /develop/ and link to the
full list.

Nir
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7EEVGGWJRWROWAUSJPD2TTUPIA4REUQO/

[ovirt-devel] oVirt Dashpanel - see all open issues and PRs on GitHub

[Sanja Bonic]

Hi everyone,

In the ovirt-site repository, we now have an overview of all open issues
and PRs:

https://github.com/oVirt/ovirt-site/blob/dashpanel/dashpanel-ovirt.md

Archived and private repositories are excluded from this list. The .md is
linked from https://www.ovirt.org/community/ in the "Developers" section
and is updated automatically every day using GitHub Actions.

If you have any questions or comments, please let us know.

Cheers,
Sanja
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/DRJYXJ5IEXIEF5M72MULQCLBIV47YZCE/

[ovirt-devel] COPR: How add new project as ovirt-master-snapshots package

[Artur Socha]

Hi Sandro,
(** I have included dev@ovirt in CC because the answer might be useful to
others as well **)

I have created a new gerrit project / package 'ovirt-engine-keycloak' [1]
and I would like to somehow enable the COPR build.  I saw there is
'ovirt-master-snapshot' [2] that has multiple packages configured ie.
vdsm-jsonrpc-java that I searched for reference.

What is the process to add a new package there (ie. some patch somewhere,
ticket or just pinging relevant people, any special setup in GH repo
besides .copr/Makefile)?

[1] https://gerrit.ovirt.org/#/q/project:ovirt-engine-keycloak
[2]
https://copr.fedorainfracloud.org/coprs/ovirt/ovirt-master-snapshot/package/vdsm-jsonrpc-java/


thanks!
-- 
Artur Socha
Senior Software Engineer, RHV
Red Hat
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/LZR63J5SAR5SRI53SLW6XQDFAQ6IYX3O/

[ovirt-devel] Re: Failed CI for engine patches - java-client-kubevirt otopi

[Shani Leviim]

Hi,
I'm currently still struggling with building the CI for my engine patches.
The latest update is that the jobs are starting but never finished so they
are getting aborted after ~10 hours/a day.

https://gerrit.ovirt.org/q/topic:%22copy-template-mbs-disk%22+(status:open%20OR%20status:merged)


*Regards,*

*Shani Leviim*


On Sun, Nov 28, 2021 at 11:47 AM Yedidyah Bar David  wrote:

> On Fri, Nov 26, 2021 at 11:36 AM Sandro Bonazzola 
> wrote:
>
>>
>>
>> Il giorno gio 25 nov 2021 alle ore 20:46 Ehud Yonasi 
>> ha scritto:
>>
>>> Indeed Martin, I can see it now.
>>> We have an issue reflecting the new resources server, probably dns or
>>> something related.
>>>
>>> Meanwhile Shani, I suggest that you change the resources server in your
>>> automation/*.repos file to:
>>> https://resources02.phx.ovirt.org/repos/ovirt/tested/master/rpm/el8
>>>
>>> We have someone already looking into it already and we hope CI will be
>>> fixed soon.
>>> Apologies.
>>>
>>
>> Please don't require any ovirt.org repository anymore in build roots of
>> any test or build job.
>> Either use CentOS Virt SIG repos or COPR repos.
>> We are dismissing ovirt-master-snapshot completely.
>>
>
> Do you have an example for a project already doing this?
>
> I now ran into a similar issue and pushed:
>
> https://gerrit.ovirt.org/c/ovirt-hosted-engine-setup/+/117827
>
> Before pushing it, I quickly skimmed through what-seems-like-relevant
> threads in my
> inbox and didn't find an existing example. Perhaps this is the wrong way
> to do this,
> and we should instead use github actions for check-patch. Was this
> discussed? Decided?
>
>
> Thanks and best regards,
>
>
>>
>>
>>
>>
>>>
>>> On 25 Nov 2021, at 18:03, Martin Perina  wrote:
>>>
>>>
>>>
>>> On Thu, Nov 25, 2021 at 2:04 PM Ehud Yonasi  wrote:
>>>
 So I am not sure where the dependency came from, but as I can see from
 otopi repo it is only realsing to ovirt-4.3 on resources at the moment.

>>>
>>> Not true, otopi is configured correctly:
>>>
>>> master -> ovirt-master
>>> https://github.com/oVirt/otopi/blob/master/.ovirtci.yaml
>>>
>>> otopi-1..9 -> ovirt-4.4
>>> https://github.com/oVirt/otopi/blob/otopi-1.9/.ovirtci.yaml
>>>
>>> Similar situation is with java-client-kubevirt, which should also be
>>> correctly setup:
>>>
>>> master -> ovirt-master, ovirt-4.4
>>> https://github.com/oVirt/java-client-kubevirt/blob/master/.stdci.yaml
>>>
>>> And I had to mention that similar situation we had for
>>> ovirt-jboss-modules-maven-plugin, which magically disappeared from tested
>>> repo cca 2 weeks ago and I needed to re-merge last patch to get the build
>>> there again. And also here everything seems correct to me:
>>>
>>>
>>> https://github.com/oVirt/ovirt-jboss-modules-maven-plugin/blob/master/automation.yaml
>>>
>>>
>>> All of those packages are included in oVirt project for quite long time,
>>> so the issue is somewhere in the Jenkins CI
>>>
>>>
 Maybe Sandro can help with that?

 On Thu, Nov 25, 2021 at 2:46 PM Shani Leviim 
 wrote:

> Hi Ehud,
> Honestly - I have no idea.
> This failure is from today, but in the patches, there is a series of
> CI failures while trying to build the patch - all failures while trying to
> build the engine.
>
>
> *Regards,*
>
> *Shani Leviim*
>
>
> On Thu, Nov 25, 2021 at 2:19 PM Ehud Yonasi 
> wrote:
>
>> Hi Shani and Artur,
>>
>> I didn't find otopi and that java-client-kubevirt package in the
>> repos listed inside the run. was it there in the first place?
>>
>> Artur, It seems the centos mirrors were not available during the time
>> of the build, could you please re-trigger it and update if it's working 
>> for
>> you now?
>>
>> Thanks,
>> Ehud.
>>
>> On Thu, Nov 25, 2021 at 1:28 PM Artur Socha 
>> wrote:
>>
>>> I could also add that I am currently having an issue with accessing
>>> Centos stream 8 AppStream repo (timed out). See [1] . Perhaps that 
>>> somehow
>>> related?
>>>
>>> [1]
>>> https://jenkins.ovirt.org/job/vdsm-jsonrpc-java_standard-check-patch/187/console
>>>
>>> Artur
>>>
>>> On Thu, Nov 25, 2021 at 11:50 AM Shani Leviim 
>>> wrote:
>>>
 Hi,
 I have a series of engine patches that keep failing although the
 chain is rebased on the latest master.
 I ran 'ci build' a couple of minutes ago and it failed with this
 one:
 11:08:45 No match for argument: otopi
 11:08:45 Error: Unable to find a match: java-client-kubevirt otopi

 https://jenkins.ovirt.org/job/ovirt-engine_standard-check-patch/15286/console

 The engine patches:

 https://gerrit.ovirt.org/q/topic:%22copy-template-mbs-disk%22+(status:open%20OR%20status:merged)

 Can someone assist, please?


 *Regards,*

 *Shani Leviim*

[ovirt-devel] Re: ovirt-engine dependency on ovirt-engine-extensions-api

[Sandro Bonazzola]

Il giorno lun 29 nov 2021 alle ore 08:45 Martin Perina 
ha scritto:

>
>
> On Mon, Nov 29, 2021 at 8:10 AM Sandro Bonazzola 
> wrote:
>
>>
>>
>> Il giorno lun 29 nov 2021 alle ore 08:02 Martin Perina <
>> mper...@redhat.com> ha scritto:
>>
>>>
>>>
>>> On Fri, Nov 26, 2021 at 6:39 PM Sandro Bonazzola 
>>> wrote:
>>>
 Hi,
 In ovirt-engine pom.xml there's a requirement for build time
 on ovirt-engine-extensions-api = 1.0.0.
 This dependency is available on maven central so online build works.

 Any clue on why we are not requiring 1.0.1
 
 instead ?

 We are packaging ovirt-engine-extensions-api during the development but
 it ships 1.0.2.SNAPSHOT so when building in offline mode (needed for
 building on CentOS Virt SIG) it fails as the 1.0.0 artifact was never
 downloaded.

 I can rebuild ovirt-engine-extensions-api from 1.0.0 or 1.0.1 which are
 available in maven central too as requiring explicitly 1.0.2.SNAPSHOT fails
 with:
 Failed to execute goal on project common-dependencies: Could not
 resolve dependencies for project
 org.ovirt.engine.core.manager:common-dependencies:jar:4.5.0-SNAPSHOT: The
 following artifacts could not be resolved:
 org.ovirt.engine.api:ovirt-engine-extensions-api:jar:1.0.2.SNAPSHOT,
 org.ovirt.java-client-kubevirt:java-client-kubevirt:jar:0.5.0,
 org.apache.sshd:sshd-common:jar:2.6.0, org.apache.sshd:sshd-core:jar:2.6.0,
 net.i2p.crypto:eddsa:jar:0.3.0,
 org.ovirt.engine.api:metamodel-server:jar:1.3.7,
 org.ovirt.vdsm-jsonrpc-java:vdsm-jsonrpc-java-client:jar:1.6.0,
 com.fasterxml.jackson.core:jackson-databind:jar:2.12.1,
 org.jboss.resteasy:resteasy-jaxrs:jar:3.9.3.Final,
 com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.12.1,
 org.apache.httpcomponents:httpclient:jar:4.5.13: Could not find artifact
 org.ovirt.engine.api:ovirt-engine-extensions-api:jar:1.0.2.SNAPSHOT ->
 [Help 1]

>>>
 Any recommendations on how to proceed?

>>>
>>> So in spec file we are requiring >= 1.0.0:
>>>
>>>
>>> https://github.com/oVirt/ovirt-engine/blob/master/ovirt-engine.spec.in#L440
>>>
>>> So it means that an RPM providing the necessary requirements should be
>>> installed.
>>>
>>
>> Yes, 1.0.2-SNAPSHOT from master is being installed *at runtime*.
>> But here we need it *at build time*.
>> So we need to add a BuildRequires line there.
>>
>>
>>> And AFAIK maven should detect we have ovirt-engine-extensions-api-1.0.z
>>> installed and it should use it for building. Or am I missing something?
>>>
>>
>> The issue is that pom file is requiring exactly 1.0.0 and not >= 1.0.0.
>> So if a different version is installed, it fails.
>>
>
> Well, I'm almost sure that xmvn is capable of using a newer version from
> RPM if the project requires an older version.
> For example mockito 3.12.4
>  requires junit 4.12
> and we have only 4.13
>  provided as an RPM.
> So isn't the problem in the SNAPSHOT version availability?
>

mmm I noticed I was using mvn --offline instead of xmvn --offline :-/ yes,
it should be only the SNAPSHOT version availability.


>
>
>>
>>
>>>
>>> I see that you built snapshot version on CBS:
>>>
>>> https://cbs.centos.org/koji/buildinfo?buildID=36134
>>>
>>> But wouldn't it be better to build the stable 1.0.1 release instead?
>>>
>>
>> Sure, I'll do. The build was a test to ensure CBS is able to build the
>> package.
>> I'll build 1.0.1 and then adjust the pom to require it instead of 1.0.0.
>>
>>
>>>
>>>
 --

 Sandro Bonazzola

 MANAGER, SOFTWARE ENGINEERING, EMEA R RHV

 Red Hat EMEA 

 sbona...@redhat.com
 

 *Red Hat respects your work life balance. Therefore there is no need to
 answer this email out of your office hours.*



>>>
>>> --
>>> Martin Perina
>>> Manager, Software Engineering
>>> Red Hat Czech s.r.o.
>>>
>>
>>
>> --
>>
>> Sandro Bonazzola
>>
>> MANAGER, SOFTWARE ENGINEERING, EMEA R RHV
>>
>> Red Hat EMEA 
>>
>> sbona...@redhat.com
>> 
>>
>> *Red Hat respects your work life balance. Therefore there is no need to
>> answer this email out of your office hours.*
>>
>>
>>
>
> --
> Martin Perina
> Manager, Software Engineering
> Red Hat Czech s.r.o.
>


-- 

Sandro Bonazzola

MANAGER, SOFTWARE ENGINEERING, EMEA R RHV

Red Hat EMEA 

sbona...@redhat.com


*Red Hat respects your work life balance. Therefore there is no need to
answer this email out of your office hours.*
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy