Re: [Devel] [Engine-devel] vds_dynamic refactor

2014-04-06 Thread Kobi Ianko
Joining in...
>From my point of view, in real life a user should have that many VDSs on one 
>Engine (from a DB point of view).
Modern DB system handles tables with millions of records and many relations, Do 
we really have a performance issue here?
We could prefer a more easy to maintain implantation in this case over DB 
performance


- Original Message -
> From: "Gilad Chaplik" 
> To: "Liran Zelkha" 
> Cc: de...@linode01.ovirt.org, "engine-devel" 
> Sent: Sunday, April 6, 2014 3:32:26 PM
> Subject: Re: [Devel] [Engine-devel] vds_dynamic refactor
> 
> - Original Message -
> > From: "Liran Zelkha" 
> > To: "Gilad Chaplik" 
> > Cc: "Itamar Heim" , de...@linode01.ovirt.org,
> > "engine-devel" 
> > Sent: Sunday, April 6, 2014 3:26:24 PM
> > Subject: Re: [Engine-devel] vds_dynamic refactor
> > 
> > On Sun, Apr 6, 2014 at 3:18 PM, Gilad Chaplik  wrote:
> > 
> > > - Original Message -
> > > > From: "Itamar Heim" 
> > > > To: "Liran Zelkha" 
> > > > Cc: "Gilad Chaplik" , de...@linode01.ovirt.org,
> > > "engine-devel" 
> > > > Sent: Sunday, April 6, 2014 11:33:12 AM
> > > > Subject: Re: [Engine-devel] vds_dynamic refactor
> > > >
> > > > On 04/06/2014 11:32 AM, Liran Zelkha wrote:
> > > > >
> > > > >
> > > > >
> > > > > On Sun, Apr 6, 2014 at 11:22 AM, Itamar Heim  > > > > > wrote:
> > > > >
> > > > > On 04/03/2014 07:51 PM, Liran Zelkha wrote:
> > > > >
> > > > > The problem is with both updates and selects.
> > > > > For selects - to get all the information for the VDS we have
> > > > > multiple
> > > > > joins. Adding another one will hurt performance even more.
> > > > > For updates - we have vds_static thats hardly changed.
> > > > > vds_statistics
> > > > > that changes all the time. vds_dynamic is not changed allot -
> > > but
> > > > > is
> > > > > updated all the time because of the status. I think it's best
> > > to
> > > > > split
> > > > > it to the two existing tables (BTW - relevant for VM as well)
> > > > >
> > > > >
> > > > > but we don't update it unless the status has changed, which is a
> > > > > rare occurance?
> > > > >
> > > > > Actually - no. We can definitely see times we are updating
> > > > > vds_dynamic
> > > > > with no reason at all. I tried to create patches for that - but it
> > > > > happens from many different places in the code.
> > > >
> > > > what would be updated vds_dyanmic for status not originating in update
> > > > run time info?
> > >
> > > We have separate DB flows for that (updateStatus and
> > > updatePartialVdsDynamicCalc and more in VdsDynamicDAODbFacadeImpl).
> > > A question: do you know if we update status in updateVdsDynamic? :-) not
> > > sure but I found a possible race for pending resources (cpu, mem), LOL
> > > :-)
> > >
> > > I think we do but not sure. Will check.
> 
> Of course it is, that was a rhetorical question :-) (a lot of emoticons and
> LOLs ;-))
> 
> > 
> > 
> > > Still holds my original thought for having vds_on_boot.
> > >
> > >
> > >
> > Let's talk f2f on Tuesday?
> 
> I'd prefer to reach conclusions here, I'd like everyone to be involved in a
> root issue like this one.
> 
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [Devel] Edit running vm feature

2014-04-09 Thread Kobi Ianko
[top posting]
To make things easier for the user we could enable the immediate fields while 
the VM is up, all other field could be disabled until the VM is down, since 
they will only apply in the next run (the user will need update them while the 
VM is down). 
This will be super easy for the user to understand, no need for warnings or 
other indications.

 

- Original Message -
> From: "Gilad Chaplik" 
> To: "Omer Frenkel" 
> Cc: devel@ovirt.org
> Sent: Wednesday, April 9, 2014 2:04:10 PM
> Subject: Re: [Devel] Edit running vm feature
> 
> - Original Message -
> > From: "Omer Frenkel" 
> > To: "Gilad Chaplik" 
> > Cc: "Scott Herold" , devel@ovirt.org
> > Sent: Wednesday, April 9, 2014 2:02:49 PM
> > Subject: Re: [Devel] Edit running vm feature
> > 
> > 
> > 
> > - Original Message -
> > > From: "Gilad Chaplik" 
> > > To: "Omer Frenkel" 
> > > Cc: "Scott Herold" , devel@ovirt.org
> > > Sent: Wednesday, April 9, 2014 1:54:35 PM
> > > Subject: Re: [Devel] Edit running vm feature
> > > 
> > > [top posting]
> > 
> > [why?]
> > 
> > > 
> > > 1) Is there a table of all the fields in the dialog, and the
> > > capabilities?
> > 
> > no
> 
> Can we have one?
> 
> > 
> > > 2) there are cases in which the user would like to decide (or maybe he
> > > doesn't have permissions to do it): i.e. hot-plug: immediate or next run;
> > > (future) pin 2 host, now (now = invoke migration), or next run.
> > > 
> > 
> > this is exactly why we have the dialog (there is a mockup in the wiki)
> > the dialog will specify the fields that the user can decide upon and let
> > him
> > choose.
> 
> Realized that post sending the email, sorry for missing that... :-/
> 
> > 
> > > 
> > > - Original Message -
> > > > From: "Omer Frenkel" 
> > > > To: "Scott Herold" 
> > > > Cc: devel@ovirt.org
> > > > Sent: Wednesday, April 9, 2014 10:15:11 AM
> > > > Subject: Re: [Devel] Edit running vm feature
> > > > 
> > > > 
> > > > 
> > > > - Original Message -
> > > > > From: "Scott Herold" 
> > > > > To: "Omer Frenkel" 
> > > > > Cc: devel@ovirt.org
> > > > > Sent: Tuesday, April 8, 2014 6:24:43 PM
> > > > > Subject: Re: [Devel] Edit running vm feature
> > > > > 
> > > > > 1) In the event some items can be applied immediately, while others
> > > > > require
> > > > > a
> > > > > restart, would it be possible to highlight not only the immediate
> > > > > items,
> > > > > but
> > > > > also state which items won't take affect immediately?
> > > > > 
> > > > 
> > > > the problem is that most fields won't take affect immediately,
> > > > so it can be a long list, so i preferred not to specify all in this
> > > > dialog.
> > > > 
> > > > > 2) On the restart action, is it a simple VM reboot, or does it need
> > > > > to
> > > > > be
> > > > > a
> > > > > cold boot for the changes? (ie: Power Off VM, Power On VM)
> > > > > 
> > > > 
> > > > it has to be cold boot, as engine need to send new configuration to
> > > > vdsm.
> > > > 
> > > > > - Original Message -
> > > > > > From: "Omer Frenkel" 
> > > > > > To: devel@ovirt.org
> > > > > > Sent: Tuesday, April 8, 2014 10:05:05 AM
> > > > > > Subject: [Devel] Edit running vm feature
> > > > > > 
> > > > > > Hi all,
> > > > > > 
> > > > > > Edit running vm feature is targeted to 3.5
> > > > > > The feature would allow editing a vm while it is running.
> > > > > > 
> > > > > > Please review the feature page and share your thoughts:
> > > > > > 
> > > > > > http://www.ovirt.org/Features/Edit_Running_VM
> > > > > > 
> > > > > > Thanks!
> > > > > > Omer.
> > > > > > ___
> > > > > > Devel mailing list
> > > > > > Devel@ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/devel
> > > > > > 
> > > > > 
> > > > ___
> > > > Devel mailing list
> > > > Devel@ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/devel
> > > > 
> > > 
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] vdsm - engine compatibility

2014-05-25 Thread Kobi Ianko
Hi, I got a VDSM of version 4.15 (latest I believe) and engine of 3.5
when trying to add the host to the cluster I'm getting:

Host 213 is installed with VDSM version (4.15) and cannot join cluster 33_new 
which is compatible with VDSM versions [4.13, 4.14, 4.9, 4.11, 4.12, 4.10]

Changing cluster version to 3.5/3.4/3.3 did not work,
how do I work around this?

10x, Kobi
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] vdsm - engine compatibility

2014-05-25 Thread Kobi Ianko
   'topology_change_detected': '0',
  'topology_change_timer': '0',
  'vlan_filtering': '0'},
 'ports': ['em1'],
 'stp': 'off'}}
clusterLevels = ['3.0', '3.1', '3.2', '3.3', '3.4']
cpuCores = '4'
cpuFlags = 
'fpu,vme,de,pse,tsc,msr,pae,mce,cx8,apic,sep,mtrr,pge,mca,cmov,pat,pse36,clflush,dts,acpi,mmx,fxsr,sse,sse2,ss,ht,tm,pbe,syscall,nx,rdtscp,lm,constant_tsc,arch_perfmon,pebs,bts,rep_good,nopl,xtopology,nonstop_tsc,aperfmperf,eagerfpu,pni,pclmulqdq,dtes64,monitor,ds_cpl,vmx,smx,est,tm2,ssse3,cx16,xtpr,pdcm,pcid,sse4_1,sse4_2,x2apic,popcnt,tsc_deadline_timer,aes,xsave,avx,f16c,rdrand,lahf_lm,ida,arat,epb,xsaveopt,pln,pts,dtherm,tpr_shadow,vnmi,flexpriority,ept,vpid,fsgsbase,smep,erms,model_Nehalem,model_Conroe,model_coreduo,model_core2duo,model_Penryn,model_Westmere,model_n270,model_SandyBridge'
cpuModel = 'Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz'
cpuSockets = '1'
cpuSpeed = '3808.000'
cpuThreads = '8'
emulatedMachines = ['pc',
'pc-q35-1.4',
'pc-q35-1.5',
'q35',
'isapc',
'pc-0.10',
'pc-0.11',
'pc-0.12',
'pc-0.13',
'pc-0.14',
'pc-0.15',
'pc-1.0',
'pc-1.1',
'pc-1.2',
'pc-1.3',
'pc-i440fx-1.4',
'pc-i440fx-1.5',
'none']
guestOverhead = '65'
hooks = {}
kvmEnabled = 'true'
lastClient = '10.35.4.213'
lastClientIface = 'ovirtmgmt'
management_ip = '0.0.0.0'
memSize = '15937'
netConfigDirty = 'False'
networks = {'ovirtmgmt': {'addr': '10.35.4.213',
  'bootproto4': 'dhcp',
  'bridged': True,
  'cfg': {'BOOTPROTO': 'dhcp',
  'DEFROUTE': 'yes',
  'DELAY': '0',
  'DEVICE': 'ovirtmgmt',
  'MTU': '1500',
  'NM_CONTROLLED': 'no',
  'ONBOOT': 'no',
  'STP': 'off',
  'TYPE': 'Bridge'},
  'gateway': '10.35.5.254',
  'iface': 'ovirtmgmt',
  'ipv6addrs': ['fe80::baca:3aff:fe7b:2859/64'],
  'ipv6gateway': '::',
  'mtu': '1500',
  'netmask': '255.255.254.0',
  'ports': ['em1'],
  'stp': 'off'}}
nics = {'em1': {'addr': '',
'cfg': {'BRIDGE': 'ovirtmgmt',
'DEVICE': 'em1',
'HWADDR': 'b8:ca:3a:7b:28:59',
'MTU': '1500',
    'NM_CONTROLLED': 'no',
'ONBOOT': 'no'},
'hwaddr': 'b8:ca:3a:7b:28:59',
'ipv6addrs': ['fe80::baca:3aff:fe7b:2859/64'],
'mtu': '1500',
'netmask': '',
'speed': 1000}}
numaNodeDistance = {'0': [10]}
numaNod

Re: [ovirt-devel] vdsm - engine compatibility

2014-05-25 Thread Kobi Ianko
will adding the 3.5 to /usr/share/vdsm/someLie.py fix it?

- Original Message -
> From: "Oved Ourfalli" 
> To: "Kobi Ianko" , "ybronhei" , "Dan 
> Kenigsberg" 
> Cc: devel@ovirt.org
> Sent: Sunday, May 25, 2014 11:37:10 AM
> Subject: Re: [ovirt-devel] vdsm - engine compatibility
> 
> I see two issues here:
> supportedENGINEs = ['3.0', '3.1', '3.2', '3.3', '3.4']
> 
> (you're using engine 3.5, that's why changing the cluster level didn't help
> you).
> 
> and:
> clusterLevels = ['3.0', '3.1', '3.2', '3.3', '3.4']
> 
> (even if the supported engines included 3.5, it would have failed on the
> clusterLevels, unless you work in one of the cluster levels above).
> 
> Dan/Yaniv - when will we update the fields above in VDSM?
> 
> Thanks,
> Oved
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "Oved Ourfalli" 
> > Cc: devel@ovirt.org
> > Sent: Sunday, May 25, 2014 11:32:47 AM
> > Subject: Re: [ovirt-devel] vdsm - engine compatibility
> > 
> > root@dhcp-4-213 kobitmp]# vdsClient -s 0 getVdsCaps
> > HBAInventory = {'FC': [], 'iSCSI': [{'InitiatorName':
> > 'iqn.1994-05.com.redhat:1e8f86fb343'}]}
> > ISCSIInitiatorName = 'iqn.1994-05.com.redhat:1e8f86fb343'
> > autoNumaBalancing = 2
> > bondings = {'bond0': {'addr': '',
> >   'cfg': {},
> >   'hwaddr': '0e:78:ef:77:84:c8',
> >   'ipv6addrs': [],
> >   'mtu': '1500',
> >   'netmask': '',
> >   'slaves': []}}
> > bridges = {'ovirtmgmt': {'addr': '10.35.4.213',
> >  'cfg': {'BOOTPROTO': 'dhcp',
> >  'DEFROUTE': 'yes',
> >  'DELAY': '0',
> >  'DEVICE': 'ovirtmgmt',
> >  'MTU': '1500',
> >  'NM_CONTROLLED': 'no',
> >  'ONBOOT': 'no',
> >  'STP': 'off',
> >  'TYPE': 'Bridge'},
> >  'gateway': '10.35.5.254',
> >  'ipv6addrs':
> >  ['fe80::baca:3aff:fe7b:2859/64'],
> >  'ipv6gateway': '::',
> >  'mtu': '1500',
> >  'netmask': '255.255.254.0',
> >  'opts': {'ageing_time': '3',
> >   'bridge_id': '8000.b8ca3a7b2859',
> >   'forward_delay': '0',
> >   'gc_timer': '16878',
> >   'group_addr': '1:80:c2:0:0:0',
> >   'group_fwd_mask': '0x0',
> >   'hash_elasticity': '4',
> >   'hash_max': '512',
> >   'hello_time': '200',
> >   'hello_timer': '150',
> >   'max_age': '2000',
> >   'multicast_last_member_count':
> >   '2',
> >   'multicast_last_member_interval':
> >   '100',
> >   '

Re: [ovirt-devel] vdsm - engine compatibility

2014-05-25 Thread Kobi Ianko
changed /usr/share/vdsm/dsaversion.py
solved the issue

10x Oved!!

- Original Message -
> From: "Kobi Ianko" 
> To: "Oved Ourfalli" 
> Cc: devel@ovirt.org
> Sent: Sunday, May 25, 2014 11:42:15 AM
> Subject: Re: [ovirt-devel] vdsm - engine compatibility
> 
> will adding the 3.5 to /usr/share/vdsm/someLie.py fix it?
> 
> - Original Message -
> > From: "Oved Ourfalli" 
> > To: "Kobi Ianko" , "ybronhei" , "Dan
> > Kenigsberg" 
> > Cc: devel@ovirt.org
> > Sent: Sunday, May 25, 2014 11:37:10 AM
> > Subject: Re: [ovirt-devel] vdsm - engine compatibility
> > 
> > I see two issues here:
> > supportedENGINEs = ['3.0', '3.1', '3.2', '3.3', '3.4']
> > 
> > (you're using engine 3.5, that's why changing the cluster level didn't help
> > you).
> > 
> > and:
> > clusterLevels = ['3.0', '3.1', '3.2', '3.3', '3.4']
> > 
> > (even if the supported engines included 3.5, it would have failed on the
> > clusterLevels, unless you work in one of the cluster levels above).
> > 
> > Dan/Yaniv - when will we update the fields above in VDSM?
> > 
> > Thanks,
> > Oved
> > 
> > - Original Message -
> > > From: "Kobi Ianko" 
> > > To: "Oved Ourfalli" 
> > > Cc: devel@ovirt.org
> > > Sent: Sunday, May 25, 2014 11:32:47 AM
> > > Subject: Re: [ovirt-devel] vdsm - engine compatibility
> > > 
> > > root@dhcp-4-213 kobitmp]# vdsClient -s 0 getVdsCaps
> > > HBAInventory = {'FC': [], 'iSCSI': [{'InitiatorName':
> > > 'iqn.1994-05.com.redhat:1e8f86fb343'}]}
> > > ISCSIInitiatorName = 'iqn.1994-05.com.redhat:1e8f86fb343'
> > > autoNumaBalancing = 2
> > > bondings = {'bond0': {'addr': '',
> > >   'cfg': {},
> > >   'hwaddr': '0e:78:ef:77:84:c8',
> > >   'ipv6addrs': [],
> > >   'mtu': '1500',
> > >   'netmask': '',
> > >   'slaves': []}}
> > > bridges = {'ovirtmgmt': {'addr': '10.35.4.213',
> > >  'cfg': {'BOOTPROTO': 'dhcp',
> > >  'DEFROUTE': 'yes',
> > >  'DELAY': '0',
> > >  'DEVICE': 'ovirtmgmt',
> > >  'MTU': '1500',
> > >  'NM_CONTROLLED': 'no',
> > >  'ONBOOT': 'no',
> > >  'STP': 'off',
> > >  'TYPE': 'Bridge'},
> > >  'gateway': '10.35.5.254',
> > >  'ipv6addrs':
> > >  ['fe80::baca:3aff:fe7b:2859/64'],
> > >  'ipv6gateway': '::',
> > >  'mtu': '1500',
> > >  'netmask': '255.255.254.0',
> > >  'opts': {'ageing_time': '3',
> > >   'bridge_id':
> > >   '8000.b8ca3a7b2859',
> > >   'forward_delay': '0',
> > >   'gc_timer': '16878',
> > >   'group_addr': '1:80:c2:0:0:0',
> > >   'group_fwd_mask': '0x0',
> > >   'hash_elasticity': '4',
> > >   '

[ovirt-devel] running VDSM local tests

2014-05-25 Thread Kobi Ianko
Hi,
One more question to go...
Trying to run the VDSM local tests:

tests]# ./run_tests_local.sh functional/momTests.py

  File "../tests/testrunner.py", line 30, in 
from vdsm import utils
  File "/root/vdsm/lib/vdsm/utils.py", line 58, in 
from .config import config
  ImportError: No module named config

Is it a known bug(on ver 4.15)? How can I work around it?

10x, Kobi
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] running VDSM local tests

2014-05-25 Thread Kobi Ianko


- Original Message -
> From: "Antoni Segura Puimedon" 
> To: "Kobi Ianko" 
> Sent: Sunday, May 25, 2014 4:12:39 PM
> Subject: Re: [ovirt-devel] running VDSM local tests
> 
> 
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: devel@ovirt.org
> > Sent: Sunday, May 25, 2014 12:39:59 PM
> > Subject: [ovirt-devel] running VDSM local tests
> > 
> > Hi,
> > One more question to go...
> > Trying to run the VDSM local tests:
> > 
> > tests]# ./run_tests_local.sh functional/momTests.py
> > 
> >   File "../tests/testrunner.py", line 30, in 
> > from vdsm import utils
> >   File "/root/vdsm/lib/vdsm/utils.py", line 58, in 
> > from .config import config
> >   ImportError: No module named config
> > 
> > Is it a known bug(on ver 4.15)? How can I work around it?
> 
> Did you first run ./autogen.sh --system && make from the root
> of the repository?
executing "make all" on vdsm root dir, after I installed the RPM fixed it

> 
> > 
> > 10x, Kobi
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] Error pushing to gerrit

2014-05-27 Thread Kobi Ianko
Hi All,
when I try to push a patch I get:

 ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by 
author/committer/uploader in commit message footer)
error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'


Although my patch is signed.

Does someone have any clue how to solve this?

10x, Kobi

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Error pushing to gerrit

2014-05-27 Thread Kobi Ianko


- Original Message -
> From: "David Caro" 
> To: "Kobi Ianko" 
> Cc: devel@ovirt.org
> Sent: Tuesday, May 27, 2014 6:25:22 PM
> Subject: Re: [ovirt-devel] Error pushing to gerrit
> 
> On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
> > Hi All,
> > when I try to push a patch I get:
> >
> >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> >  author/committer/uploader in commit message footer)
> > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> >
> >
> > Although my patch is signed.
> >
> > Does someone have any clue how to solve this?
> >
> > 10x, Kobi
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> 
> What does git log -1 show?

git log looks good: 

commit b5f56e86c64af232d3794a6f1534100a28615e77
Author: Kobi Ianko 
Date:   Tue May 13 19:00:08 2014 +0300

core: New internal command, VmSlaPolicyCommand

Adding a new command to handle the SLA parameters.
For now the new command only contains the CPU Limit parameter
which limits the VM's CPU consumption.

This Command will be called from the updateVmCommand, and 
updateMomPolicyCommand.
later on it will be called from other parts of the system that configures 
SLA parameters.

Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Kobi Ianko 

> 
> Probably the Signed-off-by header or it's not well places, or it's not
> signed by the committer/author/uploader. So you can try to amend the
> author, or the committer, or the header.
> 
> --
> David Caro
> 
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
> 
> Email: dc...@redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
> 
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Error pushing to gerrit

2014-05-27 Thread Kobi Ianko
yeap, also deleting the sign-by line and executing git commit --amend -s did 
not solve it

still same error...

- Original Message -
> From: "David Caro" 
> To: "Kobi Ianko" 
> Cc: devel@ovirt.org
> Sent: Tuesday, May 27, 2014 7:53:45 PM
> Subject: Re: [ovirt-devel] Error pushing to gerrit
> 
> On Tue 27 May 2014 05:39:28 PM CEST, Kobi Ianko wrote:
> >
> >
> > - Original Message -
> >> From: "David Caro" 
> >> To: "Kobi Ianko" 
> >> Cc: devel@ovirt.org
> >> Sent: Tuesday, May 27, 2014 6:25:22 PM
> >> Subject: Re: [ovirt-devel] Error pushing to gerrit
> >>
> >> On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
> >>> Hi All,
> >>> when I try to push a patch I get:
> >>>
> >>>  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> >>>  author/committer/uploader in commit message footer)
> >>> error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> >>>
> >>>
> >>> Although my patch is signed.
> >>>
> >>> Does someone have any clue how to solve this?
> >>>
> >>> 10x, Kobi
> >>>
> >>> ___
> >>> Devel mailing list
> >>> Devel@ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/devel
> >>
> >> What does git log -1 show?
> >
> > git log looks good:
> >
> > commit b5f56e86c64af232d3794a6f1534100a28615e77
> > Author: Kobi Ianko 
> > Date:   Tue May 13 19:00:08 2014 +0300
> >
> > core: New internal command, VmSlaPolicyCommand
> >
> > Adding a new command to handle the SLA parameters.
> > For now the new command only contains the CPU Limit parameter
> > which limits the VM's CPU consumption.
> >
> > This Command will be called from the updateVmCommand, and
> > updateMomPolicyCommand.
> > later on it will be called from other parts of the system that
> > configures SLA parameters.
> >
> > Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0
> > Bug-Url: https://bugzilla.redhat.com/1084930
> > Signed-off-by: Kobi Ianko 
> >
> >>
> >> Probably the Signed-off-by header or it's not well places, or it's not
> >> signed by the committer/author/uploader. So you can try to amend the
> >> author, or the committer, or the header.
> >>
> >> --
> >> David Caro
> >>
> >> Red Hat S.L.
> >> Continuous Integration Engineer - EMEA ENG Virtualization R&D
> >>
> >> Email: dc...@redhat.com
> >> Web: www.redhat.com
> >> RHT Global #: 82-62605
> >>
> >>
> >> ___
> >> Devel mailing list
> >> Devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/devel
> 
> Are you sure the are no extra spaces around the headers or extra
> newlines?
> 
> --
> David Caro
> 
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
> 
> Email: dc...@redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
> 
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] discussion: URI format for libvirt metadata

2014-05-27 Thread Kobi Ianko
Hi All,
In the upcoming changes we have decided to use the Metadata section of libvirt 
to store temporary data. (see 
http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMetadata)
For that the libvirt api forces us to specify a valid URI.

I have suggested using the following pattern: 
"http://ovirt.org/param/param_name";

pro: it's very simple and straightforward. 
con: it leads to nowhere and I don't think we should create a web reference for 
each param.

I would like to hear other suggestions from you all

10x, Kobi.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] discussion: URI format for libvirt metadata

2014-05-28 Thread Kobi Ianko

The URL that we will go with is "http://ovirt.org/vm/tune";.
The address is self explainable, it will contain vm tunable parameters and 
refer to a web page explaining the parameters.

10x.

> > - Forwarded Message -
> > > From: "Dan Kenigsberg" 
> > > To: "Kobi Ianko" 
> > > Cc: devel@ovirt.org
> > > Sent: Wednesday, May 28, 2014 2:16:43 AM
> > > Subject: Re: [ovirt-devel] discussion: URI format for libvirt metadata
> > > 
> > > On Tue, May 27, 2014 at 01:10:22PM -0400, Kobi Ianko wrote:
> > > > Hi All,
> > > > In the upcoming changes we have decided to use the Metadata section of
> > > > libvirt to store temporary data. (see
> > > > http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMetadata)
> > > > For that the libvirt api forces us to specify a valid URI.
> > > > 
> > > > I have suggested using the following pattern:
> > > > "http://ovirt.org/param/param_name";
> > > > 
> > > > pro: it's very simple and straightforward.
> > > > con: it leads to nowhere and I don't think we should create a web
> > > > reference
> > > > for each param.
> > > > 
> > > > I would like to hear other suggestions from you all
> > > 
> > > According to
> > > http://libvirt.org/html/libvirt-libvirt.html#virDomainSetMetadata
> > > """
> > >  ... VIR_DOMAIN_METADATA_ELEMENT @metadata must be well-formed XML
> > >  belonging
> > >  to namespace defined by @uri with local name @key.
> > > """
> > > so there is no doubt that we must have a properly-defined namespace on
> > > the
> > > URI.
> > > 
> > > Beyond that, lacking a wiki page explaining the the key, means that a
> > > reviewer knows nothing about what is this param, what are its valid
> > > values, or how oVirt is using it.
> > > 
> > > Nothing makes sure that no one else in oVirt decides to use the
> > > same param for something else.
> > > 
> > > It is important to explain that the params that you suggest are going to
> > > be used for communication beween Vdsm and MoM, and that this param is a
> > > vm-specific entity. http://ovirt.org/param/name seems like a parameter
> > > of ovirt at large, not the CPU of a particular VM.
> > > 
> > > Regards,
> > > Dan.
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > > 
> > 
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] discussion: URI format for libvirt metadata

2014-05-28 Thread Kobi Ianko


- Original Message -
> From: "Doron Fediuck" 
> To: "Kobi Ianko" 
> Cc: devel@ovirt.org
> Sent: Wednesday, May 28, 2014 3:06:44 PM
> Subject: Re: [ovirt-devel] discussion: URI format for libvirt metadata
> 
> for the sake of future updates, I suggest we use
> current suggestion with a version in the URI.
> 
> ie- http://ovirt.org/vm/tune/1.0
I prefer this one. 
> 
> Or even-
> http://ovirt.org/1.0/vm/tune
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: devel@ovirt.org
> > Cc: "Dan Kenigsberg" , "Doron Fediuck"
> > 
> > Sent: Wednesday, May 28, 2014 2:47:07 PM
> > Subject: Re: [ovirt-devel] discussion: URI format for libvirt metadata
> > 
> > 
> > The URL that we will go with is "http://ovirt.org/vm/tune";.
> > The address is self explainable, it will contain vm tunable parameters and
> > refer to a web page explaining the parameters.
> > 
> > 10x.
> > 
> > > > - Forwarded Message -
> > > > > From: "Dan Kenigsberg" 
> > > > > To: "Kobi Ianko" 
> > > > > Cc: devel@ovirt.org
> > > > > Sent: Wednesday, May 28, 2014 2:16:43 AM
> > > > > Subject: Re: [ovirt-devel] discussion: URI format for libvirt
> > > > > metadata
> > > > > 
> > > > > On Tue, May 27, 2014 at 01:10:22PM -0400, Kobi Ianko wrote:
> > > > > > Hi All,
> > > > > > In the upcoming changes we have decided to use the Metadata section
> > > > > > of
> > > > > > libvirt to store temporary data. (see
> > > > > > http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMetadata)
> > > > > > For that the libvirt api forces us to specify a valid URI.
> > > > > > 
> > > > > > I have suggested using the following pattern:
> > > > > > "http://ovirt.org/param/param_name";
> > > > > > 
> > > > > > pro: it's very simple and straightforward.
> > > > > > con: it leads to nowhere and I don't think we should create a web
> > > > > > reference
> > > > > > for each param.
> > > > > > 
> > > > > > I would like to hear other suggestions from you all
> > > > > 
> > > > > According to
> > > > > http://libvirt.org/html/libvirt-libvirt.html#virDomainSetMetadata
> > > > > """
> > > > >  ... VIR_DOMAIN_METADATA_ELEMENT @metadata must be well-formed XML
> > > > >  belonging
> > > > >  to namespace defined by @uri with local name @key.
> > > > > """
> > > > > so there is no doubt that we must have a properly-defined namespace
> > > > > on
> > > > > the
> > > > > URI.
> > > > > 
> > > > > Beyond that, lacking a wiki page explaining the the key, means that a
> > > > > reviewer knows nothing about what is this param, what are its valid
> > > > > values, or how oVirt is using it.
> > > > > 
> > > > > Nothing makes sure that no one else in oVirt decides to use the
> > > > > same param for something else.
> > > > > 
> > > > > It is important to explain that the params that you suggest are going
> > > > > to
> > > > > be used for communication beween Vdsm and MoM, and that this param is
> > > > > a
> > > > > vm-specific entity. http://ovirt.org/param/name seems like a
> > > > > parameter
> > > > > of ovirt at large, not the CPU of a particular VM.
> > > > > 
> > > > > Regards,
> > > > > Dan.
> > > > > ___
> > > > > Devel mailing list
> > > > > Devel@ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/devel
> > > > > 
> > > > 
> > > 
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Karma request: mom-0.4.1-1

2014-06-18 Thread Kobi Ianko
I've been testing on fc20

- Original Message -
> From: "Adam Litke" 
> To: "Kobi Ianko" , "Martin Sivak" 
> Cc: dan...@redhat.com, devel@ovirt.org, "Nir Soffer" , 
> "Doron Fediuck" 
> Sent: Wednesday, June 18, 2014 10:27:48 PM
> Subject: Karma request: mom-0.4.1-1
> 
> Hi Kobi, Martin, et al.
> 
> I've included the necessary changes for oVirt-3.5 into a new mom
> update (0.4.1) for fc19, fc20, and el6.  Could you please try out
> these builds (especially fc20 and fc19) and give me some karma to
> fast-track them into updates?  Thanks!
> 
> https://admin.fedoraproject.org/updates/mom-0.4.1-1.fc19
> https://admin.fedoraproject.org/updates/mom-0.4.1-1.fc20
> https://admin.fedoraproject.org/updates/mom-0.4.1-1.el6
> 
> --
> Adam Litke
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] Testing backported changes

2014-06-23 Thread Kobi Ianko
Hi,
Is there a nice way to check changes I backported to 3.4.1 without messing my 
3.5 DB?

10x
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] Problem installing a new DB

2014-07-08 Thread Kobi Ianko
Did any of you encountered this problem?

$ $HOME/ovirt-engine/bin/engine-setup
***L:ERROR Internal error: type object 'Stages' has no attribute 
'DB_CONNECTION_SETUP'

Do you know how to work around it/fix it?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Problem installing a new DB

2014-07-08 Thread Kobi Ianko
running with debug show this message:
***L:ERROR Internal error: type object 'Stages' has no attribute 
'DB_CONNECTION_SETUP'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/__main__.py", line 94, in main
installer.execute()
  File "/usr/lib/python2.7/site-packages/otopi/main.py", line 159, in execute
sys.exc_info()[2],
  File "/usr/lib/python2.7/site-packages/otopi/util.py", line 93, in 
raiseExceptionInformation
exec('raise info[1], None, info[2]')
  File "/usr/lib/python2.7/site-packages/otopi/main.py", line 153, in execute
self.context.loadPlugins()
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 497, in 
loadPlugins
self._loadPluginGroups(plugindir, needgroups, loadedgroups)
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 123, in 
_loadPluginGroups
self._loadPlugins(path, path, groupname)
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 80, in 
_loadPlugins
self._loadPlugins(base, d, groupname)
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 80, in 
_loadPlugins
self._loadPlugins(base, d, groupname)
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 111, in 
_loadPlugins
os.path.basename(path),
  File "/usr/lib/python2.7/site-packages/otopi/util.py", line 117, in loadModule
mod_desc
  File 
"/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/__init__.py",
 line 25, in 
from . import connection
  File 
"/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/connection.py",
 line 39, in 
class Plugin(plugin.PluginBase):
  File 
"/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/connection.py",
 line 104, in Plugin
name=osetupcons.Stages.DB_CONNECTION_SETUP,
PluginLoadException: type object 'Stages' has no attribute 'DB_CONNECTION_SETUP'


- Original Message -
> From: "Simone Tiraboschi" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Tuesday, July 8, 2014 1:57:44 PM
> Subject: Re: [ovirt-devel] Problem installing a new DB
> 
> Can you please run
> OTOPI_DEBUG=1 $HOME/ovirt-engine/bin/engine-setup
> 
> thanks,
> Simone
> 
> - Original Message -
> From: "plysan" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Tuesday, July 8, 2014 12:54:05 PM
> Subject: Re: [ovirt-devel] Problem installing a new DB
> 
> Hi Kobi:
> 
> Maybe your installed otopi version is not the version that ovirt-engine.spec
> declares.
> 
> thanks!
> 
> 
> 2014-07-08 18:48 GMT+08:00 Kobi Ianko < k...@redhat.com > :
> 
> 
> Did any of you encountered this problem?
> 
> $ $HOME/ovirt-engine/bin/engine-setup
> ***L:ERROR Internal error: type object 'Stages' has no attribute
> 'DB_CONNECTION_SETUP'
> 
> Do you know how to work around it/fix it?
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Problem installing a new DB

2014-07-08 Thread Kobi Ianko


- Original Message -
> From: "Yedidyah Bar David" 
> To: "Simone Tiraboschi" 
> Cc: "Kobi Ianko" , "engine-de...@ovirt.org" 
> Sent: Tuesday, July 8, 2014 2:05:05 PM
> Subject: Re: [ovirt-devel] Problem installing a new DB
> 
> - Original Message -
> > From: "Simone Tiraboschi" 
> > To: "Kobi Ianko" 
> > Cc: "engine-de...@ovirt.org" 
> > Sent: Tuesday, July 8, 2014 1:57:44 PM
> > Subject: Re: [ovirt-devel] Problem installing a new DB
> > 
> > Can you please run
> > OTOPI_DEBUG=1 $HOME/ovirt-engine/bin/engine-setup
> > 
> > thanks,
> > Simone
> > 
> > - Original Message -
> > From: "plysan" 
> > To: "Kobi Ianko" 
> > Cc: "engine-de...@ovirt.org" 
> > Sent: Tuesday, July 8, 2014 12:54:05 PM
> > Subject: Re: [ovirt-devel] Problem installing a new DB
> > 
> > Hi Kobi:
> > 
> > Maybe your installed otopi version is not the version that
> > ovirt-engine.spec
> > declares.
> > 
> > thanks!
> > 
> > 
> > 2014-07-08 18:48 GMT+08:00 Kobi Ianko < k...@redhat.com > :
> > 
> > 
> > Did any of you encountered this problem?
> > 
> > $ $HOME/ovirt-engine/bin/engine-setup
> > ***L:ERROR Internal error: type object 'Stages' has no attribute
> > 'DB_CONNECTION_SETUP'
> > 
> > Do you know how to work around it/fix it?
> 
> Was probably fixed recently - you can try latest master. what version do you
> use?

fetch and rebase did not solve it
> If 3.5.0 beta, reports setup was broken there. If you do not want that,
> remove the
> package ovirt-engine-reports-setup. Perhaps dwh too.
I don't have a package named ovirt-engine-reports-setup according to yum
> --
> Didi
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Problem installing a new DB

2014-07-08 Thread Kobi Ianko


- Original Message -
> From: "plysan" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Tuesday, July 8, 2014 2:23:33 PM
> Subject: Re: [ovirt-devel] Problem installing a new DB
> 
> could you put your output of
> 
> cat $OVIRT_GIT_REPO/ovirt-engine.spec |grep otopi
what is the OVIRT_GIT_REPO?
> 
> and
> 
> rpm -qa |grep otopi
[kianku@kobi-lap ovirt-engine]$ rpm -qa | grep otopi
otopi-java-1.2.0-0.2.master.20140121.git84f0852.fc19.noarch
otopi-1.2.0-0.2.master.20140121.git84f0852.fc19.noarch

> 
> thanks.
> 
> 
> 2014-07-08 19:15 GMT+08:00 Kobi Ianko :
> 
> >
> >
> > - Original Message -
> > > From: "Yedidyah Bar David" 
> > > To: "Simone Tiraboschi" 
> > > Cc: "Kobi Ianko" , "engine-de...@ovirt.org" <
> > devel@ovirt.org>
> > > Sent: Tuesday, July 8, 2014 2:05:05 PM
> > > Subject: Re: [ovirt-devel] Problem installing a new DB
> > >
> > > - Original Message -
> > > > From: "Simone Tiraboschi" 
> > > > To: "Kobi Ianko" 
> > > > Cc: "engine-de...@ovirt.org" 
> > > > Sent: Tuesday, July 8, 2014 1:57:44 PM
> > > > Subject: Re: [ovirt-devel] Problem installing a new DB
> > > >
> > > > Can you please run
> > > > OTOPI_DEBUG=1 $HOME/ovirt-engine/bin/engine-setup
> > > >
> > > > thanks,
> > > > Simone
> > > >
> > > > - Original Message -
> > > > From: "plysan" 
> > > > To: "Kobi Ianko" 
> > > > Cc: "engine-de...@ovirt.org" 
> > > > Sent: Tuesday, July 8, 2014 12:54:05 PM
> > > > Subject: Re: [ovirt-devel] Problem installing a new DB
> > > >
> > > > Hi Kobi:
> > > >
> > > > Maybe your installed otopi version is not the version that
> > > > ovirt-engine.spec
> > > > declares.
> > > >
> > > > thanks!
> > > >
> > > >
> > > > 2014-07-08 18:48 GMT+08:00 Kobi Ianko < k...@redhat.com > :
> > > >
> > > >
> > > > Did any of you encountered this problem?
> > > >
> > > > $ $HOME/ovirt-engine/bin/engine-setup
> > > > ***L:ERROR Internal error: type object 'Stages' has no attribute
> > > > 'DB_CONNECTION_SETUP'
> > > >
> > > > Do you know how to work around it/fix it?
> > >
> > > Was probably fixed recently - you can try latest master. what version do
> > you
> > > use?
> >
> > fetch and rebase did not solve it
> > > If 3.5.0 beta, reports setup was broken there. If you do not want that,
> > > remove the
> > > package ovirt-engine-reports-setup. Perhaps dwh too.
> > I don't have a package named ovirt-engine-reports-setup according to yum
> > > --
> > > Didi
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Problem installing a new DB

2014-07-08 Thread Kobi Ianko


- Original Message -
> From: "Yedidyah Bar David" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Tuesday, July 8, 2014 2:23:42 PM
> Subject: Re: [ovirt-devel] Problem installing a new DB
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "Simone Tiraboschi" 
> > Cc: "engine-de...@ovirt.org" 
> > Sent: Tuesday, July 8, 2014 2:01:33 PM
> > Subject: Re: [ovirt-devel] Problem installing a new DB
> > 
> > running with debug show this message:
> > ***L:ERROR Internal error: type object 'Stages' has no attribute
> > 'DB_CONNECTION_SETUP'
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/site-packages/otopi/__main__.py", line 94, in
> >   main
> > installer.execute()
> >   File "/usr/lib/python2.7/site-packages/otopi/main.py", line 159, in
> >   execute
> > sys.exc_info()[2],
> >   File "/usr/lib/python2.7/site-packages/otopi/util.py", line 93, in
> >   raiseExceptionInformation
> > exec('raise info[1], None, info[2]')
> >   File "/usr/lib/python2.7/site-packages/otopi/main.py", line 153, in
> >   execute
> > self.context.loadPlugins()
> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 497, in
> >   loadPlugins
> > self._loadPluginGroups(plugindir, needgroups, loadedgroups)
> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 123, in
> >   _loadPluginGroups
> > self._loadPlugins(path, path, groupname)
> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 80, in
> >   _loadPlugins
> > self._loadPlugins(base, d, groupname)
> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 80, in
> >   _loadPlugins
> > self._loadPlugins(base, d, groupname)
> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 111, in
> >   _loadPlugins
> > os.path.basename(path),
> >   File "/usr/lib/python2.7/site-packages/otopi/util.py", line 117, in
> >   loadModule
> > mod_desc
> >   File
> >   
> > "/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/__init__.py",
> >   line 25, in 
> > from . import connection
> >   File
> >   
> > "/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/connection.py",
> >   line 39, in 
> > class Plugin(plugin.PluginBase):
> >   File
> >   
> > "/home/kianku/ovirt-engine/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/db/connection.py",
> >   line 104, in Plugin
> > name=osetupcons.Stages.DB_CONNECTION_SETUP,
> > PluginLoadException: type object 'Stages' has no attribute
> > 'DB_CONNECTION_SETUP'
> 
> (from your other reply:)
> 
> > fetch and rebase did not solve it
> 
> Weird. Do you actually see this last line in the mentioned file? Did you
> install again?

looking at 
/home/kianku/ovirt-engine/share/ovirt-engine/setup/plugins/ovirt-engine-common/base/db/connection.py
I don't see the line in the file, is there some caching/tmp ?
> 
> A change dropping this line was merged a month ago.
> --
> Didi
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] problem with UI css file

2014-07-16 Thread Kobi Ianko
Hi,
Got the following error in the engine log:
Can't read file 
"/home/kianku/ovirt-engine/etc/ovirt-engine/branding/00-ovirt.brand/patternfly/css/styles.min.css"
 for request 
"/ovirt-engine/webadmin/theme/00-ovirt.brand/patternfly/css/styles.min.css", 
will send a 404 error response.

for some reason I'm missing "patternfly" directory...

I'm fetched and rebase with latest..

10x 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] problem with UI css file

2014-07-17 Thread Kobi Ianko
This will fix it:
http://www.ovirt.org/OVirt_Engine_Development_Environment#Setup_PatternFly_repository

- Original Message -
> From: "Kobi Ianko" 
> To: "engine-de...@ovirt.org" 
> Sent: Thursday, July 17, 2014 9:56:58 AM
> Subject: [ovirt-devel] problem with UI css file
> 
> Hi,
> Got the following error in the engine log:
> Can't read file
> "/home/kianku/ovirt-engine/etc/ovirt-engine/branding/00-ovirt.brand/patternfly/css/styles.min.css"
> for request
> "/ovirt-engine/webadmin/theme/00-ovirt.brand/patternfly/css/styles.min.css",
> will send a 404 error response.
> 
> for some reason I'm missing "patternfly" directory...
> 
> I'm fetched and rebase with latest..
> 
> 10x
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] remote rejected - not Signed-off-by

2014-07-20 Thread Kobi Ianko
Hi,
Got this message when trying to push several changes:

To gerrit.ovirt.org:ovirt-engine
 ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by 
author/committer/uploader in commit message footer)
error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'


All of the patches has "Signed-off-by" in the footer, and there are no 
conflicts in the message.

Do you have any idea what might be the issue here when trying to push?

10x, Kobi
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] remote rejected - not Signed-off-by

2014-07-20 Thread Kobi Ianko
nop, both are k...@redhat.com

- Original Message -
> From: "Oved Ourfali" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Sunday, July 20, 2014 1:40:22 PM
> Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> 
> Is that a new development environment?
> Can it be that the "Signed-off-by" section contains another user, and not the
> one you use in gerrit?
> 
> Oved
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "engine-de...@ovirt.org" 
> > Sent: Sunday, July 20, 2014 1:17:36 PM
> > Subject: [ovirt-devel] remote rejected - not Signed-off-by
> > 
> > Hi,
> > Got this message when trying to push several changes:
> > 
> > To gerrit.ovirt.org:ovirt-engine
> >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> >  author/committer/uploader in commit message footer)
> > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> > 
> > 
> > All of the patches has "Signed-off-by" in the footer, and there are no
> > conflicts in the message.
> > 
> > Do you have any idea what might be the issue here when trying to push?
> > 
> > 10x, Kobi
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] remote rejected - not Signed-off-by

2014-07-20 Thread Kobi Ianko
the git log:
http://pastebin.com/RqbQAfa3

my patches (3 patches) are based on Gilad Chaplik patches which are not merged

- Original Message -
> From: "Nir Soffer" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Sunday, July 20, 2014 2:48:06 PM
> Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "engine-de...@ovirt.org" 
> > Sent: Sunday, July 20, 2014 1:17:36 PM
> > Subject: [ovirt-devel] remote rejected - not Signed-off-by
> > 
> > Hi,
> > Got this message when trying to push several changes:
> > 
> > To gerrit.ovirt.org:ovirt-engine
> >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> >  author/committer/uploader in commit message footer)
> > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> 
> Can you share the output of git show up to the contents of the patch?
> 
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] remote rejected - not Signed-off-by

2014-07-20 Thread Kobi Ianko

the git log:
http://pastebin.com/RqbQAfa3

my patches (3 patches) are based on Gilad Chaplik patches which are not merged


- Original Message -
> From: "Nir Soffer" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Sunday, July 20, 2014 2:48:06 PM
> Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "engine-de...@ovirt.org" 
> > Sent: Sunday, July 20, 2014 1:17:36 PM
> > Subject: [ovirt-devel] remote rejected - not Signed-off-by
> > 
> > Hi,
> > Got this message when trying to push several changes:
> > 
> > To gerrit.ovirt.org:ovirt-engine
> >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> >  author/committer/uploader in commit message footer)
> > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> 
> Can you share the output of git show up to the contents of the patch?
> 
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] remote rejected - not Signed-off-by

2014-07-20 Thread Kobi Ianko
I do have a sign off by in all my patches, do you see a patch that is missing 
it in the git log below ?

- Original Message -
> From: "Yedidyah Bar David" 
> To: "Kobi Ianko" 
> Cc: "engine-de...@ovirt.org" 
> Sent: Sunday, July 20, 2014 2:59:14 PM
> Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> 
> You seem to be missing the "Signed-Off-By" line, see [1].
> 
> [1] http://www.ovirt.org/Working_with_oVirt_Gerrit#Install_the_change-ID_hook
> --
> Didi
> 
> - Original Message -
> > From: "Kobi Ianko" 
> > To: "Nir Soffer" 
> > Cc: "engine-de...@ovirt.org" 
> > Sent: Sunday, July 20, 2014 2:53:53 PM
> > Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> > 
> > the git log:
> > http://pastebin.com/RqbQAfa3
> > 
> > my patches (3 patches) are based on Gilad Chaplik patches which are not
> > merged
> > 
> > - Original Message -
> > > From: "Nir Soffer" 
> > > To: "Kobi Ianko" 
> > > Cc: "engine-de...@ovirt.org" 
> > > Sent: Sunday, July 20, 2014 2:48:06 PM
> > > Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
> > > 
> > > - Original Message -
> > > > From: "Kobi Ianko" 
> > > > To: "engine-de...@ovirt.org" 
> > > > Sent: Sunday, July 20, 2014 1:17:36 PM
> > > > Subject: [ovirt-devel] remote rejected - not Signed-off-by
> > > > 
> > > > Hi,
> > > > Got this message when trying to push several changes:
> > > > 
> > > > To gerrit.ovirt.org:ovirt-engine
> > > >  ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by
> > > >  author/committer/uploader in commit message footer)
> > > > error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
> > > 
> > > Can you share the output of git show up to the contents of the patch?
> > > 
> > > Nir
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > > 
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel