from:"Max Kovgan"

Re: [ovirt-devel] firewalld on vdsm host

2015-11-13 Thread Max Kovgan

Can you point me to the table?
Sounds good exercise in b/w compatibility and slow data/schema migration to
me.
Is there an RFE for it too?
On Nov 12, 2015 5:27 PM, "Sandro Bonazzola"  wrote:

>
>
> On Thu, Nov 12, 2015 at 3:06 PM, Fabian Deutsch 
> wrote:
>
>> On Thu, Nov 12, 2015 at 2:57 PM, Dan Kenigsberg 
>> wrote:
>> > On Thu, Nov 12, 2015 at 02:42:32PM +0100, Fabian Deutsch wrote:
>> >> On Thu, Nov 12, 2015 at 2:36 PM, Dan Kenigsberg 
>> wrote:
>> >> > On Thu, Nov 12, 2015 at 12:08:07PM +0100, Fabian Deutsch wrote:
>> >> >> Hey,
>> >> >>
>> >> >> what is the expectation/assumption about firewalld on a CentOS 7
>> host
>> >> >> where you want to install vdsm onto?
>> >> >>
>> >> >> Is vdsm taking care of it?
>> >> >>
>> >> >> I'm asking this, because firewalld seems to be in the default
>> package
>> >> >> (please correct me if I am wrong) set of CentOS 7 and thus installed
>> >> >> by default.
>> >> >
>> >> > As far as I know, Vdsm runs fine in parallel to firewalld on recent
>> >> > el7.1 (there used to be problems in early 7.0 versions).
>> >> >
>> >> > If this is not the case, please file a bug with precise versions!
>> >>
>> >> Bug 1281417 - vdsm host can not be added with firewalld enabled
>> >
>> > Would everything work all right if Vdsm's port (54321) is opened in
>> > firewalld?
>>
>> I did not try this yet - but I strongly assume yes.
>>
>> > It seems that the host CAN be added, but remains in non-responsive mode
>> > due to the firewall being shut. right?
>>
>> Correct, vdsm is up and all. It just seems to be the firewall.
>>
>> Looking at the two bugs:
>> Bug 995362 - (ovirt_firewalld_support) [RFE] Support firewalld
>> Bug 1281417 - vdsm host can not be added with firewalld enabled
>>
>> I wonder where the firewalld service configuration should happen,
>> currently in host-deploy, but I don#t really see why theer and not in
>> vdsm.
>>
>
> firewalld can't be configured right now by host-deploy being the firewall
> config sotred in the engine database for iptables only.
> We need to add firewalld support in ovirt-engine and in ovirt-host-deploy
> to properly support it.
>
>
>
>
>>
>> - fabian
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Ovirt engine find bugs job

2015-08-17 Thread Max Kovgan

? always the same?

 It's your call, so please let me know what you want to do (I'll just pin
 it to
 el7 host for now, to avoid flaky tests).

 Thanks!!


 --
 David Caro

 Red Hat S.L.
 Continuous Integration Engineer - EMEA ENG Virtualization RD

 Tel.: +420 532 294 605
 Email: dc...@redhat.com
 Web: www.redhat.com
 RHT Global #: 82-62605

 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel




-- 
Max Kovgan

Senior Software Engineer
Red Hat - EMEA ENG Virtualization RD
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Screen casting and video editing on fc21 with Blender

2015-07-23 Thread Max Kovgan

Oved. All I needed to do was screen casting. it usually was a terminal.
I have used a bit pitivi (it somewhat feels like Apple's iMovie, but is
unstable).
I've looked at the videos and Eli,

AMAZING!

I was not aware of this feature of blender!
:)

Cool!




On Thu, Jul 23, 2015 at 8:50 AM, Oved Ourfali oourf...@redhat.com wrote:

 Including editing?
  On Jul 23, 2015 7:39 AM, Max Kovgan mkov...@redhat.com wrote:

 Hi, Eli. I have yet seen any thing related to video playback or recording
 VLC cannot do.
 This includes desktop screen casting.
  On Jul 22, 2015 11:39 PM, Christopher Pereira krip...@imatronix.cl
 wrote:

 Hi,

 For Windows, if licenses are not a problem, you also have Camtasia [1],
 which uses an optimized codec that only stores images and GUI events in the
 same way RemoteDesktop does.
 As a result, recordings is lossless and take much less space. For example,
 AFAIU, if you scroll a static image on the screen, it's stored only once
 and only its position changes are recorded frame by frame. There are also
 other benefits like the fact that the mouse pointer position can be edited
 separately after recording.
 You may probably get similar results if you record everything lossless
 (which takes a lot of space and resources while recording). For best
 quality, the key is to avoid re-compression (you should only encode the
 final video).

 Camtasia also includes a complete editor.

 Besides, Camtasia's AVI files can be edited with Sony Vegas or Premiere
 and finally be rendered with standard codecs which can be shared or
 uploaded to youtube, vimeo, etc. (otherwise, you would need to provide the
 Camtasia codec for playback).

 I wonder if there are stable OS alternatives using a similar approach.

 Best regards,
 Christopher.

 [1] https://www.techsmith.com/camtasia.html

 On 22-07-2015 16:49, Eli Mesika wrote:

 Hi guys

 As you already know, some of us need to do some video/screen cast for
 their 3.6 new features
 I spent my day today in recording and editing a video for one of my new
 3.6 features and I want to share my experience to save you time (and hair..)

 Well, I started with recordmydesktop (yum) to capture the video files ,
 this worked smooth and enables you also to have a cup of coffee until the
 file is written to the disk.
 Then, after having few videos, I wanted to edit them and make a whole
 smooth video, cutting some stuff out ...
 I had started with installing pitivi (yum), from its feature list it seems
 promising but after dozens of crashes on almost every mouse move, I really
 gave up...

 Oved, sent me this post [1]:
 So, I installed Blender and tried to work with it but it seems to refuse
 adding my video files to the project time-line ...
 Digging around [2], I found that the Blender package on fc21 does not work
 well and in order to get it working you have to download Blender latest
 version (2.75a) manually from [3],
 extract it to a directory and run blender 

 Blender has many usages, but you can adjust it to do video editing, just
 follow [4] [5] and [6] tutorials (less than 15 min for all)
 (all are important, especially the first one that includes proper
 configuration)

 One major issue is to configure well the frames per second rate (fps) (can
 be shown on the file properties) of your videos if you don't want to get a
 gap between your video and the sound track

 I was able after that to edit my videos and export (render) video as MP4
 and audio as MP3 (embedded in the video file) (other formats may have codec
 issues...)

 Overall, I worked with Blender few hours, splitting videos, removing video
 strips , grabbing and dragging without a single error or crash

 Although that Blender learning curve seems to be longer than other
 applications, I recommend to use this application for video editing and
 screen casting

 If you have any question or need any assistance/advice , I will be happy
 to help.


 [1] http://opensource.com/life/15/1/current-state-linux-video-editing
 [2] http://www.spinics.net/linux/fedora/fedora-users/msg459024.html
 [3] https://www.blender.org/
 [4] https://www.youtube.com/watch?v=xSGIPmQdV6Mhtml5=1
 [5] https://www.youtube.com/watch?v=20VqQLpvctY
 [6] https://www.youtube.com/watch?v=zxFGm_LQeZQ


 Thanks
 Eli Mesika

 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel


 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel




-- 
Max Kovgan

Senior Software Engineer
Red Hat - EMEA ENG Virtualization RD
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Screen casting and video editing on fc21 with Blender

2015-07-22 Thread Max Kovgan

Hi, Eli. I have yet seen any thing related to video playback or recording
VLC cannot do.
This includes desktop screen casting.
 On Jul 22, 2015 11:39 PM, Christopher Pereira krip...@imatronix.cl
wrote:

 Hi,

 For Windows, if licenses are not a problem, you also have Camtasia [1],
 which uses an optimized codec that only stores images and GUI events in the
 same way RemoteDesktop does.
 As a result, recordings is lossless and take much less space. For example,
 AFAIU, if you scroll a static image on the screen, it's stored only once
 and only its position changes are recorded frame by frame. There are also
 other benefits like the fact that the mouse pointer position can be edited
 separately after recording.
 You may probably get similar results if you record everything lossless
 (which takes a lot of space and resources while recording). For best
 quality, the key is to avoid re-compression (you should only encode the
 final video).

 Camtasia also includes a complete editor.

 Besides, Camtasia's AVI files can be edited with Sony Vegas or Premiere
 and finally be rendered with standard codecs which can be shared or
 uploaded to youtube, vimeo, etc. (otherwise, you would need to provide the
 Camtasia codec for playback).

 I wonder if there are stable OS alternatives using a similar approach.

 Best regards,
 Christopher.

 [1] https://www.techsmith.com/camtasia.html

 On 22-07-2015 16:49, Eli Mesika wrote:

 Hi guys

 As you already know, some of us need to do some video/screen cast for
 their 3.6 new features
 I spent my day today in recording and editing a video for one of my new
 3.6 features and I want to share my experience to save you time (and hair..)

 Well, I started with recordmydesktop (yum) to capture the video files ,
 this worked smooth and enables you also to have a cup of coffee until the
 file is written to the disk.
 Then, after having few videos, I wanted to edit them and make a whole
 smooth video, cutting some stuff out ...
 I had started with installing pitivi (yum), from its feature list it
 seems promising but after dozens of crashes on almost every mouse move, I
 really gave up...

 Oved, sent me this post [1]:
 So, I installed Blender and tried to work with it but it seems to refuse
 adding my video files to the project time-line ...
 Digging around [2], I found that the Blender package on fc21 does not
 work well and in order to get it working you have to download Blender
 latest version (2.75a) manually from [3],
 extract it to a directory and run blender 

 Blender has many usages, but you can adjust it to do video editing, just
 follow [4] [5] and [6] tutorials (less than 15 min for all)
 (all are important, especially the first one that includes proper
 configuration)

 One major issue is to configure well the frames per second rate (fps)
 (can be shown on the file properties) of your videos if you don't want to
 get a gap between your video and the sound track

 I was able after that to edit my videos and export (render) video as MP4
 and audio as MP3 (embedded in the video file) (other formats may have codec
 issues...)

 Overall, I worked with Blender few hours, splitting videos, removing
 video strips , grabbing and dragging without a single error or crash

 Although that Blender learning curve seems to be longer than other
 applications, I recommend to use this application for video editing and
 screen casting

 If you have any question or need any assistance/advice , I will be happy
 to help.


 [1] http://opensource.com/life/15/1/current-state-linux-video-editing
 [2] http://www.spinics.net/linux/fedora/fedora-users/msg459024.html
 [3] https://www.blender.org/
 [4] https://www.youtube.com/watch?v=xSGIPmQdV6Mhtml5=1
 [5] https://www.youtube.com/watch?v=20VqQLpvctY
 [6] https://www.youtube.com/watch?v=zxFGm_LQeZQ


 Thanks
 Eli Mesika

 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel


 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: gerrit+ci improvement proposal

2015-06-09 Thread Max Kovgan

hi, Dear Developers!

We are aware of the urge and pressure to push your patches a.s.a.p before the 
code freeze.
Howeever, with current flow of patch updates, we currently have an overloaded 
CI, which will result in a very long waiting time for jobs to start
SO, in order to reduce that time, please make sure you are using DRAFTs [1] for 
early stage patches [during human reviews]

how to use drafts:
1) using plain git push - refer to [1]
2) using git review plugin
if you've installed git review plugin:
 git review -D -r repo branch
example with repo origin and branch master:
 git review -D -r origin master

plugin can be installed as explained here: [2]


[1] http://stackoverflow.com/questions/18106064/how-to-push-drafts-to-gerrit
[2] http://www.mediawiki.org/wiki/Gerrit/git-review#Fedora.2FCentOS


N.B.

Using drafts is the only alternative for adding 2 new gerrit flags.
If you have better ideas - you are still welcome to suggest.

Earlier today I did some mining on gerrit patches status:
out of ~1400 open patches ~350 are drafts, which was incouraging.
Yet out of all 66 committers for those patches only 6 are using drafts:
In [25]: for c in changes:
   : if c.get('status') != 'DRAFT':
   : continue
   : saints.add(c.get('owner').get('name'))
   : 
In [26]: saints
Out[26]: 
{u'Alon Bar-Lev',
 u'Liron Aravot',
 u'Martin Mucha',
 u'Nir Soffer',
 u'Piotr Kliczewski',
 u'Tomer Saban'}
Kudos.



Max Kovgan

Senior Software Engineer
Red Hat - EMEA ENG Virtualization RD
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060

- Forwarded Message -
From: Oved Ourfali oourf...@redhat.com
To: Eyal Edri ee...@redhat.com
Cc: Oved Ourfali ov...@redhat.com, devel@ovirt.org, infra 
in...@ovirt.org
Sent: Sunday, June 7, 2015 10:05:23 AM
Subject: Re: [ovirt-devel] gerrit+ci improvement proposal


On Jun 7, 2015 10:00 AM, Eyal Edri ee...@redhat.com wrote:



 - Original Message - 
  From: Oved Ourfali ov...@redhat.com 
  To: Eyal Edri ee...@redhat.com 
  Cc: in...@ovirt.org, devel@ovirt.org 
  Sent: Sunday, June 7, 2015 9:55:56 AM 
  Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
  
  
  
  - Original Message - 
   From: Eyal Edri ee...@redhat.com 
   To: Eli Mesika emes...@redhat.com 
   Cc: Oved Ourfali ov...@redhat.com, devel@ovirt.org, in...@ovirt.org 
   Sent: Sunday, June 7, 2015 9:52:15 AM 
   Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
   
   
   
   - Original Message - 
From: Eli Mesika emes...@redhat.com 
To: Oved Ourfali ov...@redhat.com 
Cc: Eyal Edri ee...@redhat.com, in...@ovirt.org, devel@ovirt.org 
Sent: Thursday, June 4, 2015 3:49:05 PM 
Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 



- Original Message - 
 From: Oved Ourfali ov...@redhat.com 
 To: Eyal Edri ee...@redhat.com 
 Cc: devel@ovirt.org, in...@ovirt.org 
 Sent: Thursday, June 4, 2015 10:03:02 AM 
 Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
 
 
 
 - Original Message - 
  From: Eyal Edri ee...@redhat.com 
  To: Sandro Bonazzola sbona...@redhat.com 
  Cc: in...@ovirt.org, devel@ovirt.org 
  Sent: Thursday, June 4, 2015 9:46:40 AM 
  Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
  
  
  
  - Original Message - 
   From: Sandro Bonazzola sbona...@redhat.com 
   To: Eyal Edri ee...@redhat.com, Max Kovgan 
   mkov...@redhat.com 
   Cc: devel@ovirt.org, in...@ovirt.org 
   Sent: Thursday, June 4, 2015 9:11:10 AM 
   Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
   
   Il 03/06/2015 21:46, Eyal Edri ha scritto: 


- Original Message - 
From: Max Kovgan mkov...@redhat.com 
To: devel@ovirt.org 
Cc: in...@ovirt.org 
Sent: Wednesday, June 3, 2015 8:22:54 PM 
Subject: [ovirt-devel] gerrit+ci improvement proposal 

Hi everyone! 
We really want to have reliable and snappy CI: to allow short 
cycles 
and 
encourage developers to write tests. 

# Problem 

Many patches are neither ready for review nor for CI upon 
submission, 
which 
is OK. 
But running all the jobs on those patches with limited 
resources 
results 
in: 
overloaded resources, slow response time, unhappy developers. 

# Proposed Solution 

To run less jobs we know we don’t need to, thus making more 
resources 
for 
the 
jobs we need to run. 
We have been experimenting to make our CI stabler and quicker 
to 
respond 
by 
using gerrit flags. This has improved in both directions very 
well 
internally

Re: [ovirt-devel] [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: gerrit+ci improvement proposal

2015-06-09 Thread Max Kovgan

Thanks!

Max Kovgan

Senior Software Engineer
Red Hat - EMEA ENG Virtualization RD
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060

- Original Message -
From: David Caro dcaro...@redhat.com
To: Max Kovgan mkov...@redhat.com
Cc: devel@ovirt.org, in...@ovirt.org
Sent: Tuesday, June 9, 2015 6:41:16 PM
Subject: Re: [urgent] call for developers - upstream jenkins: Build Queue (543) 
WAS: Fwd: [ovirt-devel] gerrit+ci improvement proposal


As a first contention measure to alleviate the flood, I've changed the way
findbugs is triggered to get triggered only on verified +1 (it will set code
review flag on pass or failure, and will run on drafts, can't use more than one
condition for the trigger).





On 06/09, Max Kovgan wrote:
 hi, Dear Developers!
 
 We are aware of the urge and pressure to push your patches a.s.a.p before the 
 code freeze.
 Howeever, with current flow of patch updates, we currently have an overloaded 
 CI, which will result in a very long waiting time for jobs to start
 SO, in order to reduce that time, please make sure you are using DRAFTs [1] 
 for early stage patches [during human reviews]
 
 how to use drafts:
 1) using plain git push - refer to [1]
 2) using git review plugin
 if you've installed git review plugin:
  git review -D -r repo branch
 example with repo origin and branch master:
  git review -D -r origin master
 
 plugin can be installed as explained here: [2]
 
 
 [1] http://stackoverflow.com/questions/18106064/how-to-push-drafts-to-gerrit
 [2] http://www.mediawiki.org/wiki/Gerrit/git-review#Fedora.2FCentOS
 
 
 N.B.
 
 Using drafts is the only alternative for adding 2 new gerrit flags.
 If you have better ideas - you are still welcome to suggest.
 
 Earlier today I did some mining on gerrit patches status:
 out of ~1400 open patches ~350 are drafts, which was incouraging.
 Yet out of all 66 committers for those patches only 6 are using drafts:
 In [25]: for c in changes:
: if c.get('status') != 'DRAFT':
: continue
: saints.add(c.get('owner').get('name'))
: 
 In [26]: saints
 Out[26]: 
 {u'Alon Bar-Lev',
  u'Liron Aravot',
  u'Martin Mucha',
  u'Nir Soffer',
  u'Piotr Kliczewski',
  u'Tomer Saban'}
 Kudos.
 
 
 
 Max Kovgan
 
 Senior Software Engineer
 Red Hat - EMEA ENG Virtualization RD
 Tel.: +972 9769 2060
 Email: mkovgan [at] redhat [dot] com
 Web: http://www.redhat.com
 RHT Global #: 82-72060
 
 - Forwarded Message -
 From: Oved Ourfali oourf...@redhat.com
 To: Eyal Edri ee...@redhat.com
 Cc: Oved Ourfali ov...@redhat.com, devel@ovirt.org, infra 
 in...@ovirt.org
 Sent: Sunday, June 7, 2015 10:05:23 AM
 Subject: Re: [ovirt-devel] gerrit+ci improvement proposal
 
 
 On Jun 7, 2015 10:00 AM, Eyal Edri ee...@redhat.com wrote:
 
 
 
  - Original Message - 
   From: Oved Ourfali ov...@redhat.com 
   To: Eyal Edri ee...@redhat.com 
   Cc: in...@ovirt.org, devel@ovirt.org 
   Sent: Sunday, June 7, 2015 9:55:56 AM 
   Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
   
   
   
   - Original Message - 
From: Eyal Edri ee...@redhat.com 
To: Eli Mesika emes...@redhat.com 
Cc: Oved Ourfali ov...@redhat.com, devel@ovirt.org, in...@ovirt.org 
Sent: Sunday, June 7, 2015 9:52:15 AM 
Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 



- Original Message - 
 From: Eli Mesika emes...@redhat.com 
 To: Oved Ourfali ov...@redhat.com 
 Cc: Eyal Edri ee...@redhat.com, in...@ovirt.org, devel@ovirt.org 
 Sent: Thursday, June 4, 2015 3:49:05 PM 
 Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
 
 
 
 - Original Message - 
  From: Oved Ourfali ov...@redhat.com 
  To: Eyal Edri ee...@redhat.com 
  Cc: devel@ovirt.org, in...@ovirt.org 
  Sent: Thursday, June 4, 2015 10:03:02 AM 
  Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
  
  
  
  - Original Message - 
   From: Eyal Edri ee...@redhat.com 
   To: Sandro Bonazzola sbona...@redhat.com 
   Cc: in...@ovirt.org, devel@ovirt.org 
   Sent: Thursday, June 4, 2015 9:46:40 AM 
   Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 
   
   
   
   - Original Message - 
From: Sandro Bonazzola sbona...@redhat.com 
To: Eyal Edri ee...@redhat.com, Max Kovgan 
mkov...@redhat.com 
Cc: devel@ovirt.org, in...@ovirt.org 
Sent: Thursday, June 4, 2015 9:11:10 AM 
Subject: Re: [ovirt-devel] gerrit+ci improvement proposal 

Il 03/06/2015 21:46, Eyal Edri ha scritto: 
 
 
 - Original Message - 
 From: Max Kovgan mkov...@redhat.com 
 To: devel@ovirt.org 
 Cc: in...@ovirt.org 
 Sent: Wednesday, June 3, 2015 8:22:54 PM 
 Subject: [ovirt-devel] gerrit+ci improvement proposal

[ovirt-devel] gerrit+ci improvement proposal

2015-06-03 Thread Max Kovgan

Hi everyone!
We really want to have reliable and snappy CI: to allow short cycles and 
encourage developers to write tests.

# Problem

Many patches are neither ready for review nor for CI upon submission, which is 
OK.
But running all the jobs on those patches with limited resources results in: 
overloaded resources, slow response time, unhappy developers.

# Proposed Solution

To run less jobs we know we don’t need to, thus making more resources for the 
jobs we need to run.
We have been experimenting to make our CI stabler and quicker to respond by 
using gerrit flags. This has improved in both directions very well internally.
Now it seems a good time to let all the oVirt projects to use this.
This solution indirectly promotes reviews and quick tests - “to fail early”, 
yet full blown static code analysis and long tests to run “when ready”.

# How it works

2 new gerrit independent flags are added to gerrit.

## CI flag

Will express patch CI status. Values:
 * +1 CI passed
 *  0 CI did not run yet
 * -1 CI failed
Permissions for setting: project maintainers (for special cases) should be able 
to set/override (except Jenkins).

## Workflow flag

Will express patch “workflow” state. Values:
 *  0 Work In Progress
 * +1 Ready For Review
 * +2 Ready For Merge
Permissions for setting: Owner can set +1, Project Maintainers can set +2

## Review + CI Integration:

Merging [“Submit” button to appear] will require: Review+1, CI+1, Workflow+2
Patch lifecycle now is:
---
patch state   |owner |reviewer |maintainer |CI tests |pass
---
added/updated |- |-|-  |quick|CI+1
review|Workflow+1|Review+1 |-  |heavy|CI+1
merge ready   |- |-|Workflow+2 |gating   |CI+1
merge |- |-|merge  |merge|CI+1

Changes from current workflow:
Owner only adds reviewers, now owner needs to set Workflow+1 for the patch to 
be reviewed, and heavily auto-tested.
Maintainer now needs to set Workflow+2 and wait for Submit button to appear 
after CI has completed running gating tests.


Next step will be to automate merge the change after Workflow+2 has been set by 
the Maintainer and gating tests passed.


## Why now?

It is elimination of waste. The sooner - the better. 
The solution has been used for a while and it works. 
Resolving the problem without gerrit involved will lead to adding unreliable 
code into jobs, and will still be prone to problems:
  Just recently, 3d ago we’ve tried detecting what to run from jenkins relying 
only on gerrit comments so that upon Verified+1, we’d run the job.
  We could not use “Review+1”, because it makes no sense at all, so we left the 
job to set Verified+1.
  Meaning - re-trigger itself immediately more than 1 times.
  
  Jenkins and its visitors very unhappy, and we had to stop those jobs, clean 
up the queue, and spam developers.

## OK OK OK. Now what?

Now we want your comments and opinions before pushing this further:
Please participate in this thread, so we can start trying it out.
Ask, Suggest better ideas, all this is welcome.


Best Regards!


N.B.
Of course, this is not written in stone, in case we find a better approach on 
solving those issues, we will change to it.
And we will keep improving so don't be afraid that it will be enforced: if this 
does not work out we will discard it.

P.S.
Kudos to dcaro, most of the work was done by him, and most of this text too.




Max Kovgan

Senior Software Engineer
Red Hat - EMEA ENG Virtualization RD
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] firewalld on vdsm host

Re: [ovirt-devel] Ovirt engine find bugs job

Re: [ovirt-devel] Screen casting and video editing on fc21 with Blender

Re: [ovirt-devel] Screen casting and video editing on fc21 with Blender

[ovirt-devel] [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: gerrit+ci improvement proposal

Re: [ovirt-devel] [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: gerrit+ci improvement proposal

[ovirt-devel] gerrit+ci improvement proposal

7 matches

Site Navigation

Mail list logo

Footer information