[ovirt-devel] Wrong pep8 library on centos

2018-04-20 Thread Petr Kotas
Hi,

Sending this to spread information.

I have encountered and issue with Centos 7.4.1708 (Core) when compiling the
oVirt engine.
The pep8 validation was not passing correctly.

It turned out, that the Centos has the old and bugged version present by
default.

The solution is to use the same version as used in oVirt CI.

Just add http://resources.ovirt.org/repos/ci-tools/el7/ to yum.repos.d and
it will start
passing again.


Best,
Petr
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] How To Construct An Local Developing Enviroment?

2018-04-06 Thread Petr Kotas
Hi everyone,

first of all, thanks for having an interest in my dev setup :).

Second, I am open to making it more official.

The first step is to create list of missing features.
Please if you can, take a look at the setup and create an issue for any
feature you would like to see in there.

Thanks!!

Best,
Petr

On Thu, Apr 5, 2018 at 5:46 PM, Greg Sheremeta <gsher...@redhat.com> wrote:

> +1. Petr, can we make this more official? Anyone else working on it?
>
> I also had the thought of using ansible to stand up the environment on
> bare metal.
>
> Greg
>
>
> On Thu, Apr 5, 2018, 11:41 AM Vojtech Szocs <vsz...@redhat.com> wrote:
>
>>
>>
>> On Thu, Apr 5, 2018 at 1:53 PM, Petr Kotas <pko...@redhat.com> wrote:
>>
>>> Hi,
>>>
>>> you can take a look at my env here https://github.com/petrkotas/
>>> ovirt-dev-env
>>>
>>
>> ​Thanks Petr for sharing this!
>>
>>
>>>
>>>
>>> it is not complete and there is still some work left.
>>>
>>> Feel free to contact me if you have any questions.
>>>
>>> Best,
>>> Petr
>>>
>>> On Tue, Apr 3, 2018 at 12:56 PM, sundw <kyland\su...@coretek.com.cn>
>>> wrote:
>>>
>>>> Hi Guys!
>>>> I plan to construct an local developing environment for oVirt.
>>>> But I can not find any relative pages from the web site(www.ovirt.org).
>>>> Maybe I am not patient :).
>>>>
>>>> Could you please give me some advice or some links about
>>>> How To Construct An Local Developing Enviroment?
>>>>
>>>> Thanks!
>>>>
>>>> --
>>>> *孙大巍*
>>>> 北京科银京成技术有限公司/新产品研发部
>>>> 13378105625
>>>>
>>>> ___
>>>> Devel mailing list
>>>> Devel@ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>
>>>
>>>
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] How To Construct An Local Developing Enviroment?

2018-04-05 Thread Petr Kotas
Hi,

you can take a look at my env here
https://github.com/petrkotas/ovirt-dev-env

it is not complete and there is still some work left.

Feel free to contact me if you have any questions.

Best,
Petr

On Tue, Apr 3, 2018 at 12:56 PM, sundw  wrote:

> Hi Guys!
> I plan to construct an local developing environment for oVirt.
> But I can not find any relative pages from the web site(www.ovirt.org).
> Maybe I am not patient :).
>
> Could you please give me some advice or some links about
> How To Construct An Local Developing Enviroment?
>
> Thanks!
>
> --
> *孙大巍*
> 北京科银京成技术有限公司/新产品研发部
> 13378105625
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Failing tests for storage-py27.

2017-08-01 Thread Petr Kotas
The patch works as promised.
The issue is now gone.

Thanks,
Petr

On Tue, Aug 1, 2017 at 9:12 AM, Petr Kotas <pko...@redhat.com> wrote:

> Thanks Nir,
>
> I am working on it right now, will post result.
>
> Petr
>
> On Mon, Jul 31, 2017 at 7:35 PM, Nir Soffer <nsof...@redhat.com> wrote:
>
>> Pter, should be fixed by https://gerrit.ovirt.org/80027
>>
>> Can you test and report if it works for you?
>>
>> On Mon, Jul 31, 2017 at 8:24 PM Nir Soffer <nsof...@redhat.com> wrote:
>>
>>> On Mon, Jul 31, 2017 at 8:09 PM Nir Soffer <nsof...@redhat.com> wrote:
>>>
>>>> On Mon, Jul 31, 2017 at 5:52 PM Petr Kotas <pko...@redhat.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have encountered an issue with VDSM master when running tests.
>>>>> Maybe I am doing something wrong, or I am overlooking something.
>>>>>
>>>>> This is a clear master without any modification pulled with the latest
>>>>> commits.
>>>>> Did anyone please encountered the same issue:
>>>>>
>>>>> == FAILURES
>>>>> ==
>>>>> __ TestDirectioChecker.test_path_ok
>>>>> __
>>>>>
>>>>> self = >>>> testMethod=test_path_ok>
>>>>>
>>>>> def test_path_ok(self):
>>>>> self.checks = 1
>>>>> with temporaryPath(data=b"blah") as path:
>>>>> checker = check.DirectioChecker(self.loop, path,
>>>>> self.complete)
>>>>> checker.start()
>>>>> self.loop.run_forever()
>>>>> pprint.pprint(self.results)
>>>>> result = self.results[0]
>>>>> >   delay = result.delay()
>>>>>
>>>>> storage/check_test.py:82:
>>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>>
>>>>> self = >>>> records in\n0+1 ... copied, 0,000496228 s, 8,1 kB/s\n') time=4299448.73
>>>>> elapsed=0.00 at 0x3b72390>
>>>>>
>>>>> def delay(self):
>>>>> # TODO: Raising MiscFileReadException for all errors to keep
>>>>> the old
>>>>> # behavior. Should probably use StorageDomainAccessError.
>>>>> if self.rc != 0:
>>>>> raise exception.MiscFileReadException(self.path, self.rc,
>>>>> self.err)
>>>>> if not self.err:
>>>>> raise exception.MiscFileReadException(self.path, "no
>>>>> stats")
>>>>> stats = self.err.splitlines()[-1]
>>>>> match = self._PATTERN.match(stats)
>>>>> if not match:
>>>>> raise exception.MiscFileReadException(self.path,
>>>>> > "no match: %r" %
>>>>> stats)
>>>>> E   MiscFileReadException: Internal file read failure:
>>>>> ('/var/tmp/tmpPpV1Rj', "no match: bytearray(b'4 bytes (4 B) copied,
>>>>> 0,000496228 s, 8,1 kB/s')")
>>>>>
>>>>> ../lib/vdsm/storage/check.py:372: MiscFileReadException
>>>>>  Captured stdout call
>>>>> 
>>>>> [>>>> in\n0+1 records out\n4 bytes (4 B) copied, 0,000496228 s, 8,1 kB/s\n')
>>>>> time=4299448.73 elapsed=0.00 at 0x3b72390>]
>>>>>
>>>>
>>> This is the issue - your dd uses "," as decimal point: 0,000496228
>>> We expect: 0.000496228
>>>
>>> Can you share the output of "locale"? on the machine?
>>>
>>> Here I get:
>>>
>>> $ locale
>>> LANG=en_US.UTF-8
>>> LC_CTYPE="en_US.UTF-8"
>>> LC_NUMERIC="en_US.UTF-8"
>>> LC_TIME="en_US.UTF-8"
>>> LC_COLLATE="en_US.UTF-8"
>>> LC_MONETARY="en_US.UTF-8"
>>> LC_MESSAGES="en_US.UTF-8"
>>> LC_PAPER="en_US.UTF-8"
>>> LC_NAME="en_US.UTF-8"
>>> LC_ADDRESS="en_US.UTF-8"
>>> LC_TELEPHONE="en_US.UTF-8"
>>> LC_MEASUREMENT="en_US.UTF-8"
>>> LC_IDENTIFICATION="en_US.UTF-8"
>>> LC_ALL=
>>>
>>> Maybe we don't configure the test environment properly?
>>>
>>> Dan, do you have any insite on this?
>>>
>>> Nir
>>>
>>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Failing tests for storage-py27.

2017-08-01 Thread Petr Kotas
Thanks Nir,

I am working on it right now, will post result.

Petr

On Mon, Jul 31, 2017 at 7:35 PM, Nir Soffer <nsof...@redhat.com> wrote:

> Pter, should be fixed by https://gerrit.ovirt.org/80027
>
> Can you test and report if it works for you?
>
> On Mon, Jul 31, 2017 at 8:24 PM Nir Soffer <nsof...@redhat.com> wrote:
>
>> On Mon, Jul 31, 2017 at 8:09 PM Nir Soffer <nsof...@redhat.com> wrote:
>>
>>> On Mon, Jul 31, 2017 at 5:52 PM Petr Kotas <pko...@redhat.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have encountered an issue with VDSM master when running tests.
>>>> Maybe I am doing something wrong, or I am overlooking something.
>>>>
>>>> This is a clear master without any modification pulled with the latest
>>>> commits.
>>>> Did anyone please encountered the same issue:
>>>>
>>>> == FAILURES
>>>> ==
>>>> __ TestDirectioChecker.test_path_ok
>>>> __
>>>>
>>>> self = 
>>>>
>>>> def test_path_ok(self):
>>>> self.checks = 1
>>>> with temporaryPath(data=b"blah") as path:
>>>> checker = check.DirectioChecker(self.loop, path,
>>>> self.complete)
>>>> checker.start()
>>>> self.loop.run_forever()
>>>> pprint.pprint(self.results)
>>>> result = self.results[0]
>>>> >   delay = result.delay()
>>>>
>>>> storage/check_test.py:82:
>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>
>>>> self = >>> records in\n0+1 ... copied, 0,000496228 s, 8,1 kB/s\n') time=4299448.73
>>>> elapsed=0.00 at 0x3b72390>
>>>>
>>>> def delay(self):
>>>> # TODO: Raising MiscFileReadException for all errors to keep
>>>> the old
>>>> # behavior. Should probably use StorageDomainAccessError.
>>>> if self.rc != 0:
>>>> raise exception.MiscFileReadException(self.path, self.rc,
>>>> self.err)
>>>> if not self.err:
>>>> raise exception.MiscFileReadException(self.path, "no
>>>> stats")
>>>> stats = self.err.splitlines()[-1]
>>>> match = self._PATTERN.match(stats)
>>>> if not match:
>>>> raise exception.MiscFileReadException(self.path,
>>>> > "no match: %r" %
>>>> stats)
>>>> E   MiscFileReadException: Internal file read failure:
>>>> ('/var/tmp/tmpPpV1Rj', "no match: bytearray(b'4 bytes (4 B) copied,
>>>> 0,000496228 s, 8,1 kB/s')")
>>>>
>>>> ../lib/vdsm/storage/check.py:372: MiscFileReadException
>>>>  Captured stdout call
>>>> 
>>>> [>>> in\n0+1 records out\n4 bytes (4 B) copied, 0,000496228 s, 8,1 kB/s\n')
>>>> time=4299448.73 elapsed=0.00 at 0x3b72390>]
>>>>
>>>
>> This is the issue - your dd uses "," as decimal point: 0,000496228
>> We expect: 0.000496228
>>
>> Can you share the output of "locale"? on the machine?
>>
>> Here I get:
>>
>> $ locale
>> LANG=en_US.UTF-8
>> LC_CTYPE="en_US.UTF-8"
>> LC_NUMERIC="en_US.UTF-8"
>> LC_TIME="en_US.UTF-8"
>> LC_COLLATE="en_US.UTF-8"
>> LC_MONETARY="en_US.UTF-8"
>> LC_MESSAGES="en_US.UTF-8"
>> LC_PAPER="en_US.UTF-8"
>> LC_NAME="en_US.UTF-8"
>> LC_ADDRESS="en_US.UTF-8"
>> LC_TELEPHONE="en_US.UTF-8"
>> LC_MEASUREMENT="en_US.UTF-8"
>> LC_IDENTIFICATION="en_US.UTF-8"
>> LC_ALL=
>>
>> Maybe we don't configure the test environment properly?
>>
>> Dan, do you have any insite on this?
>>
>> Nir
>>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Failing tests for storage-py27.

2017-07-31 Thread Petr Kotas
Hi,

I have encountered an issue with VDSM master when running tests.
Maybe I am doing something wrong, or I am overlooking something.

This is a clear master without any modification pulled with the latest
commits.
Did anyone please encountered the same issue:

== FAILURES
==
__ TestDirectioChecker.test_path_ok
__

self = 

def test_path_ok(self):
self.checks = 1
with temporaryPath(data=b"blah") as path:
checker = check.DirectioChecker(self.loop, path, self.complete)
checker.start()
self.loop.run_forever()
pprint.pprint(self.results)
result = self.results[0]
>   delay = result.delay()

storage/check_test.py:82:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = 

def delay(self):
# TODO: Raising MiscFileReadException for all errors to keep the old
# behavior. Should probably use StorageDomainAccessError.
if self.rc != 0:
raise exception.MiscFileReadException(self.path, self.rc,
self.err)
if not self.err:
raise exception.MiscFileReadException(self.path, "no stats")
stats = self.err.splitlines()[-1]
match = self._PATTERN.match(stats)
if not match:
raise exception.MiscFileReadException(self.path,
> "no match: %r" % stats)
E   MiscFileReadException: Internal file read failure:
('/var/tmp/tmpPpV1Rj', "no match: bytearray(b'4 bytes (4 B) copied,
0,000496228 s, 8,1 kB/s')")

../lib/vdsm/storage/check.py:372: MiscFileReadException
 Captured stdout call

[]
 93 tests deselected
=
== 1 failed, 1166 passed, 6 skipped, 93 deselected in
86.13 seconds ==
ERROR: InvocationError: '/vagrant/vdsm/.tox/storage-py27/bin/py.test -m not
(slow or stress) storage'
storage-py35 create: /vagrant/vdsm/.tox/storage-py35
ERROR: InterpreterNotFound: python3.5
storage-py36 create: /vagrant/vdsm/.tox/storage-py36
ERROR: InterpreterNotFound: python3.6

Thank You,
Petr
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Question about general testing

2017-07-18 Thread Petr Kotas
Hi Marc,

I have been working on a development environment for the oVirt. The
environment is basically two VMs running beside together. One runs the
engine, second is a host that runs the vdsm with nested virtualization.
 I am now working on the vagrant file with orchestration to make the
environment setup easier. So if You would wait for a few more days, You
will be able to start from my setup.

As for the containers. For you to have a full test setup, you would need to
place a VM inside the container and run a nested virtualization inside.
This is what the two projects you mentioned are doing. Therefore they are
not that lightweight as you would like.

I would recommend using the VM environment, which is the simplest solution.

I will send a reply again once my environment is up.

Petr






On Thu, Jul 13, 2017 at 4:52 PM, Greg Sheremeta  wrote:

> Does ovirt-system-tests meet your needs? It can leave the VMs standing
> when it's done.
>
> On Thu, Jul 13, 2017 at 10:39 AM, Marc Young <3vilpeng...@gmail.com>
> wrote:
>
>> I've been trying for weeks to come up with a better (most specifically
>> lighter) testing environment for external API requests (specifically
>> vagrant).
>>
>> Right now It basically hooks into a real running oVirt to spin up and
>> test VMs. It works but it's not portable or lightweight.
>>
>> I've been looking into the docker containers:
>>https://github.com/oVirt/ovirt-container-engine (doesnt look like
>> this is going to stay maintained? )
>>https://github.com/oVirt/ovirt-containers (this requires openshift
>> making it a giant yak to shave)
>>
>> Are there any thoughts on where to head from here? Im looking to purely
>> launch oVirt of specific versions and run some tests against it (launching
>> real VMs).
>>
>> I got the first docker one working, but it turned into a turtles problem
>> because there was no host, and adding a host requires ssh to be running
>> (which isnt), etc etc.
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
> --
> Greg Sheremeta, MBA
> Sr. Software Engineer
> Red Hat, Inc.
> gsher...@redhat.com
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Help understanding the conflict with libvirt-guests.service - gerrit patch 78693

2017-06-30 Thread Petr Kotas
Hi,

I am kindly asking for help with understanding the origin of conflict
within the *libvirt-guests*.service and *vdsmd.service*.

Explanation:

I am working on a graceful VM shutdown as described by the feature in a
Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1334982.

One way (the simplest one as described in the Bugzilla) of achieving the
required functionality is to utilize *"libvirt-guests.service"*, which does
exactly what is required. The second option is to write a new service that
does the shutdown and utilizes the *vdsm.* Since I am new, I do not know
what is the best solution.

Staying with the fist one I have discovered an old conflict between
*"vdsmd.service"
*and *"libvirt-guests.service"* explained in bug
https://bugzilla.redhat.com/show_bug.cgi?id=720359.
<https://bugzilla.redhat.com/show_bug.cgi?id=720359> I have tried to
reproduce described scenario and found that it is no longer an issue.
Therefore I have created a *proposal draft* patch to start a discussion,
whether it is really needed or not.

Further, the research in git history showed this conflict precedes the git
history, effectively blocking me in understanding details.

Does somebody know about this issue? I am grateful for any information that
can point me in the right direction.

Thank you in advance for any help.

Kind regards,
Petr Kotas
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] ovirt engine in docker container

2017-06-08 Thread Petr Kotas
Hi all,

I am containerizing the ovirt engine  with docker and docker-compose. Does
anybody tried something similar?

I would like to share knowledge and build universal dev environment to
easier our lives.

Thanks :)

Petr Kotas
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel