Re: [ovirt-devel] [UI] New Domain dialog broken
Update: A revert patch was merged (https://gerrit.ovirt.org/#/c/42886/) now the new/edit storage domain dialogs work correctly On 06/25/2015 05:23 PM, Tal Nisan wrote: quoting myself from an email sent to the UX team: I've traced the root cause of the broken new/edit storage domain windows to a patch from yesterday - https://gerrit.ovirt.org/42686 specifically [1] What happens is that after this patch the list values are set prior to selecting the selected element and since no element is selected the list is rendered with an empty list element as default which presents us with the immediate problem of NPE in NfsStorageView:158 and the future problem of actually being able to select an empty NFS version. While I can fix this error I'm afraid I will break functionality for the new host/cluster dropdown rendering Alexander's patch pointless so Einav/Alexander I leave it up to you to sort it out, I'm here in case you have any further questions, needless to say that this is an urgent issue since the user cannot create or update a storage domain through the webadmin [1] https://gerrit.ovirt.org/#/c/42686/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java On 06/25/2015 04:11 PM, Piotr Kliczewski wrote: Hi, I rebuilt the engine master today and get following error when opening a dialog to add storage domain: Can someone please take a look? Thanks, Piotr Thu Jun 25 14:49:01 GMT+200 2015 SEVERE: Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) __gwt$exception: : Tab(...) is undefined at Unknown.Akv(Unknown Source) at Unknown.Mjf(Unknown Source) at Unknown.Pjf(Unknown Source) at Unknown.Njf(Unknown Source) at Unknown.Xjf(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.dhk(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Rkv(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Hkv(Unknown Source) at Unknown.Sgk(Unknown Source) at Unknown.rkv(Unknown Source) at Unknown.vkv(Unknown Source) at Unknown.fsv(Unknown Source) at Unknown.usv(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.feq(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.o6n(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.thk(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.S5n(Unknown Source) at Unknown.n6n(Unknown Source) at Unknown.m6n(Unknown Source) at Unknown.O3p(Unknown Source) at Unknown.T3p(Unknown Source) at Unknown.P3p(Unknown Source) at Unknown.$5p(Unknown Source) at Unknown.Y5p(Unknown Source) at Unknown.Z5p(Unknown Source) at Unknown.j6p(Unknown Source) at Unknown.rvn(Unknown Source) at Unknown.uvn(Unknown Source) at Unknown.lzn(Unknown Source) at Unknown.ozn(Unknown Source) at Unknown.jyn(Unknown Source) at Unknown.myn(Unknown Source) at Unknown.RBe(Unknown Source) at Unknown.Rhk(Unknown Source) at Unknown.M3(Unknown Source) at Unknown.d4(Unknown Source) at Unknown.Lof/c.onreadystatechange<(Unknown Source) at Unknown.Xt(Unknown Source) at Unknown._t(Unknown Source) at Unknown.$t/<(Unknown Source) at Unknown.anonymous(Unknown Source) http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html Line 23283 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [UI] New Domain dialog broken
quoting myself from an email sent to the UX team: I've traced the root cause of the broken new/edit storage domain windows to a patch from yesterday - https://gerrit.ovirt.org/42686 specifically [1] What happens is that after this patch the list values are set prior to selecting the selected element and since no element is selected the list is rendered with an empty list element as default which presents us with the immediate problem of NPE in NfsStorageView:158 and the future problem of actually being able to select an empty NFS version. While I can fix this error I'm afraid I will break functionality for the new host/cluster dropdown rendering Alexander's patch pointless so Einav/Alexander I leave it up to you to sort it out, I'm here in case you have any further questions, needless to say that this is an urgent issue since the user cannot create or update a storage domain through the webadmin [1] https://gerrit.ovirt.org/#/c/42686/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java On 06/25/2015 04:11 PM, Piotr Kliczewski wrote: Hi, I rebuilt the engine master today and get following error when opening a dialog to add storage domain: Can someone please take a look? Thanks, Piotr Thu Jun 25 14:49:01 GMT+200 2015 SEVERE: Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) __gwt$exception: : Tab(...) is undefined at Unknown.Akv(Unknown Source) at Unknown.Mjf(Unknown Source) at Unknown.Pjf(Unknown Source) at Unknown.Njf(Unknown Source) at Unknown.Xjf(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.dhk(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Rkv(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Hkv(Unknown Source) at Unknown.Sgk(Unknown Source) at Unknown.rkv(Unknown Source) at Unknown.vkv(Unknown Source) at Unknown.fsv(Unknown Source) at Unknown.usv(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.feq(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.o6n(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.thk(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.S5n(Unknown Source) at Unknown.n6n(Unknown Source) at Unknown.m6n(Unknown Source) at Unknown.O3p(Unknown Source) at Unknown.T3p(Unknown Source) at Unknown.P3p(Unknown Source) at Unknown.$5p(Unknown Source) at Unknown.Y5p(Unknown Source) at Unknown.Z5p(Unknown Source) at Unknown.j6p(Unknown Source) at Unknown.rvn(Unknown Source) at Unknown.uvn(Unknown Source) at Unknown.lzn(Unknown Source) at Unknown.ozn(Unknown Source) at Unknown.jyn(Unknown Source) at Unknown.myn(Unknown Source) at Unknown.RBe(Unknown Source) at Unknown.Rhk(Unknown Source) at Unknown.M3(Unknown Source) at Unknown.d4(Unknown Source) at Unknown.Lof/c.onreadystatechange<(Unknown Source) at Unknown.Xt(Unknown Source) at Unknown._t(Unknown Source) at Unknown.$t/<(Unknown Source) at Unknown.anonymous(Unknown Source) http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html Line 23283 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] [UI] New Domain dialog broken
Hi, I rebuilt the engine master today and get following error when opening a dialog to add storage domain: Can someone please take a look? Thanks, Piotr Thu Jun 25 14:49:01 GMT+200 2015 SEVERE: Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) __gwt$exception: : Tab(...) is undefined at Unknown.Akv(Unknown Source) at Unknown.Mjf(Unknown Source) at Unknown.Pjf(Unknown Source) at Unknown.Njf(Unknown Source) at Unknown.Xjf(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.dhk(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Rkv(Unknown Source) at Unknown.zY(Unknown Source) at Unknown.Hkv(Unknown Source) at Unknown.Sgk(Unknown Source) at Unknown.rkv(Unknown Source) at Unknown.vkv(Unknown Source) at Unknown.fsv(Unknown Source) at Unknown.usv(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.feq(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.U5n(Unknown Source) at Unknown.o6n(Unknown Source) at Unknown.bhk(Unknown Source) at Unknown.thk(Unknown Source) at Unknown.$jr(Unknown Source) at Unknown.S5n(Unknown Source) at Unknown.n6n(Unknown Source) at Unknown.m6n(Unknown Source) at Unknown.O3p(Unknown Source) at Unknown.T3p(Unknown Source) at Unknown.P3p(Unknown Source) at Unknown.$5p(Unknown Source) at Unknown.Y5p(Unknown Source) at Unknown.Z5p(Unknown Source) at Unknown.j6p(Unknown Source) at Unknown.rvn(Unknown Source) at Unknown.uvn(Unknown Source) at Unknown.lzn(Unknown Source) at Unknown.ozn(Unknown Source) at Unknown.jyn(Unknown Source) at Unknown.myn(Unknown Source) at Unknown.RBe(Unknown Source) at Unknown.Rhk(Unknown Source) at Unknown.M3(Unknown Source) at Unknown.d4(Unknown Source) at Unknown.Lof/c.onreadystatechange<(Unknown Source) at Unknown.Xt(Unknown Source) at Unknown._t(Unknown Source) at Unknown.$t/<(Unknown Source) at Unknown.anonymous(Unknown Source) http://localhost:8080/ovirt-engine/webadmin/76B50B2E63805C707DBDD2E6CC5344F7.cache.html Line 23283 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
