Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-12-07 Thread Vojtech Szocs


- Original Message -
> From: "Yuko Katabami" <ykata...@redhat.com>
> To: "Vojtech Szocs" <vsz...@redhat.com>
> Cc: devel@ovirt.org, "Eliraz Levi" <el...@redhat.com>
> Sent: Friday, November 27, 2015 10:01:31 AM
> Subject: Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg,"
> 
> On Fri, Nov 27, 2015 at 1:41 AM, Vojtech Szocs <vsz...@redhat.com> wrote:
> 
> >
> >
> > - Original Message -
> > > From: "Yuko Katabami" <ykata...@redhat.com>
> > > To: devel@ovirt.org
> > > Sent: Tuesday, November 24, 2015 12:51:11 PM
> > > Subject: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg,"
> > >
> > > Hello all,
> > >
> > > Here is another question:
> > >
> > > File: UIMessages
> > > Resource IDs:
> > > numberValidationNumberBetweenInvalidReason
> > > numberValidationNumberGreaterInvalidReason
> > > numberValidationNumberLessInvalidReason
> > > Strings:
> > >
> > ​​
> > {0} between {1} and {2}.
> > > {0} greater than or equal to {1}.
> > > {0} less than or equal to {1}.
> > > Question: Could you please provide some example of those messages?
> > Comment
> > > section in each of those strings states "0=prefixMsg" but I would like to
> > > know what will actually replace {0}, so that I can translate them
> > properly.
> >
> > Dear Yuko,
> >
> > to my knowledge, above 3 msg keys [numberValidation*] are meant
> > to replace existing 3 msg keys [integerValidation*] as part of
> > UI validation logic refactoring.
> >
> > Please note that [numberValidation*] msg's are not used yet,
> > even though they were introduced into UIMessages.java file.
> >
> > In general, 'prefixMsg' in [numberValidation*] msg's should
> > follow the same structure as in [integerValidation*] msg's.
> >
> > Example 'prefixMsg':
> >
> > ​​
> > This field must contain an integer number
> >
> > Related patch: https://gerrit.ovirt.org/#/c/48082/
> 
> 
> ​Hi Vojtech,
> 
> Thank you for your help.
> 
> While applying change to translation, I realized that this does not work
> well in some non-English languages, including Japanese.
> 
> In these examples,
> ​
> This field must contain an integer number between {1} and {2}.
> ​
> This field must contain an integer number greater than or equal to {1}.
> ​
> This field must contain an integer number less than or equal to {1}.
> 
> I need to place the part describing the number (i.g. close after betwee,
> greater, less) before the word "an integer number" in my translation.
> 
> Order of words change depending on the language.
> ​Thus it would be better if
> ​​
> {0} prefixMsg is not used in those three strings so that we can change the
> order when we translate these.

Hi Yuko, sorry for my late response here.

As mentioned by you and Einav, we should avoid "structuring" sentences
because as you wrote, different languages use different order of words.
I'll try to emphasize that in my reviews and patches.

> 
> Please let me know if you would like me to file a BZ for this.

Yes, please do.

Maybe worth investigating all such problematic (structured) messages
and filing RFE BZ to replace the structuring with full sentences.

> 
> Kind regards,
> 
> 
> Yuko
> 
> 
> >
> > >
> > > Kind regards,
> > >
> > > Yuko
> > >
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> >
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-27 Thread Yuko Katabami
On Fri, Nov 27, 2015 at 1:41 AM, Vojtech Szocs <vsz...@redhat.com> wrote:

>
>
> - Original Message -
> > From: "Yuko Katabami" <ykata...@redhat.com>
> > To: devel@ovirt.org
> > Sent: Tuesday, November 24, 2015 12:51:11 PM
> > Subject: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg,"
> >
> > Hello all,
> >
> > Here is another question:
> >
> > File: UIMessages
> > Resource IDs:
> > numberValidationNumberBetweenInvalidReason
> > numberValidationNumberGreaterInvalidReason
> > numberValidationNumberLessInvalidReason
> > Strings:
> >
> ​​
> {0} between {1} and {2}.
> > {0} greater than or equal to {1}.
> > {0} less than or equal to {1}.
> > Question: Could you please provide some example of those messages?
> Comment
> > section in each of those strings states "0=prefixMsg" but I would like to
> > know what will actually replace {0}, so that I can translate them
> properly.
>
> Dear Yuko,
>
> to my knowledge, above 3 msg keys [numberValidation*] are meant
> to replace existing 3 msg keys [integerValidation*] as part of
> UI validation logic refactoring.
>
> Please note that [numberValidation*] msg's are not used yet,
> even though they were introduced into UIMessages.java file.
>
> In general, 'prefixMsg' in [numberValidation*] msg's should
> follow the same structure as in [integerValidation*] msg's.
>
> Example 'prefixMsg':
>
> ​​
> This field must contain an integer number
>
> Related patch: https://gerrit.ovirt.org/#/c/48082/


​Hi Vojtech,

Thank you for your help.

While applying change to translation, I realized that this does not work
well in some non-English languages, including Japanese.

In these examples,
​
This field must contain an integer number between {1} and {2}.
​
This field must contain an integer number greater than or equal to {1}.
​
This field must contain an integer number less than or equal to {1}.

I need to place the part describing the number (i.g. close after betwee,
greater, less) before the word "an integer number" in my translation.

Order of words change depending on the language.
​Thus it would be better if
​​
{0} prefixMsg is not used in those three strings so that we can change the
order when we translate these.

Please let me know if you would like me to file a BZ for this.

Kind regards,


Yuko


>
> >
> > Kind regards,
> >
> > Yuko
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-26 Thread Eliraz Levi
Hi how are you? 

NumberRangeValidation will be used. 
The patch had yet to be merged to master. 
(https://gerrit.ovirt.org/#/c/48082/6)

BR'
Eliraz :)

- Original Message - 

From: "Einav Cohen" <eco...@redhat.com> 
To: "Yuko Katabami" <ykata...@redhat.com>, "Eliraz Levi" <el...@redhat.com> 
Cc: devel@ovirt.org 
Sent: Tuesday, 24 November, 2015 3:44:04 PM 
Subject: Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg," 



- Original Message - 
From: "Yuko Katabami" <ykata...@redhat.com> 
Sent: Tuesday, November 24, 2015 6:51:11 AM 

Hello all, 

Here is another question: 

File: UIMessages 
Resource IDs: 
numberValidationNumberBetweenInvalidReason 
numberValidationNumberGreaterInvalidReason 
numberValidationNumberLessInvalidReason 
Strings: 
{0} between {1} and {2}. 
{0} greater than or equal to {1}. 
{0} less than or equal to {1}. 
Question: Could you please provide some example of those messages? Comment 
section in each of those strings states "0=prefixMsg" but I would like to 
know what will actually replace {0}, so that I can translate them properly. 

@Eliraz? 



[again - these belong to NumberRangeValidation which doesn't seem to be used 
anywhere in the code?] 




Kind regards, 

Yuko 

___ 
Devel mailing list 
Devel@ovirt.org 
http://lists.ovirt.org/mailman/listinfo/devel 


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-26 Thread Vojtech Szocs


- Original Message -
> From: "Yuko Katabami" <ykata...@redhat.com>
> To: devel@ovirt.org
> Sent: Tuesday, November 24, 2015 12:51:11 PM
> Subject: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg,"
> 
> Hello all,
> 
> Here is another question:
> 
> File: UIMessages
> Resource IDs:
> numberValidationNumberBetweenInvalidReason
> numberValidationNumberGreaterInvalidReason
> numberValidationNumberLessInvalidReason
> Strings:
> {0} between {1} and {2}.
> {0} greater than or equal to {1}.
> {0} less than or equal to {1}.
> Question: Could you please provide some example of those messages? Comment
> section in each of those strings states "0=prefixMsg" but I would like to
> know what will actually replace {0}, so that I can translate them properly.

Dear Yuko,

to my knowledge, above 3 msg keys [numberValidation*] are meant
to replace existing 3 msg keys [integerValidation*] as part of
UI validation logic refactoring.

Please note that [numberValidation*] msg's are not used yet,
even though they were introduced into UIMessages.java file.

In general, 'prefixMsg' in [numberValidation*] msg's should
follow the same structure as in [integerValidation*] msg's.

Example 'prefixMsg':
  This field must contain an integer number

Related patch: https://gerrit.ovirt.org/#/c/48082/

> 
> Kind regards,
> 
> Yuko
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-26 Thread Yuko Katabami
Hi Eliraz,

Thanks for your reply.
We need to know what will be replacing placeholder {0} in those three
strings in order to translate them.
Could you please provide me the examples?


​
{0} between {1} and {2}.
{0} greater than or equal to {1}.
{0} less than or equal to {1}.



Kind regards,

Yuko


On Fri, Nov 27, 2015 at 12:21 AM, Eliraz Levi <el...@redhat.com> wrote:

> Hi how are you?
>
> NumberRangeValidation will be used.
> The patch had yet to be merged to master.
> (https://gerrit.ovirt.org/#/c/48082/6)
>
> BR'
> Eliraz :)
>
> - Original Message -
>
> From: "Einav Cohen" <eco...@redhat.com>
> To: "Yuko Katabami" <ykata...@redhat.com>, "Eliraz Levi" <el...@redhat.com
> >
> Cc: devel@ovirt.org
> Sent: Tuesday, 24 November, 2015 3:44:04 PM
> Subject: Re: [ovirt-devel] [oVirt 3.6 Localization Question #39]
> "prefixMsg,"
>
>
>
> - Original Message -
> From: "Yuko Katabami" <ykata...@redhat.com>
> Sent: Tuesday, November 24, 2015 6:51:11 AM
>
> Hello all,
>
> Here is another question:
>
> File: UIMessages
> Resource IDs:
> numberValidationNumberBetweenInvalidReason
> numberValidationNumberGreaterInvalidReason
> numberValidationNumberLessInvalidReason
> Strings:
> ​​
> {0} between {1} and {2}.
> {0} greater than or equal to {1}.
> {0} less than or equal to {1}.
> Question: Could you please provide some example of those messages? Comment
> section in each of those strings states "0=prefixMsg" but I would like to
> know what will actually replace {0}, so that I can translate them properly.
>
> @Eliraz?
>
>
>
> [again - these belong to NumberRangeValidation which doesn't seem to be
> used
> anywhere in the code?]
>
>
> 
>
> Kind regards,
>
> Yuko
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
> 
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-26 Thread Yuko Katabami
HI Eliraz,

Sorry, please disregard my last message.
Vojtech has provided me an example of the prefixed message already.

Many thanks to both of you!

Yuko


On Fri, Nov 27, 2015 at 9:18 AM, Yuko Katabami <ykata...@redhat.com> wrote:

> Hi Eliraz,
>
> Thanks for your reply.
> We need to know what will be replacing placeholder {0} in those three
> strings in order to translate them.
> Could you please provide me the examples?
>
>
> ​
> {0} between {1} and {2}.
> {0} greater than or equal to {1}.
> {0} less than or equal to {1}.
>
>
>
> Kind regards,
>
> Yuko
>
>
> On Fri, Nov 27, 2015 at 12:21 AM, Eliraz Levi <el...@redhat.com> wrote:
>
>> Hi how are you?
>>
>> NumberRangeValidation will be used.
>> The patch had yet to be merged to master.
>> (https://gerrit.ovirt.org/#/c/48082/6)
>>
>> BR'
>> Eliraz :)
>>
>> - Original Message -
>>
>> From: "Einav Cohen" <eco...@redhat.com>
>> To: "Yuko Katabami" <ykata...@redhat.com>, "Eliraz Levi" <
>> el...@redhat.com>
>> Cc: devel@ovirt.org
>> Sent: Tuesday, 24 November, 2015 3:44:04 PM
>> Subject: Re: [ovirt-devel] [oVirt 3.6 Localization Question #39]
>> "prefixMsg,"
>>
>>
>>
>> - Original Message -
>> From: "Yuko Katabami" <ykata...@redhat.com>
>> Sent: Tuesday, November 24, 2015 6:51:11 AM
>>
>> Hello all,
>>
>> Here is another question:
>>
>> File: UIMessages
>> Resource IDs:
>> numberValidationNumberBetweenInvalidReason
>> numberValidationNumberGreaterInvalidReason
>> numberValidationNumberLessInvalidReason
>> Strings:
>> ​​
>> {0} between {1} and {2}.
>> {0} greater than or equal to {1}.
>> {0} less than or equal to {1}.
>> Question: Could you please provide some example of those messages? Comment
>> section in each of those strings states "0=prefixMsg" but I would like to
>> know what will actually replace {0}, so that I can translate them
>> properly.
>>
>> @Eliraz?
>>
>>
>>
>> [again - these belong to NumberRangeValidation which doesn't seem to be
>> used
>> anywhere in the code?]
>>
>>
>> 
>>
>> Kind regards,
>>
>> Yuko
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>> 
>>
>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-25 Thread Yuko Katabami
Hello Eliraz,

Sorry to bother you.
Could you please provide us an answer to this question, so that we can
complete our translation.

Thank you,

Yuko

On Tue, Nov 24, 2015 at 11:44 PM, Einav Cohen  wrote:

> > - Original Message -
> > From: "Yuko Katabami" 
> > Sent: Tuesday, November 24, 2015 6:51:11 AM
> >
> > Hello all,
> >
> > Here is another question:
> >
> > File: UIMessages
> > Resource IDs:
> > numberValidationNumberBetweenInvalidReason
> > numberValidationNumberGreaterInvalidReason
> > numberValidationNumberLessInvalidReason
> > Strings:
> > {0} between {1} and {2}.
> > {0} greater than or equal to {1}.
> > {0} less than or equal to {1}.
> > Question: Could you please provide some example of those messages?
> Comment
> > section in each of those strings states "0=prefixMsg" but I would like to
> > know what will actually replace {0}, so that I can translate them
> properly.
>
> @Eliraz?
> [again - these belong to NumberRangeValidation which doesn't seem to be
> used
> anywhere in the code?]
>
> >
> > Kind regards,
> >
> > Yuko
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg,"

2015-11-24 Thread Yuko Katabami
Hello all,

Here is another question:

File: UIMessages
Resource IDs:
numberValidationNumberBetweenInvalidReason
numberValidationNumberGreaterInvalidReason
numberValidationNumberLessInvalidReason
Strings:
{0} between {1} and {2}.
{0} greater than or equal to {1}.
{0} less than or equal to {1}.
Question: Could you please provide some example of those messages? Comment
section in each of those strings states "0=prefixMsg" but I would like to
know what will actually replace {0}, so that I can translate them properly.

Kind regards,

Yuko
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #39] "prefixMsg, "

2015-11-24 Thread Einav Cohen
> - Original Message -
> From: "Yuko Katabami" 
> Sent: Tuesday, November 24, 2015 6:51:11 AM
> 
> Hello all,
> 
> Here is another question:
> 
> File: UIMessages
> Resource IDs:
> numberValidationNumberBetweenInvalidReason
> numberValidationNumberGreaterInvalidReason
> numberValidationNumberLessInvalidReason
> Strings:
> {0} between {1} and {2}.
> {0} greater than or equal to {1}.
> {0} less than or equal to {1}.
> Question: Could you please provide some example of those messages? Comment
> section in each of those strings states "0=prefixMsg" but I would like to
> know what will actually replace {0}, so that I can translate them properly.

@Eliraz?
[again - these belong to NumberRangeValidation which doesn't seem to be used 
anywhere in the code?]

> 
> Kind regards,
> 
> Yuko
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel