[ovirt-devel] Re: [VDSM] Simplifying project ACL

2019-02-26 Thread Nir Soffer
On Mon, Feb 25, 2019 at 9:08 PM Dan Kenigsberg  wrote:

> On Mon, 25 Feb 2019, 20:52 Nir Soffer,  wrote:
>
>> Hi all,
>>
>> I learned recently that we have these groups in the project:
>> vdsm-maintainers: https://gerrit.ovirt.org/#/admin/groups/15,members
>> vdsm-master-maintainers:
>> https://gerrit.ovirt.org/#/admin/groups/106,members
>>
>> And we have this complicated access control list:
>> https://gerrit.ovirt.org/#/admin/projects/vdsm,access
>>
>> Developers in vdsm-master-maintainers can approve patches, but cannot
>> submit.
>> I find this strange and more complicated than needed. I think we can
>> trust people
>> in the vdsm-master-maintainers group to do the right thing.
>>
>> I sent this patch to simplify the ACL (with help of Gerrit UI):
>> https://gerrit.ovirt.org/c/97738/
>>
>> Thoughts?
>>
>
> I don't recall the origin of this differentiation, and I'd rather simplify
> it.  It makes simple sense that vdsm-master-maintainers are in full control
> of the master branch of vdsm.
>
> +1 from me.
>

Barak merged the patch so people in
https://gerrit.ovirt.org/#/admin/groups/106,members
Should be able to submit now.

Nir
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MFKPK75ETYTBI7NQRKQJZTNTV24WWVGR/


[ovirt-devel] Re: [VDSM] Simplifying project ACL

2019-02-25 Thread Dan Kenigsberg
On Mon, 25 Feb 2019, 20:52 Nir Soffer,  wrote:

> Hi all,
>
> I learned recently that we have these groups in the project:
> vdsm-maintainers: https://gerrit.ovirt.org/#/admin/groups/15,members
> vdsm-master-maintainers:
> https://gerrit.ovirt.org/#/admin/groups/106,members
>
> And we have this complicated access control list:
> https://gerrit.ovirt.org/#/admin/projects/vdsm,access
>
> Developers in vdsm-master-maintainers can approve patches, but cannot
> submit.
> I find this strange and more complicated than needed. I think we can trust
> people
> in the vdsm-master-maintainers group to do the right thing.
>
> I sent this patch to simplify the ACL (with help of Gerrit UI):
> https://gerrit.ovirt.org/c/97738/
>
> Thoughts?
>

I don't recall the origin of this differentiation, and I'd rather simplify
it.  It makes simple sense that vdsm-master-maintainers are in full control
of the master branch of vdsm.

+1 from me.
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/CZT574U5F7YM4ZWTHQBG7WPWKVBRJ7XP/