Re: [ovirt-devel] Vdsm patches need review and merge

2014-05-16 Thread Francesco Romani 
Hi,

Unfortunately, we just found 

https://bugzilla.redhat.com/show_bug.cgi?id=1098539

This looks like an engine bug, however.
Can someone please check and help with a fix?

Thanks,

- Original Message -
> From: "Dan Kenigsberg" 
> To: "Francesco Romani" 
> Cc: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" , "Gilad 
> Chaplik(gchap...@redhat.com)"
> , "Doron Fediuck (dfedi...@redhat.com)" 
> , "Chuan Liao (Jason Liao,
> HPservers-Core-OE-PSC)" , devel@ovirt.org, "Shang-Chun 
> Liang (David Liang,
> HPservers-Core-OE-PSC)" 
> Sent: Thursday, May 8, 2014 4:02:44 PM
> Subject: Re: Vdsm patches need review and merge
> 
> On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote:
> > 
> > - Original Message -
> > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" 
> > > To: "Dan Kenigsberg (dan...@redhat.com)" , "Francesco
> > > Romani" 
> > > Cc: "Gilad Chaplik  (gchap...@redhat.com)"
> > > , "Doron Fediuck
> > > (dfedi...@redhat.com)" , "Chuan Liao (Jason Liao,
> > > HPservers-Core-OE-PSC)" ,
> > > devel@ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
> > > 
> > > Sent: Thursday, May 8, 2014 2:33:14 PM
> > > Subject: RE: Vdsm patches need review and merge
> > > 
> > > Hi Dan/Francesco,
> > > 
> > > Could you help to review and merge these patches:
> > > http://gerrit.ovirt.org/#/c/27515/  (This patch is needed by 26876 since
> > > some
> > > comments in that patch need to modify caps module)
> > > http://gerrit.ovirt.org/#/c/26876/
> > > http://gerrit.ovirt.org/#/c/27403/
> > > 
> > > I didn't modify some comments in 26876 since I think they are related
> > > with
> > > codes refactor and literal syntax. I will submit a separate patch to
> > > modify
> > > these kinds of comments of numa feature altogether later. Could you
> > > please
> > > now focus on the functionality since we need to merge these patches ASAP?
> > 
> > http://gerrit.ovirt.org/#/c/27403
> > I'm OK with it (gave +1)
> > 
> > http://gerrit.ovirt.org/#/c/26876
> > I don't have objections and I don't see blockers for the functionality.
> > I'm not 100% happy with the implementation, but the existing one is on par
> > with most of code, and if we're in hurry, I guess refinements can wait.
> > 
> > http://gerrit.ovirt.org/#/c/27515
> > good enough for the same reasons above (gave +1)
> 
> Puritans would suggest to squash this into 26876, or fix the commit
> message - prior to 26876 nothing uses these private methods. But never
> mind, taken.
> 

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Vdsm patches need review and merge

2014-05-08 Thread Dan Kenigsberg 
On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote:
> 
> - Original Message -
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" 
> > To: "Dan Kenigsberg (dan...@redhat.com)" , "Francesco 
> > Romani" 
> > Cc: "Gilad Chaplik  (gchap...@redhat.com)" 
> > , "Doron Fediuck
> > (dfedi...@redhat.com)" , "Chuan Liao (Jason Liao, 
> > HPservers-Core-OE-PSC)" ,
> > devel@ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" 
> > 
> > Sent: Thursday, May 8, 2014 2:33:14 PM
> > Subject: RE: Vdsm patches need review and merge
> > 
> > Hi Dan/Francesco,
> > 
> > Could you help to review and merge these patches:
> > http://gerrit.ovirt.org/#/c/27515/  (This patch is needed by 26876 since 
> > some
> > comments in that patch need to modify caps module)
> > http://gerrit.ovirt.org/#/c/26876/
> > http://gerrit.ovirt.org/#/c/27403/
> > 
> > I didn't modify some comments in 26876 since I think they are related with
> > codes refactor and literal syntax. I will submit a separate patch to modify
> > these kinds of comments of numa feature altogether later. Could you please
> > now focus on the functionality since we need to merge these patches ASAP?
> 
> http://gerrit.ovirt.org/#/c/27403
> I'm OK with it (gave +1)
> 
> http://gerrit.ovirt.org/#/c/26876
> I don't have objections and I don't see blockers for the functionality.
> I'm not 100% happy with the implementation, but the existing one is on par
> with most of code, and if we're in hurry, I guess refinements can wait.
> 
> http://gerrit.ovirt.org/#/c/27515
> good enough for the same reasons above (gave +1)

Puritans would suggest to squash this into 26876, or fix the commit
message - prior to 26876 nothing uses these private methods. But never
mind, taken.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Vdsm patches need review and merge

2014-05-08 Thread Francesco Romani 

- Original Message -
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" 
> To: "Dan Kenigsberg (dan...@redhat.com)" , "Francesco 
> Romani" 
> Cc: "Gilad Chaplik  (gchap...@redhat.com)" 
> , "Doron Fediuck
> (dfedi...@redhat.com)" , "Chuan Liao (Jason Liao, 
> HPservers-Core-OE-PSC)" ,
> devel@ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" 
> 
> Sent: Thursday, May 8, 2014 2:33:14 PM
> Subject: RE: Vdsm patches need review and merge
> 
> Hi Dan/Francesco,
> 
> Could you help to review and merge these patches:
> http://gerrit.ovirt.org/#/c/27515/  (This patch is needed by 26876 since some
> comments in that patch need to modify caps module)
> http://gerrit.ovirt.org/#/c/26876/
> http://gerrit.ovirt.org/#/c/27403/
> 
> I didn't modify some comments in 26876 since I think they are related with
> codes refactor and literal syntax. I will submit a separate patch to modify
> these kinds of comments of numa feature altogether later. Could you please
> now focus on the functionality since we need to merge these patches ASAP?

http://gerrit.ovirt.org/#/c/27403
I'm OK with it (gave +1)

http://gerrit.ovirt.org/#/c/26876
I don't have objections and I don't see blockers for the functionality.
I'm not 100% happy with the implementation, but the existing one is on par
with most of code, and if we're in hurry, I guess refinements can wait.

http://gerrit.ovirt.org/#/c/27515
good enough for the same reasons above (gave +1)

Bests,

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Vdsm patches need review and merge

2014-05-08 Thread Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) 
Hi Dan/Francesco,

Could you help to review and merge these patches:
http://gerrit.ovirt.org/#/c/27515/  (This patch is needed by 26876 since some 
comments in that patch need to modify caps module)
http://gerrit.ovirt.org/#/c/26876/
http://gerrit.ovirt.org/#/c/27403/

I didn't modify some comments in 26876 since I think they are related with 
codes refactor and literal syntax. I will submit a separate patch to modify 
these kinds of comments of numa feature altogether later. Could you please now 
focus on the functionality since we need to merge these patches ASAP?

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei@hp.com

From: Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC)
Sent: Thursday, May 08, 2014 10:35 AM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Martin Sivak (msi...@redhat.com); 
Dan Kenigsberg (dan...@redhat.com)
Cc: Gilad Chaplik  (gchap...@redhat.com); Doron Fediuck 
(dfedi...@redhat.com); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); 
devel@ovirt.org
Subject: RE: Vdsm patches need review and merge

Hi Dan,
I heard that Martin is in TPO now, would you please take a look on these 
patches and merge it, thanks.

Best regards,
David Liang

From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Thursday, May 08, 2014 10:31 AM
To: Martin Sivak (msi...@redhat.com); Dan Kenigsberg 
(dan...@redhat.com)
Cc: Gilad Chaplik mailto:gchap...@redhat.com>> 
(gchap...@redhat.com); Doron Fediuck 
(dfedi...@redhat.com); Liang, Shang-Chun (David 
Liang, HPservers-Core-OE-PSC); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); 
devel@ovirt.org
Subject: Vdsm patches need review and merge

Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the 
transferred data format because of the xmlrpc limitations. So could you please 
review them again?

Hi Dan,
I have modified your comments for some of the above patches. Could you please 
take a look and merge those if no more comments?

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei@hp.com

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Vdsm patches need review and merge

2014-05-07 Thread Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC) 
Hi Dan,
I heard that Martin is in TPO now, would you please take a look on these 
patches and merge it, thanks.

Best regards,
David Liang

From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Thursday, May 08, 2014 10:31 AM
To: Martin Sivak (msi...@redhat.com); Dan Kenigsberg (dan...@redhat.com)
Cc: Gilad Chaplik  (gchap...@redhat.com); Doron Fediuck 
(dfedi...@redhat.com); Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); 
Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); devel@ovirt.org
Subject: Vdsm patches need review and merge

Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the 
transferred data format because of the xmlrpc limitations. So could you please 
review them again?

Hi Dan,
I have modified your comments for some of the above patches. Could you please 
take a look and merge those if no more comments?

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei@hp.com

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Vdsm patches need review and merge

2014-05-07 Thread Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) 
Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the 
transferred data format because of the xmlrpc limitations. So could you please 
review them again?

Hi Dan,
I have modified your comments for some of the above patches. Could you please 
take a look and merge those if no more comments?

Thanks & Best Regards
Shi, Xiao-Lei (Bruce)

Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei@hp.com

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel