Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
Thanks! On 11/16/2015 07:44 PM, David Caro wrote: Done! On 11/16 15:28, Dan Kenigsberg wrote: On Wed, Apr 29, 2015 at 10:03:47AM +0200, David Caro wrote: Done On 04/20, Dan Kenigsberg wrote: On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: Hi! On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to Bala (barum...@redhat.com) ? +1 from me. ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 Thanks. Few months have passed, and now we need Sahina herself as an admin of the this branch. Would you please add her as well? ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
Done! On 11/16 15:28, Dan Kenigsberg wrote: > On Wed, Apr 29, 2015 at 10:03:47AM +0200, David Caro wrote: > > Done > > > > On 04/20, Dan Kenigsberg wrote: > > > On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > > > > Hi! > > > > > > > > On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights > > > > to > > > > Bala (barum...@redhat.com) ? > > > > > > +1 from me. > > > > > > ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 > > Thanks. Few months have passed, and now we need Sahina herself as an > admin of the this branch. Would you please add her as well? -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 signature.asc Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
On Wed, Apr 29, 2015 at 10:03:47AM +0200, David Caro wrote: > Done > > On 04/20, Dan Kenigsberg wrote: > > On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > > > Hi! > > > > > > On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to > > > Bala (barum...@redhat.com) ? > > > > +1 from me. > > > > ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 Thanks. Few months have passed, and now we need Sahina herself as an admin of the this branch. Would you please add her as well? ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
Done! On 04/29, Dan Kenigsberg wrote: > On Wed, Apr 29, 2015 at 12:04:52PM +0200, David Caro wrote: > > On 04/29, Balamurugan Arumugam wrote: > > > > > > > > > - Original Message - > > > > From: "David Caro" > > > > To: "Sahina Bose" > > > > Cc: "Dan Kenigsberg" , in...@ovirt.org, "Balamurugan > > > > Arumugam" , > > > > devel@ovirt.org > > > > Sent: Wednesday, April 29, 2015 1:38:03 PM > > > > Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster > > > > > > > > You want also push rights? It's not the same submit, push, create > > > > reference, > > > > verify, code review. > > > > > > > > All those are different rights. I've added the submit, code-review and > > > > verify > > > > rights. Let me know if you want also the rest. > > > > > > > > > > > > Also note that pushing and submitting is not the same, pushing will skip > > > > gerrit > > > > and any gerrit checks, so it's usually something to avoid. While > > > > submitting > > > > is > > > > done through gerrit, what allows gerrit to check validity of the code > > > > to be > > > > merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by > > > > flabs). > > > > > > > > > > The idea behind push right is that we would do periodical rebase of > > > ovirt-3.5-gluster branch with ovirt-3.5 branch. Is this recommended way > > > to do that? > > > > > > > Which kind of rebase? Does it require using --force? > > Yes. The expected use case is as such: > > - Bala merges patches onto his ovirt-3.5-gluster branch via gerrit. > - Important patches are merged onto ovirt-3.5 by Yaniv. > - Bala wants to have them in ovirt-3.5-gluster > - Bala rebases ovirt-3.5-gluster on top of ovirt-3.5 on his host, and > pushes the new has as the tip new of ovirt-3.5-gluster. > > Pleaes let him do that! > > Dan. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpl1BL9nsEQp.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
On Wed, Apr 29, 2015 at 12:04:52PM +0200, David Caro wrote: > On 04/29, Balamurugan Arumugam wrote: > > > > > > - Original Message - > > > From: "David Caro" > > > To: "Sahina Bose" > > > Cc: "Dan Kenigsberg" , in...@ovirt.org, "Balamurugan > > > Arumugam" , > > > devel@ovirt.org > > > Sent: Wednesday, April 29, 2015 1:38:03 PM > > > Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster > > > > > > You want also push rights? It's not the same submit, push, create > > > reference, > > > verify, code review. > > > > > > All those are different rights. I've added the submit, code-review and > > > verify > > > rights. Let me know if you want also the rest. > > > > > > > > > Also note that pushing and submitting is not the same, pushing will skip > > > gerrit > > > and any gerrit checks, so it's usually something to avoid. While > > > submitting > > > is > > > done through gerrit, what allows gerrit to check validity of the code to > > > be > > > merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs). > > > > > > > The idea behind push right is that we would do periodical rebase of > > ovirt-3.5-gluster branch with ovirt-3.5 branch. Is this recommended way to > > do that? > > > > Which kind of rebase? Does it require using --force? Yes. The expected use case is as such: - Bala merges patches onto his ovirt-3.5-gluster branch via gerrit. - Important patches are merged onto ovirt-3.5 by Yaniv. - Bala wants to have them in ovirt-3.5-gluster - Bala rebases ovirt-3.5-gluster on top of ovirt-3.5 on his host, and pushes the new has as the tip new of ovirt-3.5-gluster. Pleaes let him do that! Dan. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
On 04/29, Balamurugan Arumugam wrote: > > > - Original Message - > > From: "David Caro" > > To: "Sahina Bose" > > Cc: "Dan Kenigsberg" , in...@ovirt.org, "Balamurugan > > Arumugam" , > > devel@ovirt.org > > Sent: Wednesday, April 29, 2015 1:38:03 PM > > Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster > > > > You want also push rights? It's not the same submit, push, create reference, > > verify, code review. > > > > All those are different rights. I've added the submit, code-review and > > verify > > rights. Let me know if you want also the rest. > > > > > > Also note that pushing and submitting is not the same, pushing will skip > > gerrit > > and any gerrit checks, so it's usually something to avoid. While submitting > > is > > done through gerrit, what allows gerrit to check validity of the code to be > > merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs). > > > > The idea behind push right is that we would do periodical rebase of > ovirt-3.5-gluster branch with ovirt-3.5 branch. Is this recommended way to > do that? > Which kind of rebase? Does it require using --force? > Regards, > Bala > > > > > > On 04/29, Sahina Bose wrote: > > > > > > On 04/20/2015 04:36 PM, Dan Kenigsberg wrote: > > > >On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > > > >>Hi! > > > >> > > > >>On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights > > > >>to > > > >>Bala (barum...@redhat.com) ? > > > >+1 from me. > > > > > > > >ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 > > > > > > Hi! > > > > > > Is there a push right to be enabled on this branch as well? > > > > > > Currently, rebasing and pushing is failing with following: > > > > > > remote: Branch refs/heads/ovirt-3.5-gluster: > > > remote: You are not allowed to perform this operation. > > > remote: To push into this reference you need 'Push' rights. > > > remote: User: bala > > > remote: Please read the documentation and contact an administrator > > > remote: if you feel the configuration is incorrect > > > remote: Processing changes: refs: 1, done > > > To ssh://b...@gerrit.ovirt.org:29418/vdsm.git > > > ! [remote rejected] ovirt-3.5-gluster -> ovirt-3.5-gluster (prohibited by > > > Gerrit) > > > error: failed to push some refs to > > > 'ssh://b...@gerrit.ovirt.org:29418/vdsm.git' > > > > > > ___ > > > Infra mailing list > > > in...@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/infra > > > > -- > > David Caro > > > > Red Hat S.L. > > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > > > Tel.: +420 532 294 605 > > Email: dc...@redhat.com > > Web: www.redhat.com > > RHT Global #: 82-62605 > > -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgp2wrG2wQnVR.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
- Original Message - > From: "David Caro" > To: "Sahina Bose" > Cc: "Dan Kenigsberg" , in...@ovirt.org, "Balamurugan > Arumugam" , > devel@ovirt.org > Sent: Wednesday, April 29, 2015 1:38:03 PM > Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster > > You want also push rights? It's not the same submit, push, create reference, > verify, code review. > > All those are different rights. I've added the submit, code-review and verify > rights. Let me know if you want also the rest. > > > Also note that pushing and submitting is not the same, pushing will skip > gerrit > and any gerrit checks, so it's usually something to avoid. While submitting > is > done through gerrit, what allows gerrit to check validity of the code to be > merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs). > The idea behind push right is that we would do periodical rebase of ovirt-3.5-gluster branch with ovirt-3.5 branch. Is this recommended way to do that? Regards, Bala > On 04/29, Sahina Bose wrote: > > > > On 04/20/2015 04:36 PM, Dan Kenigsberg wrote: > > >On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > > >>Hi! > > >> > > >>On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to > > >>Bala (barum...@redhat.com) ? > > >+1 from me. > > > > > >ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 > > > > Hi! > > > > Is there a push right to be enabled on this branch as well? > > > > Currently, rebasing and pushing is failing with following: > > > > remote: Branch refs/heads/ovirt-3.5-gluster: > > remote: You are not allowed to perform this operation. > > remote: To push into this reference you need 'Push' rights. > > remote: User: bala > > remote: Please read the documentation and contact an administrator > > remote: if you feel the configuration is incorrect > > remote: Processing changes: refs: 1, done > > To ssh://b...@gerrit.ovirt.org:29418/vdsm.git > > ! [remote rejected] ovirt-3.5-gluster -> ovirt-3.5-gluster (prohibited by > > Gerrit) > > error: failed to push some refs to > > 'ssh://b...@gerrit.ovirt.org:29418/vdsm.git' > > > > ___ > > Infra mailing list > > in...@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Tel.: +420 532 294 605 > Email: dc...@redhat.com > Web: www.redhat.com > RHT Global #: 82-62605 > ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
You want also push rights? It's not the same submit, push, create reference, verify, code review. All those are different rights. I've added the submit, code-review and verify rights. Let me know if you want also the rest. Also note that pushing and submitting is not the same, pushing will skip gerrit and any gerrit checks, so it's usually something to avoid. While submitting is done through gerrit, what allows gerrit to check validity of the code to be merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs). On 04/29, Sahina Bose wrote: > > On 04/20/2015 04:36 PM, Dan Kenigsberg wrote: > >On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > >>Hi! > >> > >>On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to > >>Bala (barum...@redhat.com) ? > >+1 from me. > > > >ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 > > Hi! > > Is there a push right to be enabled on this branch as well? > > Currently, rebasing and pushing is failing with following: > > remote: Branch refs/heads/ovirt-3.5-gluster: > remote: You are not allowed to perform this operation. > remote: To push into this reference you need 'Push' rights. > remote: User: bala > remote: Please read the documentation and contact an administrator > remote: if you feel the configuration is incorrect > remote: Processing changes: refs: 1, done > To ssh://b...@gerrit.ovirt.org:29418/vdsm.git > ! [remote rejected] ovirt-3.5-gluster -> ovirt-3.5-gluster (prohibited by > Gerrit) > error: failed to push some refs to > 'ssh://b...@gerrit.ovirt.org:29418/vdsm.git' > > ___ > Infra mailing list > in...@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgp_ikTr0H4tL.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
Done On 04/20, Dan Kenigsberg wrote: > On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > > Hi! > > > > On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to > > Bala (barum...@redhat.com) ? > > +1 from me. > > ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 > ___ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpt9FjWbTbxl.pgp Description: PGP signature ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
On 04/20/2015 04:36 PM, Dan Kenigsberg wrote: On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: Hi! On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to Bala (barum...@redhat.com) ? +1 from me. ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 Hi! Is there a push right to be enabled on this branch as well? Currently, rebasing and pushing is failing with following: remote: Branch refs/heads/ovirt-3.5-gluster: remote: You are not allowed to perform this operation. remote: To push into this reference you need 'Push' rights. remote: User: bala remote: Please read the documentation and contact an administrator remote: if you feel the configuration is incorrect remote: Processing changes: refs: 1, done To ssh://b...@gerrit.ovirt.org:29418/vdsm.git ! [remote rejected] ovirt-3.5-gluster -> ovirt-3.5-gluster (prohibited by Gerrit) error: failed to push some refs to 'ssh://b...@gerrit.ovirt.org:29418/vdsm.git' ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster
On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote: > Hi! > > On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to > Bala (barum...@redhat.com) ? +1 from me. ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
