Re: [riot-devel] Re-visiting the LED macros

2017-07-12 Thread Oleg Hahm
Hi Hauke!

On Tue, Jul 11, 2017 at 06:04:29PM +0200, Hauke Petersen wrote:
> For the purpose of profiling using GPIO pins, I think it makes more sense to
> think about something like a CPU specific `pin_debug` header for a small
> number (say 2?) pins that can be directly (say without overhead) controlled.
> The actual pins used should still be configured by the board, but we can put
> default pins in place and we don't need all this redundant pin wobble
> clutter in a board's configuration.

I don't fully get this point. How would this header differ from the current
LED control?

Besides, I would still vote for keeping the LED macros, because they are so
simple that you can always rely on them - even in case you have fucked
something completely up. Splitting them into a different header and maybe even
make them optional, however, is fine with me.

Cheers,
Oleg
-- 
printk(KERN_ERR "scsi%d: !!BINGO!! Falcon has no lock in NCR5380_abort\n", ...)
linux-2.6.6/drivers/scsi/atari_NCR5380.c
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel


Re: [riot-devel] Re-visiting the LED macros

2017-07-12 Thread Hauke Petersen

Hej!

On 12.07.2017 09:00, Oleg Hahm wrote:

Hi Hauke!

On Tue, Jul 11, 2017 at 06:04:29PM +0200, Hauke Petersen wrote:

For the purpose of profiling using GPIO pins, I think it makes more sense to
think about something like a CPU specific `pin_debug` header for a small
number (say 2?) pins that can be directly (say without overhead) controlled.
The actual pins used should still be configured by the board, but we can put
default pins in place and we don't need all this redundant pin wobble
clutter in a board's configuration.

I don't fully get this point. How would this header differ from the current
LED control?

See https://github.com/RIOT-OS/RIOT/pull/7352


Besides, I would still vote for keeping the LED macros, because they are so
simple that you can always rely on them

But they are problematic in some contexts:
- currently, they increase power consumption even if not used (LED pins 
are always initialized, independent of their use)
- some boards have pin usage clashes (e.g. LED pin also used for 
SPI/UART/I2C etc)


So making the LEDs optional in some way is IMHO needed in any case...


- even in case you have fucked
something completely up. Splitting them into a different header and maybe even
make them optional, however, is fine with me.

Actually, I think this is pretty much what we did with #7350 and #7352.

What do you think about this approach?

Cheers,
Hauke


Cheers,
Oleg


___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel