Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-03 Thread Christian MAUDERER

Hello,

Am 03.08.21 um 04:07 schrieb Chris Johns:

On 3/8/21 3:24 am, Sebastian Huber wrote:

On 02/08/2021 18:37, Vijay Kumar Banerjee wrote:

I think there should be a high-level user manual subsection for
networking that describes how the selection of the network stack
works. We can then add another subsection about lwip since legacy
already has one, and libbsd is getting added now.


This sounds like a good approach.



I agree.

Chris


Just so that we are all on the same page:

That would be a number of new subsections in 
https://docs.rtems.org/branches/master/user/index.html:


- 15. Selecting a Network Stack
- 16. Add-on: libbsd Stack
- 17. Add-on: lwIP
- 18. Add-on: Legacy Network Stack

Or was it meant to be only a section

- 15. Selecting a Network Stack
in https://docs.rtems.org/branches/master/user/index.html,
- a new manual "libbsd" in the top level https://docs.rtems.org/,
- a new manual "lwip" in the top level https://docs.rtems.org/

By the way: I think we maybe should keep in mind that there can be more 
add-on packages added some-when in the future that are not network 
stacks. We could for example add documentation for a CAN library, a 
display library or a weather control station. So if we need a top level 
name for all packages, we maybe should call it "add-on packages" instead 
of "network libraries".


Best regards

Christian
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH] Turn off executable permissions for a number of source files

2021-08-03 Thread Gedare Bloom
We should recommend the use of
  git config core.fileMode=false

cleanup mode is fine thanks

On Mon, Aug 2, 2021 at 1:37 PM Joel Sherrill  wrote:
>
> Cloning under Cygwin turned off executable permission on these
> files. This shows them as modified even though they have not
> explicitly been touched. Executable permission should not have
> been on for these files so this is just a minor clean up.
> ---
>  cpukit/score/cpu/aarch64/include/rtems/score/aarch64-system-registers.h | 0
>  testsuites/psxtests/psxhdrs/errno/errno.c   | 0
>  testsuites/psxtests/psxhdrs/iconv/iconv.c   | 0
>  testsuites/psxtests/psxhdrs/iconv/iconv_close.c | 0
>  testsuites/psxtests/psxhdrs/iconv/iconv_open.c  | 0
>  testsuites/psxtests/psxhdrs/monetary/strfmon.c  | 0
>  testsuites/psxtests/psxhdrs/monetary/strfmon_l.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/_Exit.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/a64l.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/abort.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/abs.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/atexit.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/atof.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/atoi.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/atol.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/atoll.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/bsearch.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/calloc.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/div.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/drand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/erand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/exit.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/free.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/getenv.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/getsubopt.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/grantpt.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/initstate.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/jrand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/l64a.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/labs.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/lcong48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/ldiv.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/llabs.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/lldiv.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/lrand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/malloc.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/mblen.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/mbstowcs.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/mbtowc.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/mkdtemp.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/mkstemp.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/mrand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/nrand48.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/posix_memalign.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/posix_openpt.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/ptsname.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/putenv.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/qsort.c  | 0
>  testsuites/psxtests/psxhdrs/stdlib/rand.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/rand_r.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/random.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/realloc.c| 0
>  testsuites/psxtests/psxhdrs/stdlib/realpath.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/seed48.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/setenv.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/setkey.c | 0
>  testsuites/psxtests/psxhdrs/stdlib/setstate.c   | 0
>  testsuites/psxtests/psxhdrs/stdlib/srand.c  | 0
>  testsu

Re: [PATCH v2 1/2] rsb: Add MicroBlaze tools

2021-08-03 Thread Gedare Bloom
On Mon, Aug 2, 2021 at 8:59 PM Alex White  wrote:
>
> ---
>  rtems/config/6/rtems-microblaze.bset  | 23 ++-
>  .../tools/rtems-binutils-xilinx-2.36.cfg  | 52 ++
>  .../tools/rtems-gcc-xilinx-10-newlib-head.cfg | 68 +++
>  3 files changed, 142 insertions(+), 1 deletion(-)
>  create mode 100644 rtems/config/tools/rtems-binutils-xilinx-2.36.cfg
>  create mode 100644 rtems/config/tools/rtems-gcc-xilinx-10-newlib-head.cfg
>
> diff --git a/rtems/config/6/rtems-microblaze.bset 
> b/rtems/config/6/rtems-microblaze.bset
> index 0e35a65..8c9784b 100644
> --- a/rtems/config/6/rtems-microblaze.bset
> +++ b/rtems/config/6/rtems-microblaze.bset
> @@ -1,3 +1,24 @@
>  %define release 1
>  %define rtems_arch microblaze
> -%include 6/rtems-default.bset
> +
> +#
> +# Default tools configuration.
> +#
> +%include 6/rtems-base.bset
> +
> +6/rtems-autotools
> +
> +devel/dtc-1.6.0-1
> +
> +#
> +# Build gdb first to raise the Python install error as early as possible.
> +# GDB needs expat so it needs to be built before.
> +#
> +
> +devel/expat-2.1.0-1
> +devel/gmp-6.1.0
> +tools/rtems-gdb-10
> +
> +tools/rtems-binutils-xilinx-2.36
> +tools/rtems-gcc-xilinx-10-newlib-head
> +tools/rtems-tools-6
> diff --git a/rtems/config/tools/rtems-binutils-xilinx-2.36.cfg 
> b/rtems/config/tools/rtems-binutils-xilinx-2.36.cfg
> new file mode 100644
> index 000..317d688
> --- /dev/null
> +++ b/rtems/config/tools/rtems-binutils-xilinx-2.36.cfg

Other target-specific tools are named like rtems-xilinx-binutils-*
It may be worth to follow that trend, like nios2 and mipstx39?

> @@ -0,0 +1,52 @@
> +%include %{_configdir}/checks.cfg
> +%include %{_configdir}/base.cfg
> +
> +%define binutils_version 7af075d
> +%define binutils_external 1
> +%define binutils_expand_name 
> sourceware-mirror-binutils-gdb-%{binutils_version}
> +%source set binutils --rsb-file=%{binutils_expand_name}.tar.gz 
> https://codeload.github.com/RTEMS/sourceware-mirror-binutils-gdb/tar.gz/%{binutils_version}
> +%hash sha512 %{binutils_expand_name}.tar.gz 
> 9f0fd9f439e026155300b507f288443ee7bbdcdd809663be88e9ca0a8b0ca2fc81bf36964abe5f66af53a23ff91d84b06035d52d68b3b166778d5145c4db7ea4
> +
Up to here it is identical to the existing rtems-binutils-2.36.cfg

You should be able to use that, and then layer the patches on top of it?

> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0001-Add-wdc.ext.clear-and-wdc.ext.flush-insns.patch
> +%hash sha512 0001-Add-wdc.ext.clear-and-wdc.ext.flush-insns.patch 
> 56971b06821d7ab36b068016dde6086941121fca40d661056fe03f17507dafab075b306fe91d191c3fa0ec3617cd8649fe3023e0e5230e3fd5b4c2a648c23a94
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0002-Add-mlittle-endian-and-mbig-endian-flags.patch
> +%hash sha512 0002-Add-mlittle-endian-and-mbig-endian-flags.patch 
> e6240d8d5eebb36b161b77348522cd59dad008017ce7579b66310719faa8bdba9d0f0466f4d81bf8c1d79ed2a3a2d777924a404da1010fc4dd866fcae2bde322
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0003-Disable-the-warning-message-for-eh_frame_hdr.patch
> +%hash sha512 0003-Disable-the-warning-message-for-eh-frame-hdr.patch 
> 2d90ef568bb649bc79b09ec3e745a25b5f177dc49f6b6bf7e9143685e5206bb7aee7a3fd3d013d64d82e2865e90a9cfeb7103aeb29189b1330613c562597a2fc
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0004-LOCAL-Fix-relaxation-of-assembler-resolved-reference.patch
> +%hash sha512 0004-LOCAL-Fix-relaxation-of-assembler-resolved-reference.patch 
> 76780fc9e410739320f07dd2fc517631f0bb4a8484d56ed96f0f8089acf1f8958dbc4045bfe67289086a63b3374a63e8fb2e09f7e7d52579b04d1114022d7214
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0005-upstream-change-to-garbage-collection-sweep-causes-m.patch
> +%hash sha512 0005-upstream-change-to-garbage-collection-sweep-causes-m.patch 
> 76a76edd26dc9bd72b0330791d14362933f5bbbc5bef0f9a9e6ee307958a4f6791ceabdaadae3c969ac3f4c786b13784f473fde6fe8ddcbf3370ccfc8761d7ab
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0006-Fix-bug-in-TLSTPREL-Relocation.patch
> +%hash sha512 0006-Fix-bug-in-TLSTPREL-Relocation.patch 
> deed94f04fa91e993043f3e2f5e7c86a7ffce83e959980daebc255247ba51d991d6289e682fa4dff1758f085e661f5c2888b078dcaf2e790873c96520928
> +
> +%patch add binutils -p1 
> https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0007-Added-Address-extension-instructions.patch
> +%hash sha51

Re: [PATCH] Turn off executable permissions for a number of source files

2021-08-03 Thread Joel Sherrill
On Tue, Aug 3, 2021 at 10:14 AM Gedare Bloom  wrote:
>
> We should recommend the use of
>   git config core.fileMode=false

Can't blanket turn off execute because of scripts at the top or waf.

We just need to be more careful.

>
> cleanup mode is fine thanks
>
> On Mon, Aug 2, 2021 at 1:37 PM Joel Sherrill  wrote:
> >
> > Cloning under Cygwin turned off executable permission on these
> > files. This shows them as modified even though they have not
> > explicitly been touched. Executable permission should not have
> > been on for these files so this is just a minor clean up.
> > ---
> >  cpukit/score/cpu/aarch64/include/rtems/score/aarch64-system-registers.h | 0
> >  testsuites/psxtests/psxhdrs/errno/errno.c   | 0
> >  testsuites/psxtests/psxhdrs/iconv/iconv.c   | 0
> >  testsuites/psxtests/psxhdrs/iconv/iconv_close.c | 0
> >  testsuites/psxtests/psxhdrs/iconv/iconv_open.c  | 0
> >  testsuites/psxtests/psxhdrs/monetary/strfmon.c  | 0
> >  testsuites/psxtests/psxhdrs/monetary/strfmon_l.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/_Exit.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/a64l.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/abort.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/abs.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/atexit.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/atof.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/atoi.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/atol.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/atoll.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/bsearch.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/calloc.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/div.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/drand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/erand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/exit.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/free.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/getenv.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/getsubopt.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/grantpt.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/initstate.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/jrand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/l64a.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/labs.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/lcong48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/ldiv.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/llabs.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/lldiv.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/lrand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/malloc.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/mblen.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/mbstowcs.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/mbtowc.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/mkdtemp.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/mkstemp.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/mrand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/nrand48.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/posix_memalign.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/posix_openpt.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/ptsname.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/putenv.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/qsort.c  | 0
> >  testsuites/psxtests/psxhdrs/stdlib/rand.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/rand_r.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/random.c | 0
> >  testsuites/psxtests/psxhdrs/stdlib/realloc.c| 0
> >  testsuites/psxtests/psxhdrs/stdlib/realpath.c   | 0
> >  testsuites/psxtests/psxhdrs/stdlib/seed48.c | 0
> >  testsuites/psxtests/psxhdrs/st

[PATCH v3 2/2] rsb: Add Xilinx QEMU

2021-08-03 Thread Alex White
---
 bare/config/devel/qemu-xilinx-v2020.2-1.cfg | 23 
 bare/config/devel/qemu-xilinx.bset  | 24 +
 2 files changed, 47 insertions(+)
 create mode 100644 bare/config/devel/qemu-xilinx-v2020.2-1.cfg
 create mode 100644 bare/config/devel/qemu-xilinx.bset

diff --git a/bare/config/devel/qemu-xilinx-v2020.2-1.cfg 
b/bare/config/devel/qemu-xilinx-v2020.2-1.cfg
new file mode 100644
index 000..94b14ef
--- /dev/null
+++ b/bare/config/devel/qemu-xilinx-v2020.2-1.cfg
@@ -0,0 +1,23 @@
+#
+# Xilinx Qemu from git
+#
+
+%if %{release} == %{nil}
+ %define release 1
+%endif
+
+%include %{_configdir}/base.cfg
+
+%include %{_configdir}/bare-config.cfg
+
+%define qemu_version xilinx-v2020.2
+
+#
+# Checkout the version tag and initialize all submodules.
+#
+%source set qemu 
git://github.com/Xilinx/qemu.git?checkout=%{qemu_version}?submodule=dtc?submodule=slirp?submodule=ui/keycodemapdb?submodule=tests/fp/berkeley-softfloat-3?submodule=tests/fp/berkeley-testfloat-3
+
+#
+# The Qemu build instructions. We use 5.x.x Release 1.
+#
+%include %{_configdir}/qemu-5-1.cfg
diff --git a/bare/config/devel/qemu-xilinx.bset 
b/bare/config/devel/qemu-xilinx.bset
new file mode 100644
index 000..91b07e8
--- /dev/null
+++ b/bare/config/devel/qemu-xilinx.bset
@@ -0,0 +1,24 @@
+#
+# Build set for Xilinx QEMU
+#
+
+%define release 1
+
+#
+# Name of the package.
+#
+package: qemu-%{qemu_version}-%{_host}-%{release}
+
+#
+# A magic internal path that would break if changes in the defaults.mc
+# macro file are made.
+#
+%define _internal_autotools_path %{_tmppath}/sb-%{_uid}/${SB_PREFIX_CLEAN}
+
+devel/autotools-internal
+devel/libiconv-1.14-1
+devel/gettext-0.18.3.1-1
+devel/libffi-3.0.13-1
+devel/pixman-0.40.0-1
+devel/glib-2.48.2-1
+devel/qemu-xilinx-v2020.2-1
-- 
2.27.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH v3 0/2] Add MicroBlaze tools to RSB

2021-08-03 Thread Alex White
Hi,

v3:
  - Follow naming convention for Xilinx .cfg files
  - Simplify rtems-xilinx-binutils-2.36.cfg with rtems-binutils-2.36.cfg include

v2:
  - Add Xilinx QEMU version to .cfg filename
  - Exclude GDB configuration with unneeded Xilinx patches

This patch set adds the MicroBlaze tools to rtems-source-builder.

Thanks,

Alex

Alex White (2):
  rsb: Add MicroBlaze tools
  rsb: Add Xilinx QEMU

 bare/config/devel/qemu-xilinx-v2020.2-1.cfg   | 23 +++
 bare/config/devel/qemu-xilinx.bset| 24 +++
 rtems/config/6/rtems-microblaze.bset  | 23 ++-
 .../tools/rtems-xilinx-binutils-2.36.cfg  | 40 +++
 .../tools/rtems-xilinx-gcc-10-newlib-head.cfg | 68 +++
 5 files changed, 177 insertions(+), 1 deletion(-)
 create mode 100644 bare/config/devel/qemu-xilinx-v2020.2-1.cfg
 create mode 100644 bare/config/devel/qemu-xilinx.bset
 create mode 100644 rtems/config/tools/rtems-xilinx-binutils-2.36.cfg
 create mode 100644 rtems/config/tools/rtems-xilinx-gcc-10-newlib-head.cfg

-- 
2.27.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH v3 1/2] rsb: Add MicroBlaze tools

2021-08-03 Thread Alex White
---
 rtems/config/6/rtems-microblaze.bset  | 23 ++-
 .../tools/rtems-xilinx-binutils-2.36.cfg  | 40 +++
 .../tools/rtems-xilinx-gcc-10-newlib-head.cfg | 68 +++
 3 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100644 rtems/config/tools/rtems-xilinx-binutils-2.36.cfg
 create mode 100644 rtems/config/tools/rtems-xilinx-gcc-10-newlib-head.cfg

diff --git a/rtems/config/6/rtems-microblaze.bset 
b/rtems/config/6/rtems-microblaze.bset
index 0e35a65..4b12899 100644
--- a/rtems/config/6/rtems-microblaze.bset
+++ b/rtems/config/6/rtems-microblaze.bset
@@ -1,3 +1,24 @@
 %define release 1
 %define rtems_arch microblaze
-%include 6/rtems-default.bset
+
+#
+# Default tools configuration.
+#
+%include 6/rtems-base.bset
+
+6/rtems-autotools
+
+devel/dtc-1.6.0-1
+
+#
+# Build gdb first to raise the Python install error as early as possible.
+# GDB needs expat so it needs to be built before.
+#
+
+devel/expat-2.1.0-1
+devel/gmp-6.1.0
+tools/rtems-gdb-10
+
+tools/rtems-xilinx-binutils-2.36
+tools/rtems-xilinx-gcc-10-newlib-head
+tools/rtems-tools-6
diff --git a/rtems/config/tools/rtems-xilinx-binutils-2.36.cfg 
b/rtems/config/tools/rtems-xilinx-binutils-2.36.cfg
new file mode 100644
index 000..625fba7
--- /dev/null
+++ b/rtems/config/tools/rtems-xilinx-binutils-2.36.cfg
@@ -0,0 +1,40 @@
+%include tools/rtems-binutils-2.36.cfg
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0001-Add-wdc.ext.clear-and-wdc.ext.flush-insns.patch
+%hash sha512 0001-Add-wdc.ext.clear-and-wdc.ext.flush-insns.patch 
56971b06821d7ab36b068016dde6086941121fca40d661056fe03f17507dafab075b306fe91d191c3fa0ec3617cd8649fe3023e0e5230e3fd5b4c2a648c23a94
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0002-Add-mlittle-endian-and-mbig-endian-flags.patch
+%hash sha512 0002-Add-mlittle-endian-and-mbig-endian-flags.patch 
e6240d8d5eebb36b161b77348522cd59dad008017ce7579b66310719faa8bdba9d0f0466f4d81bf8c1d79ed2a3a2d777924a404da1010fc4dd866fcae2bde322
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0003-Disable-the-warning-message-for-eh_frame_hdr.patch
+%hash sha512 0003-Disable-the-warning-message-for-eh-frame-hdr.patch 
2d90ef568bb649bc79b09ec3e745a25b5f177dc49f6b6bf7e9143685e5206bb7aee7a3fd3d013d64d82e2865e90a9cfeb7103aeb29189b1330613c562597a2fc
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0004-LOCAL-Fix-relaxation-of-assembler-resolved-reference.patch
+%hash sha512 0004-LOCAL-Fix-relaxation-of-assembler-resolved-reference.patch 
76780fc9e410739320f07dd2fc517631f0bb4a8484d56ed96f0f8089acf1f8958dbc4045bfe67289086a63b3374a63e8fb2e09f7e7d52579b04d1114022d7214
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0005-upstream-change-to-garbage-collection-sweep-causes-m.patch
+%hash sha512 0005-upstream-change-to-garbage-collection-sweep-causes-m.patch 
76a76edd26dc9bd72b0330791d14362933f5bbbc5bef0f9a9e6ee307958a4f6791ceabdaadae3c969ac3f4c786b13784f473fde6fe8ddcbf3370ccfc8761d7ab
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0006-Fix-bug-in-TLSTPREL-Relocation.patch
+%hash sha512 0006-Fix-bug-in-TLSTPREL-Relocation.patch 
deed94f04fa91e993043f3e2f5e7c86a7ffce83e959980daebc255247ba51d991d6289e682fa4dff1758f085e661f5c2888b078dcaf2e790873c96520928
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0007-Added-Address-extension-instructions.patch
+%hash sha512 0007-Added-Address-extension-instructions.patch 
8fb1c588eeae2356001d2d79e06c0a6dcd37be6411c11856b064973860139d1b87d490133fd98b5d70bea24f275bdbd5114e11a41141c0be05f23317b187e705
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0008-fixing-the-MAX_OPCODES-to-correct-value.patch
+%hash sha512 0008-fixing-the-MAX-OPCODES-to-correct-value.patch 
e8227eb42b87de038430ddf79bf9f7e58deee0ed263ce521512b0568456f36aab16f9cdcdb2af2b7d0e5330aab0d73479a91480731e86370d63af708d641f903
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-xilinx/rel-v2021.1/meta-microblaze/recipes-devtools/binutils/binutils/0009-Add-new-bit-field-instructions.patch
+%hash sha512 0009-Add-new-bit-field-instructions.patch 
c1bcc51762b66706b286ffd50f3d55dcb99cdc43d2312e0af16b1c1444fe57cf1351d55267438cdd8c755d197646d9726873338b9f892ceb27810f324533e01c
+
+%patch add binutils -p1 
https://raw.githubusercontent.com/Xilinx/meta-x

[PATCH v1 0/4] Reformat GcovData and GcovFunctionData

2021-08-03 Thread Ryan Long
Hi,

For these patches I:

- Made the formatting consistent
- Added Doxygen comments for parameters where it was missing
- Fixed lines that went past 80 columns (except for some comments)

Thanks,
Ryan

Ryan Long (4):
  GcovData.cc: Fix formatting
  GcovData.h: Fix formatting
  GcovFunctionData.cc: Fix formatting
  GcovFunctionData:h: Fix formatting

 tester/covoar/GcovData.cc | 198 +++-
 tester/covoar/GcovData.h  |  61 +
 tester/covoar/GcovFunctionData.cc | 271 +++---
 tester/covoar/GcovFunctionData.h  | 113 
 4 files changed, 354 insertions(+), 289 deletions(-)

-- 
1.8.3.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH v1 4/4] GcovFunctionData:h: Fix formatting

2021-08-03 Thread Ryan Long
---
 tester/covoar/GcovFunctionData.h | 113 +++
 1 file changed, 54 insertions(+), 59 deletions(-)

diff --git a/tester/covoar/GcovFunctionData.h b/tester/covoar/GcovFunctionData.h
index e1ad431..4a98abb 100644
--- a/tester/covoar/GcovFunctionData.h
+++ b/tester/covoar/GcovFunctionData.h
@@ -16,35 +16,35 @@
 
 namespace Gcov {
 
-#define FUNCTION_NAME_LENGTH64
-#define FILE_NAME_LENGTH256
+#define FUNCTION_NAME_LENGTH 64
+#define FILE_NAME_LENGTH 256
 
-#define ON_TREE_ARC_FLAG0x1
-#define FAKE_ARC_FLAG   0x2
-#define FALLTHROUGH_ARC_FLAG0x4
+#define ON_TREE_ARC_FLAG 0x1
+#define FAKE_ARC_FLAG0x2
+#define FALLTHROUGH_ARC_FLAG 0x4
 
 struct gcov_arc_info
 {
-  uint32_tsourceBlock;
-  uint32_tdestinationBlock;
-  uint32_tflags;
-  uint64_tcounter;
+  uint32_t sourceBlock;
+  uint32_t destinationBlock;
+  uint32_t flags;
+  uint64_t counter;
 };
 
 struct gcov_block_info
 {
-  uint32_tid;
-  uint32_tflags;
-  uint32_tnumberOfLines;
-  uint64_tcounter;
-  std::string sourceFileName;
-  std::list lines;
+  uint32_tid;
+  uint32_tflags;
+  uint32_tnumberOfLines;
+  uint64_tcounter;
+  std::string sourceFileName;
+  std::list lines;
 };
 
-typedef std::listarcs_t;
-typedef std::list::iterator  arcs_iterator_t;
-typedef std::list  blocks_t;
-typedef std::list::iteratorblocks_iterator_t;
+typedef std::list arcs_t;
+typedef std::list::iterator   arcs_iterator_t;
+typedef std::list   blocks_t;
+typedef std::list::iterator blocks_iterator_t;
 
 class DesiredSymbols;
 
@@ -71,27 +71,21 @@ class DesiredSymbols;
  *
  *  @param[in] chk stores the checksum value
  */
-void setChecksum(
-  const uint32_t  chk
-);
+void setChecksum( const uint32_t chk );
 
 /*!
  *  This method stores id of function
  *
  *  @param[in] idNumber stores the id value
  */
-void setId(
-  const uint32_t  idNumber
-);
+void setId( const uint32_t idNumber );
 
 /*!
  *  This method stores checksum related to function
  *
  *  @param[in] lineNo passes number of the line begining the function
  */
-void setFirstLineNumber(
-  const uint32_t  lineNo
-);
+void setFirstLineNumber( const uint32_t lineNo );
 
 /*!
  *  This method stores name of the function and ties it to its
@@ -125,8 +119,8 @@ class DesiredSymbols;
  *  @return Returns TRUE if the method succeeded and FALSE if it failed.
  */
 void setBlockFileName(
-  const blocks_iterator_t block,
-  const std::string&  fileName
+  const blocks_iterator_t block,
+  const std::string&  fileName
 );
 
 /*!
@@ -159,9 +153,9 @@ class DesiredSymbols;
  */
 void getCounters(
   uint64_t* counterValues,
-  uint32_t &countersFound,
-  uint64_t &countersSum,
-  uint64_t &countersMax
+  uint32_t& countersFound,
+  uint64_t& countersSum,
+  uint64_t& countersMax
 );
 
 /*!
@@ -169,12 +163,9 @@ class DesiredSymbols;
  *
  *  @param[in] source passes source block number
  *  @param[in] destination passes destination block number
+ *  @param[in] flags passes per block flags
  */
-void addArc(
-  uint32_tsource,
-  uint32_tdestination,
-  uint32_tflags
-);
+void addArc( uint32_t source, uint32_t destination, uint32_t flags );
 
 /*!
  *  This method adds new arc to arc list
@@ -182,10 +173,7 @@ class DesiredSymbols;
  *  @param[in] block identifies block
  *  @param[in] line passes the line number
  */
-void addBlockLine(
-  const blocks_iterator_t block,
-  const uint32_t  line
-);
+void addBlockLine( const blocks_iterator_t block, const uint32_t line );
 
 /*!
  *  This method finds block by its ID
@@ -204,13 +192,16 @@ class DesiredSymbols;
  *  @param[in] sourceFileName passes containing file name
  */
 void addBlock(
-  const uint32_t  id,
-  const uint32_t  flags,
-  const std::string&  sourceFileName
+  const uint32_t id,
+  const uint32_t flags,
+  const std::string& sourceFileName
 );
 
 /*!
  *  This method prints info about function
+ *
+ *  @param[in] textFile specifies output file
+ *  @param[in] function_number specifies the number of the function
  */
 void printFunctionInfo(
   std::ofstream& textFile,
@@ -219,6 +210,9 @@ class DesiredSymbols;
 
 /*!
  *  This method prints info about coverage of this function
+ *
+ *  @param[in] textFile specifies output file
+ *  @param[in] function_numb

[PATCH v1 1/4] GcovData.cc: Fix formatting

2021-08-03 Thread Ryan Long
---
 tester/covoar/GcovData.cc | 198 +-
 1 file changed, 106 insertions(+), 92 deletions(-)

diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc
index 59963b6..6b18fa3 100644
--- a/tester/covoar/GcovData.cc
+++ b/tester/covoar/GcovData.cc
@@ -77,44 +77,45 @@ namespace Gcov {
   return false;
 }
 
-// Read and validate the gcnoPreamble (magic, version, timestamp) from the 
file
+// Read and validate the gcnoPreamble (magic, version, timestamp)
+// from the file
 status = readFilePreamble( &gcnoPreamble, gcovFile, GCNO_MAGIC );
-if ( status <= 0 ){
+if ( status <= 0 ) {
   std::cerr << "Unable to read " << gcnoFileName << std::endl;
   return false;
 }
 
 //Read all remaining frames from file
-while( readFrame(gcovFile) ){}
+while( readFrame( gcovFile ) ) {}
 
 return true;
   }
 
 
-  bool GcovData::writeGcdaFile ()
+  bool GcovData::writeGcdaFile()
   {
-gcov_preamble preamble;
-gcov_frame_header header;
-std::ofstream gcdaFile;
-functions_iterator_t  currentFunction;
-arcs_iterator_t   currentArc;
-uint32_t  buffer;
-uint32_t  countersFound;
-uint32_t  countersFoundSum;
-uint64_t  countersSum;
-uint64_t  countersMax;
-uint64_t  llBuffer[4096];// TODO: Use common buffer
-gcov_statistics   objectStats;
-gcov_statistics   programStats;
-long int  bytes_before;
+gcov_preamblepreamble;
+gcov_frame_headerheader;
+std::ofstreamgcdaFile;
+functions_iterator_t currentFunction;
+arcs_iterator_t  currentArc;
+uint32_t buffer;
+uint32_t countersFound;
+uint32_t countersFoundSum;
+uint64_t countersSum;
+uint64_t countersMax;
+uint64_t llBuffer[4096];// TODO: Use common buffer
+gcov_statistics  objectStats;
+gcov_statistics  programStats;
+long int bytes_before;
 
 // Debug message
 //std::cerr << "Writing file: " <<  gcdaFileName << std::endl;
 
 // Lets clear counters sumators
-countersSum = 0;
-countersMax = 0;
-countersFoundSum   = 0;
+countersSum  = 0;
+countersMax  = 0;
+countersFoundSum = 0;
 
 // Open the data file.
 gcdaFile.open( gcdaFileName );
@@ -124,9 +125,9 @@ namespace Gcov {
 }
 
 //Form preamble
-preamble.magic  = GCDA_MAGIC;
-preamble.version  = gcnoPreamble.version;
-preamble.timestamp  = gcnoPreamble.timestamp;
+preamble.magic = GCDA_MAGIC;
+preamble.version   = gcnoPreamble.version;
+preamble.timestamp = gcnoPreamble.timestamp;
 
 //Write preamble
 gcdaFile.write( (char *) &preamble , 4 * sizeof( preamble ) );
@@ -140,8 +141,7 @@ namespace Gcov {
   currentFunction = functions.begin();
   currentFunction != functions.end();
   currentFunction++
-)
-{
+) {
   //Write function announcement frame header (length always equals 2)
   header.tag = GCOV_TAG_FUNCTION;
   header.length = 2;
@@ -170,7 +170,12 @@ namespace Gcov {
   // Determine how many counters there are
   // and store their counts in buffer
   countersFound = 0;
-  (*currentFunction).getCounters( llBuffer, countersFound, countersSum, 
countersMax );
+  (*currentFunction).getCounters(
+llBuffer,
+countersFound,
+countersSum,
+countersMax
+  );
   countersFoundSum += countersFound;
 
   //Write info about counters
@@ -192,14 +197,14 @@ namespace Gcov {
 }
 
 // Prepare frame with object file statistics
-header.tag = GCOV_TAG_OBJECT_SUMMARY;
-header.length = 9;
-objectStats.checksum = 0;  // TODO: have no idea hov to calculates it 
:)
+header.tag   = GCOV_TAG_OBJECT_SUMMARY;
+header.length= 9;
+objectStats.checksum = 0;   // TODO: have no idea hov to 
calculates it :)
 objectStats.counters = countersFoundSum;
-objectStats.runs = 1;// We are lying for now, we have no means of 
figuring this out
-objectStats.sum = countersSum;// Sum of all counters
-objectStats.max = countersMax;// max value for counter on last run, we 
have no clue
-objectStats.sumMax = countersMax;// we have no clue
+objectStats.runs = 1;   // // We are lying for now, we have no 
clue
+objectStats.sum  = countersSum; // Sum of all counters
+objectStats.max  = countersMax; // max value for counter on last run, 
we have no clue
+objectStats.sumMax   = countersMax; // we have no clue
 
 // Write data
 gcdaFile.write( (char *) &header, sizeof( header ) );
@@ -216,14 +221,14 @@ namespace Gcov {
 
 
 // Prepare frame with program statistics
-header.tag = GCOV_TAG_PROGRA

[PATCH v1 2/4] GcovData.h: Fix formatting

2021-08-03 Thread Ryan Long
---
 tester/covoar/GcovData.h | 61 +---
 1 file changed, 32 insertions(+), 29 deletions(-)

diff --git a/tester/covoar/GcovData.h b/tester/covoar/GcovData.h
index e135ffe..242970f 100644
--- a/tester/covoar/GcovData.h
+++ b/tester/covoar/GcovData.h
@@ -24,17 +24,17 @@ namespace Gcov {
 #define GCNO_VERSION ((uint32_t) 0x34303652 )
 
 /* GCOV tags */
-#define GCOV_TAG_FUNCTION   ((uint32_t)0x0100)
-#define GCOV_TAG_BLOCKS ((uint32_t)0x0141)
-#define GCOV_TAG_ARCS   ((uint32_t)0x0143)
-#define GCOV_TAG_LINES  ((uint32_t)0x0145)
-#define GCOV_TAG_COUNTER((uint32_t)0x01a1)
-#define GCOV_TAG_OBJECT_SUMMARY ((uint32_t)0xa100)
-#define GCOV_TAG_PROGRAM_SUMMARY((uint32_t)0xa300)
+#define GCOV_TAG_FUNCTION((uint32_t)0x0100)
+#define GCOV_TAG_BLOCKS  ((uint32_t)0x0141)
+#define GCOV_TAG_ARCS((uint32_t)0x0143)
+#define GCOV_TAG_LINES   ((uint32_t)0x0145)
+#define GCOV_TAG_COUNTER ((uint32_t)0x01a1)
+#define GCOV_TAG_OBJECT_SUMMARY  ((uint32_t)0xa100)
+#define GCOV_TAG_PROGRAM_SUMMARY ((uint32_t)0xa300)
 
 
-typedef std::list  functions_t;
-typedef std::list::iteratorfunctions_iterator_t;
+typedef std::list   functions_t;
+typedef std::list::iterator functions_iterator_t;
 
 struct gcov_preamble
 {
@@ -96,7 +96,7 @@ class DesiredSymbols;
  *
  *  @return Returns TRUE if the method succeeded and FALSE if it failed.
  */
-bool writeGcdaFile ();
+bool writeGcdaFile();
 
 /*!
  *  This method writes all contained information to stdout file
@@ -109,28 +109,28 @@ class DesiredSymbols;
  *  This method runs gcov to generate report. This method should
  *  be used only when gcno and gcda files are already generated.
  */
-void writeGcovFile( );
+void writeGcovFile();
 
 /*!
  *  This method calculates values of counters for all functions
  */
-bool processCounters( void );
+bool processCounters();
 
   private:
 
-uint32_tnumberOfFunctions;
-gcov_preamble   gcnoPreamble;
-std::string gcnoFileName;
-std::string gcdaFileName;
-std::string textFileName;
-std::string cFileName;
-functions_t functions;
+uint32_t  numberOfFunctions;
+gcov_preamble gcnoPreamble;
+std::string   gcnoFileName;
+std::string   gcdaFileName;
+std::string   textFileName;
+std::string   cFileName;
+functions_t   functions;
 
 
 /*!
  *  This method reads a frame from *.gcno file
  *
- *  @param[in] file points to a file to read
+ *  @param[in] gcovFile points to a file to read
  *
  *  @return true if read was succesfull, false otherwise
  */
@@ -140,9 +140,10 @@ class DesiredSymbols;
  *  This method reads a string from gcov file
  *
  *  @param[in] buffer stores the string
- *  @param[in] file specifies the name of the file to read
+ *  @param[in] gcovFile specifies the name of the file to read
  *
- *  @return Returns length of words read (word = 32bit) or -1 if error 
ocurred
+ *  @return Returns length of words read (word = 32bit) or -1 if error
+ *  ocurred
  */
 int readString( char* buffer, std::ifstream& gcovFile );
 
@@ -150,7 +151,7 @@ class DesiredSymbols;
  *  This method reads a frame header from gcov file
  *
  *  @param[in] header stores the header
- *  @param[in] file specifies the name of the file to read
+ *  @param[in] gcovFile specifies the name of the file to read
  *
  *  @return Returns length of words read (word = 32bit)
  *  or -1 if error ocurred
@@ -168,9 +169,9 @@ class DesiredSymbols;
  *  or -1 if error ocurred
  */
 int readFilePreamble(
-  gcov_preamble*  preamble,
-  std::ifstream&  gcovFile,
-  const uint32_t  desiredMagic
+  gcov_preamble* preamble,
+  std::ifstream& gcovFile,
+  const uint32_t desiredMagic
 );
 
 /*!
@@ -183,14 +184,16 @@ class DesiredSymbols;
  *  @return Returns true if operation was succesfull
  */
 bool readFunctionFrame(
-  gcov_frame_header   header,
-  std::ifstream&  gcovFile,
-  GcovFunctionData*   function
+  gcov_frame_header header,
+  std::ifstream&gcovFile,
+  GcovFunctionData* function
 );
 
 /*!
  *  This method prints info about previously read *.gcno file
  *  to a specified report file
+ *
+ *  @param[in] textFile specifies output file
  */
 void printGcnoFileInfo( std::ofstream& textFile );
 
-- 
1.8.3.1

___
devel mailing list
devel@rtems.org
http://li

[PATCH v1 3/4] GcovFunctionData.cc: Fix formatting

2021-08-03 Thread Ryan Long
---
 tester/covoar/GcovFunctionData.cc | 271 +++---
 1 file changed, 162 insertions(+), 109 deletions(-)

diff --git a/tester/covoar/GcovFunctionData.cc 
b/tester/covoar/GcovFunctionData.cc
index 34af677..7c9e627 100644
--- a/tester/covoar/GcovFunctionData.cc
+++ b/tester/covoar/GcovFunctionData.cc
@@ -19,9 +19,9 @@ namespace Gcov {
 
   GcovFunctionData::GcovFunctionData()
   {
-numberOfArcs = 0;
+numberOfArcs   = 0;
 numberOfBlocks = 0;
-coverageMap = NULL;
+coverageMap= NULL;
   }
 
   GcovFunctionData::~GcovFunctionData()
@@ -49,9 +49,7 @@ namespace Gcov {
 Coverage::DesiredSymbols& symbolsToAnalyze
   )
   {
-std::string   symbolName;
-
-symbolName = fcnName;
+std::string symbolName = fcnName;
 
 if ( fcnName.length() >= FUNCTION_NAME_LENGTH ) {
   std::cerr << "ERROR: Function name is too long to be correctly stored: "
@@ -63,8 +61,9 @@ namespace Gcov {
 
 // Tie function to its coverage map
 symbolInfo = symbolsToAnalyze.find( symbolName );
-if ( symbolInfo != NULL )
+if ( symbolInfo != NULL ) {
   coverageMap = symbolInfo->unifiedCoverageMap;
+}
 
 #if 0
 if ( coverageMap == NULL ) {
@@ -79,7 +78,8 @@ namespace Gcov {
 return true;
   }
 
-  bool GcovFunctionData::setFileName( const std::string& fileName ) {
+  bool GcovFunctionData::setFileName( const std::string& fileName )
+  {
 if ( fileName.length() >= FILE_NAME_LENGTH ) {
   std::cerr << "ERROR: File name is too long to be correctly stored: "
 << fileName.length() << std::endl;
@@ -107,13 +107,13 @@ namespace Gcov {
 
   void GcovFunctionData::getCounters(
 uint64_t* counterValues,
-uint32_t &countersFound,
-uint64_t &countersSum,
-uint64_t &countersMax
+uint32_t& countersFound,
+uint64_t& countersSum,
+uint64_t& countersMax
   )
   {
-arcs_iterator_t  currentArc;
-int  i;
+arcs_iterator_t currentArc;
+int i;
 
 countersFound = 0;
 countersSum   = 0;
@@ -121,19 +121,20 @@ namespace Gcov {
 
 // Locate relevant counters and copy their values
 i = 0;
-for(
-  currentArc = arcs.begin();
-  currentArc != arcs.end();
-  currentArc++
-)
-{
-  if ( currentArc->flags == 0 || currentArc->flags == 2 ||
-   currentArc->flags == 4 ) {
+for ( currentArc = arcs.begin(); currentArc != arcs.end(); currentArc++ ) {
+  if (
+currentArc->flags == 0 ||
+currentArc->flags == 2 ||
+currentArc->flags == 4
+  ) {
 countersFound++;
 countersSum += currentArc->counter;
 counterValues[i] = currentArc->counter;
-if ( countersMax <= currentArc->counter)
+
+if ( countersMax <= currentArc->counter ) {
   countersMax = currentArc->counter;
+}
+
 i++;
   }
 }
@@ -145,19 +146,19 @@ namespace Gcov {
   }
 
   void GcovFunctionData::addArc(
-uint32_t  source,
-uint32_t  destination,
-uint32_t  flags
+uint32_t source,
+uint32_t destination,
+uint32_t flags
   )
   {
 gcov_arc_info arc;
 
 numberOfArcs++;
-arc.sourceBlock = source;
+arc.sourceBlock  = source;
 arc.destinationBlock = destination;
-arc.flags = flags;
-arc.counter = 0;
-arcs.push_back(arc);
+arc.flags= flags;
+arc.counter  = 0;
+arcs.push_back( arc );
   }
 
   void GcovFunctionData::addBlock(
@@ -169,12 +170,12 @@ namespace Gcov {
 gcov_block_info block;
 
 numberOfBlocks++;
-block.id= id;
-block.flags = flags;
-block.numberOfLines = 0;
-block.counter = 0;
+block.id = id;
+block.flags  = flags;
+block.numberOfLines  = 0;
+block.counter= 0;
 block.sourceFileName = sourceFileName;
-blocks.push_back(block);
+blocks.push_back( block );
   }
 
   void GcovFunctionData::printFunctionInfo(
@@ -182,8 +183,8 @@ namespace Gcov {
 uint32_t   function_number
   )
   {
-blocks_iterator_t  currentBlock;
-arcs_iterator_tcurrentArc;
+blocks_iterator_t currentBlock;
+arcs_iterator_t   currentArc;
 
 textFile << std::endl << std::endl
  << "=="
@@ -204,9 +205,10 @@ namespace Gcov {
 textFile << std::endl;
 
 // Print blocks info
-for ( currentBlock = blocks.begin();
-  currentBlock != blocks.end();
-  currentBlock++
+for (
+  currentBlock = blocks.begin();
+  currentBlock != blocks.end();
+  currentBlock++
 ) {
   printBlockInfo( textFile, currentBlock );
 }
@@ -217,22 +219,25 @@ namespace Gcov {
 uint32_t   function_number
   )
   {
-uint32_tbaseAddress = 0;
-uint32_tbaseSize;
-uint32_tcurrentAddress;
-std::list::iterator   instruction;
+uint32_t baseAddress = 0;
+uint32_t  

Re: Error when trying to build llvm

2021-08-03 Thread Ida Delphine
Hello,
After several attempts of passing that command in the wrong build
directory, I finally was able to find the right build directory, and here's
what I found in ida.log:
https://pastebin.com/hPMmFCyj

I really can't make out what's going on or what to do next. Please help

On Fri, Jul 30, 2021 at 8:57 PM Joel Sherrill  wrote:

> On Fri, Jul 30, 2021 at 1:32 PM Ida Delphine  wrote:
> >
> > Just installed swig and now met with another error. Can't find what is
> really wrong.
> > RTEMS Source Builder - Set Builder, 6 (c938bd7cbe16)
> > Build Set: 6/rtems-llvm
> > Build Set: devel/swig.bset
> > Build Set: devel/autotools-internal.bset
> > config: devel/autoconf-2.69-1.cfg
> > package: autoconf-2.69-x86_64-linux-gnu-1
> > building: autoconf-2.69-x86_64-linux-gnu-1
> > sizes: autoconf-2.69-x86_64-linux-gnu-1: 7.493MB (installed: 0.000B)
> > cleaning: autoconf-2.69-x86_64-linux-gnu-1
> > config: devel/automake-1.12.6-1.cfg
> > package: automake-1.12.6-x86_64-linux-gnu-1
> > building: automake-1.12.6-x86_64-linux-gnu-1
> > sizes: automake-1.12.6-x86_64-linux-gnu-1: 8.085MB (installed: 0.000B)
> > cleaning: automake-1.12.6-x86_64-linux-gnu-1
> > config: devel/libtool-2.4.2-1.cfg
> > package: libtool-2.4.2-x86_64-linux-gnu-1
> > building: libtool-2.4.2-x86_64-linux-gnu-1
> > sizes: libtool-2.4.2-x86_64-linux-gnu-1: 12.775MB (installed: 0.000B)
> > cleaning: libtool-2.4.2-x86_64-linux-gnu-1
> > cleaning: autoconf-2.69-x86_64-linux-gnu-1
> > cleaning: automake-1.12.6-x86_64-linux-gnu-1
> > cleaning: libtool-2.4.2-x86_64-linux-gnu-1
> > Build Sizes: usage: 12.775MB total: 79.327MB (sources: 79.308MB,
> patches: 19.412KB, installed 0.000B)
> > Build Set: Time 0:00:17.154758
> > config: devel/swig-4.0.1.cfg
> > package: swig-4.0.1-x86_64-linux-gnu-1
> > building: swig-4.0.1-x86_64-linux-gnu-1
> > sizes: swig-4.0.1-x86_64-linux-gnu-1: 106.899MB (installed: 0.000B)
> > cleaning: swig-4.0.1-x86_64-linux-gnu-1
> > cleaning: swig-4.0.1-x86_64-linux-gnu-1
> > Build Set: Time 0:01:27.065144
> > config: tools/rtems-llvm-8.0.1.cfg
> > package: rtems-llvm-8.0.1-x86_64-linux-gnu-1
> > building: rtems-llvm-8.0.1-x86_64-linux-gnu-1
> > error: building rtems-llvm-8.0.1-x86_64-linux-gnu-1
> > Build FAILED
> >   See error report: rsb-report-rtems-llvm-8.0.1-x86_64-linux-gnu-1.txt
> > error: building rtems-llvm-8.0.1-x86_64-linux-gnu-1
> > Build Set: Time 0:04:53.632167
> > Build FAILED
> > The error report: https://pastebin.com/nFYzqWqY
>
> I don't see any compiler errors. I see warnings and if they built with
> -Werror,
> then it would fail.
>
> I think there is a way to force a cmake build to show the command invoked.
> This
> has lots of details:
>
>
> https://stackoverflow.com/questions/2670121/using-cmake-with-gnu-make-how-can-i-see-the-exact-commands
>
> I think you can manually go down into the build directory which is left
> after the build failure, and type "make VERBOSE=1" >ida.log 2>&1"
>
> Then the file ida.log should show all the commands.
>
> The URL above shows how to do it via cmake. But in this case, I think
> going into the RSB build/ directory and doing the make by hand will
> give us the next bit of into -- does it compile with -Werror.
>
> >
> > On Fri, Jul 30, 2021 at 2:24 PM Joel Sherrill  wrote:
> >>
> >> On Fri, Jul 30, 2021 at 12:46 AM Ida Delphine 
> wrote:
> >> >
> >> > Hello everyone,
> >> > I have been trying to build llvm using the command
> >> > ../source-builder/sb-set-builder --prefix=$HOME/development/rtems/6
> 6/rtems-llvm
> >> > Here's the error report
> >> > https://pastebin.com/vAXgwXMW
> >>
> >> It would have been helpful to have put the error lines in the email
> >> and a link to the full log.
> >>
> >> -- Could NOT find libedit (missing: libedit_INCLUDE_DIRS
> libedit_LIBRARIES)
> >> -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
> >> CMake Error at
> /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146
> >> (message):
> >> Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR)
> >> Call Stack (most recent call first):
> >> /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393
> >> (_FPHSA_FAILURE_MESSAGE)
> >> /usr/share/cmake-3.16/Modules/FindSWIG.cmake:64
> >> (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
> >> tools/lldb/scripts/CMakeLists.txt:18 (find_package)
> >>
> >> > Please what am I missing?
> >>
> >> Based on google results and other people having the same issue, you may
> not
> >> have swig installed. It is something to install with npm from what I
> >> see. Other people
> >> have it but need to set some variables to let cmake know where it is.
> >>
> >> Hopefully installing it will help. Chris should comment on this from
> >> an RSB perspective.
> >>
> >> --joel
> >>
> >> >
> >> > ___
> >> > devel mailing list
> >> > devel@rtems.org
> >> > http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/lis