Re: [PATCH 1/2] bsps: Import xilinx support code
On 21/12/2022 21:54, Kinsey Moore wrote:
+includes:
+- bsps/include/xilinx_support/
+- bsps/include/xilinx_support/${XIL_SUPPORT_PATH}/
Is the xilinx_support a name from you or Xilinx? Maybe just name it
xilinx or xil to make the paths shorter.
Could you please add a notice to the commit message from where you
obtained the files and some version information. This is helpful if you
want to update the code at some point in time. If it is imported from a
Git repository, a file like this is useful: cpukit/dtc/VERSION.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/2] spec/build/riscv: Default all BSPs to medany cmodel
On 21.12.22 12:21, Hesham Almatary wrote: Would it still be fine to default all RV64 BSPs to medany (and remove medlow) so that we start all of RISC-V BSPs at 0x8000? If so I'll submit modified patches and edit the ticket accordingly. Yes, this makes sense. It seems that the medlow model has limited use for RV64. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/2] spec/build/riscv: Default all BSPs to medany cmodel
On Mon, 19 Dec 2022 at 16:29, Sebastian Huber wrote: > > Hello Hesham, > > On 18/12/2022 15:27, heshamelmat...@gmail.com wrote: > > From: Hesham Almatary > > > > Currently generic RISC-V BSPs (riscv/riscv) that start with rv* and not > > rv*_medany will start at 0x7000. This adds high maintenance overhead > > and deviates from almost all other RISC-V-based OSes and baremetal programs > > that start at 0x8000. Further, testing now has to account for an extra > > parameter (medany or not) that doubles the number of BSPs need to be > > tested. > > > > This commit defaults all BSPs to use medany code model to allow starting > > all BSPs at 0x8000. BSPs that require different code models and/or > > start addresses are custom and need to add their own entries. > > > > Updates #4775 > > why do we need the medany variants for RV32? I thought medlow can access > addresses in the range -2GiB to +2GiB which is the complete 32-bit > address space? > You're right, I confused RV32 with RV64. Would it still be fine to default all RV64 BSPs to medany (and remove medlow) so that we start all of RISC-V BSPs at 0x8000? If so I'll submit modified patches and edit the ticket accordingly. > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.hu...@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht München > Registernummer: HRB 157899 > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler > Unsere Datenschutzerklärung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ -- Hesham ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
