Re: [PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Chris Johns 
On 13/2/21 10:18 am, Kinsey Moore wrote:
> On 12/2/21 5:14 am, Chris Johns wrote:
>> On 13/2/21 10:10 am, Joel Sherrill wrote:
>>> On Fri, Feb 12, 2021 at 5:06 PM Chris Johns >> > wrote:
>>>
>>> On 13/2/21 12:25 am, Jan Sommer wrote:
>>> > This patchset implements a driver for the cadence-spi
>>> > device of the Xilinx Zynq-7000 based SoCs  using the spidev API.s
>>>
>>> Thanks for the driver.
>>>
>>> A quick review of the differences between the Zynq and Ulttrascale in 
>>> this
>>> document from Xilinx:
>>>
>>> 
>>> https://www.xilinx.com/support/documentation/user_guides/ug1213-zynq-migration-guide.pdf
>>> 
>>> 
>>>
>>> shows the SPI hardware is the same. Should this driver be located under
>>> `bsps/shared/dev/spi` and then shared?
>>>
>>> If Kinsey or Jan confirms, then yes it should.
>>
>> Thanks.
>>
>>> Kinsey has had a number 
>>> of drivers work after addressing 64-bit clean issues.
>>
>> Nice. Are these in the tree?
> 
> Looking at the register setup for the two SPI instances in MPSoC, I have 
> verified that these peripherals are identical. It should definitely go in 
> bsps/shared/dev/spi.

Thanks.

> I have already committed some of the driver movement from Zynq or ARM to 
> bsps/shared/dev. There is still quite a bit more to pull out of the Zynq BSP 
> that I haven't quite gotten to.

Awesome and thanks. It is great to see this happening.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

RE: [PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Kinsey Moore 
On 12/2/21 5:14 am, Chris Johns wrote:
>On 13/2/21 10:10 am, Joel Sherrill wrote:
>> On Fri, Feb 12, 2021 at 5:06 PM Chris Johns > > wrote:
>> 
>> On 13/2/21 12:25 am, Jan Sommer wrote:
>> > This patchset implements a driver for the cadence-spi
>> > device of the Xilinx Zynq-7000 based SoCs  using the spidev API.s
>> 
>> Thanks for the driver.
>> 
>> A quick review of the differences between the Zynq and Ulttrascale in 
>> this
>> document from Xilinx:
>> 
>> 
>> https://www.xilinx.com/support/documentation/user_guides/ug1213-zynq-migration-guide.pdf
>> 
>> 
>> 
>> shows the SPI hardware is the same. Should this driver be located under
>> `bsps/shared/dev/spi` and then shared?
>> 
>> If Kinsey or Jan confirms, then yes it should.
>
> Thanks.
>
>> Kinsey has had a number 
>> of drivers work after addressing 64-bit clean issues.
>
> Nice. Are these in the tree?

Looking at the register setup for the two SPI instances in MPSoC, I have 
verified that these peripherals are identical. It should definitely go in 
bsps/shared/dev/spi.

I have already committed some of the driver movement from Zynq or ARM to 
bsps/shared/dev. There is still quite a bit more to pull out of the Zynq BSP 
that I haven't quite gotten to.

Kinsey
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Chris Johns 
On 13/2/21 10:10 am, Joel Sherrill wrote:
> On Fri, Feb 12, 2021 at 5:06 PM Chris Johns  > wrote:
> 
> On 13/2/21 12:25 am, Jan Sommer wrote:
> > This patchset implements a driver for the cadence-spi
> > device of the Xilinx Zynq-7000 based SoCs  using the spidev API.s
> 
> Thanks for the driver.
> 
> A quick review of the differences between the Zynq and Ulttrascale in this
> document from Xilinx:
> 
> 
> https://www.xilinx.com/support/documentation/user_guides/ug1213-zynq-migration-guide.pdf
> 
> 
> 
> shows the SPI hardware is the same. Should this driver be located under
> `bsps/shared/dev/spi` and then shared?
> 
> If Kinsey or Jan confirms, then yes it should.

Thanks.

> Kinsey has had a number 
> of drivers work after addressing 64-bit clean issues.

Nice. Are these in the tree?

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Joel Sherrill 
On Fri, Feb 12, 2021 at 5:06 PM Chris Johns  wrote:

> On 13/2/21 12:25 am, Jan Sommer wrote:
> > This patchset implements a driver for the cadence-spi
> > device of the Xilinx Zynq-7000 based SoCs  using the spidev API.s
>
> Thanks for the driver.
>
> A quick review of the differences between the Zynq and Ulttrascale in this
> document from Xilinx:
>
>
> https://www.xilinx.com/support/documentation/user_guides/ug1213-zynq-migration-guide.pdf
>
> shows the SPI hardware is the same. Should this driver be located under
> `bsps/shared/dev/spi` and then shared?
>

If Kinsey or Jan confirms, then yes it should. Kinsey has had a number
of drivers work after addressing 64-bit clean issues.

--joel

>
> Chris
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Chris Johns 
On 13/2/21 12:25 am, Jan Sommer wrote:
> This patchset implements a driver for the cadence-spi
> device of the Xilinx Zynq-7000 based SoCs  using the spidev API.s

Thanks for the driver.

A quick review of the differences between the Zynq and Ulttrascale in this
document from Xilinx:

https://www.xilinx.com/support/documentation/user_guides/ug1213-zynq-migration-guide.pdf

shows the SPI hardware is the same. Should this driver be located under
`bsps/shared/dev/spi` and then shared?

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 0/3] bsps/zynq: Add cadence-SPI driver

2021-02-12 Thread Jan Sommer 
This patchset implements a driver for the cadence-spi
device of the Xilinx Zynq-7000 based SoCs  using the spidev API.


Jan Sommer (3):
  bsps/xilinx_zynq: Add SPI driver for cadence-spi
  bsps/xilinx_zynq: Add SPI driver to waf
  bsps/xilinx_zynq: Add SPI driver to autotools build

 bsps/arm/xilinx-zynq/headers.am   |   2 +
 .../include/bsp/cadence-spi-regs.h|  84 
 .../arm/xilinx-zynq/include/bsp/cadence-spi.h |  48 ++
 bsps/arm/xilinx-zynq/spi/cadence-spi.c| 437 ++
 c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am  |   3 +
 spec/build/bsps/arm/xilinx-zynq/obj.yml   |   3 +
 6 files changed, 577 insertions(+)
 create mode 100644 bsps/arm/xilinx-zynq/include/bsp/cadence-spi-regs.h
 create mode 100644 bsps/arm/xilinx-zynq/include/bsp/cadence-spi.h
 create mode 100644 bsps/arm/xilinx-zynq/spi/cadence-spi.c

-- 
2.17.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel