Re: [PATCH 1/1] Hello World - Ida's proof to work on rtems
Thanks for the feedback!
On Sun, Mar 14, 2021 at 5:32 PM Gedare Bloom wrote:
> Hi Ida,
>
> This is acceptable for your proof and no further revisions are
> required, but please see my notes below:
>
> On Fri, Mar 12, 2021 at 9:13 PM Ida Delphine wrote:
> >
> > From: Meh Mbeh Ida Delphine
> >
> Author info looks good, thanks.
>
> > Modified rtems/testsuites/samples/hello/init.c to prove I can work on
> the RTEMS project for GSoC.
> See https://devel.rtems.org/wiki/Developer/Git#GitCommits for more
> about preparing "real commits" in the future. This one is acceptable
> for the proof.
>
> (We need to merge that text from
> https://devel.rtems.org/wiki/Developer/Git#GitCommits into a suitable
> subsection in
> https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch
> someday.)
>
> > ---
> > testsuites/samples/hello/init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/testsuites/samples/hello/init.c
> b/testsuites/samples/hello/init.c
> > index 34ded37c55..fa581fd447 100644
> > --- a/testsuites/samples/hello/init.c
> > +++ b/testsuites/samples/hello/init.c
> > @@ -22,7 +22,7 @@ static rtems_task Init(
> > {
> >rtems_print_printer_fprintf_putc(_test_printer);
> >TEST_BEGIN();
> > - printf( "Hello World\n" );
> > + printf( "Hello World, I'm Ida Deslphine and this is th main proof I
> can officially work on the RTEMS Project for GSoC. I'm so excited. Thank
> you all for the help you rendered when I ran into several errors!\n" );
>
> The message is great! :) Now you can start to see why we make this
> task part of our proposal preparation!
>
> Note that our code style adheres to a maximum of 80 characters per
> line: https://docs.rtems.org/branches/master/eng/coding.html
>
> We are still working toward automated code style checking (which is by
> the way a GSoC project: https://devel.rtems.org/ticket/3860 that does
> not require strong C/asm skills).
>
> Please add your info to
> https://devel.rtems.org/wiki/GSoC/2021#StudentsProposals
>
> I guess so far none of the other students who did the proof have added
> themselves, but feel free to be first! If you need help on the
> formatting, you can go in the prior year's GSoC and see how the table
> is set up. (Click Edit on the bottom of the page to find the wiki
> source.)
>
> Gedare
>
> >TEST_END();
> >rtems_test_exit( 0 );
> > }
> > --
> > 2.25.1
> >
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/1] Hello World - Ida's proof to work on rtems
Hi Ida,
This is acceptable for your proof and no further revisions are
required, but please see my notes below:
On Fri, Mar 12, 2021 at 9:13 PM Ida Delphine wrote:
>
> From: Meh Mbeh Ida Delphine
>
Author info looks good, thanks.
> Modified rtems/testsuites/samples/hello/init.c to prove I can work on the
> RTEMS project for GSoC.
See https://devel.rtems.org/wiki/Developer/Git#GitCommits for more
about preparing "real commits" in the future. This one is acceptable
for the proof.
(We need to merge that text from
https://devel.rtems.org/wiki/Developer/Git#GitCommits into a suitable
subsection in
https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch
someday.)
> ---
> testsuites/samples/hello/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testsuites/samples/hello/init.c b/testsuites/samples/hello/init.c
> index 34ded37c55..fa581fd447 100644
> --- a/testsuites/samples/hello/init.c
> +++ b/testsuites/samples/hello/init.c
> @@ -22,7 +22,7 @@ static rtems_task Init(
> {
>rtems_print_printer_fprintf_putc(_test_printer);
>TEST_BEGIN();
> - printf( "Hello World\n" );
> + printf( "Hello World, I'm Ida Deslphine and this is th main proof I can
> officially work on the RTEMS Project for GSoC. I'm so excited. Thank you all
> for the help you rendered when I ran into several errors!\n" );
The message is great! :) Now you can start to see why we make this
task part of our proposal preparation!
Note that our code style adheres to a maximum of 80 characters per
line: https://docs.rtems.org/branches/master/eng/coding.html
We are still working toward automated code style checking (which is by
the way a GSoC project: https://devel.rtems.org/ticket/3860 that does
not require strong C/asm skills).
Please add your info to https://devel.rtems.org/wiki/GSoC/2021#StudentsProposals
I guess so far none of the other students who did the proof have added
themselves, but feel free to be first! If you need help on the
formatting, you can go in the prior year's GSoC and see how the table
is set up. (Click Edit on the bottom of the page to find the wiki
source.)
Gedare
>TEST_END();
>rtems_test_exit( 0 );
> }
> --
> 2.25.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/1] Hello World - Ida's proof to work on rtems
Here's a screenshot as requested on the guide.
Thanks,
Ida.
On Sat, Mar 13, 2021 at 5:13 AM Ida Delphine wrote:
> From: Meh Mbeh Ida Delphine
>
> Modified rtems/testsuites/samples/hello/init.c to prove I can work on the
> RTEMS project for GSoC.
> ---
> testsuites/samples/hello/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testsuites/samples/hello/init.c
> b/testsuites/samples/hello/init.c
> index 34ded37c55..fa581fd447 100644
> --- a/testsuites/samples/hello/init.c
> +++ b/testsuites/samples/hello/init.c
> @@ -22,7 +22,7 @@ static rtems_task Init(
> {
>rtems_print_printer_fprintf_putc(_test_printer);
>TEST_BEGIN();
> - printf( "Hello World\n" );
> + printf( "Hello World, I'm Ida Deslphine and this is th main proof I can
> officially work on the RTEMS Project for GSoC. I'm so excited. Thank you
> all for the help you rendered when I ran into several errors!\n" );
>TEST_END();
>rtems_test_exit( 0 );
> }
> --
> 2.25.1
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH 1/1] Hello World - Ida's proof to work on rtems
From: Meh Mbeh Ida Delphine
Modified rtems/testsuites/samples/hello/init.c to prove I can work on the RTEMS
project for GSoC.
---
testsuites/samples/hello/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuites/samples/hello/init.c b/testsuites/samples/hello/init.c
index 34ded37c55..fa581fd447 100644
--- a/testsuites/samples/hello/init.c
+++ b/testsuites/samples/hello/init.c
@@ -22,7 +22,7 @@ static rtems_task Init(
{
rtems_print_printer_fprintf_putc(_test_printer);
TEST_BEGIN();
- printf( "Hello World\n" );
+ printf( "Hello World, I'm Ida Deslphine and this is th main proof I can
officially work on the RTEMS Project for GSoC. I'm so excited. Thank you all
for the help you rendered when I ran into several errors!\n" );
TEST_END();
rtems_test_exit( 0 );
}
--
2.25.1
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
