Re: [PATCH 1/2] bsps: Import xilinx support code
On Thu, Dec 22, 2022 at 12:58 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 21/12/2022 21:54, Kinsey Moore wrote:
> > +includes:
> > +- bsps/include/xilinx_support/
> > +- bsps/include/xilinx_support/${XIL_SUPPORT_PATH}/
>
> Is the xilinx_support a name from you or Xilinx? Maybe just name it
> xilinx or xil to make the paths shorter.
>
> Could you please add a notice to the commit message from where you
> obtained the files and some version information. This is helpful if you
> want to update the code at some point in time. If it is imported from a
> Git repository, a file like this is useful: cpukit/dtc/VERSION.
>
Those were added by my choice. I'll shorten them and add the requested
version information in v2. I mentioned part of it in 2/2, but better to
have it in both.
Thanks,
Kinsey
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/2] bsps: Import xilinx support code
On 21/12/2022 21:54, Kinsey Moore wrote:
+includes:
+- bsps/include/xilinx_support/
+- bsps/include/xilinx_support/${XIL_SUPPORT_PATH}/
Is the xilinx_support a name from you or Xilinx? Maybe just name it
xilinx or xil to make the paths shorter.
Could you please add a notice to the commit message from where you
obtained the files and some version information. This is helpful if you
want to update the code at some point in time. If it is imported from a
Git repository, a file like this is useful: cpukit/dtc/VERSION.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
